MCUBOOT won't boot image in 2.4.0

RE: MCUBOOT won't boot image in 2.4.0

hugzy123 — Fri, 29 Nov 2024 12:48:17 GMT

Thank you, that patch worked.

RE: MCUBOOT won't boot image in 2.4.0

Hung Bui — Wed, 20 Nov 2024 11:34:17 GMT

Hi Benjamin,
This is an old ticket. Have you tried to test with the patch applied ?
https://github.com/vidarbe/sdk-nrf/commit/00ee7b3e0a562304dca7c8da2d3ad4c5b6cc3e9d

If you used the patch and it still doesn't solve the problem for you , please create a new ticket.

RE: MCUBOOT won't boot image in 2.4.0

hugzy123 — Mon, 18 Nov 2024 13:04:10 GMT

Hi,

I think I may be having a similar issue when updating my nrf5340_ns project to ncs v2.4.4.

Does the patch being discussed here just involve changing all instances of "BOOT_HOOK_REGULAR" in "nrf53_hooks.c" to "FIH_BOOT_HOOK_REGULAR" ?

Thanks,

RE: MCUBOOT won't boot image in 2.4.0

Anthony Ambuehl — Wed, 05 Jul 2023 19:29:21 GMT

Primary issue with mcuboot not working when running with nrf5340dk_nrf5340_cpuapp_ns is resolved after fixing the issue in nrf53_hooks.

I hope that Nordic can add more testing to the releases to avoid future regressions.

RE: MCUBOOT won't boot image in 2.4.0

Sigurd Hellesvik — Wed, 05 Jul 2023 14:41:43 GMT

Hi Anthony,

I will continue helping in this case.

[quote user="anthony.asterisk"]

Also it would be wonderful if somehow VSCode would be aware of nrf53_hooks., I had to a perform a global grep of the entire v2.4.0 code base from the shell to locate nrf53_hooks.c, and its still unclear to me how/when this files is used. With SES at least we always had easy access to all of the source code that was included. Now its a complete mystery.

Even worse VSCode actually shows incorrect macro values, I have to determine the correct values by logging them at run time. For example the value of FIH_BOOT_HOOK_REGULAR reports as 1 in VSCode but reports as 0x19c1f6e1 at run time. I suppose this is probably an artifact of child images having different config settings.. there needs to be a way to deal with that.

[/quote]

For what it's worth, I agree that our extensions search features have potential for improvement.
I will convey your feedback to our VS Code team, thank you for sharing your thoughts!

Seems to me that you have solved some of the issues in this case.
To avoid misunderstandings:
Do you need help with anything else in this ticket?

Regards,
Sigurd Hellesvik

RE: MCUBOOT won't boot image in 2.4.0

Anthony Ambuehl — Fri, 30 Jun 2023 16:18:26 GMT

Yes I can confirm that after modifying nrf53_hooks.c mcuboot detected the primary slot as valid.

It would be great if in addition to fixing this, they actually included the nrf5340dk_nrf5340_cpuapp_ns in the regression testing.

RE: MCUBOOT won't boot image in 2.4.0

Vidar Berg — Fri, 30 Jun 2023 15:25:53 GMT

Thanks for the updates. I notice that the 'nrf5340dk_nrf5340_cpuapp_ns' target is not being tested for the smp_srv sample; only the 'nrf5340dk_nrf5340_cpuapp' target is being tested. If you patch nrf53_hooks.c, would you be able to make it work for now? I'll discuss this further with the developers when they return to the office on Monday.

RE: MCUBOOT won't boot image in 2.4.0

Anthony Ambuehl — Thu, 29 Jun 2023 23:26:49 GMT

Confirmed...

v2.4.0/nrf/modules/mcuboot/hooks/nr53_hooks.c is returning BOOT_HOOK_REGULAR instead of FIH_BOOT_HOOK_REGULAR.

I'm not clear on how/when nrf53_hooks.c gets pulled in, but it seems it has not been tested with mcuboot with FIH.

RE: MCUBOOT won't boot image in 2.4.0

Anthony Ambuehl — Thu, 29 Jun 2023 23:14:26 GMT

It looks like wherever boot_image_check_hook is coming from, it has not been updated to work with the Fault Injection Hardening FIH. FIH is changing the FIH_BOOT_HOOK_REGULAR to 0x19C1F6E1 as I can see from this modified log:

*** Booting Zephyr OS build v3.3.99-ncs1 ***
I: Starting bootloader
I: Swap type: none
I: Swap type: none
E: boot_image_check_hook returned 0x1 regular is 0x19c1f6e1
E: Image in the primary slot is not valid!
E: header is valid and rc is 1
E: Unable to find bootable image

Are there different boot_image_check_hooks for nrf5340 ?

Do I need to disable the FIH profile for mcuboot to work?

RE: MCUBOOT won't boot image in 2.4.0

Anthony Ambuehl — Thu, 29 Jun 2023 22:49:14 GMT

I modified my config, removing:

CONFIG_LOG_DEFAULT_LEVEL=0

and I now get a few more relevant logs. I further extended the logging in bootloader/mcuboot/boot/bootutil/loader.c, adding logs:

    BOOT_HOOK_CALL_FIH(boot_image_check_hook, FIH_BOOT_HOOK_REGULAR,
                       fih_rc, BOOT_CURR_IMG(state), slot);
    BOOT_LOG_ERR("boot_image_check_hook returned %d", fih_rc);
    if (FIH_EQ(fih_rc, FIH_BOOT_HOOK_REGULAR))
    {
        FIH_CALL(boot_image_check, fih_rc, state, hdr, fap, bs);
        BOOT_LOG_ERR("boot_image_check returned %d", fih_rc);
    }
    if (!boot_is_header_valid(hdr, fap) || FIH_NOT_EQ(fih_rc, FIH_SUCCESS))
    {
        if ((slot != BOOT_PRIMARY_SLOT) || ARE_SLOTS_EQUIVALENT())
        {
            flash_area_erase(fap, 0, flash_area_get_size(fap));
            /* Image is invalid, erase it to prevent further unnecessary
             * attempts to validate and boot it.
             */
        }
#if !defined(__BOOTSIM__)
        BOOT_LOG_ERR("Image in the %s slot is not valid!",
                     (slot == BOOT_PRIMARY_SLOT) ? "primary" : "secondary");
        BOOT_LOG_ERR("header %s valid and rc is %d",
                     (boot_is_header_valid(hdr, fap) ? "is" : "is not"),
                     fih_rc);
#endif

and here are the logs I'm getting

*** Booting Zephyr OS build v3.3.99-ncs1 ***
I: Starting bootloader
I: Swap type: none
I: Swap type: none
E: boot_image_check_hook returned 1
E: Image in the primary slot is not valid!
E: header is valid and rc is 1
E: Unable to find bootable image

The log indicates the boot_image_check_hook is returning 1 (e.g. FIH_BOOT_HOOK_REGULAR) but for some reason I'm not getting the log reporting the return value of boot_image_check..