Enabling CONFIG_BOOTLOADER_MCUBOOT=y and/or CONFIG_BT=y breaks unrelated modules

RE: Enabling CONFIG_BOOTLOADER_MCUBOOT=y and/or CONFIG_BT=y breaks unrelated modules

janb37896796 — Thu, 03 Aug 2023 17:47:58 GMT

We've resolved our issue by adding an additional config in the sub-project kconfig

config TFLITE_SUBPROJECT
    bool "Tensorflow Lite subproject."
    help
      Tensorflow Lite subproject.

And using it to gait the sub-project CmakeLists.txt

add_subdirectory_ifdef(CONFIG_TFLITE_SUBPROJECT lib)

# Include headers
zephyr_include_directories_ifdef(CONFIG_TFLITE_SUBPROJECT inc)

Config is enabled along with the other tflite configs in the main project .conf files

##Tensor Flow Lit Micro
CONFIG_CPP=y
CONFIG_STD_CPP17=y
CONFIG_TENSORFLOW_LITE_MICRO=y
CONFIG_TFLITE_SUBPROJECT=y

For anyone with similar problems, the snapshot at github.com/.../tflite_main_proj at fac5eb11 should be a working toy project with both multi image support enabled and tflite hello world running on the nrf5340dk.

RE: Enabling CONFIG_BOOTLOADER_MCUBOOT=y and/or CONFIG_BT=y breaks unrelated modules

Sigurd Hellesvik — Fri, 21 Jul 2023 14:12:23 GMT

[quote user="janb37896796"]Is there something to sysbuild you think may help or hurt the issue?[/quote]

For now, I would suggest not using sysbuild, for two reasons:

I have heard that sysbuild does not yet fully support the Partition Manager yet, so there may be some issues there.
We in techincal support are not yet as familiar with sysbuild, as it is a new feature. We should in theory provide the same support, as sysbuild is being introduced, but it takes time to build experience in practice.

[quote user="janb37896796"]1) Why does enabling the tflite configs not automatically import the module?[/quote]

I do not know this one. Could sound like a design choice from whomever added tflite.

[quote user="janb37896796"]2) Why would the child images be looking for files in the tflite module?[/quote]

I do not know how sysbuild would handle this yet.

Without sysbuild the child images should not inherit the configuration from the application.
There are two possibilities to why this happens as I see it:

Either you have enabled tflite in your board files, as these apply to all child images as well as the app.
Part of the build system detects tflite configurations and apply it in a way that makes it effect child images as well.
I know some other configurations in the application can make changes to child images, such as CONFIG_SB_SIGNING_KEY_FILE.

So that we are on the same page, can you tell me what you do to disable/enable sysbuild in your project?

RE: Enabling CONFIG_BOOTLOADER_MCUBOOT=y and/or CONFIG_BT=y breaks unrelated modules

janb37896796 — Fri, 21 Jul 2023 13:36:22 GMT

We have tried both with and without sysbuild. With sysbuild the children inherit the configs without any additional configurations on our side. This compiles but causes the bootlooping issue. Without sysbuild we have tried manually adding the configs to the children, again this compiles but causes the bootlooping issue. We've also tried B) described above without sysbuild. Is there something to sysbuild you think may help or hurt the issue?

Two great specific question for the developers could be 1) Why does enabling the tflite configs not automatically import the module? 2) Why would the child images be looking for files in the tflite module? Having insight into those would help us have some more direction in debugging.

RE: Enabling CONFIG_BOOTLOADER_MCUBOOT=y and/or CONFIG_BT=y breaks unrelated modules

Sigurd Hellesvik — Fri, 21 Jul 2023 11:20:26 GMT

Looking into why the child images try to use tflite, I see that you are using sysbuild. Is that correct?
Do you have anything you need sysbuild for at this point?

[quote user="janb37896796"]I understand many folks are on summer vacation, but perhaps there is a build system developer available we could escalate this to?[/quote]

It is generally hard for me to get help from our developers with complex projects like this.
That is more for specific problems. For example: "Is sysbuild ready yet?" or "Why would sysbuild inherit configurations from the app?"

Alternatively, you have to ask sales if you want to escalate stuff.

RE: Enabling CONFIG_BOOTLOADER_MCUBOOT=y and/or CONFIG_BT=y breaks unrelated modules

janb37896796 — Thu, 20 Jul 2023 16:56:13 GMT

Hi Siguard,
Thank you for following up and attempting to build our project. The goal of our project here is to include and use the tensorflow module so removing it is pointless.

We've been digging in to this problem more while you were away. The problem seems to be stemming from the fact that the three children images (mcuboot, hci_rpmsg hcirpmsg/b0n) are looking for the tflite code. We've tried two approaches here:
A) including the tflite configs in the three children image configs - this compiles but the code does not actually run (we would need to open a private ticket to share this particular failing code). From looking at the debugger, we get stuck in a bootloop in the mcuboot portion of the code. We can only assume this is due to the odd addition of the tflite configs. This seems like the wrong approach.

and B) attempting to exclude the tflite code from the children images. We've been unsuccessful in this. even with all function calls to tflite removed from our code, the children images are still searching for the tflite module as it is included in the west.yml as a module. Perhaps this approach of manually including tflite from the west.yml is the root of our issues but otherwise we have found to way to make the tflite module appear in the zephyr modules directory as it is not part of the "name-allowlist" in the nrf/west.yml.

I understand many folks are on summer vacation, but perhaps there is a build system developer available we could escalate this to?

RE: Enabling CONFIG_BOOTLOADER_MCUBOOT=y and/or CONFIG_BT=y breaks unrelated modules

Sigurd Hellesvik — Thu, 20 Jul 2023 08:48:19 GMT

I have been able to build your project now.

Maybe the easiest solution could be to just remove

#include <tensorflow/lite/micro/all_ops_resolver.h>

from tflite_sub_proj/lib/main_functions.cpp

Do you need this file to be included in your project?

RE: Enabling CONFIG_BOOTLOADER_MCUBOOT=y and/or CONFIG_BT=y breaks unrelated modules

Sigurd Hellesvik — Wed, 19 Jul 2023 14:08:46 GMT

We are low on staffing due to the summer vacation.
Due to this, it takes longer than normal to answer cases.
This is especially true for reproduction of issues.

Thank you for your patience.

RE: Enabling CONFIG_BOOTLOADER_MCUBOOT=y and/or CONFIG_BT=y breaks unrelated modules

Sigurd Hellesvik — Wed, 12 Jul 2023 13:58:19 GMT

I got some more unfortunate news.

I am traveling now, and I am somehow not able to run west update insde the folder on my current PC.
It is just stuck on getting sdk-nrf.

I will try this again on Monday when I am back in the office.

Normally, I would ask a collegua for help to reproduce this, but due to the summer vacation we are low on staff, so longer waiting times are expected

RE: Enabling CONFIG_BOOTLOADER_MCUBOOT=y and/or CONFIG_BT=y breaks unrelated modules

Sigurd Hellesvik — Tue, 11 Jul 2023 15:16:30 GMT

Ah, I have not. That is probably why I can not build.

I wll do this tomorrow and test the project then.
Sorry for the delay

RE: Enabling CONFIG_BOOTLOADER_MCUBOOT=y and/or CONFIG_BT=y breaks unrelated modules

janb37896796 — Mon, 10 Jul 2023 14:40:45 GMT

Hi Siguard,
Thank you for looking in to this issue. And thank you Guido for helping support.

Siguard, can you confirm that you've followed the step in the readme to update the .west/config file to point to the west.yml in tflite_main_proj?

The contents of the config should look like this:

[manifest]
path = tflite_main_proj
file = west.yml

[zephyr]
base = zephyr

If you run `west update` after updating this it should pull down the folder tflite_sub_proj repo which contains the inc and src directories

RE: Enabling CONFIG_BOOTLOADER_MCUBOOT=y and/or CONFIG_BT=y breaks unrelated modules

Sigurd Hellesvik — Mon, 10 Jul 2023 12:42:10 GMT

This is how my tflite_main_proj folder looks after "west update"

tflite]$ tree tflite_main_proj/
tflite_main_proj/
├── app
│   ├── child_image
│   │   └── mcuboot
│   │       ├── boards
│   │       │   └── nrf5340dk_nrf5340_cpuapp.overlay
│   │       └── mcuboot.conf
│   ├── CMakeLists.txt
│   ├── Kconfig
│   ├── prj.conf
│   ├── sample.yaml
│   └── src
│       └── main.c
├── CMakeLists.txt
├── Kconfig
├── README.md
├── west.yml
└── zephyr
    └── module.yml

Also, the "inc" folder is not to be seen in https://github.com/janfari/tflite_main_proj either.

Nor reffered to in https://github.com/janfari/tflite_main_proj/blob/main/west.yml

And for the west folder which I inited:

ls
tflite_main_proj  zephyr  bootloader  tools  modules

[quote user="Sigurd Hellesvik"]I got the west project set up, but get the error:[/quote]

The error is from the build btw.

RE: Enabling CONFIG_BOOTLOADER_MCUBOOT=y and/or CONFIG_BT=y breaks unrelated modules

Guido — Fri, 07 Jul 2023 19:51:20 GMT

I can't reproduce that error.
That file is in a project in the west manifest.
It should be in tflite_sub_proj/inc/main_functions.h after running west update

RE: Enabling CONFIG_BOOTLOADER_MCUBOOT=y and/or CONFIG_BT=y breaks unrelated modules

Sigurd Hellesvik — Thu, 06 Jul 2023 07:55:51 GMT

I got the west project set up, but get the error:

fatal error: main_functions.h: No such file or directory
   18 | #include <main_functions.h>

Looks like I am missing some files?

Also, I suggest that you rename your .c files to .cpp to use C++. This will make Zephyr detect some stuff automatically.

RE: Enabling CONFIG_BOOTLOADER_MCUBOOT=y and/or CONFIG_BT=y breaks unrelated modules

Guido — Wed, 05 Jul 2023 20:15:31 GMT

Hi Sigurd,

Thank you for your support. I'm janb37896796 's co-worker, they asked me to follow the issue for this week.

The original post provides a github link with a minimal project. I'll re submit: https://github.com/janfari/tflite_main_proj
We are trying to mimic our current configuration where we use west to pull individual repositories with drivers and libraries. The readme explains the setup, it's a zephyr workspace (workspace folder, clone/west init and west update).
Under tflite_main_proj/app/prj.conf look for:

# # # # BAD
# CONFIG_BOOTLOADER_MCUBOOT=y
# CONFIG_BT=y 
# # # # BAD

Uncomment any of those to replicate.

We are aware of the multi image build and partition manager being enabled when using this with the ncs/zephy. We have used them for the project and they worked without problems until now.

To give you another angle: what's new is that we are looking on using zephyr's tensorflow-lite(tflite) module, which requires C++ to be enabled.
What we have tried:
- tflite and C++ work fine on their own with the nRF5340.
- Enabling tflite and C++ with our current project which resulted in compile time errors.
- After reconstructing the configs from scratchjanb37896796 was able to single out those 2 configs to be the breaking ones when in combination with tflite and C++.
- The original post shows that we tried some solutions that we found on the devzone.

I appreciate you taking the time to review this.

Best regards,
Guido

RE: Enabling CONFIG_BOOTLOADER_MCUBOOT=y and/or CONFIG_BT=y breaks unrelated modules

Sigurd Hellesvik — Mon, 03 Jul 2023 11:51:16 GMT

Hi,

The common factor for CONFIG_BT (specifically for 5340) and CONFIG_BOOTLOADER_MCUBOOT is that they both enable multi imahe builds which also enable the partition manager.

From your error message, I can not say exactly how this is related yet.

Is it an option for you to send me your minimal project to reproduce this error?
If not, I will give you some tips on how you can debug this yourself.

Regards,
Sigurd Hellesvik