Adding another SPI device to app overlay

RE: Adding another SPI device to app overlay

sleeper — Thu, 06 Jul 2023 09:33:23 GMT

Perfect Thankyou :-)

RE: Adding another SPI device to app overlay

Sigurd Hellesvik — Thu, 06 Jul 2023 09:30:39 GMT

Either not use cdc_acm for logging, or set CONFIG_USB_CDC_ACM_LOG_LEVEL_OFF

RE: Adding another SPI device to app overlay

sleeper — Thu, 06 Jul 2023 09:23:42 GMT

So how do I stop the warning ?

I'm trying to get to a point where the build is clean, no warnings / errors.

RE: Adding another SPI device to app overlay

Sigurd Hellesvik — Thu, 06 Jul 2023 08:56:14 GMT

I was wrong. This is not due to your other configurations, but seems like it is a feature to prevent an recursive loop:

https://github.com/nrfconnect/sdk-zephyr/blob/52222dc79450304fe4a32e5e0e77b9a460a93a86/subsys/usb/device/class/cdc_acm.c#L59-L66

RE: Adding another SPI device to app overlay

sleeper — Thu, 06 Jul 2023 08:26:27 GMT

so here is the prj.conf

CONFIG_STDOUT_CONSOLE=y

CONFIG_LOG=y

CONFIG_LOG_BACKEND_UART=y

#CONFIG_SERIAL=y

CONFIG_UART_INTERRUPT_DRIVEN=y

CONFIG_UART_LINE_CTRL=y

# UART0 #

CONFIG_UART_ASYNC_API=y

CONFIG_UART_0_ASYNC=y

CONFIG_UART_0_INTERRUPT_DRIVEN=n

CONFIG_NRFX_UARTE0=y

# UART1 #

# PWM #

CONFIG_PWM=y

# SPI #

CONFIG_SPI=y

CONFIG_FLASH=y

#CONFIG_SPI_NOR=y

# USB #

CONFIG_USB_DEVICE_STACK=y

CONFIG_USB_DEVICE_PRODUCT="Zephyr CDC ACM Composite sample"

CONFIG_USB_DEVICE_PID=0x0002

CONFIG_USB_DEVICE_VID=0x2FE0

CONFIG_USB_COMPOSITE_DEVICE=y

CONFIG_USB_DEVICE_INITIALIZE_AT_BOOT=n

#CONFIG_USB_UART_CONSOLE=y

#CONFIG_USB_DEVICE_PID=0x0101

CONFIG_USB_SELF_POWERED=n

CONFIG_USB_WORKQUEUE=y

#CONFIG_USB_WORKQUEUE_STACK_SIZE=1024

CONFIG_USB_WORKQUEUE_PRIORITY=-1

#CONFIG_USB_CDC_ACM=y

#CONFIG_USB_CDC_ACM_RINGBUF_SIZE=512

#CONFIG_USB_CDC_ACM_RINGBUF_SIZE=1024

#CONFIG_USB_CDC_ACM_LOG_LEVEL_ERR=y

CONFIG_USB_DEVICE_LOG_LEVEL_ERR=y

CONFIG_USB_DRIVER_LOG_LEVEL_ERR=y

# SHELL #

CONFIG_SHELL=y

CONFIG_SHELL_BACKEND_SERIAL=y

CONFIG_SHELL_BACKENDS=y

CONFIG_SHELL_LOG_BACKEND=n

#CONFIG_SHELL_BACKEND_SERIAL_INIT_PRIORITY=51

RE: Adding another SPI device to app overlay

Sigurd Hellesvik — Thu, 06 Jul 2023 08:23:01 GMT

[quote user="sleeper"]

One more question for now, not sure why i'm getting this warning

C:\ncs\v2.4.0\zephyr\subsys\usb\device\class\cdc_acm.c:63:2: warning: #warning "USB_CDC_ACM_LOG_LEVEL forced to LOG_LEVEL_NONE" [-Wcpp]
63 | #warning "USB_CDC_ACM_LOG_LEVEL forced to LOG_LEVEL_NONE"

[/quote]

Some of your other project configurations also affect USB_CDC_ACM_LOG_LEVEL

RE: Adding another SPI device to app overlay

sleeper — Thu, 06 Jul 2023 08:16:41 GMT

Yes that has fixed it, thanks.

One more question for now, not sure why i'm getting this warning

C:\ncs\v2.4.0\zephyr\subsys\usb\device\class\cdc_acm.c:63:2: warning: #warning "USB_CDC_ACM_LOG_LEVEL forced to LOG_LEVEL_NONE" [-Wcpp]
63 | #warning "USB_CDC_ACM_LOG_LEVEL forced to LOG_LEVEL_NONE"

RE: Adding another SPI device to app overlay

Sigurd Hellesvik — Thu, 06 Jul 2023 06:23:11 GMT

Maybe you need the other commit, mentioned in Peripheral LBS example: Policy CMP0010 is not set and No SOURCES given to Zephyr library: lib__libc__common as well?

https://github.com/zephyrproject-rtos/zephyr/pull/56309/commits/2094e19a3c58297125c1289ea0ddec89db317f96

RE: Adding another SPI device to app overlay

sleeper — Wed, 05 Jul 2023 15:51:30 GMT

mmmmm ok so i patched with this

https://github.com/zephyrproject-rtos/zephyr/commit/c03e1900ae7faf2d64b9275735f59c585a028937

and it still creates the warning.....???

-- The C compiler identification is GNU 12.2.0
-- The CXX compiler identification is GNU 12.2.0
-- The ASM compiler identification is GNU
-- Found assembler: C:/ncs/toolchains/31f4403e35/opt/zephyr-sdk/arm-zephyr-eabi/bin/arm-zephyr-eabi-gcc.exe
CMake Warning at C:/ncs/v2.4.0/zephyr/CMakeLists.txt:838 (message):
No SOURCES given to Zephyr library: lib__libc__common

Excluding target from build.

RE: Adding another SPI device to app overlay

Sigurd Hellesvik — Wed, 05 Jul 2023 14:13:10 GMT

[quote user="sleeper"]

should i worry about this build warning ?

CMake Warning at C:/ncs/v2.4.0/zephyr/CMakeLists.txt:838 (message):
No SOURCES given to Zephyr library: lib__libc__common

[/quote]

I do not think you need to worry.

It will be fixed in upcoming releases of the nRF Connect SDK.

See build/mcuboot/child_image_preload.cmake is created with backslash '\' instead of forward slash '/' on line 7 for more info

RE: Adding another SPI device to app overlay

sleeper — Wed, 05 Jul 2023 14:09:11 GMT

ok that sorted

should i worry about this build warning ?

CMake Warning at C:/ncs/v2.4.0/zephyr/CMakeLists.txt:838 (message):
No SOURCES given to Zephyr library: lib__libc__common

Excluding target from build.

RE: Adding another SPI device to app overlay

Sigurd Hellesvik — Wed, 05 Jul 2023 14:02:49 GMT

That is becasue your DTS node still has the "label" property:

spi_flash0:spi_flash0@0 {

compatible = "jedec,spi-nor";

reg = <0>;

// irq-gpios = <&gpio0 21 0>;

spi-max-frequency = <1000000>;

label = "W25Q64JV";

jedec-id = [EF 40 17];

size = <0x4000000>;

};

RE: Adding another SPI device to app overlay

sleeper — Wed, 05 Jul 2023 13:17:24 GMT

no sure what you mean....???

this is how i get device reference

static const struct device *flash =

DEVICE_DT_GET(DT_NODELABEL(spi_flash0));

this is what the build reports in red

-- Found devicetree overlay: c:/Users/IMS_DEV/Documents/vscode/cdc_acm_composite/app.overlay
'label' is marked as deprecated in 'properties:' in C:/ncs/v2.4.0/zephyr/dts/bindings\mtd\jedec,spi-nor.yaml for node /soc/spi@40003000/spi_flash0@0.

RE: Adding another SPI device to app overlay

Sigurd Hellesvik — Wed, 05 Jul 2023 09:26:05 GMT

From nordic,nrf-spi:

[quote user="sleeper"]'label' is marked as deprecated in 'properties:' in C:/ncs/v2.4.0/zephyr/dts/bindings\mtd\jedec,spi-nor.yaml for node /soc/spi@40003000/spi_flash0@0.[/quote]

The "label" dts property have been deprecated.
Use DT_NODELLABEL instead to get references to DTS nodes.
For example how this is done here: https://github.com/nrfconnect/sdk-nrf/blob/99d94faedc3db9cd640aac12ea3f8849c8ac9651/samples/cellular/lwm2m_client/src/sensors/light_sensor.c#L18

Regards,
Sigurd Hellesvik

RE: Adding another SPI device to app overlay

sleeper — Tue, 04 Jul 2023 14:08:27 GMT

Also why do i get this warning ?

'label' is marked as deprecated in 'properties:' in C:/ncs/v2.4.0/zephyr/dts/bindings\mtd\jedec,spi-nor.yaml for node /soc/spi@40003000/spi_flash0@0.