Regression in nRF Connect VS Code extension re overlay files

RE: Regression in nRF Connect VS Code extension re overlay files

Raoul — Wed, 12 Jul 2023 22:51:39 GMT

Thanks for clarifying, that does explain the situation. I'll convey what you said to the developers and leave it up to them whether they want to implement a change now, or in coordination with NCS v2.5.0. Again, I personally thought that all flags were simply passed on to West, but apparently it's not that simple.

Especially with the summer vacations nowadays, I think you'll have to wait a while for a fix. Use West in the mean time. But thank you again for reporting.

Best regards,

Raoul

RE: Regression in nRF Connect VS Code extension re overlay files

Florian — Wed, 12 Jul 2023 22:43:02 GMT

Hi Raoul,

thanks for all the work that you're putting in and for digging deeper.

I'm actually running on latest OSS Zephyr mainline (not the nRF Connect SDK). So formally you could probably say that this setup is not supported. But then it worked flawlessly in the prior release of the extension...

If it's an easy fix it's probably worth doing even if not strictly supported - just to not break people's setup. But if it's complicated I'd understand if you won't fix it if it's not in nRF SDK.

Kind regards,

Florian

RE: Regression in nRF Connect VS Code extension re overlay files

Raoul — Wed, 12 Jul 2023 22:31:17 GMT

Hi Florian,

I suspect you're completely right on all points. I can confirm too that the extra flag is added upon a second build.

One of the issues here is the unclear status of EXTRA_DTC_OVERLAY_FILE in NCS. Is it currently actually doing what you want it to? And are you running an updated v2.4.99?

If the VS Code extension team is working under the assumption that the -DEXTRA_DTC_OVERLAY file is not in use before v2.5.0, perhaps the continued use of a "synthesized" -DDTC_OVERLAY_FILE is the "conscious decision" they refer to. It makes sense that they would coordinate an extension change with the release of v.2.5.0 in that case. I'll see if I can find out more.

Best regards,

Raoul

RE: Regression in nRF Connect VS Code extension re overlay files

Florian — Wed, 12 Jul 2023 10:39:50 GMT

Hi Raoul,

this is probably a misunderstanding. -DEXTRA_DTC_OVERLAY_FILE is correctly passed to the build tool.

The problem is that starting with the most recent version an additional/redundant -DDTC_OVERLAY_FILE argument is automatically generated after the first build that takes precedence and overrides the -DEXTRA_DTC_OVERLAY_FILE addition that is still present. The west command then has both options present at the same time.

I guess that the new version somehow extracts overlay files from the build directory and synthesizes a -DDTC_OVERLAY_FILE option from it which it didn't do before.

After the first build when opening the build configuration with "Edit Build Configuration..." the additional -DDTC_OVERLAY_FILE will be visible.

You're right, my version is 2023.6.345 - sorry for providing the wrong version number above.

Regards,

Florian

RE: Regression in nRF Connect VS Code extension re overlay files

Raoul — Wed, 12 Jul 2023 10:30:28 GMT

Hi Florian, I got word from one of the developers:

It was a conscious decision that we don't yet set EXTRA_DTC_OVERLAY_FILE, because it doesn't exists yet in 2.4.x, it will only be present in NCS 2.5.0.

Checking the release notes, I see that indeed the first mention of EXTRA_DTC_OVERLAY_FILE is in v2.4.99. However I see EXTRA_DTC_OVERLAY_FILE mentioned in some docs before that, for example this NCS 2.4.0 page. This might have caused the confusion.

Still, I'm surprised that the extension doesn't just pass all the -D arguments directly to West.

Could you please confirm your extension version for me? I might like to do some testing of my own. You mentioned v2023.6.6, but as far as I know the newest version is 2023.6.345.

I should mention, many developers are now starting their summer vacation. Are you okay with just sticking with West for the near future?

Best regards,

Raoul

RE: Regression in nRF Connect VS Code extension re overlay files

Raoul — Wed, 05 Jul 2023 15:21:33 GMT

Got it, thanks! I'll pass this on immediately and if needed I'll try to reproduce it tomorrow.

If I hear anything useful from the developers I'll let you know.

Best regards,

Raoul

RE: Regression in nRF Connect VS Code extension re overlay files

Florian — Wed, 05 Jul 2023 15:00:28 GMT

Hi Raoul,

no, no sysbuild or anything other special involved. We're building a single binary with devicetree overlays, some of which are passed in via -DEXTRA_DTC_OVERLAY_FILE and others should be discovered by naming convention ({$sourceDir}/boards/[board-name].overlay). The west build command does it right and older versions of the extension also do it right. Should be easy to reproduce.

Florian

RE: Regression in nRF Connect VS Code extension re overlay files

Raoul — Wed, 05 Jul 2023 13:30:11 GMT

Hi again,

One of the developers is asking if you are trying to do a sysbuild. Are you? Since the extension introduced some changes in this area: https://nrfconnect.github.io/vscode-nrf-connect/release_notes/connect/2023.6.345.html#other-changes-related-to-sysbuild

Thanks again.

Best regards,

Raoul

RE: Regression in nRF Connect VS Code extension re overlay files

Raoul — Wed, 05 Jul 2023 13:13:16 GMT

Hi Florian, thanks for the (clear) bug report. I've passed this on to the extension developers.

Best regards,

Raoul