v2.3.0 Merge overflow

RE: v2.3.0 Merge overflow

Robert de Brum — Thu, 27 Jul 2023 21:32:54 GMT

I could not find the issue but it resolved itself when I cleaned up the test code and simply started over and try again.

Thanks for the help. I will close this now.

RE: v2.3.0 Merge overflow

Simonr — Tue, 18 Jul 2023 12:00:33 GMT

1. What device are you trying to pair with here? If this semaphore take() function doesn't return it seems to point to the sc_public_key not being ready so that it's only waiting for it to be ready.

2. Sorry, here I was referring to how the #includes are formatted in NCS 2.3.0 versus older NCS versions, but it does not seem to have changed since NCS 2.1.2, so I don't think this is what we're looking for.

Best regards,

Simon

RE: v2.3.0 Merge overflow

Robert de Brum — Fri, 14 Jul 2023 22:11:21 GMT

1. The paring_key_generate() fromt he peripheral_nfc_pairing sample gets halted and doesn't return. I am finding that there is a semaphore take() function that never returns. I can trace this to from main.c bt_le_oob_get_local() => bt_smp_le_oob_generate_sc_data() => k_sem_take(&sc_local_pkey_ready, K_FOREVER); (line 5322 file zephyr/subsys/bluetooth/host/smp.c).

2. After including the hci_driver.h the issue persisted. I haven't traced it too far since it is a lower priority issue but I will try to get some more info unless you have any other suggestions.

RE: v2.3.0 Merge overflow

Simonr — Fri, 14 Jul 2023 09:16:37 GMT

1. There are some changes to NFC in NCS 2.3.0 here. Make sure that the NFC library is aligned with the new library implementation. What exactly is not working in your NFC pairing?

2. I don't know all the changes between NCS versions by heart, but I know that there were some changes between in how some files/folders were included in main.c files. How does your "old" include files for I.E. the hci_driver.h file is added. In the newest NCS versions the hci_driver.h is included like this: #include <zephyr/drivers/bluetooth/hci_driver.h>

Best regards,

Simon

RE: v2.3.0 Merge overflow

Robert de Brum — Thu, 13 Jul 2023 23:39:51 GMT

Thanks again.

I was able to build, however I notice 2 other issues that v2.3.0 present that were not in the previous firmware.

1 is that the NFC pairing does not work for me. I have compared my code line for line with the peripheral_nfc_pairing sample (freshly downloaded from version 2.3.0) and I cannot find a difference in the C code or configuration/CMake files.

2 is that I cannot read the static address of the device using bt_read_static_addr() - the error reports that this command is not available.

Are these known issues as well? Should I migrate to something more stable for now like v2.2?

Thanks

RE: v2.3.0 Merge overflow

Simonr — Thu, 13 Jul 2023 13:25:20 GMT

Hi again

This not being configurable was a bug I wasn't aware of, but it's solved and documented in this pull request: https://github.com/nrfconnect/sdk-nrf/pull/10661

In short, what will work is to disable it in a Kconfig file in the project itself like the snippet below, as well as disable it in the prj.conf with CONFIG_NCS_SAMPLE_EMPTY_NET_CORE_CHILD_IMAGE=n.

config NCS_SAMPLE_EMPTY_NET_CORE_CHILD_IMAGE
    bool "test"
    default n

Best regards,

Simon

RE: v2.3.0 Merge overflow

Robert de Brum — Wed, 12 Jul 2023 23:42:15 GMT

Hello,

Thanks for this. I found that I cannot set this prompt directly, and looking at the KConfig files, all of my current configurations would set this to =y. When I added a prompt for myself and use the configuration above, the build still overlaps and fails.

config NCS_SAMPLE_EMPTY_NET_CORE_CHILD_IMAGE
	bool
	depends on SOC_NRF5340_CPUAPP && BOARD_ENABLE_CPUNET
	depends on NRF53_UPGRADE_NETWORK_CORE && !NCS_INCLUDE_RPMSG_CHILD_IMAGE
	default y
	help
	  nRF5340 empty network core sample as a child image (network core).

Was this meant to be not user-configurable? Should it be in a future release?

Thanks

RE: v2.3.0 Merge overflow

Simonr — Wed, 12 Jul 2023 07:26:31 GMT

It seems like the project tries to flash both an empty NET core and your own NET core image causing an overlap here. In NCS 2.3.0, the CONFIG_NCS_SAMPLE_EMPTY_NET_CORE_CHILD_IMAGE was introduced, that defaults to y in our projects, and adds an empty network core sample as a child image.

Can you try disabling this config to avoid flashing two NET core images?

Best regards,

Simon