GPIO overlays

RE: GPIO overlays

Bret Foreman — Mon, 17 Jul 2023 16:21:18 GMT

It's working!

Thanks

RE: GPIO overlays

Vidar Berg — Mon, 17 Jul 2023 06:46:55 GMT

Thanks for sharing your project. Yes, it is necessary to remove the alias as well if you delete the button node, just as I did in the overlay I posted earlier.

While building your project, I got an "implicit declaration" warning for the GPIO_DT_SPEC_GET() macro and an "incomplete type" error for the gpio_dt_spec struct. This was because you were missing the <zephyr/drivers/gpio.h> include.

Build log

Code with required "include"

#include <zephyr/drivers/gpio.h>

#define LED0_NODE DT_ALIAS(mycustomled)
static const struct gpio_dt_spec led = GPIO_DT_SPEC_GET(LED0_NODE, gpios);

RE: GPIO overlays

Bret Foreman — Fri, 14 Jul 2023 21:13:19 GMT

Adding only

/delete-node/ &button2;

In my overlay file causes this line in the dts file to fail:

		sw1 = &button2;

The message is "Unknown reference to &button2" as you might expect.

Adding this line to my overlay:

		/delete-property/ sw1;

Does not fix it.

I've zipped up and attached the entire project so you can see the build failure first hand.devzone.nordicsemi.com/.../cm_5F00_fw_5F00_core.zip

RE: GPIO overlays

Vidar Berg — Fri, 14 Jul 2023 11:24:30 GMT

It looks like you only deleted the alias, but not the button node. I had this line at the beginning of my overlay:

/delete-node/ &button2;

[quote user="bretforeman_personal"]I pasted in the runtime code as you suggested and the build still fails[/quote]

Can you please post the build log? You should be able to compile despite the warning about overlapping pin assignments.

RE: GPIO overlays

Bret Foreman — Thu, 13 Jul 2023 17:59:32 GMT

I added the delete-property as you suggested. In my case, GPIO 15 was connected to button2 and aliased to sw1 in my boards dts file. Here's fragment from the board's dts:

	buttons {
		compatible = "gpio-keys";
		button1: button_1 {
			gpios = <&gpio0 11 GPIO_PULL_UP>;
			label = "Push button switch 1";
		};
		button2: button_2 {
			gpios = <&gpio0 15 GPIO_PULL_UP>;
			label = "Push button switch 2";
		};
	};

	/* These aliases are provided for compatibility with samples */
	aliases {
		led0 = &led1;
		led1 = &led2;
		sw0 = &button1;
		sw1 = &button2;
		mcuboot-button0 = &button1;
		mcuboot-led0 = &led1;
		watchdog0 = &wdt0;
	};

So my overlay deletes sw1 and looks like this:

/{
	custom_leds {
 	   compatible = "gpio-leds";
	   led0: led_0 {
		  gpios = <&gpio0 15 GPIO_ACTIVE_HIGH>;
		  label = "My custom LED";
	   };
	};
	aliases {
		mycustomled = &led0;
		/delete-property/ sw1;
	};
 };

I'm still getting the same warning:

Pin 15 of &gpio0 already assigned to &button2
bl652_dvk.dts(44, 12): Overlapping assignment

I pasted in the runtime code as you suggested and the build still fails, probably because I'm still not correctly deleting the button and replacing with the led.

Can you see what I still have wrong?

RE: GPIO overlays

Vidar Berg — Thu, 13 Jul 2023 08:20:48 GMT

[quote user=""]The first problem with this approach is that I get the following warning:[/quote]

As indicated by the warning, you currently have the GPIO assigned as both a button and an LED. To get rid of the warning, you can delete the button node and its alias in your overlay, as shown below.

/delete-node/ &button2;


/{
    custom_leds {
        compatible = "gpio-leds";
        led0: led_0 {
            gpios = <&gpio0 24 GPIO_ACTIVE_HIGH>;
            label = "My custom LED";
        };
    };
    aliases {
        mycustomled = &ledx;
        /delete-property/ sw2;
    };

};

[quote user=""]The next thing I do is to try and get a device in the runtime code with the following line:[/quote]

If you want to use the Zephyr GPIO API to control the pin, then you need to initialize the gpio_dt_spec struct for the child node (led0). You can see how it is done in the Blinky example here: https://github.com/nrfconnect/sdk-zephyr/blob/b37ce40878ec52295afe6350d17712d60eb6639a/samples/basic/blinky/src/main.c#L20C75-L20C75

E.g.,

#define LED0_NODE DT_ALIAS(mycustomled)

static const struct gpio_dt_spec led = GPIO_DT_SPEC_GET(LED0_NODE, gpios);

Best regards,

Vidar