LTE mode preference default cannot be updated

RE: LTE mode preference default cannot be updated

cgnd_chris — Mon, 23 Oct 2023 00:28:19 GMT

Not sure if this will help in this case, but it's possible to change the default value of a choice as explained in docs.zephyrproject.org/.../setting.html

RE: LTE mode preference default cannot be updated

JordanYates — Mon, 25 Sep 2023 09:35:36 GMT

Right, but that relies on the user to remember to add `-- -DEXTRA_CONF_FILE=overlay-lte.conf` every time they build for an LTE board. Which apart from being error prone is a pain to type.

RE: LTE mode preference default cannot be updated

Didrik Rokhaug — Mon, 25 Sep 2023 09:18:22 GMT

[quote user="JordanYates"]If you can provide an example of the overlay file you are suggesting that would be great.[/quote]

I've modified the hello_world sample to do demonstrate this:

devzone.nordicsemi.com/.../hello_5F00_world_5F00_lte.zip

When you build with overlay-lte.conf added the "LTE features" will be added to the application.

When you build without the overlay, they will be disabled, and because all the LTE related configs are in the overlay, you will not get any warnings.

RE: LTE mode preference default cannot be updated

JordanYates — Mon, 25 Sep 2023 03:49:43 GMT

If you can provide an example of the overlay file you are suggesting that would be great.
A .conf file doesn't work, because the symbol won't exist for non-LTE boards.
A kconfig file doesn't work, because the symbol does not have a name, which is the point of this ticket.
The defconfig file doesn't make sense, because the desired networking mode is based on the application, not the board.

Warnings are not acceptable because all applications are run through CI, which fails on warnings.

RE: LTE mode preference default cannot be updated

Didrik Rokhaug — Fri, 22 Sep 2023 14:23:11 GMT

[quote user="JordanYates"]This is not ideal for two reasons. It requires an overlay file for every board that you want to compile against, and it only works at an application level. If I wish to override the default for all applications in my repo, that is a lot of duplication.[/quote]

I might be missing some details about how you have set up your projects and boards, but you should only need one overlay file per application, not one per board per application.

Another possibility, if the board always should have the option enabled is to put it in the board's defconfig file.

[quote user="JordanYates"]

>Even if CONFIG_LTE_MODE_PREFERENCE was directly configurable by the user, you would still have the same problem that it is not defined when CONFIG_LTE_LINK_CONTROL is disabled.

Having the value not defined when LTE_LINK_CONTROL is disabled is not a problem, that is the desired solution.

[/quote]

Then I am not sure if I really understand the problem. An undefined Kconfig symbol will give a Kconfig warning, but it shouldn't really keep you from building your application in either case.

Can you share the build errors you get?

RE: LTE mode preference default cannot be updated

JordanYates — Wed, 20 Sep 2023 12:01:28 GMT

> Another option is to use a Kconfig overlay file, which is added to the build when you want to enable the LTE-related features. You can e.g. look at the asset_tracker_v2 sample application how this can be done.

This is not ideal for two reasons. It requires an overlay file for every board that you want to compile against, and it only works at an application level. If I wish to override the default for all applications in my repo, that is a lot of duplication.

>Even if CONFIG_LTE_MODE_PREFERENCE was directly configurable by the user, you would still have the same problem that it is not defined when CONFIG_LTE_LINK_CONTROL is disabled.

Having the value not defined when LTE_LINK_CONTROL is disabled is not a problem, that is the desired solution.

RE: LTE mode preference default cannot be updated

Didrik Rokhaug — Wed, 20 Sep 2023 11:54:06 GMT

Hi,

Even if CONFIG_LTE_MODE_PREFERENCE was directly configurable by the user, you would still have the same problem that it is not defined when CONFIG_LTE_LINK_CONTROL is disabled.

But, as it is a choice, you are not supposed to use it directly, but instead set one of these options: https://github.com/nrfconnect/sdk-nrf/blob/b0bb4e078b9833ebbd1faf58eb0db17cba525983/lib/lte_link_control/Kconfig#L181-L220

Setting these options if CONFIG_LTE_LINK_CONTROL is not enabled will give a warning, but the build itself should succeed (assuming the code is written so that the LTE related parts are removed).

However, you could of course argue that a build shouldn't have warnings at all.

Another option is to use a Kconfig overlay file, which is added to the build when you want to enable the LTE-related features. You can e.g. look at the asset_tracker_v2 sample application how this can be done.

Best regards,

Didrik