Device Tree translation into devicetree_generated.h not going as planned

RE: Device Tree translation into devicetree_generated.h not going as planned

Ryjan — Wed, 01 Nov 2023 22:02:27 GMT

I just found an error I thought I had corrected 3 times already, but I must have deleted that changes. In my board definition file Kconfig.defconfig I had my board defined as BOARD_CONFIG_BOARD_SMRTSW_V1_2 instead of BOARD_SMRTSW_V1_2. I'm not sure why it gave me the error it did. I'm guessing that it silently defaults to some other settings and ended up wanting to initialize a bunch of UART features. After fixing that, it compiled and ran. I saw my LEDs illuminate for the first time.

RE: Device Tree translation into devicetree_generated.h not going as planned

Ryjan — Wed, 01 Nov 2023 19:03:46 GMT

The short version of my issue is I had another copy of my device tree in a location where West could find it, but the one I was editing was not the correct one.

This came from several attempts at getting this working while being pulled off onto a different project daily. I had the device tree that I was editing in the project root under boards/ but the one the West could find was a temporary version I put in the Zephyr boards/ directory. That is why my pullups were all set to up for the GPIOs and even the pin number were incorrect. None of the PWM changes I made were changes to the correct file. I found this after using Nordic's graphical tool for the device tree and noted that it was opening the copy I was not editing.

This brought me back to the issue I hadn't solved, but had forgotten about. I want to use an out of tree board definition. The seminar showed a couple of different ways to do it in NCS:

I've opted to use something that works for regular Zephyr by adding a few lines to my CMakeLists.txt file:

# BOARD_ROOT and BOARD need to be defined before finding Zephyr so the definitions are available before compilation
set(BOARD_ROOT ${CMAKE_CURRENT_SOURCE_DIR})
set(BOARD smrtsw_v1_2)

I inserted this before

find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE})

After that line is too late to define the BOARD_ROOT and BOARD.

By including the BOARD I no longer need to define on the command line if just using West and the code is easier for me to keep in one repo and distribute to my coworkers.

Now the device tree is at least referenced correctly, but I haven't gotten the code to run because there is an issue with the UART initialization. I had to include "zephyr,bt-uart = &uart0" in the chosen section of the device tree to allow it finish compiling, but I didn't need or have that before. I don't think my project needs the UART even for the RTT. Is that correct? Getting rid of all references to the UART in my device tree also does not make it happy. I found

# enable uart driver
CONFIG_SERIAL=y

# enable console
CONFIG_CONSOLE=y
CONFIG_UART_CONSOLE=y

But even when disabling those my project still thinks I need UART stuff compiled to run. When I include all of that I get an initialization assert on line 330 of hci_init because a semaphore times out during initialization. It appears to be just the first bt_hci_cmd_send_sync() call to preform a reset. Seem logical for starting up the system the host controller for the Bluetooth. I was guessing that my addition of bt-uart was messing up the initialization because I don't have some other dependency initialized for the bt-uart. However, I don't think that I need any of that. So where else could something be asking for the uart to be setup. I would like to not include it. Am I correct that I do not need the UART to be initialized to have a working RTT console?

RE: Device Tree translation into devicetree_generated.h not going as planned

Ryjan — Fri, 27 Oct 2023 15:10:01 GMT

I think I've found the cause. Once I get a solution going I'll report back. As expected it looks like a something that I've missed, but this chat has helped me arrive at that conclusion.

RE: Device Tree translation into devicetree_generated.h not going as planned

Simonr — Thu, 26 Oct 2023 11:45:04 GMT

Hi again Ryjan

You should still set the CONFIG_NFCT_PINS_AS_GPIOS=y in your NCS version, as this is the correct way to set NFCT pins as GPIOs in most nRF Connect SDK versions.

Unfortunately I don't have much more to add to the PWM issue either, but let me know how the webinar went and whether or not it helped at all. I don't see what's set up incorrectly I'm afraid but will discuss this with a few colleagues to see if they have any suggestions on this as well. Do you have a Development Kit available, and if so do you also see the same issue with the PWMs there as well?

One thing could be to try using the nRF DeviceTree extension in VS code to get a better view of what is enabled and not in your project. It gives a more user friendly display (GUI style) of the device tree and makes it easier to keep track of.

Best regards,

Simon

RE: Device Tree translation into devicetree_generated.h not going as planned

Ryjan — Wed, 25 Oct 2023 14:29:55 GMT

I can't remember why I eliminated the NFC setting at the issue, but I do see in devicetree_generated.h that it looks like there are flags set to disable it.

/*
 * Devicetree node: /soc/nfct@40005000
 *
 * Node identifier: DT_N_S_soc_S_nfct_40005000
 *
 * Binding (compatible = nordic,nrf-nfct):
 *   $ZEPHYR_BASE\dts\bindings\net\wireless\nordic,nrf-nfct.yaml
 *
 * (Descriptions have moved to the Devicetree Bindings Index
 * in the documentation.)
 */

/* Node's full path: */
#define DT_N_S_soc_S_nfct_40005000_PATH "/soc/nfct@40005000"

/* Node's name with unit-address: */
#define DT_N_S_soc_S_nfct_40005000_FULL_NAME "nfct@40005000"

/* Node parent (/soc) identifier: */
#define DT_N_S_soc_S_nfct_40005000_PARENT DT_N_S_soc

/* Node's index in its parent's list of children: */
#define DT_N_S_soc_S_nfct_40005000_CHILD_IDX 14

/* Helper macros for child nodes of this node. */
#define DT_N_S_soc_S_nfct_40005000_FOREACH_CHILD(fn) 
#define DT_N_S_soc_S_nfct_40005000_FOREACH_CHILD_SEP(fn, sep) 
#define DT_N_S_soc_S_nfct_40005000_FOREACH_CHILD_VARGS(fn, ...) 
#define DT_N_S_soc_S_nfct_40005000_FOREACH_CHILD_SEP_VARGS(fn, sep, ...) 
#define DT_N_S_soc_S_nfct_40005000_FOREACH_CHILD_STATUS_OKAY(fn) 
#define DT_N_S_soc_S_nfct_40005000_FOREACH_CHILD_STATUS_OKAY_SEP(fn, sep) 
#define DT_N_S_soc_S_nfct_40005000_FOREACH_CHILD_STATUS_OKAY_VARGS(fn, ...) 
#define DT_N_S_soc_S_nfct_40005000_FOREACH_CHILD_STATUS_OKAY_SEP_VARGS(fn, sep, ...) 

/* Node's dependency ordinal: */
#define DT_N_S_soc_S_nfct_40005000_ORD 81

/* Ordinals for what this node depends on directly: */
#define DT_N_S_soc_S_nfct_40005000_REQUIRES_ORDS \
	4, /* /soc */ \
	5, /* /soc/interrupt-controller@e000e100 */

/* Ordinals for what depends directly on this node: */
#define DT_N_S_soc_S_nfct_40005000_SUPPORTS_ORDS /* nothing */

/* Existence and alternate IDs: */
#define DT_N_S_soc_S_nfct_40005000_EXISTS 1
#define DT_N_INST_0_nordic_nrf_nfct DT_N_S_soc_S_nfct_40005000
#define DT_N_NODELABEL_nfct         DT_N_S_soc_S_nfct_40005000

/* Macros for properties that are special in the specification: */
#define DT_N_S_soc_S_nfct_40005000_REG_NUM 1
#define DT_N_S_soc_S_nfct_40005000_REG_IDX_0_EXISTS 1
#define DT_N_S_soc_S_nfct_40005000_REG_IDX_0_VAL_ADDRESS 1073762304 /* 0x40005000 */
#define DT_N_S_soc_S_nfct_40005000_REG_IDX_0_VAL_SIZE 4096 /* 0x1000 */
#define DT_N_S_soc_S_nfct_40005000_RANGES_NUM 0
#define DT_N_S_soc_S_nfct_40005000_FOREACH_RANGE(fn) 
#define DT_N_S_soc_S_nfct_40005000_IRQ_NUM 1
#define DT_N_S_soc_S_nfct_40005000_IRQ_IDX_0_EXISTS 1
#define DT_N_S_soc_S_nfct_40005000_IRQ_IDX_0_VAL_irq 5
#define DT_N_S_soc_S_nfct_40005000_IRQ_IDX_0_VAL_irq_EXISTS 1
#define DT_N_S_soc_S_nfct_40005000_IRQ_IDX_0_EXISTS 1
#define DT_N_S_soc_S_nfct_40005000_IRQ_IDX_0_VAL_priority 1
#define DT_N_S_soc_S_nfct_40005000_IRQ_IDX_0_VAL_priority_EXISTS 1
#define DT_N_S_soc_S_nfct_40005000_COMPAT_MATCHES_nordic_nrf_nfct 1
#define DT_N_S_soc_S_nfct_40005000_COMPAT_VENDOR_IDX_0_EXISTS 1
#define DT_N_S_soc_S_nfct_40005000_COMPAT_VENDOR_IDX_0 "Nordic Semiconductor"
#define DT_N_S_soc_S_nfct_40005000_COMPAT_MODEL_IDX_0_EXISTS 1
#define DT_N_S_soc_S_nfct_40005000_COMPAT_MODEL_IDX_0 "nrf-nfct"
#define DT_N_S_soc_S_nfct_40005000_STATUS_disabled 1

/* Pin control (pinctrl-<i>, pinctrl-names) properties: */
#define DT_N_S_soc_S_nfct_40005000_PINCTRL_NUM 0

/* Generic property macros: */
#define DT_N_S_soc_S_nfct_40005000_P_reg {1073762304 /* 0x40005000 */, 4096 /* 0x1000 */}
#define DT_N_S_soc_S_nfct_40005000_P_reg_IDX_0 1073762304
#define DT_N_S_soc_S_nfct_40005000_P_reg_IDX_0_EXISTS 1
#define DT_N_S_soc_S_nfct_40005000_P_reg_IDX_1 4096
#define DT_N_S_soc_S_nfct_40005000_P_reg_IDX_1_EXISTS 1
#define DT_N_S_soc_S_nfct_40005000_P_reg_FOREACH_PROP_ELEM(fn) fn(DT_N_S_soc_S_nfct_40005000, reg, 0) \
	fn(DT_N_S_soc_S_nfct_40005000, reg, 1)
#define DT_N_S_soc_S_nfct_40005000_P_reg_FOREACH_PROP_ELEM_SEP(fn, sep) fn(DT_N_S_soc_S_nfct_40005000, reg, 0) DT_DEBRACKET_INTERNAL sep \
	fn(DT_N_S_soc_S_nfct_40005000, reg, 1)
#define DT_N_S_soc_S_nfct_40005000_P_reg_FOREACH_PROP_ELEM_VARGS(fn, ...) fn(DT_N_S_soc_S_nfct_40005000, reg, 0, __VA_ARGS__) \
	fn(DT_N_S_soc_S_nfct_40005000, reg, 1, __VA_ARGS__)
#define DT_N_S_soc_S_nfct_40005000_P_reg_FOREACH_PROP_ELEM_SEP_VARGS(fn, sep, ...) fn(DT_N_S_soc_S_nfct_40005000, reg, 0, __VA_ARGS__) DT_DEBRACKET_INTERNAL sep \
	fn(DT_N_S_soc_S_nfct_40005000, reg, 1, __VA_ARGS__)
#define DT_N_S_soc_S_nfct_40005000_P_reg_EXISTS 1
#define DT_N_S_soc_S_nfct_40005000_P_interrupts {5 /* 0x5 */, 1 /* 0x1 */}
#define DT_N_S_soc_S_nfct_40005000_P_interrupts_IDX_0 5
#define DT_N_S_soc_S_nfct_40005000_P_interrupts_IDX_0_EXISTS 1
#define DT_N_S_soc_S_nfct_40005000_P_interrupts_IDX_1 1
#define DT_N_S_soc_S_nfct_40005000_P_interrupts_IDX_1_EXISTS 1
#define DT_N_S_soc_S_nfct_40005000_P_interrupts_FOREACH_PROP_ELEM(fn) fn(DT_N_S_soc_S_nfct_40005000, interrupts, 0) \
	fn(DT_N_S_soc_S_nfct_40005000, interrupts, 1)
#define DT_N_S_soc_S_nfct_40005000_P_interrupts_FOREACH_PROP_ELEM_SEP(fn, sep) fn(DT_N_S_soc_S_nfct_40005000, interrupts, 0) DT_DEBRACKET_INTERNAL sep \
	fn(DT_N_S_soc_S_nfct_40005000, interrupts, 1)
#define DT_N_S_soc_S_nfct_40005000_P_interrupts_FOREACH_PROP_ELEM_VARGS(fn, ...) fn(DT_N_S_soc_S_nfct_40005000, interrupts, 0, __VA_ARGS__) \
	fn(DT_N_S_soc_S_nfct_40005000, interrupts, 1, __VA_ARGS__)
#define DT_N_S_soc_S_nfct_40005000_P_interrupts_FOREACH_PROP_ELEM_SEP_VARGS(fn, sep, ...) fn(DT_N_S_soc_S_nfct_40005000, interrupts, 0, __VA_ARGS__) DT_DEBRACKET_INTERNAL sep \
	fn(DT_N_S_soc_S_nfct_40005000, interrupts, 1, __VA_ARGS__)
#define DT_N_S_soc_S_nfct_40005000_P_interrupts_EXISTS 1
#define DT_N_S_soc_S_nfct_40005000_P_status "disabled"
#define DT_N_S_soc_S_nfct_40005000_P_status_STRING_TOKEN disabled
#define DT_N_S_soc_S_nfct_40005000_P_status_STRING_UPPER_TOKEN DISABLED
#define DT_N_S_soc_S_nfct_40005000_P_status_ENUM_IDX 2
#define DT_N_S_soc_S_nfct_40005000_P_status_ENUM_TOKEN disabled
#define DT_N_S_soc_S_nfct_40005000_P_status_ENUM_UPPER_TOKEN DISABLED
#define DT_N_S_soc_S_nfct_40005000_P_status_FOREACH_PROP_ELEM(fn) fn(DT_N_S_soc_S_nfct_40005000, status, 0) \
	fn(DT_N_S_soc_S_nfct_40005000, status, 1) \
	fn(DT_N_S_soc_S_nfct_40005000, status, 2) \
	fn(DT_N_S_soc_S_nfct_40005000, status, 3) \
	fn(DT_N_S_soc_S_nfct_40005000, status, 4) \
	fn(DT_N_S_soc_S_nfct_40005000, status, 5) \
	fn(DT_N_S_soc_S_nfct_40005000, status, 6) \
	fn(DT_N_S_soc_S_nfct_40005000, status, 7)
#define DT_N_S_soc_S_nfct_40005000_P_status_FOREACH_PROP_ELEM_SEP(fn, sep) fn(DT_N_S_soc_S_nfct_40005000, status, 0) DT_DEBRACKET_INTERNAL sep \
	fn(DT_N_S_soc_S_nfct_40005000, status, 1) DT_DEBRACKET_INTERNAL sep \
	fn(DT_N_S_soc_S_nfct_40005000, status, 2) DT_DEBRACKET_INTERNAL sep \
	fn(DT_N_S_soc_S_nfct_40005000, status, 3) DT_DEBRACKET_INTERNAL sep \
	fn(DT_N_S_soc_S_nfct_40005000, status, 4) DT_DEBRACKET_INTERNAL sep \
	fn(DT_N_S_soc_S_nfct_40005000, status, 5) DT_DEBRACKET_INTERNAL sep \
	fn(DT_N_S_soc_S_nfct_40005000, status, 6) DT_DEBRACKET_INTERNAL sep \
	fn(DT_N_S_soc_S_nfct_40005000, status, 7)
#define DT_N_S_soc_S_nfct_40005000_P_status_FOREACH_PROP_ELEM_VARGS(fn, ...) fn(DT_N_S_soc_S_nfct_40005000, status, 0, __VA_ARGS__) \
	fn(DT_N_S_soc_S_nfct_40005000, status, 1, __VA_ARGS__) \
	fn(DT_N_S_soc_S_nfct_40005000, status, 2, __VA_ARGS__) \
	fn(DT_N_S_soc_S_nfct_40005000, status, 3, __VA_ARGS__) \
	fn(DT_N_S_soc_S_nfct_40005000, status, 4, __VA_ARGS__) \
	fn(DT_N_S_soc_S_nfct_40005000, status, 5, __VA_ARGS__) \
	fn(DT_N_S_soc_S_nfct_40005000, status, 6, __VA_ARGS__) \
	fn(DT_N_S_soc_S_nfct_40005000, status, 7, __VA_ARGS__)
#define DT_N_S_soc_S_nfct_40005000_P_status_FOREACH_PROP_ELEM_SEP_VARGS(fn, sep, ...) fn(DT_N_S_soc_S_nfct_40005000, status, 0, __VA_ARGS__) DT_DEBRACKET_INTERNAL sep \
	fn(DT_N_S_soc_S_nfct_40005000, status, 1, __VA_ARGS__) DT_DEBRACKET_INTERNAL sep \
	fn(DT_N_S_soc_S_nfct_40005000, status, 2, __VA_ARGS__) DT_DEBRACKET_INTERNAL sep \
	fn(DT_N_S_soc_S_nfct_40005000, status, 3, __VA_ARGS__) DT_DEBRACKET_INTERNAL sep \
	fn(DT_N_S_soc_S_nfct_40005000, status, 4, __VA_ARGS__) DT_DEBRACKET_INTERNAL sep \
	fn(DT_N_S_soc_S_nfct_40005000, status, 5, __VA_ARGS__) DT_DEBRACKET_INTERNAL sep \
	fn(DT_N_S_soc_S_nfct_40005000, status, 6, __VA_ARGS__) DT_DEBRACKET_INTERNAL sep \
	fn(DT_N_S_soc_S_nfct_40005000, status, 7, __VA_ARGS__)
#define DT_N_S_soc_S_nfct_40005000_P_status_EXISTS 1
#define DT_N_S_soc_S_nfct_40005000_P_compatible {"nordic,nrf-nfct"}
#define DT_N_S_soc_S_nfct_40005000_P_compatible_IDX_0 "nordic,nrf-nfct"
#define DT_N_S_soc_S_nfct_40005000_P_compatible_IDX_0_STRING_TOKEN nordic_nrf_nfct
#define DT_N_S_soc_S_nfct_40005000_P_compatible_IDX_0_STRING_UPPER_TOKEN NORDIC_NRF_NFCT
#define DT_N_S_soc_S_nfct_40005000_P_compatible_IDX_0_EXISTS 1
#define DT_N_S_soc_S_nfct_40005000_P_compatible_FOREACH_PROP_ELEM(fn) fn(DT_N_S_soc_S_nfct_40005000, compatible, 0)
#define DT_N_S_soc_S_nfct_40005000_P_compatible_FOREACH_PROP_ELEM_SEP(fn, sep) fn(DT_N_S_soc_S_nfct_40005000, compatible, 0)
#define DT_N_S_soc_S_nfct_40005000_P_compatible_FOREACH_PROP_ELEM_VARGS(fn, ...) fn(DT_N_S_soc_S_nfct_40005000, compatible, 0, __VA_ARGS__)
#define DT_N_S_soc_S_nfct_40005000_P_compatible_FOREACH_PROP_ELEM_SEP_VARGS(fn, sep, ...) fn(DT_N_S_soc_S_nfct_40005000, compatible, 0, __VA_ARGS__)
#define DT_N_S_soc_S_nfct_40005000_P_compatible_LEN 1
#define DT_N_S_soc_S_nfct_40005000_P_compatible_EXISTS 1
#define DT_N_S_soc_S_nfct_40005000_P_wakeup_source 0
#define DT_N_S_soc_S_nfct_40005000_P_wakeup_source_EXISTS 1

The line that I think should make the difference is "#define DT_N_S_soc_S_nfct_40005000_STATUS_disabled 1" so it appears to be disabled.

As a note , this is a custom board definition and I'm planning on attending the webinar later today on the subject of building custom boards. I the end, I expect it to be a syntax error on my part in the devicetree, but I just don't see it yet.

Concerning the PWM channels, right not I have just a single call to select a output level that is set once, so I can verify that I have it working. Since I am using a custom board, the pins are different than the ones in the developer kit board for the nRF52832. The issue I see so far with them is that devicetree_generated.h does not seem to correctly reflect the devicetree I setup. Only PWM0 is used and the channels are not as set. Unfortunately there is not a lot off error checking in the devicetree toolchain so my issues fail silently without giving me very many clues as to where the issue lies.

RE: Device Tree translation into devicetree_generated.h not going as planned

Simonr — Wed, 25 Oct 2023 07:17:40 GMT

The CONFIG_NFCT_PINS_AS_GPIOS is only deprecated in the latest (main branch) version of the nRF Connect SDK, so the device tree addition should indeed not matter if you're using any SDK version prior to NCS 2.4.2.

So adding the CONFIG_NFCT_PINS_AS_GPIOS=y does not do anything to fix the P0.09 and P0.10 on your end?

Regarding your PWM question, OUT in I.E. NRF_FUN_PWM_OUT0 refers to it being an output pin. Are the pins you're using for PWM connected to LEDS, and that's why you're expecting lights to fade? Note that the LEDs on the DK is connected to P0.17-P0.20, so if you're using the onboard LEDs you need to use these pins.

Best regards,

Simon

RE: Device Tree translation into devicetree_generated.h not going as planned

Ryjan — Mon, 23 Oct 2023 17:37:54 GMT

I started this project in February so it should not be the latest. I did try adding &uicr { nfct-pins-as-gpios; }; into the device tree and remove CONFIG_NFCT_PINS_AS_GPIOS=y and my hack and the problem came right back. I looked through the changlogs for the different SDKs and could not find a reference to that change in them.

I am using a switch on pin 0.10 that has a pull down. Pins 0.03 and 0.08 are both using pull ups and have opposite logic.

RE: Device Tree translation into devicetree_generated.h not going as planned

Simonr — Mon, 23 Oct 2023 15:00:46 GMT

CONFIG_NFCT_PINS_AS_GPIOS=y was recently deprecated, and we recommend using the devicetree for the most recent NCS releases. What NCS version are you working on here? If it doesn't help to set NFC pins as GPIOs, can you try using other pins than the NFC pins just to make sure.

Which of the pins is it that has inverted logic compared to the others? I'll take another look if that doesn't help either.

Best regards,

Simon

RE: Device Tree translation into devicetree_generated.h not going as planned

Ryjan — Mon, 23 Oct 2023 13:32:52 GMT

I spent quite a bit of time trying to blame it on an NFC pin issue, but ultimately ruled it out. I edited my prj.conf to include this: CONFIG_NFCT_PINS_AS_GPIOS=y and did some testing. In the end I determined that it was not the source of my issue with the button, but I may have incorrectly concluded that. Do I need to also have &uicr { nfct-pins-as-gpios; }; in my device tree as well?

RE: Device Tree translation into devicetree_generated.h not going as planned

Simonr — Mon, 23 Oct 2023 11:19:40 GMT

The first thing that comes to mind when reading this case is that you're using pins P0.09 and P0.10 as PWM and buttons. By default these pins are set as NFCT pins and thus won't work as expected when used as GPIOs. This would explain why one button is inverted and why one of the PWMs doesn't work as expected.

You'll need to use the Devicetree to configure NFCT pins as GPIOS with &uicr { nfct-pins-as-gpios; }; in your project.

Best regards,

Simon