Implementation of Periodic SPI Operations with nrfx

RE: Implementation of Periodic SPI Operations with nrfx

BENBF — Tue, 02 Jan 2024 16:58:24 GMT

It seems that it works as intended when using IRQ_CONNECT() instead of IRQ_DIRECT_CONNECT().

Thank you,
Best regards

RE: Implementation of Periodic SPI Operations with nrfx

Kenneth — Tue, 02 Jan 2024 12:13:26 GMT

The first I would try is whether the code you shared works as intended when using IRQ_CONNECT() instead of IRQ_DIRECT_CONNECT().

Kenneth

RE: Implementation of Periodic SPI Operations with nrfx

BENBF — Tue, 02 Jan 2024 09:36:37 GMT

Hello,
Thank you for your answer.

I'm using IRQ_DIRECT_CONNECT() to declare my 50Hz timer.
Unfortunately, as my SPI transactions are quite long, it triggers a timeout when I'm performing them directly from the timer handler function. This is why I tried to offload those transactions with another thread.

The observed behaviour is that the SPI thread is not activated every time the timer IRQ is fired and I don't understand why. The observed behaviour remains the same even if I lower the timer frequency.

Do you know if there is a way to access thread scheduler information or to force it to update itself in order to be sure that my SPI thread is indeed the next one to be performed when the timer IRQ occurs ?

Best regards

RE: Implementation of Periodic SPI Operations with nrfx

Kenneth — Tue, 02 Jan 2024 08:35:36 GMT

The only thing I can think of and I want to mention is that when you define the interrupts, you can choose between either IRQ_CONNECT() or IRQ_DIRECT_CONNECT(). Bascially the first allow you to use the zephyr api as-is from the interrupt handler, while the other you need to add some macros to the interrupt handler if you want to use the zephyr api from the interrupt handler. You can read more about it here:
https://developer.nordicsemi.com/nRF_Connect_SDK/doc/latest/zephyr/kernel/services/interrupts.html

Kenneth

RE: Implementation of Periodic SPI Operations with nrfx

ovrebekk — Wed, 27 Dec 2023 09:58:00 GMT

We are severely understaffed this week because of the Christmas holidays, and Kenneth will have to get back to you on this next week. Sorry for the inconvenience.

Best regards
Torbjørn

RE: Implementation of Periodic SPI Operations with nrfx

BENBF — Thu, 21 Dec 2023 14:28:49 GMT

Hello, thank you for your answers.

In the end it appear that I can't use PPI for my application as I need to have fine control over SPI transactions...

I tried to perform my SPI transactions in a dedicated thread that is triggered by a 50 Hz timer.
Unfortunately, my SPI thread is not triggered every time that timer callback is called. Do you have nay idea of what be the cause of this issue ?

I've tried to trigger the thread with either semaphore or thread management (with k_thread_resume()) but the observed behaviour is the same

This is the test code I'm using:

void t_test(void){
    while(1){
        //k_sem_take(&_sem, K_FOREVER);
        printk("Second Thread\n");
        k_thread_suspend(t_thread);
    }
}



void main(void)
{
    //k_sem_init(&_sem, 0, 1);

    t_thread = k_thread_create(&t_k_thread, _stack, STACKSIZE, t_test, NULL, NULL, NULL, -2, 0, K_NO_WAIT);
    k_msleep(1000);
    printk("Starting timer\n");
    meas_timer_init();

    while (1) {
        printk("Main thread: still alive\n");
        k_msleep(1000);
    }
}

And this is the timer part :

ISR_DIRECT_DECLARE(meas_timer_handler)
{

    if (NRF_TIMER1->EVENTS_COMPARE[0]) {
        NRF_TIMER1->EVENTS_COMPARE[0] = 0;
        printk("Timer\n");
        //k_sem_give(&_sem);
        k_thread_resume(t_thread);
       
    }
    return 0;
}

void meas_timer_init(void)
{
    IRQ_DIRECT_CONNECT(TIMER1_IRQn, 4, meas_timer_handler, 0);
    NRF_TIMER1->BITMODE = 32;
    NRF_TIMER1->PRESCALER = 8;
    NRF_TIMER1->MODE = TIMER_MODE_MODE_Timer;
    NRF_TIMER1->CC[0] = 1250;
    NRF_TIMER1->SHORTS = 0;
    NRF_TIMER1->SHORTS = TIMER_SHORTS_COMPARE0_CLEAR_Enabled << TIMER_SHORTS_COMPARE0_CLEAR_Pos;
    NRF_TIMER1->INTENSET = TIMER_INTENSET_COMPARE0_Enabled << TIMER_INTENSET_COMPARE0_Pos;
    NRF_TIMER1->TASKS_START = 1;
    irq_enable(TIMER1_IRQn);
}

Thank you,
Best regards

RE: Implementation of Periodic SPI Operations with nrfx

PabloL — Wed, 06 Dec 2023 14:06:46 GMT

Hi,

1) Set a timer in timer mode:

#define TIMER1_INST_IDX 0
#define TIMER_COMPARE_COUNT 320000  // 16000000 * 0.02s

// Timer instance
const nrfx_timer_t timer1_inst = NRFX_TIMER_INSTANCE(TIMER1_INST_IDX);

void timer_init(void)
{
    nrfx_err_t err;
    (void)err;
    
    // Configure Timer
    uint32_t base_frequency = NRF_TIMER_BASE_FREQUENCY_GET(timer1_inst.p_reg);
    nrfx_timer_config_t config = NRFX_TIMER_DEFAULT_CONFIG(base_frequency);
    config.bit_width = NRF_TIMER_BIT_WIDTH_32;
    config.mode = NRF_TIMER_MODE_TIMER;
    config.p_context = &timer1_inst;
    err = nrfx_timer_init(&timer1_inst, &config, NULL);
    NRFX_ASSERT(err == NRFX_SUCCESS);
    
    #if defined(__ZEPHYR__)
    IRQ_DIRECT_CONNECT(NRFX_IRQ_NUMBER_GET(NRF_TIMER_INST_GET(TIMER1_INST_IDX)), IRQ_PRIO_LOWEST,
    NRFX_TIMER_INST_HANDLER_GET(TIMER1_INST_IDX), 0);
    #endif
    
    /* Setting the timer (in timer mode) channel NRF_TIMER_CC_CHANNEL0 in the extended compare
     * mode to clear the timer and trigger an event if internal counter register is equal
     * to TIMER_COMPARE_COUNT.
     */
    nrfx_timer_extended_compare(&timer1_inst, NRF_TIMER_CC_CHANNEL0, TIMER_COMPARE_COUNT,
    NRF_TIMER_SHORT_COMPARE0_CLEAR_MASK, false);
}

2) Set SPIM:

// SPIM instance to be used
#define SPIM_INST_IDX 4

// SPI instance
nrfx_spim_t spim_inst = NRFX_SPIM_INSTANCE(SPIM_INST_IDX);

// SPI Configuration
void SPI_Init(void)
{
    nrfx_spim_config_t spim_config = NRFX_SPIM_DEFAULT_CONFIG(SCK_PIN,
                                                              MOSI_PIN,
                                                              MISO_PIN,
                                                              CS_PIN);

	spim_config.ss_pin = CS_PIN;
	spim_config.use_hw_ss = true;		// hardware SS (SPIM4 only)

    // Enable IRQ if necessary
	// IRQ_CONNECT(DT_IRQN(DT_NODELABEL(spi4)),
	// 			DT_IRQ(DT_NODELABEL(spi4), priority),
	// 			nrfx_isr, nrfx_spim4_irq_handler, 0);

    err = nrfx_spim_init(&spim_inst, &spim_config, NULL, NULL);
    NRFX_ASSERT(err != NRFX_SUCCESS);
}

3) Configure DPPI:

uint8_t ppi_channel1;

void ppi_init(void)
{
	nrfx_err_t err;

	/* Allocate a (D)PPI channel. */
	err = nrfx_gppi_channel_alloc(&ppi_channel1);
	if (err != NRFX_SUCCESS) {
		LOG_ERR("nrfx_gppi_channel_alloc error: 0x%08X", err);
		return;
	}
	
	/* Configure endpoints of the channel so that the TIMER1, CCCH0 event is
	 * connected with the SPIM task.
	 */
	nrfx_gppi_channel_endpoints_setup(ppi_channel1,
			nrfx_timer_compare_event_address_get(&timer1_inst, NRF_TIMER_CC_CHANNEL0),
			nrfx_spim_start_task_address_get(&spim_inst));
	
	// Enable the channel
	nrfx_gppi_channels_enable(BIT(ppi_channel1));
}

4) Configure xfer and start timer:

    uint8_t tx_data[TX_DATA_SIZE]; // FILL with data to send
    uint8_t rx_data[RX_DATA_SIZE];
    
    // SPIM Descriptor
    nrfx_spim_xfer_desc_t spim_xfer_desc = NRFX_SPIM_XFER_TRX(tx_data, sizeof(tx_data), rx_data, sizeof(rx_data));

	// Configure SPIM transfer, hold for an event, increment rx pointer after transfer
	// Note: Should reset the pointer at some point
	err = nrfx_spim_xfer(&spim_inst, &spim_xfer_desc, NRFX_SPIM_FLAG_HOLD_XFER|NRFX_SPIM_FLAG_REPEATED_XFER|NRFX_SPIM_FLAG_RX_POSTINC|NRFX_SPIM_FLAG_NO_XFER_EVT_HANDLER);
    NRFX_ASSERT(err != NRFX_SUCCESS);

	
	nrfx_timer_clear(&timer1_inst);
    nrfx_timer_enable(&timer1_inst);

Enjoy!

RE: Implementation of Periodic SPI Operations with nrfx

Kenneth — Wed, 06 Dec 2023 13:01:13 GMT

Hello,

You may find the following two examples useful (I hope).

How to setup timer to toggle a pin using ppi:
https://github.com/zephyrproject-rtos/hal_nordic/tree/master/nrfx/samples/src/nrfx_gppi/one_to_one

But in your case you need to trigger a spi transfer instead, so here is an example on how to setup a spi transfer:
https://github.com/zephyrproject-rtos/hal_nordic/tree/master/nrfx/samples/src/nrfx_spim/non_blocking

But in your case you should setup the nrfx_spim_xfer(..NRFX_SPIM_FLAG_HOLD_XFER). Then use the nrfx_spim_start_task_address_get() to find the start task adress that should be used to connect the ppi channel from the timer (instead of nrfx_gpiote_out_task_address_get).

Kenneth