RE: Assertion Failed - PCA100040

Karl Ylvisaker — Thu, 04 Jan 2024 15:06:57 GMT

Hello,

Thank you for your patience with this.

I am glad to hear that you were able to successfully test the NFC samples, since this gives us a strong indication that the issue is with the source code.

Before I start the review I thought I should asl : Do you still require support with this?
Just in case you've already found the root cause of your issue in the time since we last spoke.

If you do still require support with this, could you please specify which error code that is returned when the NFC fails to initialize?
Please make sure to have DEBUG defined in your preprocessor defines, like shown in the included image, to have the logger module output an error message whenever a non-NRF_SUCCESS error code is passed to an APP_ERROR_CHECK.

Best regards,
Karl

RE: Assertion Failed - PCA100040

Samiya Khaliq — Tue, 02 Jan 2024 06:50:56 GMT

Sure, I can wait.

RE: Assertion Failed - PCA100040

Øyvind — Wed, 27 Dec 2023 09:52:32 GMT

Hello,

We are severely understaffed this week because of the Christmas holidays, and Karl will have to get back to you on this next week. Sorry for the inconvenience.

Kind regards,
Øyvind

RE: Assertion Failed - PCA100040

Samiya Khaliq — Sun, 24 Dec 2023 12:16:16 GMT

I ran the NFC examples, and they work fine. I also replaced my main.c file with those examples to check if my sdk_config.h file is working fine, and it does. So, the problem is in my code. It fails to initialize NFC.

RE: Assertion Failed - PCA100040

Karl Ylvisaker — Thu, 21 Dec 2023 16:29:50 GMT

Have you verified that the NFC is initialized as expected?

Best regards,
Karl

RE: Assertion Failed - PCA100040

Samiya Khaliq — Thu, 21 Dec 2023 15:25:16 GMT

I have added the nrfx_saadc_config_t struct. The code builds and runs, but no NFC is detected on my NFC tools app.

#include <stdint.h>
#include <string.h>
#include "nfc_t2t_lib.h"
#include "nfc_ndef_msg.h"
#include "nfc_text_rec.h"
#include "boards.h"
#include "app_error.h"
#include "nrfx_saadc.h"
#include "nrf_log.h"
#include "nrf_log_ctrl.h"
#include "nrf_log_default_backends.h"

#define MAX_REC_COUNT 3  /**< Maximum records count. */
#define NFC_TEXT_BUF_SIZE 20  /**< Maximum size of the NFC text buffer. */

/* Buffer used to hold an NFC NDEF message. */
uint8_t m_ndef_msg_buf[256];

/* Buffer used to hold the NFC text. */
static uint8_t m_nfc_text_buf[NFC_TEXT_BUF_SIZE];

/* NFC module initialization status */
static bool nfc_initialized = false;

/* Callback function for handling NFC events. */
static void nfc_callback(void* p_context, nfc_t2t_event_t event, const uint8_t* p_data, size_t data_length)
{
    (void)p_context;

    switch (event)
    {
        case NFC_T2T_EVENT_FIELD_ON:
            bsp_board_led_on(BSP_BOARD_LED_0);
            break;
        case NFC_T2T_EVENT_FIELD_OFF:
            bsp_board_led_off(BSP_BOARD_LED_0);
            break;
        default:
            break;
    }
}

/* Function declaration for nrfx_saadc_event_handler */
void nrfx_saadc_event_handler(nrfx_saadc_evt_t const * p_event);

/* Function for initializing logging. */
static void log_init(void)
{
    ret_code_t err_code = NRF_LOG_INIT(NULL);
    APP_ERROR_CHECK(err_code);

    NRF_LOG_DEFAULT_BACKENDS_INIT();
}

/* Function for reading ADC value using nrfx SAADC. */
static uint16_t read_adc_value(void)
{
    ret_code_t err_code;
    nrf_saadc_value_t adc_value;

    // Sample conversion
    err_code = nrfx_saadc_sample_convert(0, &adc_value);
    APP_ERROR_CHECK(err_code);

    NRF_LOG_INFO("ADC Value: %d", adc_value);

    return adc_value;
}

/* Function definition for nrfx_saadc_event_handler */
void nrfx_saadc_event_handler(nrfx_saadc_evt_t const * p_event)
{
    if (p_event->type == NRFX_SAADC_EVT_DONE)
    {
        // Check if SAADC conversion was successful
        if (p_event->data.done.p_buffer != NULL)
        {
            // SAADC conversion successful, handle the result if needed
            // Access the buffer with p_event->data.done.p_buffer
            NRF_LOG_INFO("SAADC conversion successful");
        }
        else
        {
            // SAADC conversion failed
            NRF_LOG_ERROR("SAADC conversion failed");
        }

        // Restart SAADC conversion for continuous sampling
        ret_code_t err_code = nrfx_saadc_buffer_convert(NULL, 1);
        APP_ERROR_CHECK(err_code);
    }
    else if (p_event->type == NRFX_SAADC_EVT_LIMIT)
    {
        // Handle SAADC limit event (if needed)
        // This event occurs when the sampled value goes beyond the set limits
        NRF_LOG_WARNING("SAADC limit event");
    }
}


/* ADC message encoding function */
static ret_code_t adc_msg_encode(uint8_t* p_buffer, uint32_t* p_len)
{
    ret_code_t err_code;

    // Read ADC value here (replace this with your ADC reading logic)
    uint16_t adc_value = read_adc_value();

    // Convert ADC value to ASCII
    snprintf((char*)m_nfc_text_buf, sizeof(m_nfc_text_buf), "%d", adc_value);

    /* Create NFC NDEF text record description in English */
    NFC_NDEF_TEXT_RECORD_DESC_DEF(nfc_en_text_rec,
                                  UTF_8,
                                  (uint8_t*)"en",
                                  2,
                                  m_nfc_text_buf,
                                  strlen((char*)m_nfc_text_buf));

    /* Create NFC NDEF message description, capacity - MAX_REC_COUNT records */
    NFC_NDEF_MSG_DEF(nfc_text_msg, MAX_REC_COUNT);

    /* Add text records to NDEF text message */
    err_code = nfc_ndef_msg_record_add(&NFC_NDEF_MSG(nfc_text_msg), &NFC_NDEF_TEXT_RECORD_DESC(nfc_en_text_rec));
    APP_ERROR_CHECK(err_code);

    /* Encode NDEF message */
    err_code = nfc_ndef_msg_encode(&NFC_NDEF_MSG(nfc_text_msg), p_buffer, p_len);
    return err_code;
}

/* Function for application main entry. */
int main(void)
{
    uint32_t len = sizeof(m_ndef_msg_buf);
    ret_code_t err_code;

    // Initialize logging
    log_init();

    // Initialize nrfx SAADC with configuration
    nrfx_saadc_config_t saadc_config = {
        .resolution = NRF_SAADC_RESOLUTION_10BIT,
        .oversample = NRF_SAADC_OVERSAMPLE_DISABLED,
        .interrupt_priority = NRFX_SAADC_CONFIG_IRQ_PRIORITY,
        .low_power_mode = false
    };

    err_code = nrfx_saadc_init(&saadc_config, nrfx_saadc_event_handler);
    APP_ERROR_CHECK(err_code);

    // Set up NFC
    err_code = nfc_t2t_setup(nfc_callback, NULL);
    APP_ERROR_CHECK(err_code);

    // NFC module is initialized
    nfc_initialized = true;

    // Configure LED-pins as outputs
    bsp_board_init(BSP_INIT_LEDS);

    // Initialize SAADC channel once during initialization
    nrf_saadc_channel_config_t channel_config = NRFX_SAADC_DEFAULT_CHANNEL_CONFIG_SE(NRF_SAADC_INPUT_AIN0);
    channel_config.gain = NRF_SAADC_GAIN1_6;
    err_code = nrfx_saadc_channel_init(0, &channel_config);
    APP_ERROR_CHECK(err_code);

    // Start SAADC conversion for continuous sampling
    err_code = nrfx_saadc_buffer_convert(NULL, 1);
    APP_ERROR_CHECK(err_code);

    while (1)
    {
        // Check if the SAADC is not busy before starting a new conversion
        if (!nrfx_saadc_is_busy())
        {
            // Read ADC value
            uint16_t adc_value = read_adc_value();

            // Encode ADC message
            err_code = adc_msg_encode(m_ndef_msg_buf, &len);
            APP_ERROR_CHECK(err_code);

            // Check if NFC is initialized before setting the payload
            if (nfc_initialized)
            {
                // Set created message as the NFC payload
                err_code = nfc_t2t_payload_set(m_ndef_msg_buf, len);
                APP_ERROR_CHECK(err_code);
            }

            NRF_LOG_FLUSH();
        }

        // Sleep or perform other tasks
        __WFE();
    }
}

RE: Assertion Failed - PCA100040

luckyyorange — Sun, 17 Dec 2023 18:37:15 GMT

Hello,

The problem is on line 171 of main.c where you pass NULL as a parameter. The nrfx_saadc_init function asserts the p_config parameter at line 216 of nrf_saadc.c and evaluates to false when given NULL since the saadc requires important configurations before being used. Thus, the runtime assertion failed error is thrown. A nrfx_saadc_config_t struct must be populated with the desired resolution, oversampling, power mode, and interrupt priority field configurations and then passed as a pointer in place of the NULL.

Hope this help!