HSL Mesh server defintion macro issue

RE: HSL Mesh server defintion macro issue

parksj10 — Fri, 02 Feb 2024 05:49:56 GMT

FWIW to anyone seeing this in the future, I solved it by refactoring like so:


static struct bt_mesh_onoff_srv onoff_srv_0 = BT_MESH_ONOFF_SRV_INIT(&onoff_handlers);
static struct bt_mesh_lightness_srv lightness_srv_0 = BT_MESH_LIGHTNESS_SRV_INIT(&lightness_handlers);
static struct bt_mesh_light_hsl_srv light_hsl_srv_0 = BT_MESH_LIGHT_HSL_SRV_INIT(&lightness_srv_0, &hue_handlers, &saturation_handlers);
static struct bt_mesh_onoff_srv onoff_srv_1 = BT_MESH_ONOFF_SRV_INIT(&onoff_handlers);
static struct bt_mesh_lightness_srv lightness_srv_1 = BT_MESH_LIGHTNESS_SRV_INIT(&lightness_handlers);
static struct bt_mesh_light_hsl_srv light_hsl_srv_1 = BT_MESH_LIGHT_HSL_SRV_INIT(&lightness_srv_1, &hue_handlers, &saturation_handlers);


struct led_ctx
{
	struct k_work_delayable onoff_work;
	struct k_work_delayable lightness_work;
	struct k_work_delayable sat_work;
	struct k_work_delayable hue_work;

	struct bt_mesh_onoff_srv *onoff;
	struct bt_mesh_lightness_srv *lightness;
	struct bt_mesh_light_hsl_srv *light_hsl;
	struct bt_mesh_light_hue_srv *hue;
	struct bt_mesh_light_sat_srv *sat;

	uint32_t onoff_remaining;
	bool onoff_value;
	uint32_t lightness_remaining;
	uint16_t lightness_value;
	uint32_t hue_remaining;
	uint16_t hue_value;
	uint32_t sat_remaining;
	uint16_t sat_value;
	uint16_t element_idx;
	// 2. link element_idx to this context, then lookup the ctx based on element of the model
	// 3. also rearrange elements to created for each led (element one is led 1, element 2 is led 2)
};

static const LED_COUNT = 2;
struct led_ctx led_ctx[LED_COUNT] = {{
	.onoff = &onoff_srv_0,
	.lightness = &lightness_srv_0,
	.light_hsl = &light_hsl_srv_0,
	.hue = &light_hsl_srv_0.hue,
	.sat = &light_hsl_srv_0.sat,
},
{
	.onoff = &onoff_srv_1,
	.lightness = &lightness_srv_1,
	.light_hsl = &light_hsl_srv_1,
	.hue = &light_hsl_srv_1.hue,
	.sat = &light_hsl_srv_1.sat,
}};

RE: HSL Mesh server defintion macro issue

Susheel Nuguru — Tue, 30 Jan 2024 07:56:30 GMT

That is basic C programming issue. You cannot initialize a whole struct this way. You can initialize pointers to a struct but not the whole struct as a constant initializer.

I suggest that you omit .lightness initialization at this point and do a memcpy from .lightness_srv_1 into a lightness struct inside model_handler_init

RE: HSL Mesh server defintion macro issue

parksj10 — Tue, 30 Jan 2024 07:29:52 GMT

Please see the original post, this is not possible. I need to add the HSL server as well. The HSL server takes the lightness server as an argument. I cannot define them both in the led_ctx variable

RE: HSL Mesh server defintion macro issue

Susheel Nuguru — Tue, 30 Jan 2024 06:28:54 GMT

Right, I do not know why I did not see this at the first glance but the compiler says it clearly that you are not using the constant in the initializer for .lightness. Instead do it like this

#if DT_NODE_EXISTS(DT_ALIAS(led0))
	{
     .lightness = BT_MESH_LIGHTNESS_SRV_INIT(&lightness_srv_handlers),
	},
#endif
#if DT_NODE_EXISTS(DT_ALIAS(led1))
    {
     .lightness = BT_MESH_LIGHTNESS_SRV_INIT(&lightness_srv_handlers),
	 },
#endif
};

No need to have additional static variables lightness_srv_0 and lightness_srv_1

RE: HSL Mesh server defintion macro issue

parksj10 — Mon, 29 Jan 2024 20:12:31 GMT

That is indeed a typo, but it isn’t the root problem. If I fix that the base problem still exists.

RE: HSL Mesh server defintion macro issue

Susheel Nuguru — Mon, 29 Jan 2024 11:18:51 GMT

I think it is a copy paste issue in your code. You have not created an instance for øightness_srv_1 since you have this below checking for node exists for led0 twice

#if DT_NODE_EXISTS(DT_ALIAS(led0))
	static struct bt_mesh_lightness_srv lightness_srv_0 = BT_MESH_LIGHTNESS_SRV_INIT(&lightness_handlers);
#endif
#if DT_NODE_EXISTS(DT_ALIAS(led0))
	static struct bt_mesh_lightness_srv lightness_srv_1 = BT_MESH_LIGHTNESS_SRV_INIT(&lightness_handlers);
#endif

You need to change it to

#if DT_NODE_EXISTS(DT_ALIAS(led0))
	static struct bt_mesh_lightness_srv lightness_srv_0 = BT_MESH_LIGHTNESS_SRV_INIT(&lightness_handlers);
#endif
#if DT_NODE_EXISTS(DT_ALIAS(led1))
	static struct bt_mesh_lightness_srv lightness_srv_1 = BT_MESH_LIGHTNESS_SRV_INIT(&lightness_handlers);
#endif