Issues with CONFIG settings not being enabled in NCS V2.6.0

RE: Issues with CONFIG settings not being enabled in NCS V2.6.0

Vidar Berg — Thu, 11 Apr 2024 04:44:40 GMT

Excellent - glad to hear that it fixed it.

[quote user="Mike Austin (LPI)"]I probably need to learn how to trawl through Zephyr and NCS commits to keep abreast of changes with each new release as I'd then be able to pre-empt a few of these issues next time I need to upgrade my SDK[/quote]

I often use the search function in VS Code. For instance, I found usage examples of the sys_poweroff() function by searching for it across the *.c files in the SDK tree.

I also use the GitLens extension to help find relevant commits.

Best regards,

Vidar

RE: Issues with CONFIG settings not being enabled in NCS V2.6.0

Mike Austin (LPI) — Wed, 10 Apr 2024 22:07:05 GMT

Fantatic - that's fixed my SYS_INIT issues.

I probably need to learn how to trawl through Zephyr and NCS commits to keep abreast of changes with each new release as I'd then be able to pre-empt a few of these issues next time I need to upgrade my SDK

Thanks for your help Vidar

RE: Issues with CONFIG settings not being enabled in NCS V2.6.0

Vidar Berg — Wed, 10 Apr 2024 12:36:30 GMT

Hi Mike,

Changing the function to declaration to 'static int detect_wakeup_latch(void)' and removing the ARG_UNUSED(dev); line should remove the warning.

Relevant commit:

https://github.com/nrfconnect/sdk-zephyr/commit/a5fd0d184a15d0af52599e0f5f5af880f353c6d4

Regards,

Vidar

RE: Issues with CONFIG settings not being enabled in NCS V2.6.0

Mike Austin (LPI) — Wed, 10 Apr 2024 12:21:49 GMT

Hi Vidar,

OK, that #include <zephyr/sys/poweroff.h> was what I needed! That seems to have sorted out the error around the sys_poweroff().

Those SYS_INIT() calls haven't changed from the version that built OK under NCS V2.2.0. This is what I have setup:

/* Grabs contents of RESETREAS and LATCH registers  */
static int detect_wakeup_latch(const struct device *dev)
{
	ARG_UNUSED(dev);

	/* Check status of RESETREAS register to determine what caused exit from System OFF */
	/* 0x0001 = Reset pin 
	 * 0x0002 = Watchdog
	 * 0x0004 = Software
	 * 0x0008 = CPU Lockup
	 * 0x10000 = Wakeup from System Off via DETECT from GPIO
	 * 0x20000 = Wakeup from System Off via ANADETECT from LPCOMP
	 * 0x40000 = Wakeup from System Off via Debug mode
	 * 0x80000 = Wakeup from System Off via NFC
	*/
	reset_reason = NRF_POWER->RESETREAS;
	(void)NRF_TIMER0->EVENTS_COMPARE[0];

	/* Record status of LATCH register to check with GPIO triggered exit from System OFF (if applicable) */
	gpio_trigger = NRF_GPIO->LATCH;
	
	/* Disable inputs from affecting the DETECT signal, which should preserve LATCH and prevent spurious interrupts */
	gpio_pin_trig_disable();

	return (0);
}

/* Prevent deep sleep (system off) from being entered on long timeouts
 * or `K_FOREVER` due to the default residency policy.
 *
 * This has to be done before anything tries to sleep, which means
 * before the threading system starts up between PRE_KERNEL_2 and
 * POST_KERNEL.  Do it at the start of PRE_KERNEL_2.
 */
static int disable_ds_1(const struct device *dev)
{
	ARG_UNUSED(dev);

	pm_policy_state_lock_get(PM_STATE_SOFT_OFF,PM_ALL_SUBSTATES);

	return 0;
}

SYS_INIT(detect_wakeup_latch, PRE_KERNEL_2, 0);
SYS_INIT(disable_ds_1, PRE_KERNEL_1, 0);

What I'm trying to do is grab details of which GPIO has triggered the device out of SYSTEM_OFF. The disable_ds_1() function is something I think I blindly copied from somewhere when I was getting the SYSTEM_OFF stuff working 12 months or so ago.

Regards,

Mike

RE: Issues with CONFIG settings not being enabled in NCS V2.6.0

Vidar Berg — Wed, 10 Apr 2024 11:45:18 GMT

Hello,

I'm sorry to hear you have had this many challenges with the migration. Support for the PM subsystem was removed in SDK v2.5.0. The reasoning for this change was given in the commit message here: https://github.com/nrfconnect/sdk-zephyr/commit/96b38273138f05dd06cf7a58fa361f401e773e5e. Unfortunately, this change was not mentioned in the release notes or migration documentation.

[quote user=""]So, that looks like rather than needing to have CONFIG_PM=y in my proj.conf, I need to have CONFIG_POWEROFF=y. And then, rather than call pm_state_force(), I have to call sys_poweroff().[/quote]

In addition to enabling CONFIG_POWEROFF, did you include the poweroff.h header (#include <zephyr/sys/poweroff.h>) in the source file that calls the function?

[quote user=""]I'm also getting a bunch of build warnings around including the <zephyr/init.h> header file that I can't make sense o[/quote]

The warnings seems to stem from your SYS_INIT() calls, indicating that the initialization functions are not declared with the expected type. Or is detect_wakeup_latch() declared like this: static int detect_wakeup_latch(void)?

Best regards,

Vidar