RE: Trying to implement longpress function for keypad, but don't know what to set in the device tree for input-device

never — Fri, 20 Sep 2024 13:15:11 GMT

RocketMan You should pass a different phandle (buttons) to the longpress device to be as an input reference (input = <&buttons>). So your device tree will look like this:

	buttons: buttons {
		 compatible = "gpio-keys";
		 btntopleft: button_0 {
			gpios = <&gpio0 23 (GPIO_PULL_UP | GPIO_ACTIVE_LOW)>;
			label = "BTN_TOP_LEFT";
			zephyr,code = <INPUT_KEY_0>;
		 };		 
		btntopmid: button_1 {
			gpios = <&gpio1 5 (GPIO_PULL_UP | GPIO_ACTIVE_LOW)>;			
			label = "BTN_TOP_MIDDLE";
			zephyr,code = <INPUT_KEY_1>;
		};		 
		btntopright: button_2 {
			gpios = <&gpio1 7 (GPIO_PULL_UP | GPIO_ACTIVE_LOW)>;				
			label = "BTN_TOP_RIGHT";
			zephyr,code = <INPUT_KEY_2>;
		};
		btnleft: button_3 {
			gpios = <&gpio1 9 (GPIO_PULL_UP | GPIO_ACTIVE_LOW)>;			
			label = "BTN_LEFT";
			zephyr,code = <INPUT_KEY_3>;
		};	
		btndpadleft: button_4 {
			gpios = <&gpio0 24 (GPIO_PULL_UP | GPIO_ACTIVE_LOW)>;
			label = "BTN_DPAD_LEFT";
			zephyr,code = <INPUT_KEY_4>;
		};			 
		btndpadtop: button_5 {
			gpios = <&gpio0 25 (GPIO_PULL_UP | GPIO_ACTIVE_LOW)>;
			label = "BTN_DPAD_TOP";
			zephyr,code = <INPUT_KEY_5>;
		 };
		btndpadright: button_6 {
		   	gpios = <&gpio0 26 (GPIO_PULL_UP | GPIO_ACTIVE_LOW)>;
		   	label = "BTN_DPAD_RIGHT";	
			   zephyr,code = <INPUT_KEY_6>;	
		}; 		 
		 btndpadbot: button_7 {
			gpios = <&gpio0 28 (GPIO_PULL_UP | GPIO_ACTIVE_LOW)>;
			label = "BTN_DPAD_BOTTOM";
			zephyr,code = <INPUT_KEY_7>;
		 };
		 btnright: button_8 {
			gpios = <&gpio0 27 (GPIO_PULL_UP | GPIO_ACTIVE_LOW)>;
			label = "BTN_RIGHT";
			zephyr,code = <INPUT_KEY_8>;
		};
		 btnbot: button_9 {
//			gpios = <&gpio0 29 (GPIO_PULL_UP | GPIO_ACTIVE_LOW)>;
			gpios = <&gpio1 10 (GPIO_PULL_UP | GPIO_ACTIVE_LOW)>;		// trigger for testing 
			label = "BTN_BOTTOM";
			zephyr,code = <INPUT_KEY_9>;
		};
	};
	
    // No need for kp_input_device

	longpress: longpress {
		input = <&buttons>;
		compatible = "zephyr,input-longpress";
        input-codes = <INPUT_KEY_0>,<INPUT_KEY_1>,<INPUT_KEY_2>,<INPUT_KEY_3>,<INPUT_KEY_4>,<INPUT_KEY_5>,<INPUT_KEY_6>,<INPUT_KEY_7>,<INPUT_KEY_8>, <INPUT_KEY_9>;
        short-codes = <INPUT_KEY_A>,<INPUT_KEY_B>,<INPUT_KEY_C>,<INPUT_KEY_D>,<INPUT_KEY_E>,<INPUT_KEY_F>,<INPUT_KEY_G>,<INPUT_KEY_H>,<INPUT_KEY_I>, <INPUT_KEY_J>;  
		long-codes  = <INPUT_KEY_K>,<INPUT_KEY_L>,<INPUT_KEY_M>,<INPUT_KEY_N>,<INPUT_KEY_O>,<INPUT_KEY_P>,<INPUT_KEY_Q>,<INPUT_KEY_R>,<INPUT_KEY_S>, <INPUT_KEY_T>;
        long-delay-ms = <1000>;
    };

In your source code you don't need lines

static const struct device *const kp_dev = DEVICE_DT_GET(
    DT_NODELABEL(kp_input_device));

and

DEVICE_DT_DEFINE(DT_INST(0, vnd_input_device), NULL, NULL, NULL, NULL,
		 PRE_KERNEL_1, CONFIG_KERNEL_INIT_PRIORITY_DEVICE, NULL);

since your keypad device is actually buttons and they've already been instantiated by Zephyr.

Thanks!

RE: Trying to implement longpress function for keypad, but don't know what to set in the device tree for input-device

RocketMan — Fri, 12 Apr 2024 15:33:50 GMT

thanks Siguard. That is working, but I was trying to use the longpress feature in the devicetree (using CONFIG_INPUT=y). I thought that would be an easier way. The other question using the longpress feature, if it would work to detect two buttons pressed together. I'll stay with your solution unless I hear otherwise.

RE: Trying to implement longpress function for keypad, but don't know what to set in the device tree for input-device

Sigurd Hellesvik — Fri, 12 Apr 2024 08:50:17 GMT

Hi,

Have a look at this sample:

https://github.com/martelmy/NCS_examples/tree/main/peripherals/long_press_button

does that help?

Regards,
Sigurd Hellesvik

RE: Trying to implement longpress function for keypad, but don't know what to set in the device tree for input-device

RocketMan — Fri, 12 Apr 2024 02:59:03 GMT

here's the code where I get the keys from the device tree in case I'm missing something...

static const struct gpio_dt_spec key_topleft = GPIO_DT_SPEC_GET(DT_NODELABEL(btntopleft), gpios);

gpio_pin_configure_dt(&key_topleft, GPIO_INPUT);