RE: nRF5340: FCB(Flash Circular Buffer) on external flash

chris22222 — Tue, 01 Apr 2025 22:40:20 GMT

I came to the same conclusion as your solution but technically this is incorrect. I am working on a bug report and PR to file with zephyr. The issue is with this snippet:

	for (int i = 0; i < FCB_SECTOR_COUNT; i++) {
		fcb_instance_sectors[i].fs_off = i * SPI_FLASH_SECTOR_SIZE;
		fcb_instance_sectors[i].fs_size = SPI_FLASH_SECTOR_SIZE;
	}

flash_sector->fs_off is defined as an absolute address relative to the beginning of the flash device:

struct flash_sector {
	/** Sector offset from the beginning of the flash device */
	off_t fs_off;
	/** Sector size in bytes */
	size_t fs_size;
};

However fcb uses flash_area read and write accesses when interacting with the flash. This means that it uses relative addressing, not absolute.

If you define your flash_area with a partition boundary starting at 0x0000, the issue will not manifest. However, if the partition is started at any other address like 0x5000, using fs_offset as defined will pass an absolute address into flash_area_read and flash_area_write. fcb_init will fail to initialize because the flash_area_read of the fcb header will be out of bounds.

The way to get around this is the improperly us flash_sector->fs_off with relative addressing as we both have done.

I spent about half a day figuring this out, but I was particularly stuck with fcb_init since my partition was located in the last 8 sectors of flash.

RE: nRF5340: FCB(Flash Circular Buffer) on external flash

Yanpengwu — Wed, 29 May 2024 08:23:24 GMT

Hi Amanda, any update on this?

RE: nRF5340: FCB(Flash Circular Buffer) on external flash

Yanpengwu — Wed, 24 Apr 2024 16:05:22 GMT

Update: Currently I can init FCB and append logs successfully, but can't read the correct log entries from the flash.
Could you help me have a look at my code? Thank you very much.

FCB Init:

#define SPI_FLASH_SECTOR_SIZE        		4096
#define FCB_VERSION							1
#define FCB_SECTOR_COUNT					511
#define FCB_SCRATCH_SECTOR_COUNT			11

// FCB sectors array, need to be inited per sector
static struct flash_sector fcb_instance_sectors[FCB_SECTOR_COUNT];

int fcb_init_instance()
{
	struct fcb *fcb = &fcb_instance;
	const struct flash_area *log_fa = NULL;
	const struct flash_parameters *flash_params = NULL;
	int rc;

	memset(fcb, 0, sizeof(*fcb));
	
	// Init the array of fcb_instance_sectors, need to init it per sector
	memset(fcb_instance_sectors, 0, sizeof(fcb_instance_sectors));
	for (int i = 0; i < FCB_SECTOR_COUNT; i++) {
		fcb_instance_sectors[i].fs_off = i * SPI_FLASH_SECTOR_SIZE;
		fcb_instance_sectors[i].fs_size = SPI_FLASH_SECTOR_SIZE;
	}

	// 1. Open flash area log_data_parti
    rc = flash_area_open(FLASH_AREA_ID(log_data_parti), &log_fa);
    if (rc) {
        LOG_ERR("[fcb_init_instance] Failed to open log partition: %d", rc);
        return -ENODEV;
    }

	flash_params = flash_get_parameters(log_fa->fa_dev);
	if (!flash_params) {
		LOG_ERR("[fcb_init_instance] Failed to get flash parameters\n");
		return -ENODEV;
	}

	//2. Must erase the fcb->f_sectors before fcb_init, otherwise the f_magic checking will be failed!
	rc = flash_area_erase(log_fa, 0, log_fa->fa_size);
	if (rc != 0) {
		LOG_ERR("[fcb_init_instance] Failed to erase Flash area, error %d", rc);
		flash_area_close(log_fa);
		return rc;
	} 

	// 3. int FCB instance on log_data_parti
	fcb->f_magic = 0x1a1a1a1a;
    fcb->f_version = FCB_VERSION;
    fcb->f_sector_cnt = FCB_SECTOR_COUNT; 
	fcb->f_scratch_cnt = FCB_SCRATCH_SECTOR_COUNT;
    fcb->f_sectors = fcb_instance_sectors;
	fcb->f_align = flash_params->write_block_size;

    rc = fcb_init(log_fa->fa_id, fcb);
    if (rc) {
        LOG_ERR("[fcb_init_instance] FCB init failed with error %d", rc);
        return rc;
    } else {
		LOG_WRN("[fcb_init_instance] FCB init OK! %d", rc);
	}

	flash_area_close(log_fa);

	return 0;
}

Append entry to FCB:

int fcb_append_log_entry(T_log_entry* log_data, size_t len)
{
    struct fcb_entry entry_descriptor;
    int rc;

	memset(&entry_descriptor, 0, sizeof(struct fcb_entry));
	rc = fcb_append(&fcb_instance, len, &entry_descriptor);
    if (rc) {
		// Do rotation in case of reaching the end of partition
		if (rc == -ENOSPC) {
            LOG_ERR("[fcb_append_log_entry] No space left, rotating FCB and try again");
            rc = fcb_rotate(&fcb_instance);
            if (rc) {
                LOG_ERR("[fcb_append_log_entry] FCB rotate failed with error %d", rc);
                return rc;
            }

            // Retry to append
            rc = fcb_append(&fcb_instance, len, &entry_descriptor);
            if (rc) {
                LOG_ERR("[fcb_append_log_entry] FCB append retry failed after rotate, error %d", rc);
                return rc;
            }
        } else {
			LOG_ERR("[fcb_append_log_entry] Failed to append data: %d", rc);
            return rc;
        }
    }

    rc = flash_area_write(fcb_instance.fap, entry_descriptor.fe_data_off, log_data, len);
    if (rc) {
        LOG_ERR("[fcb_append_log_entry] Failed to write to FCB: %d", rc);
        fcb_append_finish(&fcb_instance, &entry_descriptor);
        return rc;
    }	

	rc = fcb_append_finish(&fcb_instance, &entry_descriptor);
	if (rc) {
        LOG_ERR("[fcb_append_log_entry] FCB append finish failed with error %d", rc);
        return rc;
    }

	return 0;	
}

Read and print entries from a sector:

void fcb_print_Sector(uint16_t sector_no)
{
	struct fcb_entry entry_desc, first_entry_desc;
	T_log_entry log_data;
	int rc;

    memset(&entry_desc, 0, sizeof(entry_desc));
	entry_desc.fe_sector = &fcb_instance_sectors[sector_no];
	// Start with the first entry in this sector
    rc = fcb_getnext(&fcb_instance, &entry_desc);
	memcpy(&first_entry_desc, &entry_desc, sizeof(struct fcb_entry));

    while(rc == 0) {
		if(entry_desc.fe_sector == first_entry_desc.fe_sector){
			rc = flash_area_read(fcb_instance.fap, entry_desc.fe_data_off, &log_data, entry_desc.fe_data_len);
			if (rc) {
				LOG_ERR("[fcb_print_Sector] Failed to read entry with error %d", rc);
				continue;
			} else{
				LOG_INF("[fcb_print_Sector] type=%d, value=%4.6f, timestamp=%08u", 
								log_data.type, log_data.value, log_data.timestamp);
			}

			// Get the next entry
			rc = fcb_getnext(&fcb_instance, &entry_desc);
		} else {
			break;
		}
    } 	
}

RE: nRF5340: FCB(Flash Circular Buffer) on external flash

Amanda Hsieh — Tue, 23 Apr 2024 19:14:46 GMT

Hi,

I am looking into your case and will reply when I collect enough information.

Regards,
Amanda H.