UART tx using thingy91

RE: UART tx using thingy91

ovrebekk — Mon, 10 Jun 2024 10:57:44 GMT

Hi Youssef

Great to hear you were able to get it working!

I will close the case then, unless you have more questions.

Best regards
Torbjørn

RE: UART tx using thingy91

Youssef Elbattah — Fri, 07 Jun 2024 15:52:46 GMT

Hello Torbjørn,

I wanted to let you know that I have switched to async mode with UART1. Based on the sample provided in this GitHub repository, I managed to fix the issue.

Best regards,

Youssef

RE: UART tx using thingy91

ovrebekk — Thu, 06 Jun 2024 09:27:04 GMT

Hi Youssef

Could you test this with MCUboot disabled?

CONFIG_BOOTLOADER_MCUBOOT=n

Having MCUboot enabled can some times cause issues for UART applications, and it would be good to know if this is the case here.

Best regards
Torbjørn

RE: UART tx using thingy91

Youssef Elbattah — Fri, 31 May 2024 11:33:06 GMT

Hi Torbjørn,

Following your suggestion, I tried using UART1 in async mode for communication between the nRF52 and nRF91. However, I encountered some issues:

On the nRF52 side, whenever I send data, the callback jumps to the UART_TX_ABORT case instead of UART_TX_DONE.
On the nRF91 side, when I send data over UART1, the callback correctly calls UART_TX_DONE, but nothing is received on the nRF52.

Best regards

Youssef

RE: UART tx using thingy91

Youssef Elbattah — Fri, 31 May 2024 11:11:58 GMT

Hi Torbjørn,

I have already set CONFIG_UART_INTERRUPT_DRIVEN and CONFIG_NRF_SW_LPUART_INT_DRIVEN but the same issue,

the first image shows that the lpuart sends 8 bytes as expected for the first try, but then it sends only 0 as shown in the second image

I have tried to use uart1 and uart 0 with async but it doesn't work, does lpuart supports async mode ?

Best regards

Youssef

RE: UART tx using thingy91

ovrebekk — Fri, 31 May 2024 11:01:34 GMT

Hi Youssef

I believe you need CONFIG_UART_INTERRUPT_DRIVEN and CONFIG_NRF_SW_LPUART_INT_DRIVEN enabled if you want to use these functions.

In many cases I think the ASYNC interface is more convenient. Have you tried to use this instead?

Best regards
Torbjørn

RE: UART tx using thingy91

Youssef Elbattah — Thu, 30 May 2024 09:36:02 GMT

Now, when i have activated uart0, so status = "okay" there's no error, but when i tried to send data over lpuart, the function uart_irq_handler returns 5 for the first time then it returns 0 bytes.

here's my callback :

static void uart_irq_handler(const struct device *dev, void *context)
{
    uint8_t buf[] = {1, 2, 3, 4, 5};
    printk("uart_irq_handler\n");
    if (uart_irq_tx_ready(dev)) {
        int ret = uart_fifo_fill(dev, buf, sizeof(buf));
        printk("fill %d bytes\n", ret);
        uart_irq_tx_disable(dev);
    }

    if (uart_irq_rx_ready(dev)) {
        uint8_t buf[10];
        int len = uart_fifo_read(dev, buf, sizeof(buf));

        if (len) {
            printk("read %d bytes\n", len);
        }else{
            printk("no data %d bytes\n",len);
        }
    }
}

it returns : fill 5 bytes , then fill 0 bytes

Best regards,

Youssef

RE: UART tx using thingy91

Youssef Elbattah — Thu, 30 May 2024 09:06:43 GMT

Hi Torbjørn,

I have disabled the UART console, but I am still encountering the same issue.

Here is my prj.conf file:

CONFIG_GPIO=y
CONFIG_SERIAL=y
#CONFIG_UART_INTERRUPT_DRIVEN=y
CONFIG_LOG=y
CONFIG_COREDUMP_DEVICE=y
CONFIG_DEBUG_COREDUMP=y
CONFIG_DEBUG_COREDUMP_BACKEND_LOGGING=y
CONFIG_FPU=y
CONFIG_UART_CONSOLE=n

i tried also to disable CONFIG_SERIAL but the same problem.

Best regards

Youssef

RE: UART tx using thingy91

ovrebekk — Thu, 30 May 2024 08:22:10 GMT

Hi Youssef

It seems the issue is that you still have the UART console library enabled, even though you have disabled uart0 and removed the uart console chosen definition.

Could you try to disable the UART console by adding the following to your project configuration?

CONFIG_UART_CONSOLE=n

Best regards
Torbjørn

RE: UART tx using thingy91

Youssef Elbattah — Wed, 29 May 2024 16:03:12 GMT

Hi Torbjørn,

When I tried using LPUART with the Thingy91_nrf9160ns, I encountered a build error. The error message is as follows:

C:/ncs/v2.5.0/deps/zephyr/include/zephyr/device.h:85:41: error: '__device_dts_ord_96' undeclared here (not in a function); did you mean '__device_dts_ord_16'?
   85 | #define DEVICE_NAME_GET(dev_id) _CONCAT(__device_, dev_id)
      |                                         ^~~~~~~~~
C:/ncs/v2.5.0/deps/zephyr/include/zephyr/toolchain/common.h:132:26: note: in definition of macro '_DO_CONCAT'
132 | #define _DO_CONCAT(x, y) x ## y
      |                          ^
C:/ncs/v2.5.0/deps/zephyr/include/zephyr/device.h:85:33: note: in expansion of macro '_CONCAT'
   85 | #define DEVICE_NAME_GET(dev_id) _CONCAT(__device_, dev_id)
      |                                 ^~~~~~~
C:/ncs/v2.5.0/deps/zephyr/include/zephyr/device.h:211:37: note: in expansion of macro 'DEVICE_NAME_GET'
211 | #define DEVICE_DT_NAME_GET(node_id) DEVICE_NAME_GET(Z_DEVICE_DT_DEV_ID(node_id))
      |                                     ^~~~~~~~~~~~~~~
C:/ncs/v2.5.0/deps/zephyr/include/zephyr/device.h:228:34: note: in expansion of macro 'DEVICE_DT_NAME_GET'
228 | #define DEVICE_DT_GET(node_id) (&DEVICE_DT_NAME_GET(node_id))
      |                                  ^~~~~~~~~~~~~~~~~~
C:/ncs/v2.5.0/deps/zephyr/drivers/console/uart_console.c:40:9: note: in expansion of macro 'DEVICE_DT_GET'
   40 |         DEVICE_DT_GET(DT_CHOSEN(zephyr_console))

here is my thingy91_nrf9160ns.overlay file :

/ {
    chosen {
        zephyr,bt-c2h-uart=&lpuart;
    };
};

&uart1 {

    status = "okay";

    current-speed = <115200>;

    pinctrl-0 = <&uart1_default_alt>;

    pinctrl-1 = <&uart1_sleep_alt>;

    pinctrl-names = "default", "sleep";

    lpuart: nrf-sw-lpuart {

        compatible = "nordic,nrf-sw-lpuart";

        status = "okay";

        label = "LPUART";

        req-pin = <24>;

        rdy-pin = <25>;

    };

};

&uart0 {

    status = "disabled";

};

&gpio0 {

    status = "okay";

};

&gpiote {

    interrupts = <49 NRF_DEFAULT_IRQ_PRIORITY>;

};

&pinctrl {

    uart1_default_alt: uart1_default_alt {

        group1 {

            psels = <NRF_PSEL(UART_RX, 0, 23)>,

                <NRF_PSEL(UART_TX, 0, 22)>,

                <NRF_PSEL(UART_CTS, 0, 13)>,

                <NRF_PSEL(UART_RTS, 0, 14)>;

        };

    };

    uart1_sleep_alt: uart1_sleep_alt {

        group1 {
            psels = <NRF_PSEL(UART_RX, 0, 23)>,
                <NRF_PSEL(UART_TX, 0, 22)>,
                <NRF_PSEL(UART_CTS, 0, 13)>,
                <NRF_PSEL(UART_RTS, 0, 14)>;
            low-power-enable;

        };

    };

};

main.c file (which is based on lpuart sample):

#include <zephyr/kernel.h>
#include <zephyr/device.h>
#include <zephyr/devicetree.h>
#include <zephyr/logging/log.h>
#include <zephyr/drivers/uart.h>

LOG_MODULE_REGISTER(app);

#define BUF_SIZE 64
static K_MEM_SLAB_DEFINE(uart_slab, BUF_SIZE, 3, 4);

static void uart_irq_handler(const struct device *dev, void *context)
{
    uint8_t buf[] = {1, 2, 3, 4, 5};

    if (uart_irq_tx_ready(dev)) {
        (void)uart_fifo_fill(dev, buf, sizeof(buf));
        uart_irq_tx_disable(dev);
    }

    if (uart_irq_rx_ready(dev)) {
        uint8_t buf[10];
        int len = uart_fifo_read(dev, buf, sizeof(buf));

        if (len) {
            printk("read %d bytes\n", len);
        }
    }
}

static void interrupt_driven(const struct device *dev)
{
    uint8_t c = 0xff;

    uart_irq_callback_set(dev, uart_irq_handler);
    uart_irq_rx_enable(dev);
    while (1) {
        uart_irq_tx_enable(dev);
        k_sleep(K_MSEC(500));

        uart_poll_out(dev, c);
        k_sleep(K_MSEC(100));
    }
}

static void uart_callback(const struct device *dev,
              struct uart_event *evt,
              void *user_data)
{
    struct device *uart = user_data;
    int err;

    switch (evt->type) {
    case UART_TX_DONE:
        LOG_INF("Tx sent %d bytes", evt->data.tx.len);
        break;

    case UART_TX_ABORTED:
        LOG_ERR("Tx aborted");
        break;

    case UART_RX_RDY:
        LOG_INF("Received data %d bytes", evt->data.rx.len);
        break;

    case UART_RX_BUF_REQUEST:
    {
        uint8_t *buf;

        err = k_mem_slab_alloc(&uart_slab, (void **)&buf, K_NO_WAIT);
        __ASSERT(err == 0, "Failed to allocate slab");

        err = uart_rx_buf_rsp(uart, buf, BUF_SIZE);
        __ASSERT(err == 0, "Failed to provide new buffer");
        break;
    }

    case UART_RX_BUF_RELEASED:
        k_mem_slab_free(&uart_slab, (void *)evt->data.rx_buf.buf);
        break;

    case UART_RX_DISABLED:
        break;

    case UART_RX_STOPPED:
        break;
    }
}

static void async(const struct device *lpuart)
{
    uint8_t txbuf[5] = {1, 2, 3, 4, 5};
    int err;
    uint8_t *buf;

    err = k_mem_slab_alloc(&uart_slab, (void **)&buf, K_NO_WAIT);
    __ASSERT(err == 0, "Failed to alloc slab");

    err = uart_callback_set(lpuart, uart_callback, (void *)lpuart);
    __ASSERT(err == 0, "Failed to set callback");

    err = uart_rx_enable(lpuart, buf, BUF_SIZE, 10000);
    __ASSERT(err == 0, "Failed to enable RX");

    while (1) {
        err = uart_tx(lpuart, txbuf, sizeof(txbuf), 10000);
        __ASSERT(err == 0, "Failed to initiate transmission");

        k_sleep(K_MSEC(500));

        uart_poll_out(lpuart, txbuf[0]);
        k_sleep(K_MSEC(100));
    }
}

int main(void)
{
    const struct device *lpuart = DEVICE_DT_GET(DT_NODELABEL(lpuart));

    __ASSERT(device_is_ready(lpuart), "LPUART device not ready");

    if (IS_ENABLED(CONFIG_NRF_SW_LPUART_INT_DRIVEN)) {
        interrupt_driven(lpuart);
    } else {
        async(lpuart);
    }

    return 0;
}

and my thingy91_nrf9160ns.conf file :

CONFIG_NRF_SW_LPUART=y
CONFIG_NRF_SW_LPUART_INT_DRIVEN=y

CONFIG_UART_1_ASYNC=y
CONFIG_UART_1_INTERRUPT_DRIVEN=n
CONFIG_UART_1_NRF_HW_ASYNC=y
CONFIG_UART_1_NRF_HW_ASYNC_TIMER=2

Best Regards

Youssef

RE: UART tx using thingy91

Youssef Elbattah — Wed, 29 May 2024 13:26:39 GMT

Hi Torbjørn,

Currently, I'm using UART0 for both devices. Should I switch to using LPUART for both devices? If so, what mode should I use for lpuart driver?

Best regards

Youssef

RE: UART tx using thingy91

ovrebekk — Wed, 29 May 2024 12:15:16 GMT

Hi Youssef

Have you considered using the LPUART driver instead, since you are establishing communication between two Nordic devices?

This driver is optimized for lower power consumption, and should be easier to interface than accessing the serial drivers directly.

Best regards
Torbjørn

RE: UART tx using thingy91

Youssef Elbattah — Wed, 29 May 2024 09:18:04 GMT

Update

I've modified the callback function. After enabling the transmission and attempting to send 8 bytes, the uart_fill_fifo function correctly returns 8 bytes. However, when I check if the transfer is complete using the uart_irq_tx_complete function, it does not return 1 as expected.

if (!(uart_irq_rx_ready(uart_dev) || uart_irq_tx_ready(uart_dev)))
    {
        LOG_DBG("spurious interrupt");
    }
    if (uart_irq_tx_ready(uart_dev))
    {
        int tx_sent = uart_fifo_fill(uart_dev, (uint8_t *)tx_buf, tx_data_length);
        printf("tx_sent: %u\n", tx_sent);
        printf("Data to be sent length = %u\n",tx_data_length);
        if (tx_sent <= 0)
        {
            printf("Error %d sending data over UART1 bus\n", tx_sent);
            return;
        }

        while (uart_irq_tx_complete(uart_dev) != 1)
        {
            printf("Wait for UART0 data transmition complete\n");
        }
        printf("UART0 data transmitted\n");
        uart_irq_tx_disable(uart_dev);
        k_sem_give(&tx_sem);
    }