Setting Extra CMake Arguments only applies to initial build

RE: Setting Extra CMake Arguments only applies to initial build

Hieu — Thu, 11 Jul 2024 18:31:58 GMT

Hi Sergii_K,

The issue where additional flags are lost after editing build configuration is a known limitation of nRF Connect for VS Code. It is being worked on.

I don't remember issue with pristine build though, but it is likely related.

My apologies for the inconvenience.

Hieu

RE: Setting Extra CMake Arguments only applies to initial build

Sergii_K — Thu, 11 Jul 2024 14:46:39 GMT

Hello Hieu ,
but, is another way to give compiler flag for a specific build exists?

For example, we need to have two build configurations for single application,
with second configuration CMake compiler flag added

-DCMAKE_C_FLAGS="-DUSE_PIPE2"

The flag works well for the initial build, but lost when I open "edit build configuration" or run pristine build.

Is it true impossible to use conditional compilation specific to selected build, with nRF Connect extension?

RE: Setting Extra CMake Arguments only applies to initial build

Hieu — Tue, 18 Jun 2024 13:40:21 GMT

Hi jrhaws,

I wonder if the JLINK_FLASH_BUILD trick you are using is working in the first place, rather than that it doesn't work only on the second image.

I tested by adding some print() in imgtool.py files as followed:

// imgtool main.py

def sign(key, public_key_format, align, version, pad_sig, header_size,
         pad_header, slot_size, pad, confirm, max_sectors, overwrite_only,
         endian, encrypt_keylen, encrypt, infile, outfile, dependencies,
         load_addr, hex_addr, erased_val, save_enctlv, security_counter,
         boot_record, custom_tlv, rom_fixed, max_align, clear, fix_sig,
         fix_sig_pubkey, sig_out, vector_to_sign):

    
    print("hieu imgtool main.py test point 1")
    if confirm:
        # Confirmed but non-padded images don't make much sense, because
        # otherwise there's no trailer area for writing the confirmed status.
        print("hieu imgtool main.py test point 2")
        pad = True

// image.py, just to be sure I am tweaking the correct imgtool copy
                if hasattr(key, 'sign'):
                    print(os.path.basename(__file__) + ": sign the payload hivo2")
                    sig = key.sign(bytes(self.payload))

And here is the log I got. It seems the confirm flag was not set for any of the images.

[28/33] Generating ../../zephyr/app_signed.hex
hieu imgtool main.py test point 1
image.py: sign the payload hieu2
[29/33] Generating ../../zephyr/app_update.bin
hieu imgtool main.py test point 1
image.py: sign the payload hieu2
[31/33] Generating ../../zephyr/app_test_update.hex
hieu imgtool main.py test point 1
image.py: sign the payload hieu2
[33/33] Generating zephyr/merged.hex

I wonder if the IMGTOOL_ARGS line in your CMakeLists.txt works at all. Perhaps the primary slot image is just confirmed by default, not thanks to your change.

Did you find somewhere the reference that arguments can be added to this IMGTOOL_ARGS list?

RE: Setting Extra CMake Arguments only applies to initial build

Hieu — Wed, 12 Jun 2024 13:23:16 GMT

I understand now. I will have to investigate this and come back later.

RE: Setting Extra CMake Arguments only applies to initial build

jrhaws — Tue, 11 Jun 2024 20:20:33 GMT

In our CI system we run a build with this command:

nrfutil toolchain-manager launch -- west build -b pru_001697 --build-dir _bld . -DJLINK_FLASH_BUILD=TRUE

This causes the primary image to be confirmed, but the secondary to not be. I would expect that if I set the JLINK_FLASH_BUILD flag to true, it will apply to BOTH images.

If I set JLINK_FLASH_BUILD to true inside the CMakeLists.txt file, then both images ARE confirmed properly.

RE: Setting Extra CMake Arguments only applies to initial build

Hieu — Tue, 11 Jun 2024 20:16:19 GMT

Hi jrhaws,

The nRF Connect Extension for VS Code issue with using build configuration, extra CMake arguments, and multi-image build is unfortunately a known issue that our team hasn't been able to resolve due to some complications in the build system.

Our apologies for the inconvenience.

[quote user=""]In addition, if I run a build from the command line, the same issue shows up. The secondary image is NOT confirmed, when it is expected to be so.[/quote]

Regarding this point, however. Is this from the first time building with the command line? Or from the second time? Could you please give me some detailed steps to reproduce this observation?

Hieu