Can you use the heap in custom secure partitions in TFM?

RE: Can you use the heap in custom secure partitions in TFM?

Sigurd Hellesvik — Wed, 19 Jun 2024 13:37:20 GMT

[quote user="gdl"]It does print out the #warning "AAAAAAAAAAA" when changing the following file, so maybe thats the right [/quote]

Then, I guess this is the file that is being defaulted to if no other file is used.

As you probably see that this is a bit of new territory for us as well.
But know that our TF-M devs are getting info from this ticket, so we will hopefully get a better way to do this stuff at a later point in time.

RE: Can you use the heap in custom secure partitions in TFM?

gdl — Wed, 19 Jun 2024 12:42:02 GMT

[quote userid="106736" url="~/f/nordic-q-a/112129/can-you-use-the-heap-in-custom-secure-partitions-in-tfm/489406"]Yep, I think so.
The default sram partitioning looks like this, so I guess you will have enough here that you dont need to increase that.[/quote]

Great Many thanks.

[quote userid="106736" url="~/f/nordic-q-a/112129/can-you-use-the-heap-in-custom-secure-partitions-in-tfm/489406"]I have not used this before, but.
When I look it up, it looks like it is passed with cmake and not Kconfig.
For example https://github.com/Z3Prover/z3/issues/990:
"cmake -G Ninja -DCMAKE_BUILD_TYPE=RelWithDebInfo .."[/quote]

I will look into it further. I seem to get an error when using it with the default size-optimized building, but the speed-optimized one probably works.

[quote userid="106736" url="~/f/nordic-q-a/112129/can-you-use-the-heap-in-custom-secure-partitions-in-tfm/489406"]Can i suggest that you temporarily put #warning "AAAAAAAAAAA" inside each of the SRAM defines in those files to see which one is being used with the 9161?[/quote]

It doesn't seem to use one of the two partition_defs.h inside the common-directory as nothing seems to be displayed when pressing build

/home/usern/ncs/modules/tee/tf-m/trusted-firmware-m/platform/ext/target/nordic_nrf/common/nrf91/partition/region_defs.h

/home/usern/ncs/modules/tee/tf-m/trusted-firmware-m/platform/ext/target/nordic_nrf/common/nrf5340/partition/region_defs.h

It does print out the #warning "AAAAAAAAAAA" when changing the following file, so maybe thats the right

one /home/usern/ncs/nrf/modules/trusted-firmware-m/tfm_boards/partition/region_defs.h

RE: Can you use the heap in custom secure partitions in TFM?

Sigurd Hellesvik — Wed, 19 Jun 2024 06:47:43 GMT

[quote user="gdl"]How/With which command do i activate RelWithDebInfo?
Do i need to pass it differently?[/quote]

I have not used this before, but.
When I look it up, it looks like it is passed with cmake and not Kconfig.
For example https://github.com/Z3Prover/z3/issues/990:
"cmake -G Ninja -DCMAKE_BUILD_TYPE=RelWithDebInfo .."

[quote user="gdl"]And how do i increase the sram-size? Just by setting a higher number in this line in the same file you linked or is something more needed?[/quote]

Yep, I think so.
The default sram partitioning looks like this, so I guess you will have enough here that you dont need to increase that.

  sram_primary (0x40000 - 256kB): 
+--------------------------------------------------+
+---0x20000000: mcuboot_sram (0x8000 - 32kB)-------+
+---0x20000000: sram_secure (0x8000 - 32kB)--------+
| 0x20000000: tfm_sram (0x8000 - 32kB)             |
+---0x20008000: sram_nonsecure (0x38000 - 224kB)---+
+---0x20008000: nrf_modem_lib_sram (0x4568 - 17kB)-+
| 0x20008000: nrf_modem_lib_ctrl (0x4e8 - 1kB)     |
| 0x200084e8: nrf_modem_lib_tx (0x2080 - 8kB)      |
| 0x2000a568: nrf_modem_lib_rx (0x2000 - 8kB)      |
+--------------------------------------------------+
| 0x2000c568: sram_primary (0x33a98 - 206kB)       |
+--------------------------------------------------+

[quote user="gdl"]There is also no direct "equivalent" folder for my device (nrf9161), inside the directory
(/home/usern/ncs/modules/tee/tf-m/trusted-firmware-m/platform/ext/target/nordic_nrf/common/) only the following folders exist:
-core
-nrf91
-nrf5340
-nrf9120
-nrf9160[/quote]

Good point.
Can i suggest that you temporarily put #warning "AAAAAAAAAAA" inside each of the SRAM defines in those files to see which one is being used with the 9161?

RE: Can you use the heap in custom secure partitions in TFM?

gdl — Tue, 18 Jun 2024 15:46:58 GMT

Hey
thanks for your reply

Regarding RelWithDebInfo:
I commented-out "CONFIG_DEBUG=y" and instead tried adding one of the following lines (each tested separately) to my prj.conf:
CONFIG_relwithdebinfo =y
relwithdebinfo =y
CONFIG_RelWithDebInfo =y
CONFIG_REL_WITH_DEB_INFO =y

The full prj.conf then reads:

#
# Copyright (c) 2021 Nordic Semiconductor ASA
#
# SPDX-License-Identifier: Apache-2.0
#

CONFIG_BUILD_WITH_TFM=y
CONFIG_TFM_PROFILE_TYPE_NOT_SET=y
CONFIG_TFM_CONNECTION_BASED_SERVICE_API=y
CONFIG_TFM_PARTITION_CRYPTO=n
#CONFIG_DEBUG=Y
CONFIG_relwithdebinfo=y

CONFIG_TFM_SECURE_UART=y
CONFIG_TFM_SECURE_UART1=y

However they each led to the same undefined symbol error, so i couldn't build the program (while setting CONFIG_DEBUG=y works):

/home/usern/vscodeprojects/tfm_secure_partition_modified/prj.conf:12: warning: attempt to assign the value 'y' to the undefined symbol relwithdebinfo

error: Aborting due to Kconfig warnings

/home/usern/vscodeprojects/tfm_secure_partition_modified/prj.conf:12: warning: attempt to assign the value 'y' to the undefined symbol relwithdebinfo

error: Aborting due to Kconfig warnings

/home/usern/vscodeprojects/tfm_secure_partition_modified/prj.conf:12: warning: attempt to assign the value 'y' to the undefined symbol RelWithDebInfo

error: Aborting due to Kconfig warnings

/home/usern/vscodeprojects/tfm_secure_partition_modified/prj.conf:12: warning: attempt to assign the value 'y' to the undefined symbol REL_WITH_DEB_INFO

error: Aborting due to Kconfig warnings

        $<$<OR:$<CONFIG:Debug>,$<CONFIG:relwithdebinfo>>:ENABLE_HEAP>

How/With which command do i activate RelWithDebInfo?
Do i need to pass it differently?

Regarding the heap:

[quote userid="106736" url="~/f/nordic-q-a/112129/can-you-use-the-heap-in-custom-secure-partitions-in-tfm/489343"]For heap size, you should be able to increase it here, or equivalent for different boards.
Just make sure to size up the partitioning of sram as well when doing that.[/quote]

Ok thanks a lot.
Is there still a limit on the heap size?

And how do i increase the sram-size? Just by setting a higher number in this line in the same file you linked or is something more needed?

#define SPU_SRAM_REGION_SIZE    (0x00002000)

There is also no direct "equivalent" folder for my device (nrf9161), inside the directory
(/home/usern/ncs/modules/tee/tf-m/trusted-firmware-m/platform/ext/target/nordic_nrf/common/) only the following folders exist:
-core
-nrf91
-nrf5340
-nrf9120
-nrf9160

Should i just edit the region_defs file within core and snrf91(/home/usern/ncs/modules/tee/tf-m/trusted-firmware-m/platform/ext/target/nordic_nrf/common/nrf91/partition/region_defs.h)?

RE: Can you use the heap in custom secure partitions in TFM?

Sigurd Hellesvik — Tue, 18 Jun 2024 14:22:25 GMT

So far this is what I got:

Here is how the HEAP is enabled:

https://github.com/nrfconnect/sdk-trusted-firmware-m/blob/0fa3c2a105a9c737643594bed2fef6dca11049f7/platform/CMakeLists.txt#L352

So you must use either DEBUG or relwithdebinfo (release build with dwarf debug info enabled) to get the C heap.

[quote user="gdl"]And currently the programm only compiles with "CONFIG_DEBUG=y" in the prj.conf (as described in starting post). Does setting "CONFIG_DEBUG=y" impact performance or cause security issues?[/quote]

We do not have full insight into CONFIG_DEBUG, or how it will change in the future, so unfortunally I am unable to promise anything in regards to this question now.

Since debug configuration is not generally intended for releases, it could have some impacts, unfortunately.
The one thing I know for sure will be impacted is that the program will take more space.

I suggest that you try RelWithDebInfo and see if that works, as it seems to be a middle ground between release and debug builds.

For heap size, you should be able to increase it here, or equivalent for different boards.
Just make sure to size up the partitioning of sram as well when doing that.

RE: Can you use the heap in custom secure partitions in TFM?

gdl — Tue, 18 Jun 2024 08:13:51 GMT

It's a C programm running in its own secure partition that stores some data permanently on the heap (corresponding roughly to what objects and their members are in object-oriented langs) and also uses the heap to generate data and return it to the caller. The external user in the non-secure world can call roughly a dozen functions the programm offers to the outside through an interface. The individual data can be relatively large, e.g. several hundred bytes or in more rare cases >1000 bytes. The entire heap is ofc larger than that.

Would setting the "heap_size"-attribute in the manifest change the heap-size itself?

(Rewriting the application itself (instead of the secure partition configuration) would be complicated as it's already finished and to be used in various different tasks (not just on a microcontroller), however would be interested in it anyway if that's the suggested solution.)

Edit: And currently the programm only compiles with "CONFIG_DEBUG=y" in the prj.conf (as described in starting post). Does setting "CONFIG_DEBUG=y" impact performance or cause security issues?

RE: Can you use the heap in custom secure partitions in TFM?

Sigurd Hellesvik — Tue, 18 Jun 2024 06:41:34 GMT

The answer is that this is still a bit complicated.
I can explain to you what you would have to do to use the heap.

Could you explain a bit what you need the heap for in TF-M, so I can better guide you?

Alternatively: Maybe it is easier to avoid using the heap in TF-M and solve your issue in another way instead. Worth thinking about.

RE: Can you use the heap in custom secure partitions in TFM?

gdl — Mon, 17 Jun 2024 13:30:00 GMT

OK thanks

RE: Can you use the heap in custom secure partitions in TFM?

Sigurd Hellesvik — Mon, 17 Jun 2024 13:21:29 GMT

Hi,

Im will ask

Regards,
Sigurd Hellesvik