LED array indication while dfu process in MCU boot

RE: LED array indication while dfu process in MCU boot

Priyesh Shahi — Wed, 07 Aug 2024 06:28:20 GMT

Thank you Abhijith,

I will try with these files also.

RE: LED array indication while dfu process in MCU boot

Menon — Tue, 06 Aug 2024 15:00:00 GMT

hello Priyesh,

[quote user="Priyesh Shahi"]However, I would still like to know which driver file or BLE service file handles the downloading of packets from BLE. Additionally, it seems the MCUBOOT_INDICATION_LED is only for UART. Even after enabling it, the LED did not blink. I also tried printing logs in the main.c file of zephyr/boot to see where the code sets the LED, but none of those logs printed during a DFU over BLE. The only logs that printed were from the LED initialization function. It appears the indication LED may not be working for DFU over BLE.[/quote]

DFU over BLE is primarily managed by the Simple Management Protocol (SMP) service in the nRF Connect SDK. I recommend checking ncs\v2.x.x\zephyr\subsys\mgmt\mcumgr\transport\smp_bt.c, which handles the Bluetooth transport layer specific to SMP, and smp.c, which handles the core SMP.

Yes, you are right that the MCUBOOT_INDICATION_LED feature is typically used for UART-based DFU and might not be directly tied to the BLE DFU process. I think you can achieve this by modifying the SMP callbacks

Kind Regards,

Abhijith

RE: LED array indication while dfu process in MCU boot

Priyesh Shahi — Fri, 02 Aug 2024 11:32:01 GMT

Hi Abhijith,

Thank you for your response.

It's okay if you can't compare the nRF5 SDK and the nRF Connect SDK. thank you for your help with the MCUBOOT_INDICATION_LED configuration.

Regarding the firmware packets, I have managed to implement a solution

[quote userid="112989" url="~/f/nordic-q-a/112690/led-array-indication-while-dfu-process-in-mcu-boot/493964"]In case you don't want to modify sdk code, I used MCUmgr callbacks to implement something similar to what you describe:
https://docs.zephyrproject.org/latest/services/device_mgmt/mcumgr_callbacks.html[/quote]

However, I would still like to know which driver file or BLE service file handles the downloading of packets from BLE. Additionally, it seems the MCUBOOT_INDICATION_LED is only for UART. Even after enabling it, the LED did not blink. I also tried printing logs in the main.c file of zephyr/boot to see where the code sets the LED, but none of those logs printed during a DFU over BLE. The only logs that printed were from the LED initialization function. It appears the indication LED may not be working for DFU over BLE.

RE: LED array indication while dfu process in MCU boot

Menon — Fri, 02 Aug 2024 08:23:17 GMT

Hello Priyesh,

I apologize, but I won't be able to compare the nRF5 SDK and the nRF Connect SDK because I don't have any experience working with the older nRF5 SDK. I really don't know how it works.

Regarding the configuration of MCUBOOT_INDICATION_LED, you can check this sample. In the sample, this configuration is used for serial recovery and also shows how to configure the LED.

[quote user="Priyesh Shahi"] Can you help me identify which file exactly handles the firmware packets being downloaded from Bluetooth?[/quote]

I couldn't understand this last point very well. Could you please clarify what you mean by "file" here? In nRF connect SDK OTA DFU is based on BLE service.

Kind Regards,

Abhijith

RE: LED array indication while dfu process in MCU boot

Priyesh Shahi — Thu, 01 Aug 2024 10:17:15 GMT

Hello,

Sorry for the late response, but I was busy with some other work. I have tried almost all these solutions, but even the MCUBOOT_INDICATION_LED is not doing anything when my device is downloading the DFU packets from Bluetooth. Can you help me identify which file exactly handles the firmware packets being downloaded from Bluetooth?

Additionally, I have experience working with the nRF5 SDK, where we used the nrf_dfu_req_handler.c file to handle packet downloads and made changes there. Is there a similar file or handler in the nRF Connect SDK?

Thank you for your assistance.

Kind regards,
Priyesh Shahi

RE: LED array indication while dfu process in MCU boot

Priyesh Shahi — Tue, 16 Jul 2024 05:09:36 GMT

Thanks for the detailed instructions! I will try this approach and let you know if it works. I'll implement the changes in board.c and make the necessary modifications to the configuration and CMakeLists.txt files. I'll also write the system_led_blink() function. I'll update you on the results soon.

RE: LED array indication while dfu process in MCU boot

KWolfe81 — Mon, 15 Jul 2024 17:22:22 GMT

I was able to do the exact same without modifying MCUboot. I put MCUboot hooks in board.c as that file is compiled by both the APP and the child image (mcuboot). Best practice would put it elsewhere, but it's the least intrusive way.

In child_image/mcuboot.conf, I set:

CONFIG_BOOT_IMAGE_ACCESS_HOOKS=y
CONFIG_BOOT_IMAGE_ACCESS_HOOK_NRF5340=n

In my board's associated CMakeLists.txt file, I set:

zephyr_library_include_directories(${ZEPHYR_MCUBOOT_MODULE_DIR}/boot/bootutil/include)
zephyr_library_include_directories(${ZEPHYR_MCUBOOT_MODULE_DIR}/boot/zephyr/include)

Then defined the following functions in board.c. You'll need to write your own system_led_blink() function.

#include <bootutil/image.h>
#include <bootutil/bootutil.h>

//-----------------------------------------------------------------------------
int boot_perform_update_hook(int img_index, struct image_header *img_head, const struct flash_area *area)
{
    system_led_blink(LED_COLOR_OFF, LED_COLOR_PURPLE, 250);
    return BOOT_HOOK_REGULAR;
}

//-----------------------------------------------------------------------------
int boot_read_swap_state_primary_slot_hook(int image_index, struct boot_swap_state *state)
{
    return BOOT_HOOK_REGULAR;
}

//-----------------------------------------------------------------------------
fih_int boot_image_check_hook(int img_index, int slot)
{
    FIH_RET(fih_int_encode(BOOT_HOOK_REGULAR));
}

//-----------------------------------------------------------------------------
int boot_copy_region_post_hook(int img_index, const struct flash_area *area, size_t size)
{
    system_led_set_color(LED_COLOR_WHITE);
    return 0;
}

//-----------------------------------------------------------------------------
int boot_read_image_header_hook(int img_index, int slot, struct image_header *img_head)
{
    return BOOT_HOOK_REGULAR;
}

RE: LED array indication while dfu process in MCU boot

Nicolas Goualard — Mon, 15 Jul 2024 15:37:52 GMT

In case you don't want to modify sdk code, I used MCUmgr callbacks to implement something similar to what you describe:
https://docs.zephyrproject.org/latest/services/device_mgmt/mcumgr_callbacks.html

RE: LED array indication while dfu process in MCU boot

Menon — Mon, 08 Jul 2024 15:41:00 GMT

Hello,

To implement your use case, you need to edit the source code of MCUboot integrated with the SDK. When doing this, you must ensure compatibility with each SDK update. Other than that, I don't foresee any issues.

Kind regards,

Abhijith

RE: LED array indication while dfu process in MCU boot

Priyesh Shahi — Mon, 08 Jul 2024 04:19:01 GMT

Is it good practice to change the code inside the SDK directory, or is there a better way to do this?

RE: LED array indication while dfu process in MCU boot

Menon — Fri, 05 Jul 2024 13:10:07 GMT

Hello,

First, you need to define the GPIOs for the LEDs in the Device Tree Source (DTS) file or create an overlay file that specifies the dedicated GPIOs for your LED array. Next, modify the MCUBoot bootloader code to handle the array of LEDs. Customize the MCUBoot source code (located at `bootloader\mcuboot\boot\zephyr\main`) to loop through and toggle the LEDs during the indication phase.

Kind regards,

Abhijith

RE: LED array indication while dfu process in MCU boot

Priyesh Shahi — Thu, 04 Jul 2024 04:37:09 GMT

I am using NCS v2.5.1 on the nRF52840. I know about the CONFIG_MCUBOOT_INDICATION_LED setting, but I need help using this setting for an array of LEDs. Can you please assist me with that?

I have eight Leds on board which are connected to different gpios.

RE: LED array indication while dfu process in MCU boot

Menon — Wed, 03 Jul 2024 19:09:38 GMT

Hello,

I wanted to let you know that I have been assigned to this case and have started looking into it. Could you share the SDK version you are working with and specify which Nordic chip or development kit you are using? When you update the mcuboot code, you need to account for each update coming for the SDK. I assume that by "LED function" you mean CONFIG_MCUBOOT_INDICATION_LED.

Kind Regards,

Abhijith