NRF52840 fs_sample SD fs_close error on NCS 2.7.0

RE: NRF52840 fs_sample SD fs_close error on NCS 2.7.0

sheldon_b — Fri, 23 Aug 2024 13:07:18 GMT

I just verified the fix works on my hardware as well.

RE: NRF52840 fs_sample SD fs_close error on NCS 2.7.0

sheldon_b — Fri, 23 Aug 2024 12:38:28 GMT

Hi Tom,

I really appreciate you picking up the torch here. Excellent work troubleshooting so fast. I'll swap back to this project right now and see if I can replicate the fix.

RE: NRF52840 fs_sample SD fs_close error on NCS 2.7.0

SST — Fri, 23 Aug 2024 12:23:20 GMT

Fixed, see above.

RE: NRF52840 fs_sample SD fs_close error on NCS 2.7.0

SST — Fri, 23 Aug 2024 12:22:48 GMT

I think I have found the issue.

There is a missing break between line 796 and 797 of sd_ops.c. The bug was introduced in this commit:

https://github.com/nrfconnect/sdk-zephyr/commit/05c84ccb2d7a7cb39e49d769503ac22edffeb6f7

Do you do any testing on hardware for release? It seems not. Perhaps you might save your customers a lot of time with something like https://rockface.io/

Thanks,

Tom

RE: NRF52840 fs_sample SD fs_close error on NCS 2.7.0

SST — Fri, 23 Aug 2024 10:45:32 GMT

Slight progress.

The write is a red herring I introduced while trying to create a simplified test case. (The fs_sample opens with only FS_O_CREATE, adding FS_O_WRITE fixed it).

The close is still, however, failing.

RE: NRF52840 fs_sample SD fs_close error on NCS 2.7.0

SST — Thu, 22 Aug 2024 18:38:48 GMT

HI Maria,

I seem to have the same situation:

Code based on the fs_sample
Worked on NCS 2.5.0
Broken after moving to NCS 2.7.0
Custom board but it is ultimately an sd card on the SPI port.
fs_open() succeeds
fs_write() fails with -13 the file is created but the content is not written
fs_close() fails with -5
fs_mkdir() also returns an error. The directory is created.

The write process fails on line 4032 of ff.c.

if (!(fp->flag & FA_WRITE)) LEAVE_FF(fs, FR_DENIED);

fp->flag is 0x58
FA_WRITE is 0x2

flag is set to 0x58 in f_open(), (called by fs_open(&file, path, FS_O_CREATE)). It is set via mode (line 3863) however the steps to this point are optimised out.

Thanks,

Tom

RE: NRF52840 fs_sample SD fs_close error on NCS 2.7.0

sheldon_b — Thu, 22 Aug 2024 18:31:47 GMT

Hi, thanks for reaching out. I had to take a few weeks off from this issue but will soon be picking it back up.

RE: NRF52840 fs_sample SD fs_close error on NCS 2.7.0

SST — Thu, 22 Aug 2024 18:17:26 GMT

Hi,

I seem to have exactly the same failure. The circumstances and symptoms line up perfectly with everything you mention. Did you find a solution?

RE: NRF52840 fs_sample SD fs_close error on NCS 2.7.0

sheldon_b — Tue, 30 Jul 2024 18:16:53 GMT

I will try to find more information for you.

RE: NRF52840 fs_sample SD fs_close error on NCS 2.7.0

Maria Gilje — Fri, 26 Jul 2024 13:18:25 GMT

Hello,

I was not able to find anything meaningful from my initial investigations. The potential sources for FR_DISK_ERR occuring was many, and I would not be able to conclude anything without debugging this. I would like to reproduce this, but it could be tricky since you are using a custom board.

If you can do a debugging session to find out where FR_DISK_ERR is returned, this will be of much help.

As a side-note: Since this is a Zephyr sample, there could be help to find in the Zephyr project Discord server as well.

Best regards,

Maria

RE: NRF52840 fs_sample SD fs_close error on NCS 2.7.0

Maria Gilje — Thu, 25 Jul 2024 12:56:47 GMT

Hello,

I have started to investigate this, and I will get back to you tomorrow with my initial findings.

Best regards,

Maria