NCS 2.7.0 and "requires-ulbpr" for spi-nor

RE: NCS 2.7.0 and "requires-ulbpr" for spi-nor

rw_w — Tue, 27 Aug 2024 07:16:36 GMT

Ok, I will check with the Zephyr Issue Board on Github.

RE: NCS 2.7.0 and "requires-ulbpr" for spi-nor

Kazi Afroza Sultana — Mon, 26 Aug 2024 07:18:51 GMT

Hello,

There seems to have been some changes to the spi_nor.c driver in NCS 2.7.0 that causes this. The changes made seems to be done by Zephyr.

There is link to the file on github with the ''blame'' turned on

https://github.com/nrfconnect/sdk-zephyr/blame/main/drivers/flash/spi_nor.c

RE: NCS 2.7.0 and "requires-ulbpr" for spi-nor

rw_w — Tue, 13 Aug 2024 07:29:59 GMT

In the spi_nor driver (zephyr/drivers/flash/spi_nor.c) the struct spi_nor_config in v2.7.0 now also contains flags for some device tree opt-ins:

struct spi_nor_config {
    ...
	/* exist flags for dts opt-ins */
	bool dpd_exist:1;
	bool dpd_wakeup_sequence_exist:1;
	bool mxicy_mx25r_power_mode_exist:1;
	bool reset_gpios_exist:1;
	bool requires_ulbpr_exist:1;
	bool wp_gpios_exist:1;
	bool hold_gpios_exist:1;
};

If CONFIG_SPI_NOR_SFDP_RUNTIME=y is not used in the project configuration, requires_ulpbr from the devicetree is evaluated correctly and cfg->requires_ulbpr_exist is set to 1.

If CONFIG_SPI_NOR_SFDP_RUNTIME=y is used in the project configuration, it seems that requires_ulpbr from the devicetree is not evaluated and cfg->requires_ulbpr_exist stays 0.

The reason for that seems to be (line 1678):

#define GENERATE_CONFIG_STRUCT(idx)								\
	static const struct spi_nor_config spi_nor_##idx##_config = {				\
		.spi = SPI_DT_SPEC_INST_GET(idx, SPI_WORD_SET(8), CONFIG_SPI_NOR_CS_WAIT_DELAY),\
		COND_CODE_1(CONFIG_SPI_NOR_SFDP_RUNTIME, EMPTY(), (INST_CONFIG_STRUCT_GEN(idx)))};

So INST_CONFIG_STRUCT_GEN(idx), which would set cfg->requires_ulbpr_exist according to the device tree, is not called if CONFIG_SPI_NOR_SFDP_RUNTIME is used. But there also does not seem to be any other way to provide the information that ulbpr command is required to the spi nor driver at runtime.

RE: NCS 2.7.0 and "requires-ulbpr" for spi-nor

Kazi Afroza Sultana — Fri, 09 Aug 2024 15:17:08 GMT

Can you please explain this "cfg->requires_ulbpr_exist is not initialized"?

RE: NCS 2.7.0 and "requires-ulbpr" for spi-nor

rw_w — Thu, 01 Aug 2024 06:32:37 GMT

Yes, it is enabled in the device tree. That is not the problem.

The problem is that if CONFIG_SPI_NOR_SFDP_RUNTIME=y is used in the prj.conf file cfg->requires_ulbpr_exist is not initialized for spi_nor in NCS 2.7.0.

RE: NCS 2.7.0 and "requires-ulbpr" for spi-nor

Kazi Afroza Sultana — Wed, 31 Jul 2024 17:42:20 GMT

Hello RW,

In consequence of my last reply (adding the overlay in SLM application);

The overlay in enabled in the built device tree file.

You can continue to check if cfg->requires_ulbpr_exist is set with SLM, when run full modem FOTA.

RE: NCS 2.7.0 and "requires-ulbpr" for spi-nor

rw_w — Wed, 31 Jul 2024 11:55:55 GMT

Hello,

I tried the jesd216 sample (https://docs.zephyrproject.org/latest/samples/drivers/jesd216/README.html) on the NRF9160 DK with the overlay changes you suggested, as I could not find an easy way to access the NOR-flash in the serial_lte_modem application.

I extended this sample to also perform a write operation and print out the state of cfg->requires_ulbpr_exist.

It was working on the NRF9160 DK and also on my hardware (and devicetree) as expected (the parameter was set).

But if I add CONFIG_SPI_NOR_SFDP_RUNTIME=y to the configuration of the sample (which is also set in my application) cfg->requires_ulbpr_exist is not set on the NRF9160 DK and on my hardware.

So it seems cfg->requires_ulbpr_exist is not initialized if the SFDP parameters of the NOR-FLASH are read out at runtime (with CONFIG_SPI_NOR_SFDP_RUNTIME=y).

Is this behaviour intended?

Best Regards

RE: NCS 2.7.0 and "requires-ulbpr" for spi-nor

Kazi Afroza Sultana — Fri, 26 Jul 2024 16:01:05 GMT

Hello rw,

Can you please try our official sample (Serila_lte_modem) making this change in overlay file () ?

&arduino_spi {
mx25r64: mx25r6435f@1 {
status = "okay";
requires-ulbpr;
};
};