NCS Does Not Respect C Rule Against Function Overloads Under Certain Conditions

RE: NCS Does Not Respect C Rule Against Function Overloads Under Certain Conditions

ActiBaker — Tue, 20 Aug 2024 16:31:31 GMT

Ahh, I was unaware this was a "feature" of C in the old days. I looked around the internet with better keywords (incomplete function prototype) and found that the compiler setting -Wstrict-prototypes will mark instances of this.

I now understand the value of placing void in the parameter list, like void test(void).

Thanks for your help, Priyanka.

RE: NCS Does Not Respect C Rule Against Function Overloads Under Certain Conditions

Nguyen Hoan Hoang — Tue, 20 Aug 2024 12:50:30 GMT

There are usually 2 compiler settings. One for treat warnings as error. The other is disable all warning. Normally this should show a warning. If you don't see it, the disable all warnings may be active. Unfortunately, I don't know where those settings are in NCS. Look for the compiler settings. You might find tons of warning once you enable it. ;)

RE: NCS Does Not Respect C Rule Against Function Overloads Under Certain Conditions

Priyanka — Tue, 20 Aug 2024 12:39:09 GMT

Hi,

This likely occurs because of how lenient or strict different compilers are with the checking. In your case, even though function overloading is not allowed, you actually have two versions of the test function.

So in your sample, you first have a function declaration as:

[quote user=""]void test();[/quote]

Now, C is less strict about function declarations compared to C++. Hence when you have this declaration it likely understands it as a function which can take any arguments and return a void. So later when you have the definition as follows:

[quote user=""]void test(void * arg)
{
arbitrary_code();
}[/quote]

It does not actually violate what you have declared before. What you have done here is incomplete function prototyping. Certain compilers are lenient with this and others like the IAR are a bit more strict with this. The better solution is to avoid incomplete function prototyping and declare it properly always.

Hope this helps.

Regards,

Priyanka