Adding NVS in zigbee sample

RE: Adding NVS in zigbee sample

Håkon Alseth — Fri, 29 Nov 2024 13:30:44 GMT

Hi,

Great to hear that it is working now. Hope you have a wonderful weekend!

Kind regards,

Håkon

RE: Adding NVS in zigbee sample

Dhaval Dalvadi — Fri, 29 Nov 2024 06:38:31 GMT

Hi Håkon Alseth
I guess something was with cache
its working now on mac as well

RE: Adding NVS in zigbee sample

Håkon Alseth — Wed, 27 Nov 2024 11:32:22 GMT

Hi,

I am unable to reproduce this behavior. Are you using a stock nvs sample or the network_coordinator example when testing this?

[quote user="Dalvadi Anil"]'__device_dts_ord_DT_N_NODELABEL_second_storage_PARENT_PARENT_ORD' undeclared (first use in this function)
89 | #define DEVICE_NAME_GET(dev_id) _CONCAT(__device_, dev_id)[/quote]

This indicates that there's a device-tree issue happening, as the error will be reported differently if the partition name is not found.

Kind regards,

Håkon

RE: Adding NVS in zigbee sample

Dalvadi Anil — Tue, 26 Nov 2024 11:13:47 GMT

Hi,

I am getting below error in mac

CMakeLists.txt File

# SPDX-License-Identifier: Apache-2.0

cmake_minimum_required(VERSION 3.20.0)

macro(app_set_runner_args)

board_runner_args(dfu-util "--dfuse-modifiers=force:mass-erase")

board_runner_args(pyocd "--erase")

board_runner_args(nrfjprog "--erase")

endmacro()

find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE})

project(nvs_2)

target_sources(app PRIVATE src/main.c)

target_include_directories(app PRIVATE ${ZEPHYR_BASE}/subsys/fs/nvs)

Error

[{
"resource": "/Users/nistantritech/Documents/Zigbee/nvs_2/src/main.c",
"owner": "C/C++: IntelliSense",
"code": "20",
"severity": 8,
"message": "identifier \"__device_dts_ord_DT_N_NODELABEL_second_storage_PARENT_PARENT_ORD\" is undefined",
"source": "C/C++",
"startLineNumber": 81,
"startColumn": 20,
"endLineNumber": 81,
"endColumn": 40
},{
"resource": "/Users/nistantritech/Documents/Zigbee/nvs_2/src/main.c",
"owner": "C/C++: IntelliSense",
"code": "20",
"severity": 8,
"message": "identifier \"DT_N_NODELABEL_second_storage_REG_IDX_0_VAL_ADDRESS\" is undefined",
"source": "C/C++",
"startLineNumber": 86,
"startColumn": 14,
"endLineNumber": 86,
"endColumn": 34
}]

Full Output

* Executing task: nRF Connect: Generate config nrf21540dk_nrf52840 for /Users/nistantritech/Documents/Zigbee/nvs_2

Building nvs_2
west build --build-dir /Users/nistantritech/Documents/Zigbee/nvs_2/build /Users/nistantritech/Documents/Zigbee/nvs_2 --pristine --board nrf21540dk_nrf52840 -- -DNCS_TOOLCHAIN_VERSION=NONE -DCONFIG_DEBUG_OPTIMIZATIONS=y -DCONFIG_DEBUG_THREAD_INFO=y -DCONF_FILE=/Users/nistantritech/Documents/Zigbee/nvs_2/prj.conf -DDTC_OVERLAY_FILE=nrf21540dk_nrf52840.overlay -DBOARD_ROOT=/Users/nistantritech/Documents/Zigbee/nvs_2

-- west build: generating a build system
Loading Zephyr default modules (Zephyr base).
-- Application: /Users/nistantritech/Documents/Zigbee/nvs_2
-- CMake version: 3.21.0
-- Found Python3: /opt/nordic/ncs/toolchains/f8037e9b83/opt/python@3.9/bin/python3.9 (found suitable version "3.9.6", minimum required is "3.8") found components: Interpreter
-- Cache files will be written to: /Users/nistantritech/Library/Caches/zephyr
-- Zephyr version: 3.5.99 (/opt/nordic/ncs/v2.6.1/zephyr)
-- Found west (found suitable version "1.2.0", minimum required is "0.14.0")
-- Board: nrf21540dk_nrf52840
-- Found host-tools: zephyr 0.16.5 (/opt/nordic/ncs/toolchains/f8037e9b83/opt/zephyr-sdk)
-- Found toolchain: zephyr 0.16.5 (/opt/nordic/ncs/toolchains/f8037e9b83/opt/zephyr-sdk)
-- Found Dtc: /opt/nordic/ncs/toolchains/f8037e9b83/bin/dtc (found suitable version "1.6.1", minimum required is "1.4.6")
-- Found BOARD.dts: /opt/nordic/ncs/v2.6.1/zephyr/boards/arm/nrf21540dk_nrf52840/nrf21540dk_nrf52840.dts
-- Found devicetree overlay: nrf21540dk_nrf52840.overlay
-- Generated zephyr.dts: /Users/nistantritech/Documents/Zigbee/nvs_2/build/zephyr/zephyr.dts
-- Generated devicetree_generated.h: /Users/nistantritech/Documents/Zigbee/nvs_2/build/zephyr/include/generated/devicetree_generated.h
-- Including generated dts.cmake file: /Users/nistantritech/Documents/Zigbee/nvs_2/build/zephyr/dts.cmake
Parsing /opt/nordic/ncs/v2.6.1/zephyr/Kconfig
Loaded configuration '/opt/nordic/ncs/v2.6.1/zephyr/boards/arm/nrf21540dk_nrf52840/nrf21540dk_nrf52840_defconfig'
Merged configuration '/Users/nistantritech/Documents/Zigbee/nvs_2/prj.conf'
Merged configuration '/Users/nistantritech/Documents/Zigbee/nvs_2/build/zephyr/misc/generated/extra_kconfig_options.conf'
Configuration saved to '/Users/nistantritech/Documents/Zigbee/nvs_2/build/zephyr/.config'
Kconfig header saved to '/Users/nistantritech/Documents/Zigbee/nvs_2/build/zephyr/include/generated/autoconf.h'
-- Found GnuLd: /opt/nordic/ncs/toolchains/f8037e9b83/opt/zephyr-sdk/arm-zephyr-eabi/bin/../lib/gcc/arm-zephyr-eabi/12.2.0/../../../../arm-zephyr-eabi/bin/ld.bfd (found version "2.38")
-- The C compiler identification is GNU 12.2.0
-- The CXX compiler identification is GNU 12.2.0
-- The ASM compiler identification is GNU
-- Found assembler: /opt/nordic/ncs/toolchains/f8037e9b83/opt/zephyr-sdk/arm-zephyr-eabi/bin/arm-zephyr-eabi-gcc
-- Using ccache: /opt/nordic/ncs/toolchains/f8037e9b83/bin/ccache
-- Found partition manager static configuration: /Users/nistantritech/Documents/Zigbee/nvs_2/pm_static.yml
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/nistantritech/Documents/Zigbee/nvs_2/build
-- west build: building application
[1/164] Preparing syscall dependency handling

[4/164] Generating include/generated/version.h
-- Zephyr version: 3.5.99 (/opt/nordic/ncs/v2.6.1/zephyr), build: v3.5.99-ncs1-1
[163/164] Linking C executable zephyr/zephyr.elf
Memory region Used Size Region Size %age Used
FLASH: 45652 B 1 MB 4.35%
RAM: 12480 B 256 KB 4.76%
IDT_LIST: 0 GB 32 KB 0.00%
[164/164] Generating zephyr/merged.hex
* Terminal will be reused by tasks, press any key to close it.

* Executing task: nRF Connect: Build [pristine]: nvs_2/build (active)

Building nvs_2
west build --build-dir /Users/nistantritech/Documents/Zigbee/nvs_2/build /Users/nistantritech/Documents/Zigbee/nvs_2 --pristine --board nrf21540dk_nrf52840 -- -DNCS_TOOLCHAIN_VERSION=NONE -DCONF_FILE=prj.conf -DDTC_OVERLAY_FILE=nrf21540dk_nrf52840.overlay -DCONFIG_DEBUG_OPTIMIZATIONS=y -DCONFIG_DEBUG_THREAD_INFO=y -DBOARD_ROOT=/Users/nistantritech/Documents/Zigbee/nvs_2

* Executing task: nRF Connect: Build: nvs_2/build (active)

Building nvs_2
west build --build-dir /Users/nistantritech/Documents/Zigbee/nvs_2/build /Users/nistantritech/Documents/Zigbee/nvs_2

ninja: no work to do.
* Terminal will be reused by tasks, press any key to close it.

* Executing task: nRF Connect: Flash: nvs_2/build (active)

Flashing build to 681596074
west flash -d /Users/nistantritech/Documents/Zigbee/nvs_2/build --skip-rebuild --dev-id 681596074

-- west flash: using runner nrfjprog
-- runners.nrfjprog: mass erase requested
-- runners.nrfjprog: reset after flashing requested
-- runners.nrfjprog: Flashing file: /Users/nistantritech/Documents/Zigbee/nvs_2/build/zephyr/merged.hex
[ #################### ] 0.218s | Erase file - Done erasing
[ #################### ] 0.563s | Program file - Done programming
[ #################### ] 0.552s | Verify file - Done verifying
Enabling pin reset.
Applying pin reset.
-- runners.nrfjprog: Board with serial number 681596074 flashed successfully.
* Terminal will be reused by tasks, press any key to close it.

* Executing task: nRF Connect: Build [pristine]: nvs_2/build (active)

Building nvs_2
west build --build-dir /Users/nistantritech/Documents/Zigbee/nvs_2/build /Users/nistantritech/Documents/Zigbee/nvs_2 --pristine --board nrf21540dk_nrf52840 -- -DNCS_TOOLCHAIN_VERSION=NONE -DCONF_FILE=prj.conf -DDTC_OVERLAY_FILE=nrf21540dk_nrf52840.overlay -DCONFIG_DEBUG_OPTIMIZATIONS=y -DCONFIG_DEBUG_THREAD_INFO=y -DBOARD_ROOT=/Users/nistantritech/Documents/Zigbee/nvs_2

[4/164] Generating include/generated/version.h
-- Zephyr version: 3.5.99 (/opt/nordic/ncs/v2.6.1/zephyr), build: v3.5.99-ncs1-1
[156/164] Building C object CMakeFiles/app.dir/src/main.c.obj
FAILED: CMakeFiles/app.dir/src/main.c.obj
ccache /opt/nordic/ncs/toolchains/f8037e9b83/opt/zephyr-sdk/arm-zephyr-eabi/bin/arm-zephyr-eabi-gcc -DKERNEL -DNRF52840_XXAA -DPICOLIBC_LONG_LONG_PRINTF_SCANF -D_FORTIFY_SOURCE=1 -D_POSIX_C_SOURCE=200809 -D__LINUX_ERRNO_EXTENSIONS__ -D__PROGRAM_START -D__ZEPHYR__=1 -I/opt/nordic/ncs/v2.6.1/zephyr/subsys/fs/nvs -I/opt/nordic/ncs/v2.6.1/zephyr/include -I/Users/nistantritech/Documents/Zigbee/nvs_2/build/zephyr/include/generated -I/opt/nordic/ncs/v2.6.1/zephyr/soc/arm/nordic_nrf/nrf52 -I/opt/nordic/ncs/v2.6.1/zephyr/soc/common/nordic_nrf/. -I/opt/nordic/ncs/v2.6.1/zephyr/soc/arm/nordic_nrf/common/. -I/opt/nordic/ncs/v2.6.1/nrf/include -I/opt/nordic/ncs/v2.6.1/nrf/tests/include -I/opt/nordic/ncs/v2.6.1/modules/hal/cmsis/CMSIS/Core/Include -I/opt/nordic/ncs/v2.6.1/zephyr/modules/cmsis/. -I/opt/nordic/ncs/v2.6.1/modules/hal/nordic/nrfx -I/opt/nordic/ncs/v2.6.1/modules/hal/nordic/nrfx/drivers/include -I/opt/nordic/ncs/v2.6.1/modules/hal/nordic/nrfx/mdk -I/opt/nordic/ncs/v2.6.1/zephyr/modules/hal_nordic/nrfx/. -I/opt/nordic/ncs/v2.6.1/modules/debug/segger/SEGGER -I/opt/nordic/ncs/v2.6.1/modules/debug/segger/Config -isystem /opt/nordic/ncs/v2.6.1/zephyr/lib/libc/common/include -isystem /opt/nordic/ncs/v2.6.1/nrfxlib/crypto/nrf_cc310_platform/include -fno-strict-aliasing -Og -imacros /Users/nistantritech/Documents/Zigbee/nvs_2/build/zephyr/include/generated/autoconf.h -fno-printf-return-value -fno-common -g -gdwarf-4 -fdiagnostics-color=always -mcpu=cortex-m4 -mthumb -mabi=aapcs -mfp16-format=ieee -mtp=soft --sysroot=/opt/nordic/ncs/toolchains/f8037e9b83/opt/zephyr-sdk/arm-zephyr-eabi/arm-zephyr-eabi -imacros /opt/nordic/ncs/v2.6.1/zephyr/include/zephyr/toolchain/zephyr_stdint.h -Wall -Wformat -Wformat-security -Wno-format-zero-length -Wno-pointer-sign -Wpointer-arith -Wexpansion-to-defined -Wno-unused-but-set-variable -Werror=implicit-int -fno-pic -fno-pie -fno-asynchronous-unwind-tables -ftls-model=local-exec -fno-reorder-functions --param=min-pagesize=0 -fno-defer-pop -fmacro-prefix-map=/Users/nistantritech/Documents/Zigbee/nvs_2=CMAKE_SOURCE_DIR -fmacro-prefix-map=/opt/nordic/ncs/v2.6.1/zephyr=ZEPHYR_BASE -fmacro-prefix-map=/opt/nordic/ncs/v2.6.1=WEST_TOPDIR -ffunction-sections -fdata-sections --specs=picolibc.specs -std=c99 -MD -MT CMakeFiles/app.dir/src/main.c.obj -MF CMakeFiles/app.dir/src/main.c.obj.d -o CMakeFiles/app.dir/src/main.c.obj -c /Users/nistantritech/Documents/Zigbee/nvs_2/src/main.c
In file included from /opt/nordic/ncs/v2.6.1/zephyr/include/zephyr/toolchain/gcc.h:98,
from /opt/nordic/ncs/v2.6.1/zephyr/include/zephyr/toolchain.h:50,
from /opt/nordic/ncs/v2.6.1/zephyr/include/zephyr/kernel_includes.h:23,
from /opt/nordic/ncs/v2.6.1/zephyr/include/zephyr/kernel.h:17,
from /Users/nistantritech/Documents/Zigbee/nvs_2/src/main.c:41:
/Users/nistantritech/Documents/Zigbee/nvs_2/src/main.c: In function 'main':
/opt/nordic/ncs/v2.6.1/zephyr/include/zephyr/device.h:89:41: error: '__device_dts_ord_DT_N_NODELABEL_second_storage_PARENT_PARENT_ORD' undeclared (first use in this function)
89 | #define DEVICE_NAME_GET(dev_id) _CONCAT(__device_, dev_id)
| ^~~~~~~~~
/opt/nordic/ncs/v2.6.1/zephyr/include/zephyr/toolchain/common.h:137:26: note: in definition of macro '_DO_CONCAT'
137 | #define _DO_CONCAT(x, y) x ## y
| ^
/opt/nordic/ncs/v2.6.1/zephyr/include/zephyr/device.h:89:33: note: in expansion of macro '_CONCAT'
89 | #define DEVICE_NAME_GET(dev_id) _CONCAT(__device_, dev_id)
| ^~~~~~~
/opt/nordic/ncs/v2.6.1/zephyr/include/zephyr/device.h:216:37: note: in expansion of macro 'DEVICE_NAME_GET'
216 | #define DEVICE_DT_NAME_GET(node_id) DEVICE_NAME_GET(Z_DEVICE_DT_DEV_ID(node_id))
| ^~~~~~~~~~~~~~~
/opt/nordic/ncs/v2.6.1/zephyr/include/zephyr/device.h:233:34: note: in expansion of macro 'DEVICE_DT_NAME_GET'
233 | #define DEVICE_DT_GET(node_id) (&DEVICE_DT_NAME_GET(node_id))
| ^~~~~~~~~~~~~~~~~~
/opt/nordic/ncs/v2.6.1/zephyr/include/zephyr/storage/flash_map.h:348:9: note: in expansion of macro 'DEVICE_DT_GET'
348 | DEVICE_DT_GET(DT_MTD_FROM_FIXED_PARTITION(DT_NODELABEL(label)))
| ^~~~~~~~~~~~~
/Users/nistantritech/Documents/Zigbee/nvs_2/src/main.c:52:33: note: in expansion of macro 'FIXED_PARTITION_DEVICE'
52 | #define NVS_PARTITION_DEVICE FIXED_PARTITION_DEVICE(NVS_PARTITION)
| ^~~~~~~~~~~~~~~~~~~~~~
/Users/nistantritech/Documents/Zigbee/nvs_2/src/main.c:81:27: note: in expansion of macro 'NVS_PARTITION_DEVICE'
81 | fs.flash_device = NVS_PARTITION_DEVICE;
| ^~~~~~~~~~~~~~~~~~~~
/opt/nordic/ncs/v2.6.1/zephyr/include/zephyr/device.h:89:41: note: each undeclared identifier is reported only once for each function it appears in
89 | #define DEVICE_NAME_GET(dev_id) _CONCAT(__device_, dev_id)
| ^~~~~~~~~
/opt/nordic/ncs/v2.6.1/zephyr/include/zephyr/toolchain/common.h:137:26: note: in definition of macro '_DO_CONCAT'
137 | #define _DO_CONCAT(x, y) x ## y
| ^
/opt/nordic/ncs/v2.6.1/zephyr/include/zephyr/device.h:89:33: note: in expansion of macro '_CONCAT'
89 | #define DEVICE_NAME_GET(dev_id) _CONCAT(__device_, dev_id)
| ^~~~~~~
/opt/nordic/ncs/v2.6.1/zephyr/include/zephyr/device.h:216:37: note: in expansion of macro 'DEVICE_NAME_GET'
216 | #define DEVICE_DT_NAME_GET(node_id) DEVICE_NAME_GET(Z_DEVICE_DT_DEV_ID(node_id))
| ^~~~~~~~~~~~~~~
/opt/nordic/ncs/v2.6.1/zephyr/include/zephyr/device.h:233:34: note: in expansion of macro 'DEVICE_DT_NAME_GET'
233 | #define DEVICE_DT_GET(node_id) (&DEVICE_DT_NAME_GET(node_id))
| ^~~~~~~~~~~~~~~~~~
/opt/nordic/ncs/v2.6.1/zephyr/include/zephyr/storage/flash_map.h:348:9: note: in expansion of macro 'DEVICE_DT_GET'
348 | DEVICE_DT_GET(DT_MTD_FROM_FIXED_PARTITION(DT_NODELABEL(label)))
| ^~~~~~~~~~~~~
/Users/nistantritech/Documents/Zigbee/nvs_2/src/main.c:52:33: note: in expansion of macro 'FIXED_PARTITION_DEVICE'
52 | #define NVS_PARTITION_DEVICE FIXED_PARTITION_DEVICE(NVS_PARTITION)
| ^~~~~~~~~~~~~~~~~~~~~~
/Users/nistantritech/Documents/Zigbee/nvs_2/src/main.c:81:27: note: in expansion of macro 'NVS_PARTITION_DEVICE'
81 | fs.flash_device = NVS_PARTITION_DEVICE;
| ^~~~~~~~~~~~~~~~~~~~
In file included from /opt/nordic/ncs/v2.6.1/zephyr/include/zephyr/arch/arm/arch.h:20,
from /opt/nordic/ncs/v2.6.1/zephyr/include/zephyr/arch/cpu.h:19,
from /opt/nordic/ncs/v2.6.1/zephyr/include/zephyr/kernel_includes.h:37:
/opt/nordic/ncs/v2.6.1/zephyr/include/zephyr/devicetree.h:198:36: error: 'DT_N_NODELABEL_second_storage_REG_IDX_0_VAL_ADDRESS' undeclared (first use in this function)
198 | #define DT_NODELABEL(label) DT_CAT(DT_N_NODELABEL_, label)
| ^~~~~~~~~~~~~~~
/opt/nordic/ncs/v2.6.1/zephyr/include/zephyr/devicetree.h:4345:33: note: in definition of macro 'DT_CAT4'
4345 | #define DT_CAT4(a1, a2, a3, a4) a1 ## a2 ## a3 ## a4
| ^~
/opt/nordic/ncs/v2.6.1/zephyr/include/zephyr/devicetree.h:2225:30: note: in expansion of macro 'DT_REG_ADDR_BY_IDX'
2225 | #define DT_REG_ADDR(node_id) DT_REG_ADDR_BY_IDX(node_id, 0)
| ^~~~~~~~~~~~~~~~~~
/opt/nordic/ncs/v2.6.1/zephyr/include/zephyr/storage/flash_map.h:319:39: note: in expansion of macro 'DT_REG_ADDR'
319 | #define FIXED_PARTITION_OFFSET(label) DT_REG_ADDR(DT_NODELABEL(label))
| ^~~~~~~~~~~
/opt/nordic/ncs/v2.6.1/zephyr/include/zephyr/devicetree.h:198:29: note: in expansion of macro 'DT_CAT'
198 | #define DT_NODELABEL(label) DT_CAT(DT_N_NODELABEL_, label)
| ^~~~~~
/opt/nordic/ncs/v2.6.1/zephyr/include/zephyr/storage/flash_map.h:319:51: note: in expansion of macro 'DT_NODELABEL'
319 | #define FIXED_PARTITION_OFFSET(label) DT_REG_ADDR(DT_NODELABEL(label))
| ^~~~~~~~~~~~
/Users/nistantritech/Documents/Zigbee/nvs_2/src/main.c:53:33: note: in expansion of macro 'FIXED_PARTITION_OFFSET'
53 | #define NVS_PARTITION_OFFSET FIXED_PARTITION_OFFSET(NVS_PARTITION)
| ^~~~~~~~~~~~~~~~~~~~~~
/Users/nistantritech/Documents/Zigbee/nvs_2/src/main.c:86:21: note: in expansion of macro 'NVS_PARTITION_OFFSET'
86 | fs.offset = NVS_PARTITION_OFFSET;
| ^~~~~~~~~~~~~~~~~~~~
ninja: build stopped: subcommand failed.
FATAL ERROR: command exited with status 1: /opt/nordic/ncs/toolchains/f8037e9b83/bin/cmake --build /Users/nistantritech/Documents/Zigbee/nvs_2/build

* The terminal process terminated with exit code: 1.
* Terminal will be reused by tasks, press any key to close it.

* Executing task: nRF Connect: Build [pristine]: nvs_2/build (active)

Building nvs_2
west build --build-dir /Users/nistantritech/Documents/Zigbee/nvs_2/build /Users/nistantritech/Documents/Zigbee/nvs_2 --pristine --board nrf21540dk_nrf52840 -- -DNCS_TOOLCHAIN_VERSION=NONE -DCONF_FILE=prj.conf -DDTC_OVERLAY_FILE=nrf21540dk_nrf52840.overlay -DCONFIG_DEBUG_OPTIMIZATIONS=y -DCONFIG_DEBUG_THREAD_INFO=y -DBOARD_ROOT=/Users/nistantritech/Documents/Zigbee/nvs_2

* The terminal process terminated with exit code: 1.
* Terminal will be reused by tasks, press any key to close it.

RE: Adding NVS in zigbee sample

Håkon Alseth — Tue, 26 Nov 2024 10:06:53 GMT

Thank you for explaining.

Can you share the full output? including the cmake configuration?

It should look similar to this (tested on a macbook):

-- west build: generating a build system
Loading Zephyr module(s) (Zephyr base): sysbuild_default
-- Found Python3: /Library/Developer/CommandLineTools/usr/bin/python3 (found suitable version "3.9.6", minimum required is "3.8") found components: Interpreter
-- Cache files will be written to: /Users/hkn/Library/Caches/zephyr
-- Found west (found suitable version "1.2.0", minimum required is "0.14.0")
-- Board: nrf52840dk, qualifiers: nrf52840
Parsing /opt/ncs/nrf/samples/zigbee/light_bulb/Kconfig.sysbuild
Loaded configuration '/opt/ncs/nrf/samples/zigbee/light_bulb/build/_sysbuild/empty.conf'
Merged configuration '/opt/ncs/nrf/samples/zigbee/light_bulb/build/_sysbuild/empty.conf'
Configuration saved to '/opt/ncs/nrf/samples/zigbee/light_bulb/build/zephyr/.config'
Kconfig header saved to '/opt/ncs/nrf/samples/zigbee/light_bulb/build/_sysbuild/autoconf.h'
-- 
   ********************************
   * Running CMake for light_bulb *
   ********************************

Loading Zephyr default modules (Zephyr base).
-- Application: /opt/ncs/nrf/samples/zigbee/light_bulb
-- CMake version: 3.30.2
-- Found Python3: /usr/bin/python3 (found suitable version "3.9.6", minimum required is "3.8") found components: Interpreter
-- Cache files will be written to: /Users/hkn/Library/Caches/zephyr
-- Zephyr version: 3.6.99 (/opt/ncs/zephyr)
-- Found west (found suitable version "1.2.0", minimum required is "0.14.0")
-- Board: nrf52840dk, qualifiers: nrf52840
-- ZEPHYR_TOOLCHAIN_VARIANT not set, trying to locate Zephyr SDK
-- Found host-tools: zephyr 0.16.8 (/opt/zephyr-sdk-0.16.8)
-- Found toolchain: zephyr 0.16.8 (/opt/zephyr-sdk-0.16.8)
-- Found Dtc: /opt/homebrew/bin/dtc (found suitable version "1.7.1", minimum required is "1.4.6")
-- Found BOARD.dts: /opt/ncs/zephyr/boards/nordic/nrf52840dk/nrf52840dk_nrf52840.dts
-- Found devicetree overlay: /opt/ncs/nrf/samples/zigbee/light_bulb/boards/nrf52840dk_nrf52840.overlay
-- Generated zephyr.dts: /opt/ncs/nrf/samples/zigbee/light_bulb/build/light_bulb/zephyr/zephyr.dts
-- Generated devicetree_generated.h: /opt/ncs/nrf/samples/zigbee/light_bulb/build/light_bulb/zephyr/include/generated/devicetree_generated.h
-- Including generated dts.cmake file: /opt/ncs/nrf/samples/zigbee/light_bulb/build/light_bulb/zephyr/dts.cmake
Parsing /opt/ncs/zephyr/Kconfig
Loaded configuration '/opt/ncs/zephyr/boards/nordic/nrf52840dk/nrf52840dk_nrf52840_defconfig'
Merged configuration '/opt/ncs/nrf/samples/zigbee/light_bulb/prj.conf'
Merged configuration '/opt/ncs/nrf/samples/zigbee/light_bulb/build/light_bulb/zephyr/.config.sysbuild'
Configuration saved to '/opt/ncs/nrf/samples/zigbee/light_bulb/build/light_bulb/zephyr/.config'
Kconfig header saved to '/opt/ncs/nrf/samples/zigbee/light_bulb/build/light_bulb/zephyr/include/generated/autoconf.h'
-- Found GnuLd: /opt/zephyr-sdk-0.16.8/arm-zephyr-eabi/arm-zephyr-eabi/bin/ld.bfd (found version "2.38")
-- The C compiler identification is GNU 12.2.0
-- The CXX compiler identification is GNU 12.2.0
-- The ASM compiler identification is GNU
-- Found assembler: /opt/zephyr-sdk-0.16.8/arm-zephyr-eabi/bin/arm-zephyr-eabi-gcc
-- Using ccache: /opt/homebrew/bin/ccache
CMake Warning at /opt/ncs/zephyr/CMakeLists.txt:2027 (message):
  __ASSERT() statements are globally ENABLED


-- Configuring done (4.1s)
-- Generating done (0.2s)
-- Build files have been written to: /opt/ncs/nrf/samples/zigbee/light_bulb/build/light_bulb
-- Found partition manager static configuration : /opt/ncs/nrf/samples/zigbee/light_bulb/pm_static.yml
Partition 'settings_storage' is not included in the dynamic resolving since it is statically defined.
Partition 'zboss_nvram' is not included in the dynamic resolving since it is statically defined.
Partition 'zboss_product_config' is not included in the dynamic resolving since it is statically defined.
-- Configuring done (6.1s)
-- Generating done (0.0s)
-- Build files have been written to: /opt/ncs/nrf/samples/zigbee/light_bulb/build
-- west build: building application
[5/10] Performing build step for 'light_bulb'
[1/363] Preparing syscall dependency handling

[6/363] Generating include/generated/version.h
-- Zephyr version: 3.6.99 (/opt/ncs/zephyr), build: v3.6.99-ncs2
[356/363] Building C object CMakeFiles/app.dir/src/main.c.obj
[363/363] Linking C executable zephyr/zephyr.elf
Memory region         Used Size  Region Size  %age Used
           FLASH:      374960 B       972 KB     37.67%
             RAM:       59504 B       256 KB     22.70%
        IDT_LIST:          0 GB        32 KB      0.00%
Generating files from /opt/ncs/nrf/samples/zigbee/light_bulb/build/light_bulb/zephyr/zephyr.elf for board: nrf52840dk
[10/10] Generating ../merged.hex

Kind regards,

Håkon

RE: Adding NVS in zigbee sample

Dhaval Dalvadi — Tue, 26 Nov 2024 04:41:34 GMT

Hi
It worked in windows system but in mac it gives error as mentioned above

had already deleted build folder and have confirmed pm_static.yml there with code you have provided and confirmed in windows that it works fine

RE: Adding NVS in zigbee sample

Håkon Alseth — Mon, 25 Nov 2024 14:27:50 GMT

Hi,

[quote user="dhavaldalvadi"]this worked but partially If I compile same in mac it gives compilation error second_storage undefined[/quote]

I am not sure I understand, did the proposed fix work on one machine and not another?

Can you share a bit more details on what works and what does not ?

Please note that you have to delete your build folder when explicitly creating a new pm_static.yml file.

Kind regards,

Håkon

RE: Adding NVS in zigbee sample

Dhaval Dalvadi — Sun, 24 Nov 2024 10:47:21 GMT

Hi Hakon

this worked but partially If I compile same in mac it gives compilation error second_storage undefined

RE: Adding NVS in zigbee sample

Håkon Alseth — Fri, 22 Nov 2024 15:07:23 GMT

Hi,

Thank you for sharing this, I was able to reproduce the scenario.

The problem is that ZIGBEE_SCENES uses settings, which uses NVS as the backend.

The application must then setup a specific storage partition that does not overlap with this settings partition. This can be done by setting a dedicated partition, lets name this "second_storage" here for simplicity:

// Comment out "original" partition name
//#define NVS_PARTITION       storage_partition
#define NVS_PARTITION       second_storage

Then we adjust the flash by placing this in the myproject/pm_static.yml:

app:
  address: 0x0
  end_address: 0xf3000
  region: flash_primary
  size: 0xf3000
settings_storage:
  address: 0xfe000
  end_address: 0x100000
  placement:
    align:
      start: 0x1000
    before:
    - end
  region: flash_primary
  size: 0x2000
sram_primary:
  address: 0x20000000
  end_address: 0x20040000
  region: sram_primary
  size: 0x40000
zboss_nvram:
  address: 0xf5000
  end_address: 0xfd000
  placement:
    after:
    - app
    align:
      start: 0x1000
  region: flash_primary
  size: 0x8000
zboss_product_config:
  address: 0xfd000
  end_address: 0xfe000
  placement:
    after:
    - zboss_nvram
  region: flash_primary
  size: 0x1000
second_storage:
  address: 0xf3000
  end_address: 0xf5000
  placement:
    align:
      start: 0x1000
    before:
    - end
  region: flash_primary
  size: 0x2000

Ran your on a nrf52840dk_nrf52840 board:

*** Booting nRF Connect SDK v2.8.0-a2386bfc8401 ***
*** Using Zephyr OS v3.7.99-0bc3393fb112 ***
I: Starting ZBOSS Light Switch example
I: 3 Sectors of 4096 bytes
I: alloc wra: 0, bf8
I: data wra: 0, 280
Id: 1, Address: 192.168.1.1
Id: 2, Key: ff fe fd fc fb fa f9 f8 
Id: 3, Reboot_counter: 120
Id: 5, Longarray: 0 1 2 3 4 5 6 7 8 9 a b c d e f 10 11 12 13 14 15 16 17 18 19 1a 1b 1c 1d 1e 1f 20 21 22 23 24 25 26 27 2 
Reboot counter history: ...120...119...118...117...116...115...114...113...112...111...110...109...108...107...106...105...0
Oldest reboot counter: 0
Rebooting in ...5...4...3...2...1

Remember to delete your build folder and regenerate the project when changing the partition layout.

Could you try this and report back?

Kind regards,

Håkon

RE: Adding NVS in zigbee sample

Dhaval Dalvadi — Thu, 21 Nov 2024 06:49:01 GMT

Håkon Alseth
I found if I comment

CONFIG_ZIGBEE_SCENES=y

it works fine

but I will need that so how can I fix it any idea?

RE: Adding NVS in zigbee sample

Dhaval Dalvadi — Thu, 21 Nov 2024 05:18:29 GMT

Hi,

I tried to reproduce with sample you can use coordniator example with below prj.conf

# SPDX-License-Identifier: LicenseRef-Nordic-5-Clause

CONFIG_NCS_SAMPLES_DEFAULTS=y

CONFIG_SERIAL=y

CONFIG_GPIO=y

# Make sure printk is not printing to the UART console

CONFIG_CONSOLE=y

CONFIG_UART_CONSOLE=y

CONFIG_HEAP_MEM_POOL_SIZE=2048

CONFIG_MAIN_THREAD_PRIORITY=7

CONFIG_ZIGBEE=y

CONFIG_ZIGBEE_APP_UTILS=y

CONFIG_ZIGBEE_ROLE_COORDINATOR=y

# Enable DK LED and Buttons library

CONFIG_DK_LIBRARY=y

# This example requires more workqueue stack

CONFIG_SYSTEM_WORKQUEUE_STACK_SIZE=2048

# Enable nRF ECB driver

CONFIG_CRYPTO=y

CONFIG_CRYPTO_NRF_ECB=y

CONFIG_CRYPTO_INIT_PRIORITY=80

# Networking

CONFIG_NET_IPV6=n

CONFIG_NET_IP_ADDR_CHECK=n

CONFIG_NET_UDP=n

# SPDX-License-Identifier: LicenseRef-Nordic-5-Clause

CONFIG_NCS_SAMPLES_DEFAULTS=y

CONFIG_NO_OPTIMIZATIONS=y

CONFIG_UART_INTERRUPT_DRIVEN=n

CONFIG_SERIAL=y

CONFIG_UART_ASYNC_API=y

CONFIG_UART_1_ASYNC=y

CONFIG_GPIO=y

# Make sure printk is not printing to the UART console

CONFIG_CONSOLE=y

CONFIG_UART_CONSOLE=y

CONFIG_HEAP_MEM_POOL_SIZE=2048

CONFIG_ZIGBEE=y

CONFIG_ZIGBEE_APP_UTILS=y

# Enable DK LED and Buttons library

CONFIG_DK_LIBRARY=y

# This example requires more workqueue stack

CONFIG_SYSTEM_WORKQUEUE_STACK_SIZE=2048

# Enable API for powering down unused RAM parts

CONFIG_RAM_POWER_DOWN_LIBRARY=y

# Networking

CONFIG_NET_IPV6=n

CONFIG_NET_IP_ADDR_CHECK=n

CONFIG_NET_UDP=n

#CONFIG_CLOCK_CONTROL_NRF_K32SRC_RC=y

CONFIG_ZIGBEE_SCENES=y

CONFIG_LOG_MODE_IMMEDIATE=y

CONFIG_ZIGBEE_CHANNEL=15

CONFIG_FLASH=y

CONFIG_FLASH_PAGE_LAYOUT=y

CONFIG_NVS=y

CONFIG_LOG=y

CONFIG_LOG_MODE_IMMEDIATE=y

CONFIG_NVS_LOG_LEVEL_DBG=y

CONFIG_REBOOT=y

CONFIG_MPU_ALLOW_FLASH_WRITE=y

# choose RTT console

CONFIG_UART_CONSOLE=n

CONFIG_USE_SEGGER_RTT=y

CONFIG_RTT_CONSOLE=y

CONFIG_MAIN_STACK_SIZE=4096

and main function from nvs sample with required variables and #defines

#include <zephyr/drivers/flash.h>

#include <zephyr/storage/flash_map.h>

#include <zephyr/fs/nvs.h>

static struct nvs_fs fs;

#define NVS_PARTITION storage_partition

#define NVS_PARTITION_DEVICE FIXED_PARTITION_DEVICE(NVS_PARTITION)

#define NVS_PARTITION_OFFSET FIXED_PARTITION_OFFSET(NVS_PARTITION)

/* 1000 msec = 1 sec */

#define SLEEP_TIME 100

/* maximum reboot counts, make high enough to trigger sector change (buffer */

/* rotation). */

#define MAX_REBOOT 400

#define ADDRESS_ID 1

#define KEY_ID 2

#define RBT_CNT_ID 3

#define STRING_ID 4

#define LONG_ID 5

int main(void)

{

int rc = 0, cnt = 0, cnt_his = 0;

char buf[16];

uint8_t key[8], longarray[128];

uint32_t reboot_counter = 0U, reboot_counter_his;

struct flash_pages_info info;

/* define the nvs file system by settings with:

* sector_size equal to the pagesize,

* 3 sectors

* starting at NVS_PARTITION_OFFSET

fs.flash_device = NVS_PARTITION_DEVICE;

if (!device_is_ready(fs.flash_device)) {

printk("Flash device %s is not ready\n", fs.flash_device->name);

return 0;

}

fs.offset = NVS_PARTITION_OFFSET;

rc = flash_get_page_info_by_offs(fs.flash_device, fs.offset, &info);

if (rc) {

printk("Unable to get page info\n");

return 0;

}

fs.sector_size = info.size;

fs.sector_count = 3U;

rc = nvs_mount(&fs);

if (rc) {

printk("Flash Init failed\n");

return 0;

}

/* ADDRESS_ID is used to store an address, lets see if we can

* read it from flash, since we don't know the size read the

* maximum possible

rc = nvs_read(&fs, ADDRESS_ID, &buf, sizeof(buf));

if (rc > 0) { /* item was found, show it */

printk("Id: %d, Address: %s\n", ADDRESS_ID, buf);

} else {/* item was not found, add it */

strcpy(buf, "192.168.1.1");

printk("No address found, adding %s at id %d\n", buf,

ADDRESS_ID);

(void)nvs_write(&fs, ADDRESS_ID, &buf, strlen(buf)+1);

}

/* KEY_ID is used to store a key, lets see if we can read it from flash

rc = nvs_read(&fs, KEY_ID, &key, sizeof(key));

if (rc > 0) { /* item was found, show it */

printk("Id: %d, Key: ", KEY_ID);

for (int n = 0; n < 8; n++) {

printk("%x ", key[n]);

}

printk("\n");

} else {/* item was not found, add it */

printk("No key found, adding it at id %d\n", KEY_ID);

key[0] = 0xFF;

key[1] = 0xFE;

key[2] = 0xFD;

key[3] = 0xFC;

key[4] = 0xFB;

key[5] = 0xFA;

key[6] = 0xF9;

key[7] = 0xF8;

(void)nvs_write(&fs, KEY_ID, &key, sizeof(key));

}

/* RBT_CNT_ID is used to store the reboot counter, lets see

* if we can read it from flash

rc = nvs_read(&fs, RBT_CNT_ID, &reboot_counter, sizeof(reboot_counter));

if (rc > 0) { /* item was found, show it */

printk("Id: %d, Reboot_counter: %d\n",

RBT_CNT_ID, reboot_counter);

} else {/* item was not found, add it */

printk("No Reboot counter found, adding it at id %d\n",

RBT_CNT_ID);

(void)nvs_write(&fs, RBT_CNT_ID, &reboot_counter,

sizeof(reboot_counter));

}

/* STRING_ID is used to store data that will be deleted,lets see

* if we can read it from flash, since we don't know the size read the

* maximum possible

rc = nvs_read(&fs, STRING_ID, &buf, sizeof(buf));

if (rc > 0) {

/* item was found, show it */

printk("Id: %d, Data: %s\n",

STRING_ID, buf);

/* remove the item if reboot_counter = 10 */

if (reboot_counter == 10U) {

(void)nvs_delete(&fs, STRING_ID);

}

} else {

/* entry was not found, add it if reboot_counter = 0*/

if (reboot_counter == 0U) {

printk("Id: %d not found, adding it\n",

STRING_ID);

strcpy(buf, "DATA");

(void)nvs_write(&fs, STRING_ID, &buf, strlen(buf) + 1);

}

/* LONG_ID is used to store a larger dataset ,lets see if we can read

* it from flash

rc = nvs_read(&fs, LONG_ID, &longarray, sizeof(longarray));

if (rc > 0) {

/* item was found, show it */

printk("Id: %d, Longarray: ", LONG_ID);

for (int n = 0; n < sizeof(longarray); n++) {

printk("%x ", longarray[n]);

}

printk("\n");

} else {

/* entry was not found, add it if reboot_counter = 0*/

if (reboot_counter == 0U) {

printk("Longarray not found, adding it as id %d\n",

LONG_ID);

for (int n = 0; n < sizeof(longarray); n++) {

longarray[n] = n;

}

(void)nvs_write(

&fs, LONG_ID, &longarray, sizeof(longarray));

}

cnt = 5;

while (1) {

k_msleep(SLEEP_TIME);

if (reboot_counter < MAX_REBOOT) {

if (cnt == 5) {

/* print some history information about

* the reboot counter

* Check the counter history in flash

printk("Reboot counter history: ");

while (1) {

rc = nvs_read_hist(

&fs, RBT_CNT_ID,

&reboot_counter_his,

sizeof(reboot_counter_his),

cnt_his);

if (rc < 0) {

break;

}

printk("...%d", reboot_counter_his);

cnt_his++;

}

if (cnt_his == 0) {

printk("\n Error, no Reboot counter");

} else {

printk("\nOldest reboot counter: %d",

reboot_counter_his);

}

printk("\nRebooting in ");

}

printk("...%d", cnt);

cnt--;

if (cnt == 0) {

printk("\n");

reboot_counter++;

(void)nvs_write(

&fs, RBT_CNT_ID, &reboot_counter,

sizeof(reboot_counter));

if (reboot_counter == MAX_REBOOT) {

printk("Doing last reboot...\n");

}

sys_reboot(0);

}

} else {

printk("Reboot counter reached max value.\n");

printk("Reset to 0 and exit test.\n");

reboot_counter = 0U;

(void)nvs_write(&fs, RBT_CNT_ID, &reboot_counter,

sizeof(reboot_counter));

break;

}

return 0;

}

RE: Adding NVS in zigbee sample

Håkon Alseth — Wed, 20 Nov 2024 13:58:00 GMT

Hi,

The layout is generated based on the configuration.

Can you please share how to recreate this scenario?

Kind regards,

Håkon

RE: Adding NVS in zigbee sample

Dhaval Dalvadi — Wed, 20 Nov 2024 13:53:25 GMT

Hi Hakon
I am not sure where to alter partition layout
in nvs example it used to be mentioned in device tree but if have used zigbee samples
not able to find where to add nvs partition or if it has then how to modify it

RE: Adding NVS in zigbee sample

Håkon Alseth — Wed, 20 Nov 2024 13:03:18 GMT

Hi,

Can you share how you are reproducing this issue?

When altering the partition layout, it is important that you re-generate the build (ie. delete the build folder, then re-configure) - this is to ensure that the partitions are generated within the address space of the chosen device.

Your address space seems to be out-of-bounds.

Kind regards,

Håkon