"scheduled_action_handle()" is executed many times

RE: "scheduled_action_handle()" is executed many times

a.da — Thu, 09 Jan 2025 00:08:31 GMT

Hi Hung,

Thank you for your quick response. I’m looking forward to the release.

a.da

RE: "scheduled_action_handle()" is executed many times

Hung Bui — Wed, 08 Jan 2025 15:44:16 GMT

Hi A.da,
A PR has been created following your suggestion:
https://github.com/nrfconnect/sdk-nrf/pull/19805
Thanks for your report 👍

RE: "scheduled_action_handle()" is executed many times

Hung Bui — Tue, 07 Jan 2025 13:33:36 GMT

Hi a.da,

Thanks for the report . I think you are right. But I'm checking with the mesh team to hear from them. I will keep you updated.

RE: "scheduled_action_handle()" is executed many times

a.da — Tue, 07 Jan 2025 07:57:48 GMT

Additional information:

I found something concerning in the nRF Connect SDK.
There is a function that converts "uptime" to "TAI Time."
time_srv.c / tai_at()
However, it seems that "subsec" is not being used for carrying over to "sec."
As a result, the conversion to "TAI Time" appears to be inaccurate.
After making the modification as shown in the attached file, the function "scheduled_action_handle()" was executed only once at the scheduled time.
The at symbol (@) indicates the areas that have been edited.

Cote:

static inline struct bt_mesh_time_tai
tai_at(const struct bt_mesh_time_srv *srv, int64_t uptime)
{
	const struct bt_mesh_time_tai *sync = &srv->data.sync.status.tai;
	int64_t steps = (SUBSEC_STEPS * (uptime - srv->data.sync.uptime)) /
			MSEC_PER_SEC;
	uint64_t sec    = 0;				// @@@ Add
	uint64_t subsec = 0;				// @@@ Add

	if (tai_is_unknown(sync)) {
		return *sync;
	}

	// @@@ Delete
//	return (struct bt_mesh_time_tai) {
//		.sec = sync->sec + (steps / SUBSEC_STEPS),
//		.subsec = sync->subsec + steps,
//	};

	// @@@ Add
	subsec = sync->subsec + steps;
	sec    = sync->sec    + (subsec / SUBSEC_STEPS);

	if (subsec >= SUBSEC_STEPS) {
		subsec %= SUBSEC_STEPS;
	}

	return (struct bt_mesh_time_tai) {
		.sec    = sec   ,
		.subsec = subsec,
	};
}

devzone.nordicsemi.com/.../time_5F00_srv.c

Log:

[00:00:34.988,891] [00:00:34.988,922] <dbg> bt_mesh_time_srv: handle_time_set: tai subsec [00:00:34.988,922] <dbg> bt_mesh_time_srv: handle_time_set: uncertainty [00:00:34.988,952] <dbg> bt_mesh_time_srv: handle_time_set: tai_utc_delta [00:00:34.988,952] <dbg> bt_mesh_time_srv: handle_time_set: [00:00:34.988,983] <dbg> bt_mesh_time_srv: handle_time_set: is_authority [00:00:34.988,983] <dbg> bt_mesh_time_srv: handle_time_set: uptime [00:01:00.609,008] <dbg> bt_mesh_scheduler_srv: action_set: [00:01:00.609,100] <dbg> bt_mesh_scheduler_srv: schedule_action: [00:01:00.609,100] <dbg> bt_mesh_scheduler_srv: schedule_action: [00:01:00.609,100] <dbg> bt_mesh_scheduler_srv: schedule_action: [00:01:00.609,130] <dbg> bt_mesh_scheduler_srv: schedule_action: [00:01:00.609,130] <dbg> bt_mesh_scheduler_srv: schedule_action: [00:01:00.609,161] <dbg> bt_mesh_scheduler_srv: schedule_action: [00:01:00.609,161] <dbg> bt_mesh_scheduler_srv: schedule_action: [00:01:00.609,191] <dbg> bt_mesh_scheduler_srv: schedule_action: [00:01:00.609,252] <dbg> bt_mesh_scheduler_srv: schedule_action: [00:01:00.609,283] <dbg> bt_mesh_scheduler_srv: schedule_action: [00:01:00.609,283] <dbg> bt_mesh_scheduler_srv: schedule_action: [00:01:00.609,313] <dbg> bt_mesh_scheduler_srv: schedule_action: [00:01:00.609,313] <dbg> bt_mesh_scheduler_srv: schedule_action: [00:01:00.609,344] <dbg> bt_mesh_scheduler_srv: schedule_action: [00:01:00.609,344] <dbg> bt_mesh_scheduler_srv: schedule_action: [00:01:00.609,405] <dbg> bt_mesh_scheduler_srv: run_scheduler: [00:01:00.624,084] <dbg> bt_mesh_scheduler_srv: encode_action_status: [00:01:00.624,114] <dbg> bt_mesh_scheduler_srv: encode_action_status: [00:01:00.624,145] <dbg> bt_mesh_scheduler_srv: encode_action_status: [00:01:00.624,145] <dbg> bt_mesh_scheduler_srv: encode_action_status: [00:01:00.624,145] <dbg> bt_mesh_scheduler_srv: encode_action_status: [00:01:00.624,176] <dbg> bt_mesh_scheduler_srv: encode_action_status: [00:01:00.624,176] <dbg> bt_mesh_scheduler_srv: encode_action_status: [00:01:00.624,206] <dbg> bt_mesh_scheduler_srv: encode_action_status: [00:01:00.624,206] <dbg> bt_mesh_scheduler_srv: encode_action_status: [00:01:00.624,206] <dbg> bt_mesh_scheduler_srv: encode_action_status: [00:01:00.624,237] <dbg> bt_mesh_scheduler_srv: encode_action_status: [00:01:00.624,237] <dbg> bt_mesh_scheduler_srv: encode_action_status: [00:01:00.624,267] <dbg> bt_mesh_scheduler_srv: encode_action_status: [00:01:00.624,267] <dbg> bt_mesh_scheduler_srv: encode_action_status: [00:01:00.624,298] <dbg> bt_mesh_scheduler_srv: encode_action_status: [00:01:00.624,298] <dbg> bt_mesh_scheduler_srv: encode_action_status: [00:01:00.624,328] <dbg> bt_mesh_scheduler_srv: encode_action_status: [00:01:00.624,328] <dbg> bt_mesh_scheduler_srv: encode_action_status: [00:01:00.624,328] <dbg> bt_mesh_scheduler_srv: encode_action_status: [00:01:00.624,359] <dbg> bt_mesh_scheduler_srv: encode_action_status: [00:01:00.624,359] <dbg> bt_mesh_scheduler_srv: encode_action_status: [00:01:00.624,389] <dbg> bt_mesh_scheduler_srv: encode_action_status: [00:01:00.624,389] <dbg> bt_mesh_scheduler_srv: encode_action_status: [00:01:00.624,420] <dbg> bt_mesh_scheduler_srv: encode_action_status: [00:06:00.824,523] <dbg> bt_mesh_scheduler_srv: scheduled_action_handle: [00:06:00.824,584] <dbg> bt_mesh_scheduler_srv: scheduled_action_handle: [00:06:00.824,645] <dbg> bt_mesh_scheduler_srv: scheduled_action_handle: [00:06:00.824,645] <dbg> bt_mesh_scheduler_srv: scheduled_action_handle: [00:06:00.824,737] <dbg> bt_mesh_scheduler_srv: schedule_action: [00:06:00.824,737] <dbg> bt_mesh_scheduler_srv: schedule_action: [00:06:00.824,737] <dbg> bt_mesh_scheduler_srv: schedule_action: [00:06:00.824,768] <dbg> bt_mesh_scheduler_srv: schedule_action: [00:06:00.824,768] <dbg> bt_mesh_scheduler_srv: schedule_action: [00:06:00.824,798] <dbg> bt_mesh_scheduler_srv: schedule_action: [00:06:00.824,829] <dbg> bt_mesh_scheduler_srv: schedule_action: [00:06:00.824,829] <dbg> bt_mesh_scheduler_srv: schedule_action: [00:06:00.824,951] <dbg> bt_mesh_scheduler_srv: schedule_action: [00:06:00.824,951] <dbg> bt_mesh_scheduler_srv: schedule_action: [00:06:00.824,951] <dbg> bt_mesh_scheduler_srv: schedule_action: [00:06:00.824,981] <dbg> bt_mesh_scheduler_srv: schedule_action: [00:06:00.824,981] <dbg> bt_mesh_scheduler_srv: schedule_action: [00:06:00.825,012] <dbg> bt_mesh_scheduler_srv: schedule_action: [00:06:00.825,012] <dbg> bt_mesh_scheduler_srv: schedule_action: [00:06:00.825,073] <dbg> bt_mesh_scheduler_srv: run_scheduler:

<dbg> bt_mesh_time_srv: handle_time_set: tai sec         : 892473518822531 : 42 : 0 : 37 time_zone_offset: 36 : 0 : 34988 Rx: scheduler server action index 0 set, ack 1 Current uptime 60609 Current time: year: 125 month: 0 day: 7 hour: 16 minute: 29 second: 59 Scheduled time: year: 125 month: 0 day: 7 hour: 16 minute: 35 second: 0 Scheduler started. Target uptime: 360824. Current uptime: 60609. Tx: scheduler server action status: index: 0 year: 100 month: 0xfff day: 0 wday: 0x7f hour: 16 minute: 35 second: 0 action: 0 transition: 0 scene: 0 Tx: scheduler server action status: index: 0 year: 100 month: 0xfff day: 0 wday: 0x7f hour: 16 minute: 35 second: 0 action: 0 transition: 0 scene: 0 Scheduler action fired: 0 Onoff srv addr: 486 set: 0 Onoff srv addr: 487 set: 0 Onoff srv addr: 488 set: 0 Current uptime 360824 Current time: year: 125 month: 0 day: 7 hour: 16 minute: 35 second: 0 Scheduled time: year: 125 month: 0 day: 8 hour: 16 minute: 35 second: 0 Scheduler started. Target uptime: 86760824. Current uptime: 360825.

Could you please check and confirm?

RE: "scheduled_action_handle()" is executed many times

a.da — Mon, 06 Jan 2025 01:19:33 GMT

Hi Hung, thanks for your reply.

Was the problem showed in the first log that "scheduler server action status" is executed 2 times ?

I don't think executing it twice is a problem. It is because there are cases where "send_scheduler_action_status()" may be called twice when receiving a "Scheduler Action Set".
The first log was quoted to show the value of ”Current uptime” when receiving the "Scheduler Action Set".
scheduler_srv.c

static int action_set(const struct bt_mesh_model *model, struct bt_mesh_msg_ctx *ctx,
		      struct net_buf_simple *buf, bool ack)
{
	struct bt_mesh_scheduler_srv *srv = model->rt->user_data;
	uint8_t idx;
	struct bt_mesh_schedule_entry tmp = { 0 };

	scheduler_action_unpack(buf, &idx, &tmp);

	if (!scheduler_action_valid(&tmp, idx)) {
		return -EINVAL;
	}

	srv->sch_reg[idx] = tmp;
	LOG_DBG("Rx: scheduler server action index %d set, ack %d", idx, ack);

	if (srv->sch_reg[idx].action < BT_MESH_SCHEDULER_SCENE_RECALL ||
	   (srv->sch_reg[idx].action == BT_MESH_SCHEDULER_SCENE_RECALL &&
	    srv->sch_reg[idx].scene_number != 0)) {
		schedule_action(srv, idx);
		run_scheduler(srv);
	}

	if (srv->action_set_cb) {
		srv->action_set_cb(srv, ctx, idx, &srv->sch_reg[idx]);
	}

	if (IS_ENABLED(CONFIG_BT_SETTINGS)) {
		store(srv, idx, is_entry_defined(srv, idx));
	}

	if (is_entry_defined(srv, idx)) {
		/* publish state changing */
		send_scheduler_action_status(model, NULL, idx, false);
	}

	if (ack) { /* reply on the action set command */
		send_scheduler_action_status(model, ctx, idx, false);
	}

	return 0;
}

The Scheduler Server will delay the work by the difference between "Target uptime" and "Current uptime".
scheduler_srv.c

static void run_scheduler(struct bt_mesh_scheduler_srv *srv)
{
	struct tm sched_time;
	int64_t current_uptime = k_uptime_get();
	uint8_t planned_idx = get_least_time_index(srv);

	if (planned_idx == BT_MESH_SCHEDULER_ACTION_ENTRY_COUNT) {
		return;
	}

	tai_to_ts(&srv->sched_tai[planned_idx], &sched_time);
	int64_t scheduled_uptime = bt_mesh_time_srv_mktime(srv->time_srv,
			&sched_time);

	if (scheduled_uptime < 0) {
		LOG_WRN("Scheduler not started. Error: %lld.", scheduled_uptime);
		return;
	}

	srv->idx = planned_idx;
	k_work_reschedule(&srv->delayed_work,
			  K_MSEC(MAX(scheduled_uptime - current_uptime, 0)));
	LOG_DBG("Scheduler started. Target uptime: %lld. Current uptime: %lld.",
			scheduled_uptime, current_uptime);
}

However, when the work resumes, it seems to be behaving abnormally for the following reasons.

"Current uptime" exceeded "Target uptime".
"Current uptime" was converted to 10:54:59AM instead of 10:55:00AM.

Could you tell me how to reproduce the issue ? Which sample you based your test on ?

We are developing based on the Light fixture. We have added components such as the Scheduler Server and Time Server to the sample.
However, the smartphone app is developed in-house, and testing of the Scheduler Server cannot be performed within nRF Mesh App.

Is there anything else you need?

a.da

RE: "scheduled_action_handle()" is executed many times

Hung Bui — Fri, 27 Dec 2024 15:20:09 GMT

Hi A.da,

I'm not so familiar with the mesh scheduler server so you may need to explain the issue a little bit more clear.
Was the problem showed in the first log that "scheduler server action status" is executed 2 times ?

Could you tell me how to reproduce the issue ? Which sample you based your test on ?