Long Press Button Interrupt in NCS

RE: Long Press Button Interrupt in NCS

Edvin — Fri, 10 Jan 2025 08:32:34 GMT

[quote user="bhargav_gondaliya"]but it working when I change pin number of button. I have custom nrf52832 board and button is connected with reset pin. [/quote]

I am not sure I understand. If you configure the reset pin as a reset pin, then you will not get an event in the application. It will reset the chip immediately when the button is pressed. If it is not configured as a reset pin, it will work as a normal GPIO, P0.21.

I have not tested the zephyr long_press. I assume you can use it, but it probably does something similar to what you are already doing, using a timer to detect whether the pin has been held for an amount of time.

Best regards,

Edvin

RE: Long Press Button Interrupt in NCS

bhargav_gondaliya — Fri, 10 Jan 2025 05:27:01 GMT

Edvin , How can I implement long press on reset pin (according to schematic)? Is zephyr support dual functionality?

RE: Long Press Button Interrupt in NCS

bhargav_gondaliya — Thu, 09 Jan 2025 13:00:31 GMT

Thank you. It's also work for me. got print from button_timer_expiry_handler.

"Button long-pressed for 10 seconds\n"

but it working when I change pin number of button. I have custom nrf52832 board and button is connected with reset pin. I have attached a schematic of reset pin and button.

what will be pin configuration according to above image?? Is zephyr support dual functionality??

one more question is that can I use zephyr - long press instead of timer??
Sorry for the I shared lately about custom hardware.

RE: Long Press Button Interrupt in NCS

Edvin — Thu, 09 Jan 2025 09:43:53 GMT

Thank you. I believe my behavior was a bit different than yours, but we are running this on different hardware, so that may be why.

In my case, I was not able to trigger the interrupt, because I shorted the pin to a button pin, and your button_0 devicetree configuration didn't have a pullup. So first, I added this in your test.overlay:

    buttons {
        compatible = "gpio-keys";
        button0
        {
            gpios = <&gpio0 21 (GPIO_PULL_UP | GPIO_ACTIVE_LOW)>;
            label = "SW1";
        };
    };  
};

Then I changed your bsp_button_init() to trigger on both rising and falling edges (like you originally had when you created this ticket):

void bsp_button_init(){

    uint8_t ret;

    if(!device_is_ready(button_0.port)){
        LOG_INF("button init failed");
    }

    // configure button gpio as input
    ret = gpio_pin_configure_dt(&button_0, GPIO_INPUT);
    if (ret < 0) {
        return;
    }
    //ret = gpio_pin_interrupt_configure_dt(&button_0, GPIO_INT_EDGE_RISING);
    ret = gpio_pin_interrupt_configure_dt(&button_0, GPIO_INT_EDGE_BOTH);
    if (ret < 0) {
        return;
    }

}

And finally, I adjusted your long_button_pressed() callback to check the state of the pin, starting the timer only if it was pressed, and stopping the timer if it was not pressed (which would have been triggered by a release action):

void long_button_pressed(const struct device *dev, struct gpio_callback *cb, uint32_t pins)
{
   // if (gpio_pin_get_dt(&button_0)) {
    if(pins & BIT(button_0.pin)){
        int val = gpio_pin_get_dt(&button_0);
        LOG_INF("button pin detected %08x, val %d", pins, val);
        if (val == 1) { // if (val) { 
            k_timer_start(&button_timer, K_SECONDS(10), K_NO_WAIT);
            LOG_INF("Timer started");
        }
        else {
            k_timer_stop(&button_timer);
            long_press_detected = false;
            LOG_INF("Timer stopped");
        }
    }
}

Also added some logging in that callback, as you can see.

Please note:

For testing this is of course ok, but for HW specific .overlays, the "best practice" is to create a folder called boards in your application root folder, and then create an overlay file called "<board_name>.overlay" in there. This will automatically be picked up by the compiler.

For application specific overlays, the common practise is to have a file called "app.overlay". This should hold the devicetree configurations that are common for all boards. I'll add an empty nrf52840dk_nrf52840.overlay in a boards folder, just so that you see what I mean. But this is just formalities, and the way we do it in our samples. You decide how to build up your app.

devzone.nordicsemi.com/.../long_5F00_press_5F00_v2.zip

Give it a go, and let me know if it doesn't work.

Best regards,

Edvin

RE: Long Press Button Interrupt in NCS

bhargav_gondaliya — Thu, 09 Jan 2025 09:21:25 GMT

Hi, Edvin have you looked in the application?

RE: Long Press Button Interrupt in NCS

bhargav_gondaliya — Wed, 08 Jan 2025 18:53:00 GMT

devzone.nordicsemi.com/.../long_5F00_press.zip

Hi Edvin I have uploaded my application here, let me know if you faced any issue in test. it is without any sensitive information.

RE: Long Press Button Interrupt in NCS

Edvin — Wed, 08 Jan 2025 10:07:54 GMT

The easiest is probably to strip down your application so it can just reproduce your issue without having any sensitive information, and you can upload it here. So e.g. if you are able to reproduce the issue without the eeprom parts, then perhaps you can strip down that part, basically remaining only the components for the button, the timer, and see if it still fails. If so, you can upload it here. It shouldn't hold any sensitive information.

If you need to create a private ticket, that is pretty much the same way that you created this ticket, but I believe you need to fill your profile with a bit more information first. It should say what you need when you try to create a private ticket.

Best regards,

Edvin

RE: Long Press Button Interrupt in NCS

bhargav_gondaliya — Wed, 08 Jan 2025 05:29:53 GMT

Yes, that same timer including the eeprom parts.
how can I create new private issue? I will upload there.

RE: Long Press Button Interrupt in NCS

Edvin — Tue, 07 Jan 2025 13:59:35 GMT

Is that the exact same timer, with the exact same timeout handler? (including the eeprom parts)?

Again, if you upload your application, I can have a look.

Best regards,

Edvin

RE: Long Press Button Interrupt in NCS

bhargav_gondaliya — Tue, 07 Jan 2025 13:37:19 GMT

timer should be start when button press detected, if it is not pressed for 10 sec then timer should be stop.
If I start timer in main then it trigger the timeout handler.

RE: Long Press Button Interrupt in NCS

Edvin — Tue, 07 Jan 2025 13:06:04 GMT

ok. So then the question is, can you start the timer from main()? Does it trigger the timeout handler then?

BR,
Edvin

RE: Long Press Button Interrupt in NCS

bhargav_gondaliya — Tue, 07 Jan 2025 12:56:27 GMT

I have called long_press_button() from main

RE: Long Press Button Interrupt in NCS

Edvin — Tue, 07 Jan 2025 12:52:26 GMT

[quote user="bhargav_gondaliya"]Is pin configuration and button node is correct?
[/quote]

Looks ok, but I haven't tested it. If you want me to, please zip and upload the zipped application folder here.

But since you get the initial callback, I assume it is correct.

I would try to split up the application. I would say that you got the button handling working, so what remains is the timer and timeout handler.

What if you just start the timer from main(). Does the timeout handler get called then?

[quote user="Edvin Holmseth"]

And finally, is long_press_button() called at some point before all this?

[/quote]

Still not sure where you are calling the long_press_button() from.

Best regards,

Edvin

RE: Long Press Button Interrupt in NCS

bhargav_gondaliya — Tue, 07 Jan 2025 12:18:06 GMT

Hi, when button pressed single time long_button_pressed is called and got log of button pin detected.
unable to triggered "button_timer_expiry_handler".

neither "long_press not detected" printed nor button_timer_expiry_handler triggered.

basically, I want to implement feature like when button is pressed for 10 sec my device should be reset (button_timer_expiry_handler should be triggered automatically after 10 sec ).

I will try as you suggested

For debugging purposes, have you tried to comment out these two lines:

k_timer_stop(&button_timer);
long_press_detected = false; // Reset flag if button is released

Is pin configuration and button node is correct?

RE: Long Press Button Interrupt in NCS

Edvin — Tue, 07 Jan 2025 11:50:14 GMT

Hello,

Sorry for the late reply. Still working on the backlog from the christmas/new years break.

It was not clear to me which callback does what, only based on your snippets.

It is still not clear to me which callback that is triggered and which one that is not. Which is the one that is triggered on a (normal) button press (that is not long)?

[quote user="bhargav_gondaliya"] I am got LOG_INF("button pin detected"); from long_press_button callback.[/quote]

The "button pin detected" is from your long_button_pressed(), not long_press_button().

But if you see "button pin detected" in your log, it suggests that the long_button_pressed() was triggered, at least. And that it calls k_timer_start(). Is button_timer_expiry_handler() triggered at any point? Or is "long_press not detected" printed before the button_timer_expiry_handler() is triggered?

For debugging purposes, have you tried to comment out these two lines:

k_timer_stop(&button_timer);
long_press_detected = false; // Reset flag if button is released

And finally, is long_press_button() called at some point before all this?

Best regards,

Edvin

RE: Long Press Button Interrupt in NCS

bhargav_gondaliya — Tue, 07 Jan 2025 06:30:47 GMT

Hi,Edvin is there any solution about long press button?

RE: Long Press Button Interrupt in NCS

bhargav_gondaliya — Sat, 04 Jan 2025 09:02:26 GMT

Yes, I am able to enter in gpio interrupt callback. I am got LOG_INF("button pin detected"); from long_press_button callback.

RE: Long Press Button Interrupt in NCS

X4ce — Sat, 04 Jan 2025 08:57:01 GMT

Hi,

Are you able to enter in gpio interrupt callback?

Regards