nPM1300 LEDs not recognized by CAF LED module - "No LEDs defined" error

RE: nPM1300 LEDs not recognized by CAF LED module - "No LEDs defined" error

runsiv — Wed, 08 Jan 2025 09:31:25 GMT

Thanks for the update. I will pass the feedback on internally as I don't see any reason why it should be be added

Regards

Runar

RE: nPM1300 LEDs not recognized by CAF LED module - "No LEDs defined" error

Lowlanders — Wed, 08 Jan 2025 07:36:59 GMT

Hi, yes now I understand.
The core issue was that the CAF LED module isn't configured to work with the nPM1300's specific LED driver. It expects either PWM or GPIO-based LEDs, but the nPM1300 uses its own unique LED driver.

While modifying the CAF LED implementation could be a solution, I've decided to build a solution using Zephyr directly instead. This approach will bypass the CAF LED module entirely and utilize Zephyr's native LED APIs to interact with the nPM1300 LED driver.

It would still be beneficial if Nordic could update the LED module in future SDK versions to natively support the Nordic nPM1300 LED driver. This would simplify the integration of nPM1300 into projects using the CAF LED module for those who prefer to use it.

Thanks

RE: nPM1300 LEDs not recognized by CAF LED module - "No LEDs defined" error

runsiv — Wed, 08 Jan 2025 07:32:36 GMT

As Greg mentions above can you show the compiled DTS for the application?

It would also be in good to see how you get the device pointer

Regards

Runar

RE: nPM1300 LEDs not recognized by CAF LED module - "No LEDs defined" error

caeg — Tue, 07 Jan 2025 19:25:37 GMT

The condition of the assert in leds.c is:
DT_HAS_COMPAT_STATUS_OKAY(DT_DRV_COMPAT)

DT_DRV_COMPAT is #defined at the top of leds.c:

#ifdef CONFIG_CAF_LEDS_PWM
#define DT_DRV_COMPAT pwm_leds
#elif defined(CONFIG_CAF_LEDS_GPIO)
#define DT_DRV_COMPAT gpio_leds
#else
#error "LED driver must be specified in configuration"
#endif

I don't see any signs that you're using PWM LEDs so DT_DRV_COMPAT should likely be gpio_leds.

Search in your <build_dir>/zephyr/zephyr.dts file for nodes with compatible = "gpio-leds" -- does one exist and have status = "okay"? That's what the DT_HAS_COMPAT_STATUS_OKAY macro is testing for.

RE: nPM1300 LEDs not recognized by CAF LED module - "No LEDs defined" error

Lowlanders — Tue, 07 Jan 2025 15:44:44 GMT

Hi,
the version of ncs is v2.8.0.

Yes there are the pull ups at SDA/SCL. The nPM1300 is working great.

I can use the LEDs connected to the nPM1300 by using Zephyr's LED driver.
But with the CAF LED driver it seems not to work. I've just modified the nRF Desktop App.

.........
from C:/ncs/v2.8.0/nrf/subsys/caf/modules/leds.c:7:
C:/ncs/v2.8.0/nrf/subsys/caf/modules/leds.c: In function 'leds_init':
C:/ncs/v2.8.0/zephyr/include/zephyr/toolchain/gcc.h:87:36: error: static assertion failed: "No LEDs defined"
   87 | #define BUILD_ASSERT(EXPR, MSG...) _Static_assert((EXPR), "" MSG)
      |                                    ^~~~~~~~~~~~~~
C:/ncs/v2.8.0/nrf/subsys/caf/modules/leds.c:182:9: note: in expansion of macro 'BUILD_ASSERT'
182 |         BUILD_ASSERT(DT_HAS_COMPAT_STATUS_OKAY(DT_DRV_COMPAT) > 0, "No LEDs defined");
      |         ^~~~~~~~~~~~
[288/368] Building C object modules/hal_nordic/nrfx/CMakeFiles/modules__hal_nordic__nrfx.dir/C_/ncs/v2.8.0/modules/hal/nordic/nrfx/drivers/src/nrfx_gpiote.c.obj
ninja: build stopped: subcommand failed.

RE: nPM1300 LEDs not recognized by CAF LED module - "No LEDs defined" error

runsiv — Tue, 07 Jan 2025 14:02:31 GMT

I will look into your issue. On the first glance your overlay looks fine to me.

Do you have pull ups on the I2C pins?

It would also be great if you can post the entire build error and which version of NCS you are using. Just to save some time you can also upload your application if you are using the nrf5340dk and I can test on my end

Regards

Runar