BLE Advertising module still uses pstorage in SDK 11?

RE: BLE Advertising module still uses pstorage in SDK 11?

Vidar Berg — Fri, 13 May 2016 10:37:36 GMT

Good. Have reported it to the team so it should be fixed in SDK 12

RE: BLE Advertising module still uses pstorage in SDK 11?

Eliot Stock — Fri, 13 May 2016 10:34:58 GMT

Thank you. I'll patch it for now and hope to see a fix in SDK 12.

RE: BLE Advertising module still uses pstorage in SDK 11?

Vidar Berg — Fri, 13 May 2016 10:33:51 GMT

Yes, this is a SDK bug.

RE: BLE Advertising module still uses pstorage in SDK 11?

Eliot Stock — Fri, 13 May 2016 09:00:57 GMT

But it's not in my code. It's not even in the example project's code. It's your code - it's in the SDK. It's ble_advertising.c L185. Are you saying it's an SDK bug?

RE: BLE Advertising module still uses pstorage in SDK 11?

Vidar Berg — Fri, 13 May 2016 07:55:58 GMT

rewrote my answer, hope it is more clear now. The short answer is that you can remove any reference to pstorage in your code.

RE: BLE Advertising module still uses pstorage in SDK 11?

Eliot Stock — Thu, 12 May 2016 15:42:25 GMT

Not clear, sorry. The BLE advertising module does still use pstorage in SDK 11, yes? So if I want to use the Peer Manager and advertise, I must use both pstorage and pstorage in the one project?

RE: BLE Advertising module still uses pstorage in SDK 11?

Vidar Berg — Thu, 12 May 2016 11:28:55 GMT

Hi,

Pstorage does not need to be linked in when using fstorage, and should have been removed from the SDK examples using peer manager / fstorage (reported as bug internally). The problem lays in the flash_access_in_progress() function which uses both fstorage and pstorage API to check for pending flash operations:

static bool flash_access_in_progress()
{
uint32_t err_code;
uint32_t count = 0;

// Will always return NRF_ERROR_INVALID_STATE since pstorage is not initialized
err_code = pstorage_access_status_get(&count);
if ((err_code != NRF_ERROR_INVALID_STATE) && (err_code != NRF_SUCCESS))
{
    ADV_LOG("[ADV]: pstorage_access_status_get returned %d.\r\n", err_code);
    return true;
}

if (err_code == NRF_ERROR_INVALID_STATE)
{
    err_code = fs_queued_op_count_get(&count);
    if (err_code != FS_SUCCESS)
    {
        return false;
    }
    ADV_LOG("[ADV]: fs_queued_op_count_get gives count %d.\r\n", count);
}

if(count != 0)
{
    return true;
}
else
{
    return false;
}
}

But the pstorage call won't have any effect since it is not initialized and therefore safe to remove:

static bool flash_access_in_progress()
{
   uint32_t err_code;
   uint32_t count = 0;

   err_code = fs_queued_op_count_get(&count);
   if (err_code != FS_SUCCESS)
   {
       return false;
   }
   ADV_LOG("[ADV]: fs_queued_op_count_get gives count %d.\r\n", count);


  if(count != 0)
  {
      return true;
   }
   else
   {
      return false;
   }
}

Note that fstorage and pstorage are not designed to co-exist in the same project so the advertising module should either use pstorage_access_status_get() or fs_queued_op_count_get depending on what module is used in the application, but not both (wasting memory).