Radio notification init problem

RE: Radio notification init problem

codezork — Wed, 17 Aug 2016 21:43:30 GMT

Thank you for clarifying this.

RE: Radio notification init problem

Susheel Nuguru — Wed, 17 Aug 2016 06:57:52 GMT

There was a bug in the older versions of CMSIS core_cm0.h which was fixed (i dont know which version it was fixed, download the latest)

The new implemenation shows that masking is done correctly with 0XFF (not 0XF which you opted in your code) below is the code from newer core_cm0.h file

__STATIC_INLINE uint32_t NVIC_GetPriority(IRQn_Type IRQn)
{

  if ((int32_t)(IRQn) < 0)
  {
    return((uint32_t)(((SCB->SHP[_SHP_IDX(IRQn)] >> _BIT_SHIFT(IRQn) ) & (uint32_t)0xFFUL) >> (8U - __NVIC_PRIO_BITS)));
  }
  else
  {
    return((uint32_t)(((NVIC->IP[ _IP_IDX(IRQn)] >> _BIT_SHIFT(IRQn) ) & (uint32_t)0xFFUL) >> (8U - __NVIC_PRIO_BITS)));
  }
}

RE: Radio notification init problem

codezork — Mon, 15 Aug 2016 18:56:46 GMT

IMHO you must change nrf_nvic.h for SDK11 to:

static inline uint32_t sd_nvic_EnableIRQ(IRQn_Type IRQn)
{
  if (!__sd_nvic_app_accessible_irq(IRQn))
  {
    return NRF_ERROR_SOC_NVIC_INTERRUPT_NOT_AVAILABLE;
  }
  if (!__sd_nvic_is_app_accessible_priority(NVIC_GetPriority(IRQn)&0xF))
  {
    return NRF_ERROR_SOC_NVIC_INTERRUPT_PRIORITY_NOT_ALLOWED;
  }

  if (nrf_nvic_state.__cr_flag)
  {
    nrf_nvic_state.__irq_masks[(uint32_t)((int32_t)IRQn) >> 5] |= (uint32_t)(1 << ((uint32_t)((int32_t)IRQn) & (uint32_t)0x1F));
  }
  else
  {
    NVIC_EnableIRQ(IRQn);
  }
  return NRF_SUCCESS;
}

After this change ble_radio_notification.c works properly on a nrf51.

RE: Radio notification init problem

codezork — Mon, 15 Aug 2016 17:46:27 GMT

Thank you for your quick answer. I forgot to say that I am working on a nrf51422 which is Cortex-M0 based. And my core_cm0.h file looks like this:

__STATIC_INLINE uint32_t NVIC_GetPriority(IRQn_Type IRQn)
{

  if(IRQn < 0) {
    return((uint32_t)((SCB->SHP[_SHP_IDX(IRQn)] >> _BIT_SHIFT(IRQn) ) >> (8 - __NVIC_PRIO_BITS)));  } /* get priority for Cortex-M0 system interrupts */
  else {
    return((uint32_t)((NVIC->IP[ _IP_IDX(IRQn)] >> _BIT_SHIFT(IRQn) ) >> (8 - __NVIC_PRIO_BITS)));  } /* get priority for device specific interrupts  */
}

RE: Radio notification init problem

Susheel Nuguru — Mon, 15 Aug 2016 10:48:22 GMT

for me in core_cm4.h file it shows like below

There is no _BIT_SHIFT here. Are you having correct CMSIS files