[bug report] SDK v12 C++ issue in peer_manager_types declaration

RE: [bug report] SDK v12 C++ issue in peer_manager_types declaration

Susheel Nuguru — Fri, 16 Sep 2016 08:47:33 GMT

Technically this is not a bug, as SDK only supports C99 compilers officially for now. But we cannot ignore other compiler users, so I updated list in SDK11 and SDK12 known issues with this thread

RE: [bug report] SDK v12 C++ issue in peer_manager_types declaration

Susheel Nuguru — Tue, 13 Sep 2016 07:20:55 GMT

hi Patrice, this could be an oversight, i will inform the designer to change it but i cannot create any ticket on it. I hope this is ok.

update:

just talked to the developer and he will change this member to data[1];

RE: [bug report] SDK v12 C++ issue in peer_manager_types declaration

Patrice Rudaz — Tue, 13 Sep 2016 07:16:37 GMT

Thanks Aryan for your comment... By the way, you Nordic guys have changed this in the header files of the SoftDevice API (ble_gattc.h, ble_gatts.h & ble_l2cap.h) from SDK10 to SDK11 in the same way I did here for the peer_manager module. That's why I thought it was an oversight...

RE: [bug report] SDK v12 C++ issue in peer_manager_types declaration

Susheel Nuguru — Mon, 12 Sep 2016 07:01:37 GMT

It seems like this is C99 feature only. Some compilers might optionally add this feature but it seems not so common. Peer manager header files did not add support for CPP by adding#ifdef __cplusplus`, so they are not compiled and tested with any CPP compilers.

RE: [bug report] SDK v12 C++ issue in peer_manager_types declaration

Patrice Rudaz — Fri, 09 Sep 2016 06:00:18 GMT

Yes of course @Keton, we can set it as a pointer... I've fixed this problem with an array of 1 element just to respect you way it's done in all other header's files, like ble_gattc.h.

RE: [bug report] SDK v12 C++ issue in peer_manager_types declaration

Keton — Thu, 08 Sep 2016 19:00:38 GMT

It may be my poor understanding of C but wasn't it meant for data to be an array pointer so it should corrected to uint8_t* data?