Reinitializing advertising packet stops scanner?

RE: Reinitializing advertising packet stops scanner?

KasemC — Sat, 04 Mar 2017 19:25:20 GMT

The line where the application was failing is in is_manuf_data_present() function call here:

memcmp(adv_data, manuf_data, manuf_data_length).

The problem was that I didnt pass address in memcmp of the both adv_data and manuf_data values.

Just for clarification the function is supposed to be written as:

memcmp(&adv_data, &manuf_data, manuf_data_length)

RE: Reinitializing advertising packet stops scanner?

Jørgen Holmefjord — Fri, 03 Mar 2017 10:35:26 GMT

Could you debug your application, as described here, to see exactly on which line your application is failing? Have you checked the data in the advertising packet to see that you have the fields you expect? As there are not softdevice calls inside the is_manuf_data_present() function, most likely your application is trying to access an index out of range in one the array or something similar.

RE: Reinitializing advertising packet stops scanner?

KasemC — Thu, 02 Mar 2017 16:55:51 GMT

yeah it's failing when processing the advertising packet, here's a code of the central looks at the manuf data and compares it:

uint32_t              err_code;
const ble_gap_evt_t * p_gap_evt = &p_ble_evt->evt.gap_evt;
/* When the scanner recieves an advertisement packet, it will return it in a BLE_GAP_EVT_aDV_REPORT event to the application. */ 
	uint8_t string = 120; 
	uint8_t manuf_data_length; 
	uint8_t * manuf_data = 0;
	char * device_name; 
	switch (p_ble_evt->header.evt_id)
{
    case BLE_GAP_EVT_ADV_REPORT:
			{
        const ble_gap_evt_adv_report_t * p_adv_report = &p_gap_evt->params.adv_report; /* Contains the adv report */ 
				//	if (is_uuid_present(&m_pressure_uuid, p_adv_report))
						if(is_device_name_present(DEVICE_NAME, 7, p_adv_report)) 
						{
							if(is_manuf_data_present(manuf_data, 8, p_adv_report))
							{ 
                                          err_code = sd_ble_gap_connect(&p_adv_report->peer_addr,
                                          &m_scan_params,
                                          &m_connection_param);

            if (err_code == NRF_SUCCESS)
            {
                // scan is automatically stopped by the connect
                err_code = bsp_indication_set(BSP_INDICATE_IDLE);
                APP_ERROR_CHECK(err_code);
            }
							n_periph += 1;
        //}
					//else{
					// code here to specifically connect to devices based on their timestamp
					}
				}
       break;
    }

this is the code of the is_manuf_data_present function:

     static bool is_manuf_data_present(uint8_t * manuf_data, uint8_t manuf_data_length, const ble_gap_evt_adv_report_t *p_adv_report)
  {
  uint32_t err_code;
  uint32_t index = 0;
  uint8_t *p_data = (uint8_t *)p_adv_report->data;
  uint8_t adv_data_length; 
 uint8_t * adv_data;

while (index < p_adv_report->dlen)
{
    uint8_t field_length = p_data[index];
    uint8_t field_type   = p_data[index+1];

			if (field_type == BLE_GAP_AD_TYPE_MANUFACTURER_SPECIFIC_DATA)
    {
        adv_data_length = field_length-1;
					memcpy(&adv_data, &p_data[index+4], adv_data_length-2) ;
					usb_printf("Manuf data:%08x length: %d\r\n", adv_data, adv_data_length);
			//	LED2_ON(); 
					if((adv_data_length == (manuf_data_length+2)) && (!memcmp(adv_data, manuf_data, manuf_data_length))){						            
						return true;
					}
    }
    index += field_length+1;
}
return false;

}

RE: Reinitializing advertising packet stops scanner?

Jørgen Holmefjord — Thu, 02 Mar 2017 15:28:54 GMT

None of this code shows where your application is failing. It sounds like your central is failing when it process the received advertising packet. Could you post code of how you are looking at the manufacturer data of the advertising packet? The central should not "remember" anything about the peripheral, unless you have performed bonding, and nothing related to advertising whatsoever.

RE: Reinitializing advertising packet stops scanner?

KasemC — Wed, 01 Mar 2017 23:30:37 GMT

sorry for the late reply, here's a screenshot of my code on the peripheral side in main while loop:

while(true){
	if(disconnected){
		err_code = sd_ble_gap_adv_stop(); //SD_BLE_GAP_ADV_STOP
		APP_ERROR_CHECK(err_code);
		reintialise_ble_adv_packet();
		err_code = ble_advertising_start(BLE_ADV_MODE_FAST);
		APP_ERROR_CHECK(err_code);
		disconnected = false;
	}

} and here's where I disconnect in response to the message 150 in the scanner:

    case BLE_PRESSURE_C_EVT_RX_EVT:  
					//usb_printf("Received over BLE: %f\r\n", *((float*)(p_ble_pressure_evt->p_data))); 
				//usb_printf("Received over BLE with reference %d", p_ble_pressure_evt->p_data[0]);
				if(p_ble_pressure_evt->p_data[0] == 100){
					usb_send_message(p_ble_pressure_evt->p_data[0], &p_ble_pressure_evt->p_data[1], p_ble_pressure_evt->data_len - 1); }
					else if( p_ble_pressure_evt->p_data[0] == 150) {
						//usb_printf("Periph received TimeStamp\r\n");
						err_code = sd_ble_gap_disconnect(m_ble_pressure_c.conn_handle, BLE_HCI_REMOTE_USER_TERMINATED_CONNECTION);
						
						APP_ERROR_CHECK(err_code);
						usb_printf("Periph received TimeStamp,disconnect err_code: %d\r\n", err_code);
						connected = false; 
					}
					else{ // for other types of messages 
					//stream_all_64_values(p_ble_pressure_evt);
					//stream_2_values(p_ble_pressure_evt);
					stream_Cext_C2_C15_C30_temp_values(p_ble_pressure_evt);
				}
				break;

The err code from discconnect is an NRF_SUCCESS, when the scanner detects a disconnect event on the ble event handler it does a scan_start as shown below:

	case	BLE_GAP_EVT_DISCONNECTED:
		p_ble_pressure_c->conn_handle = BLE_CONN_HANDLE_INVALID; 
		printf("Disconnected"); 
		scan_start(); 
		break;

RE: Reinitializing advertising packet stops scanner?

Jørgen Holmefjord — Thu, 23 Feb 2017 08:17:11 GMT

Can you post the code of what you are doing in the code when it fails?

RE: Reinitializing advertising packet stops scanner?

KasemC — Wed, 22 Feb 2017 17:57:00 GMT

The error code of softdevice calls on peripheral are NRF_SUCCESS and on the scanner, the softdevice call is diconnect returns an NRF_SUCCESS, after disconnection it does a scan strat again anf the error_code for that iis also an NRF_SUCCESS.

I tired debugging my application using LED's to see where it fails. The application fails ehen examining the manuf data of peripheral. So it sees the adv packet and extracts its content then fails.

RE: Reinitializing advertising packet stops scanner?

Jørgen Holmefjord — Wed, 22 Feb 2017 15:06:28 GMT

Are you checking all error codes from softdevice calls? Have you tried debugging your application to see where your application is crashing?