nRF52840 TWIM

RE: nRF52840 TWIM

jlz — Mon, 14 Aug 2017 09:29:51 GMT

No need for any trace when the signal are low.

RE: nRF52840 TWIM

MartinBL — Fri, 07 Jul 2017 14:50:25 GMT

Regarding GPIO configs I haven't changed anything.

Are you able to upload a logic trace?

RE: nRF52840 TWIM

jlz — Fri, 07 Jul 2017 09:34:22 GMT

Sill waiting for answers. One note in your picture where you send 0xAA but is not in your code. It could be the random data from RAM.

RE: nRF52840 TWIM

jlz — Wed, 05 Jul 2017 11:51:08 GMT

EDIT: Yes I know about the differences between TWI and TWIM.

Because the TWI do not describe any STOP and START conditions that are vital for I2C I then borrowed that was closes to the part I needed from TWIM. This is a guess because chapter 48 do not describe anything about this. Even if I use TWIM with DMA it should work but it does not, How about your GPIO_PIN_CONF?

RE: nRF52840 TWIM

MartinBL — Wed, 05 Jul 2017 10:54:18 GMT

I have added another edit.

RE: nRF52840 TWIM

jlz — Wed, 05 Jul 2017 07:30:17 GMT

No luck with the drive strength changes and TXD works so I think this part is Ok. So I'm stuck right now but I have two questions to you. And basically because your example is DMA for sure and my thread is about non-DMA.

Have you setup anything prior to this e.g. DMA configuration?
What have you set on the GPIO configuration (PIN_CONF) for your I2C pins?

RE: nRF52840 TWIM

jlz — Tue, 04 Jul 2017 15:59:30 GMT

Yes I did test the setup with a I2C-USB cable connected to the SDOF stick, so I know that I have the right device address. I have not setup any Nordic environment so I cannot test your test code.

In my case with your code converted to my source I do not get anything more then low pins.

I will try to change the drive strength but in my first code example TXD worked!?

RE: nRF52840 TWIM

MartinBL — Tue, 04 Jul 2017 13:36:19 GMT

Please see the edit in my previous answer. Also, have you tried the twi_scanner example in the SDK? It is useful for making sure that everything is wired correctly and working properly. It will also show you what address to use in your code.

RE: nRF52840 TWIM

jlz — Tue, 04 Jul 2017 13:04:31 GMT

It did not work. The interface pins goes low when master mode is enabled and that’s it, nothing more.

Just to make sure I did it right I give you the change below including the defines.

// register map
#define I2C_STARTRX_REG		0x0000
#define I2C_STARTTX_REG		0x0008
#define I2C_STOP_REG		0x0014
#define I2C_SUSPEND_REG		0x001C
#define I2C_RESUME_REG		0x0020
#define I2C_STOPPED_REG		0x0104
#define I2C_RXDREADY_REG	0x0108
#define I2C_TXSENT_REG		0x010C
#define I2C_ERROR_REG		0x0124
#define I2C_BB_REG			0x0138
#define I2C_SUSPENDED_REG	0x0148
#define I2C_RXSTARTED_REG	0x014C
#define I2C_TXSTARTED_REG	0x0150
#define I2C_LASTRX_REG		0x015C
#define I2C_LASTTX_REG		0x0160
#define I2C_SHORT_REG		0x0200
#define I2C_INTENSET_REG	0x0304
#define I2C_INTENCLR_REG	0x0308
#define I2C_ERRORSRC_REG	0x04C4
#define I2C_ENABLE_REG		0x0500
#define I2C_PSEL_SCL_REG	0x0508
#define I2C_PSEL_SDA_REG	0x050C
#define I2C_RXD_REG		0x0518
#define I2C_TXD_REG		0x051C
#define I2C_FREQUENCY_REG	0x0524
#define I2C_RXD_PTR_REG		0x0534
#define I2C_RXD_MAXCNT_REG	0x0538
#define I2C_RXD_AMOUNT_REG	0x053C
#define I2C_RXD_LIST_REG	0x0540
#define I2C_TXD_PTR_REG		0x0544
#define I2C_TXD_MAXCNT_REG	0x0548
#define I2C_TXD_AMOUNT_REG	0x054C
#define I2C_TXD_LIST_REG	0x0550
#define I2C_ADDRESS_REG		0x0588

output_32( USED_I2C_BLOCK+I2C_ENABLE_REG, 0 );

output_32( USED_I2C_BLOCK+I2C_SHORT_REG, (1<<12) | (1<<9) );

output_32( USED_I2C_BLOCK+I2C_ADDRESS_REG, (SlaveAddress<<1) );

output_32( USED_I2C_BLOCK+I2C_TXD_PTR_REG, 0x20021000 );
output_32( USED_I2C_BLOCK+I2C_TXD_MAXCNT_REG, 1 );

output_32( USED_I2C_BLOCK+I2C_RXD_PTR_REG, 0x20020000 );
output_32( USED_I2C_BLOCK+I2C_RXD_MAXCNT_REG, DataBufferSize );

output_32( USED_I2C_BLOCK+I2C_ENABLE_REG, 1 );

output_32( USED_I2C_BLOCK+I2C_LASTTX_REG, 1 );

output_32( USED_I2C_BLOCK+I2C_STARTTX_REG, 1 );

// Wait for TX to complete
TIMER_Timer_Delay( 100000 );

output_32( USED_I2C_BLOCK+I2C_STARTRX_REG, 1 );

RE: nRF52840 TWIM

jlz — Tue, 04 Jul 2017 12:21:14 GMT

Yes the output/input works (used for 20 years, no change ;)

I’m not using DMA and I guess that you do not need to set the pointer to TX/RX and directly read from the TXD/RXD. Also the chapter without DMA do not describe this part.

No the controller do not add the READ bit so I have to add it. I shift the slave address because it’s an 7-bit address.

I will try your approach because it’s more simple then my more complex implementation. If everything are handle in hardware I do not have to do it manually that I’m currently doing now.

If you need more info or missing defines I can add them to the thread.

RE: nRF52840 TWIM

MartinBL — Tue, 04 Jul 2017 10:39:34 GMT

Hi,

Assuming that your output_32() function is bug free;

Are you sure it is necessary to left shift the slave address?
Do you really need to add 1 to the address when reading from a slave? The TWI module takes care of that.
Where do you set the TX and RX buffer?

Here is one way to use do a "bare bone" TX/RX transfer:

static void twi_transfer()
{
    NRF_TWIM0->ENABLE = TWIM_ENABLE_ENABLE_Disabled << TWIM_ENABLE_ENABLE_Pos;
    NRF_TWIM0->SHORTS = (TWIM_SHORTS_LASTTX_STOP_Enabled << TWIM_SHORTS_LASTTX_STOP_Pos) | 
                        (TWIM_SHORTS_LASTRX_STOP_Enabled << TWIM_SHORTS_LASTRX_STOP_Pos);
    
    
    NRF_TWIM0->PSEL.SCL = MPU_TWI_SCL_PIN;
    NRF_TWIM0->PSEL.SDA = MPU_TWI_SDA_PIN;
    NRF_TWIM0->FREQUENCY = TWI_FREQUENCY_FREQUENCY_K400;
    NRF_TWIM0->ADDRESS = MPU_ADDRESS;
    
    NRF_TWIM0->TXD.PTR = (uint32_t)&p_tx_buffer;
    NRF_TWIM0->TXD.MAXCNT = 1;
    
    NRF_TWIM0->RXD.PTR = (uint32_t)&p_rx_buffer;
    NRF_TWIM0->RXD.MAXCNT = 1;
    
    NRF_TWIM0->ENABLE = TWIM_ENABLE_ENABLE_Enabled << TWIM_ENABLE_ENABLE_Pos;
    
    NRF_TWIM0->EVENTS_LASTTX = 0;
    NRF_TWIM0->TASKS_STARTTX = 1;
    
    // Wait for TX to complete
    nrf_delay_us(100);
    
    NRF_TWIM0->TASKS_STARTRX = 1;
}

You can also use:

NRF_TWIM0->SHORTS = (TWIM_SHORTS_LASTTX_STARTRX_Enabled << TWIM_SHORTS_LASTTX_STARTRX_Pos)

To start an RX immediately after the TX is completed.

I don't know what is going on inside output_32(), but you seem to know how to use register base addresses and register offsets, so I think the above code should be easy for you to port.

EDIT: The above code will produce the following action on the TWI bus:

You can see that the TWI module takes care of left shifting of your 7-bit address and adds the READ bit automatically.

EDIT 2: I have reviewed the case again and noticed a few more things that I didn't see initially:

Since you talk about DMA and use the I2C_TXD_MAXCNT_REG register, but at the same time also talk about using TRD/TXD registers directly it sounds like you are cherry picking features from the legacy TWI module and the new TWIM module.

The legacy TWI module is basically "copy-pasted" hardware from the nRF51. It has a lot less features than the new module in nRF52. It does not have any DMA features for example. If you want to use the legacy module and use TXD/RXD registers directly you can only use the features available in this particular module. Legacy TWI documentation. With the legacy module you will have to update the TXD register for every byte you want to send.
The new module in nRF52 is an extension of the legacy module and hence shares some of the same registers. If you want to use DMA you will have to use the features documented here and you cannot use RXD/TXD directly.