C++ compilation error using CLI with SDK 14: error: expected declaration before '}' token

RE: C++ compilation error using CLI with SDK 14: error: expected declaration before '}' token

Jakub Rzeszutko — Mon, 04 Mar 2019 10:27:30 GMT

Problem fixed. Answer in this thread.

RE: C++ compilation error using CLI with SDK 14: error: expected declaration before '}' token

Jakub Rzeszutko — Mon, 04 Mar 2019 09:45:56 GMT

Hi,

Please find attached a solution, this should be available in the next SDK release.

The main difference is in macro resposible for creating subcommands . When using C++ compiler subcommands shall be created with macro: NRF_CLI_CPP_CREATE_STATIC_SUBCMD_SET.

C++ syntax looks following:

// C++ and C syntax

NRF_CLI_CPP_CREATE_STATIC_SUBCMD_SET(m_sub_print,                                                                       
    NRF_CLI_CMD(all,   NULL, "Print all entered parameters.", cmd_print_all),                                           
    NRF_CLI_CMD(param, NULL, "Print each parameter in new line.", cmd_print_param),                                     
    NRF_CLI_SUBCMD_SET_END                                                                                        
);

While old C syntax was:

/* C only syntax */
NRF_CLI_CREATE_STATIC_SUBCMD_SET(m_sub_print)                                                                            
{                                                                                                                        
    NRF_CLI_CMD(all,   NULL, "Print all entered parameters.", cmd_print_all),                                            
    NRF_CLI_CMD(param, NULL, "Print each parameter in new line.", cmd_print_param),                                      
    NRF_CLI_SUBCMD_SET_END                                                                                               
};

Please find attached new nrf_cli.h and C++ file with example commands.

devzone.nordicsemi.com/.../cli.zip

nrf_cli.h can be compiled either by C or C++ compiler.

RE: C++ compilation error using CLI with SDK 14: error: expected declaration before '}' token

Jakub Rzeszutko — Wed, 23 Jan 2019 06:59:51 GMT

No,

All files including nrf_cli.h must be compiled with C compiler.

RE: C++ compilation error using CLI with SDK 14: error: expected declaration before '}' token

wtan — Wed, 23 Jan 2019 06:33:54 GMT

I'm encountering this issue myself also. Do you have a solution for this?

RE: C++ compilation error using CLI with SDK 14: error: expected declaration before '}' token

Jakub Rzeszutko — Mon, 04 Sep 2017 08:31:43 GMT

Good to read that :).

Please only keep in mind when using CLI from SDK13.1 that nrf_cli_fprintf will not work correctly for very long strings (exceeding NRF_CLI_PRINTF_BUFF_SIZE) . In such case you will need to split the message.

RE: C++ compilation error using CLI with SDK 14: error: expected declaration before '}' token

schef — Mon, 04 Sep 2017 08:22:13 GMT

On my surprise using cli from SDK13.1 works out of the box. Until then i'm happy with this solution.

RE: C++ compilation error using CLI with SDK 14: error: expected declaration before '}' token

Jakub Rzeszutko — Fri, 01 Sep 2017 08:39:36 GMT

Hi,

Unfortunatelly I am not able to prepare any quick solution for macros which would work. The only recommendation I have for now is to have to add extra file which will wrap C++ class functions to C.

RE: C++ compilation error using CLI with SDK 14: error: expected declaration before '}' token

Jakub Rzeszutko — Wed, 30 Aug 2017 11:25:20 GMT

I am currently working on C++ version of these macros. I will let you know once I will finish (and if I will be able to do it ;) ). Command declaration will be a bit different but you will not need so much manual work.

RE: C++ compilation error using CLI with SDK 14: error: expected declaration before '}' token

Jakub Rzeszutko — Wed, 30 Aug 2017 10:12:22 GMT

You don't need so many files.

The easiest solution which come to my mind is that you can create something like: cmd_api.cpp and cmd_api.h. You can collect there all class functions and "translate" them to C form (unpack from class).

Next you can include cmd_api.h to C file where you will be adding commands with CLI macros.

In SDK 14 you shall be able to use CLI from SDK13.1 but it will require some effort to migrate it. And you will have all limitations of old console.

RE: C++ compilation error using CLI with SDK 14: error: expected declaration before '}' token

schef — Wed, 30 Aug 2017 10:04:34 GMT

Would it be possible to use CLI from the SDK13,1? This module worked.

RE: C++ compilation error using CLI with SDK 14: error: expected declaration before '}' token

schef — Wed, 30 Aug 2017 09:52:20 GMT

I use Classes. So i would have to write a C implementation for every function i would want to call. I will make some testing and response what works for me.

RE: C++ compilation error using CLI with SDK 14: error: expected declaration before '}' token

Jakub Rzeszutko — Wed, 30 Aug 2017 08:41:31 GMT

It is not so easy. For sure you will be not able to use macro: NRF_CLI_CREATE_STATIC_SUBCMD_SET inside C++ file. there is const variable declaration and next its initialization what is not allowed in C++.

Is it a kind of big problem to implement commands in C file?

RE: C++ compilation error using CLI with SDK 14: error: expected declaration before '}' token

schef — Wed, 30 Aug 2017 08:37:06 GMT

Ok. But that still doesnt help me to call c++ commands directly. Maybe just to make the init in the C file and then registring the commands and subcommands in the c++ file.

RE: C++ compilation error using CLI with SDK 14: error: expected declaration before '}' token

Jakub Rzeszutko — Wed, 30 Aug 2017 08:05:55 GMT

Yes.

In main.cpp I am only using these 3 functions (handling CLI):

extern "C" {
extern void cli_start(void);
extern void cli_init(void);
extern void cli_process(void);
}

I've created file cli.c where I moved all CLI related stuff. Inside cli.c I have implemented above functions. Now main.cpp is compiled with g++ and cli.c with gcc.

RE: C++ compilation error using CLI with SDK 14: error: expected declaration before '}' token

schef — Wed, 30 Aug 2017 07:52:56 GMT

What do you mean by working fine? Was is usable?

RE: C++ compilation error using CLI with SDK 14: error: expected declaration before '}' token

Jakub Rzeszutko — Tue, 29 Aug 2017 12:36:58 GMT

One more possible solution came to my mind. I will test it during the week. All CLI related functions/macros shall be in C file. I will remove them from main and add one more c file to the example.

RE: C++ compilation error using CLI with SDK 14: error: expected declaration before '}' token

Jakub Rzeszutko — Tue, 29 Aug 2017 12:03:39 GMT

I can't find a solution to compile CLI under C++ compiler. Maybe a workaround would be to add CLI as precompiled library to c++ project.

RE: C++ compilation error using CLI with SDK 14: error: expected declaration before '}' token

schef — Tue, 29 Aug 2017 10:01:58 GMT

Yes i saw alot of macros inside.

RE: C++ compilation error using CLI with SDK 14: error: expected declaration before '}' token

Jakub Rzeszutko — Tue, 29 Aug 2017 09:28:13 GMT

I found a bug causing this error: In file: nrf_log_backend_interface.h (sdk\nrf5\components\libraries\experimental_log)

you need to change last lines from:

#endif // SUPPRESS_INLINE_IMPLEMENTATION

#endif //NRF_LOG_BACKEND_INTERFACE_H

#ifdef __cplusplus
}
#endif

to:

#endif // SUPPRESS_INLINE_IMPLEMENTATION

#ifdef __cplusplus
}
#endif

#endif //NRF_LOG_BACKEND_INTERFACE_H

Unfortunatelly C++ compiler will not manage to handle nrf_cli.h macros.

However I was able to compile this example when I removed all CLI related code to newly added file. I moved there all CLI includes, commands and initialization procedures. It only provided API functions to init, start and process CLI. It was working fine.

RE: C++ compilation error using CLI with SDK 14: error: expected declaration before '}' token

schef — Tue, 29 Aug 2017 08:30:48 GMT

examples/peripheral/cli.

RE: C++ compilation error using CLI with SDK 14: error: expected declaration before '}' token

Jakub Rzeszutko — Tue, 29 Aug 2017 08:29:02 GMT

Hi,

Please let me know which example you are trying to compile?