fstorage page info

RE: fstorage page info

SimonEMB — Thu, 18 Apr 2019 14:00:37 GMT

I changed the program_unit of m_flash_info in nrf_fstorage_sd.c

/* Flash device information. */
static nrf_fstorage_info_t m_flash_info =
{
#if   defined(NRF51)
    .erase_unit   = 1024,
#elif defined(NRF52_SERIES)
    .erase_unit   = 4096,
#endif
    .program_unit = 1,
    .rmap         = true,
    .wmap         = false,
};

RE: fstorage page info

Petter Myhre — Mon, 19 Feb 2018 17:00:26 GMT

SDK 14.2.0 was released before this was discovered, the next release is SDK 15.

RE: fstorage page info

naman.trivedi — Fri, 16 Feb 2018 13:36:05 GMT

I am using NRF52 with SDK14.2.0 with Softdevice 5.0. I am also getting NRF_ERROR_INVALID_LENGTH while writing the data to flash. Value of lenth parameter is 8.

In the init function inside the nrf_fstorage_sd.c file, p_fs->p_flash_info = &m_flash_info; line is inside the if loop. So I want to know if this bug is fixed in SDK 14.2.0?

RE: fstorage page info

Petter Myhre — Wed, 29 Nov 2017 12:04:51 GMT

Please see my edited answer.

RE: fstorage page info

rdecker — Tue, 28 Nov 2017 02:46:48 GMT

#include <app_error.h>
#include <nrf_fstorage.h>                                                                                                                                                         
#include <nrf_fstorage_sd.h>                                                                                                                                                      
#include <nrf_soc.h>

#define ETH_FLASH_START 0x3e000                                                                                                                                     
#define ETH_FLASH_END   0x3ffff
 
static void fstorage_evt_handler(nrf_fstorage_evt_t * p_evt);

NRF_FSTORAGE_DEF(nrf_fstorage_t fstorage) =                                                                                                                                       
  {                                                                                                                                                                                 
      /* Set a handler for fstorage events. */                                                                                                                                      
      .evt_handler = fstorage_evt_handler,                                                                                                                                          
                                                                                                                                                                                    
      /* These below are the boundaries of the flash space assigned to this instance of fstorage.                                                                                   
       * You must set these manually, even at runtime, before nrf_fstorage_init() is called.                                                                                        
       * The function nrf5_flash_end_addr_get() can be used to retrieve the last address on the                                                                                     
       * last page of flash available to write data. */                                                                                                                             
      .start_addr = ETH_FLASH_START,                                                                                                                                                
   };

void main() {
...
ret_code_t rc;
      rc = nrf_fstorage_init(&fstorage, &nrf_fstorage_sd, NULL);
      APP_ERROR_CHECK(rc);
...
}

RE: fstorage page info

Petter Myhre — Tue, 21 Nov 2017 12:08:44 GMT

How exactly have you defined your fstorage instance?

RE: fstorage page info

rdecker — Mon, 20 Nov 2017 21:06:34 GMT

Upon calling nrf_fstorage_init() a second time I get undefined values.

Moving the "p_fs->p_flash_info = &m_flash_info;" line in the init function of nrf_fstorage_sd.c above the if statement seems to have fixed my issue. This prevents p_flash_info from being uninitalized on subsequent calls to nrf_fstorage_init. I have left the NRF_ATFIFO_INIT line inside the if block. Am I doing something incorrect or is this a bug in the supplied library code? I'd appreciate you guys looking into it. Thanks.

RE: fstorage page info

Petter Myhre — Mon, 20 Nov 2017 15:33:57 GMT

It should be possible to call nrf_fstorage_init() for every instance you want, but how exactly have you defined your instance? It sounds like you have some undefined values of nrf_fstorage_t?

RE: fstorage page info

rdecker — Sat, 18 Nov 2017 00:31:01 GMT

I did some more digging and it turns out that p_flash_info is 0x00000000 and so program_unit is some "random" value. I see that it should be set to 4 in nrf_fstorage_sd.c which I am including in my build system.

Edit: with some logging it seems that the init function is being called twice (once for peer_manager, and once for my code?). However in the second call the if !m_flags.initialized branch is not taken and thus p_flash_info is not set (nrf_fstorage_sd.c:380). This seems incorrect to me. I was under the impression multiple fstorage instances could be constructed and used in different application modules.

RE: fstorage page info

rdecker — Fri, 17 Nov 2017 23:46:18 GMT

I tried switching the length to be a multiple of 4. In my test I am using "nrf_fstorage_write(&fstorage, 0x100000, data, 24, NULL)" and I still get ERROR 9 [NRF_ERROR_INVALID_LENGTH]. According to the 14.0 migration guide the length should be in bytes, thus I am doing 24.

As far as I know the program unit (2277 bytes) retrieved from p_flash_info is read only and cannot be changed. Attempting to set it makes gcc say "error: assignment of member 'program_unit' in read-only object". How would I lower the program unit to be 4 bytes and not 2k?

I am using &nrf_fstorage_sd in my nrf_fstorage_init line. I am using the s140 soft device with ble in other parts of my code base.

RE: fstorage page info

Petter Myhre — Wed, 08 Nov 2017 15:09:15 GMT

The program unit should be the word size, which is 4 bytes. The length has to be a multiple of 4 bytes, like the length of m_hello_world.

Edit 29.11.2017:

This is a bug. The fix is (as you figured out) to put p_fs->p_flash_info = &m_flash_info; before the if in the init function of nrf_fstorage_sd.c

This will be fixed in the next SDK release.