Button long press strange behaviour(SDK12.3)

RE: Button long press strange behaviour(SDK12.3)

Joakim Jakobsen — Tue, 16 Jan 2018 16:22:08 GMT

Hi mm81.
Sorry for the delay. I couldn't seem to reproduce the problem you are having. Maybe I'm doing something different from you.
You can take a look at Jørn's answer in this thread, that might be useful, as he is explaining how to acheive what you want.

RE: Button long press strange behaviour(SDK12.3)

mm81 — Thu, 11 Jan 2018 02:23:11 GMT

Thanks Joakim!

I defined the button and LED in a customized board definition header file (just modified from pca10028.h)

#define BUTTON_POWER	 0//0

#define BUTTON_A 10//

The system.h is not needed and I have removed it from the project.

As described above I am using SDK12.3 on a nrf51822 (QFACA10) and developing base on ble_app_template from peripheral examples; so I am using a softdevice S130.

I am using APP_BUTTON for BUTTON_POWER, BUTTON_A for detection. When press detected each button will start it's OWN 5000ms single shot timer (two seperate timer); when the timer expired and the button is still being press it will be recognised as a long press.

Problem I found is I found that when the system has been run for a while after started, a short press will immediately recognised as a long press.

Some info for your reference:

The softdevice is not yet paired to any device yet (i just started the development so I am now still working on the application part). I just put the device in a idle state (Not deep sleep ) after advertisement expired.
The button must have been pressed ONCE first below this problem happens. (i.e. the 5000ms must have been started once first)
In latest testing I tried to add a 1000ms repeating timer and start it immediately once the program start. And the issue is gone.

Do you have any idea?

Many thanks!

RE: Button long press strange behaviour(SDK12.3)

Joakim Jakobsen — Wed, 10 Jan 2018 09:29:14 GMT

Thanks! I will take a look and see if I can reproduce your problem.
Where are you defining the BUTTON_POWER, BUTTON_A etc?
I can see that you included the system.h, that is not from the SDK, maybe you could upload that file as well? So that when I test, it is as similar to your project as possible.
Best regards.

RE: Button long press strange behaviour(SDK12.3)

mm81 — Tue, 09 Jan 2018 14:11:20 GMT

And I am using ble peripheral template as base for development.

RE: Button long press strange behaviour(SDK12.3)

mm81 — Tue, 09 Jan 2018 14:04:29 GMT

Hihi, it is Sdk12.3 on a nrf51822qfac

RE: Button long press strange behaviour(SDK12.3)

Joakim Jakobsen — Tue, 09 Jan 2018 13:59:51 GMT

Hi mm81!
Which SDK and device is it that you are working with?

RE: Button long press strange behaviour(SDK12.3)

mm81 — Fri, 05 Jan 2018 06:55:29 GMT

Hello, yes the two pins has different polarity and they are correctly set.

Actually I found both pins exhibit same behaviour (both would enter long press with a short press immediately after the program's been running for a while).

I suspect this is a APP TIMER issue...

RE: Button long press strange behaviour(SDK12.3)

MANGO — Fri, 05 Jan 2018 05:01:25 GMT

Hello.

static void button_power_5sec_handler(void * p_context){
   if(nrf_gpio_pin_read(BUTTON_POWER)==1) //if button 1 is still pressed

static void button_a_5sec_handler(void * p_context){
   if(nrf_gpio_pin_read(BUTTON_A)==0) //if button 2 is still pressed

Can you check which one to use; 0 or 1?

Except that, I cannot detect major problems with your code.

-Regards, MANGO

RE: Button long press strange behaviour(SDK12.3)

MANGO — Thu, 04 Jan 2018 06:03:55 GMT

Thanks for uploading it. I thought you have created one single shot mode timer but looks like you are running 2 single shot timers.

Anyways, the community members will take a look at the code. I wish for your patience, please.

-Regards, MANGO

RE: Button long press strange behaviour(SDK12.3)

mm81 — Thu, 04 Jan 2018 05:37:04 GMT

It is defined outside the main. I tried to upload the c file in my original post, can you take a look on it? Thanks

RE: Button long press strange behaviour(SDK12.3)

MANGO — Thu, 04 Jan 2018 05:26:37 GMT

Hello, about the

It is initialised **in main**: APP_TIMER_DEF(button_power_5sec_timer_id); //define 5 second timer id

you mean you have defined that inside the main function like this?

int main(void) {
   APP_TIMER_DEF(button_power_5sec_timer_id);
   // ...
   return 0; }

or is that defined outside the main function?

How about uploading your source C file in your original post? Then I think we can speed things up.

RE: Button long press strange behaviour(SDK12.3)

mm81 — Thu, 04 Jan 2018 05:26:18 GMT

I need to insert code line by line?

RE: Button long press strange behaviour(SDK12.3)

mm81 — Thu, 04 Jan 2018 05:24:16 GMT

Time out handler

static void button_power_5sec_handler(void * p_context)

{
UNUSED_PARAMETER(p_context);    
if(nrf_gpio_pin_read(BUTTON_POWER)==1) //if button 1 is still pressed
{
    NRF_LOG_INFO("Button1 5sec long pressed\r\n");
			v33_ctrl_off();
			pwr_ctrl_off();
}
	app_timer_stop(button_power_5sec_timer_id);
button_power_5sec_timer_enabled=false;

}

RE: Button long press strange behaviour(SDK12.3)

mm81 — Thu, 04 Jan 2018 05:19:44 GMT

Thanks~

It is initialised in main: APP_TIMER_DEF(button_power_5sec_timer_id); //define 5 second timer id
Is configured as single shot timer

case APP_BUTTON_RELEASE: NRF_LOG_INFO("Button%d Released \r\n", pin_no); switch(pin_no) { case BUTTON_POWER: app_timer_stop(button_power_5sec_timer_id); button_power_5sec_timer_enabled=false; break; case BUTTON_A: app_timer_stop(button_a_5sec_timer_id); button_a_5sec_timer_enabled=false; change_op_mode(); break; } break;

RE: Button long press strange behaviour(SDK12.3)

MANGO — Thu, 04 Jan 2018 05:16:59 GMT

Hello, then I would recommend you to edit your original question.

When editing, press the preformatted text button to insert the code.

-Regards, MANGO

RE: Button long press strange behaviour(SDK12.3)

MANGO — Thu, 04 Jan 2018 05:15:11 GMT

Hello,

err_code = app_timer_create(&button_power_5sec_timer_id, APP_TIMER_MODE_SINGLE_SHOT, button_5sec_timer_handler);

Is your button_power_5sec_timer_id variable a global / static variable? It has to be.
Did you configured the timer as a APP_TIMER_MODE_SINGLE_SHOT / APP_TIMER_MODE_REPEATED timer?
Can you show me the code related to the APP_BUTTON_RELEASE part and the timer handler part?

I think your code when pressing the button doesn't seem to be a problem.

I cannot tell big issues without those parts.

RE: Button long press strange behaviour(SDK12.3)

mm81 — Thu, 04 Jan 2018 05:03:56 GMT

Sorry don't know how to properly paste the code here with correct format...

Timer init as below: err_code = app_timer_create(&button_power_5sec_timer_id, APP_TIMER_MODE_SINGLE_SHOT, button_power_5sec_handler);

I start timer when detect a button press in button_handler():

err_code = app_timer_start(button_power_5sec_timer_id, APP_TIMER_TICKS(5000,APP_TIMER_PRESCALER), NULL); //start timer, 5 second timeout

RE: Button long press strange behaviour(SDK12.3)

MANGO — Thu, 04 Jan 2018 04:31:32 GMT

Hello, can you post your 5sec pressing code so that we can inspect what's the problem?