The Saadc of issue of uninit

RE: The Saadc of issue of uninit

lenli — Thu, 13 Sep 2018 13:14:13 GMT

hi:

The uninit function will stay in a while loop until the STOPPED event is generated.

There are just a while,it cant be guaranteed to trigger the STOPPED event.its not very strict and may be have some except. i agree with u said in later.

RE: The Saadc of issue of uninit

Jørgen Holmefjord — Thu, 13 Sep 2018 12:18:59 GMT

The uninit function will stay in a while loop until the STOPPED event is generated. There is no need for interrupts to be enabled in order for events to be generated. If you frequently pull the STOPPED event register, you will read the event when it is generated. If a timeout should happen for some reason, before the STOPPED event is generated, this should be caught by the ASSERT (given that you have enabled ASSERTS by defining symbol DEBUG_NRF in the preprocessor symbols). You will not be able to call init function before the STOPPED event is generated, or you will be trapped in assert handler.

RE: The Saadc of issue of uninit

lenli — Thu, 13 Sep 2018 10:33:15 GMT

hi:

Long time no see.

nrf_saadc_task_trigger(NRF_SAADC_TASK_STOP) is triggered in uninit function,as the interupt is disabled,so it cant happed.

But the init function will enable the interupt in next time,the stop task will happed immediatly.

in ADCIRQ some of state will hava some problem,as i said in above.

i agree that Olaf said.

RE: The Saadc of issue of uninit

Jørgen Holmefjord — Thu, 14 Jun 2018 10:49:32 GMT

I do not understand why this issue should apprear. The uninit function disable all interrupts before triggering STOP task. Implementing the workaround proposed by Olaf will most likely break the functionality of the abort function (see this thread for more details - this issue have been fixed in SDK 15).

RE: The Saadc of issue of uninit

device_nrf_001 — Wed, 13 Jun 2018 20:21:18 GMT

I am facing the same issue as discussed above. I tried using else if case as suggested above and it solved the problem but I don't want to change the driver and would rather prefer use latest version of SDK if the problem is solved. I am using currently SDK 12. Kindly let me know if there is a SDK version which solves this issue.

RE: The Saadc of issue of uninit

device_nrf_001 — Wed, 13 Jun 2018 20:15:32 GMT

has this issue resolved in SDK 14 or SDK 15?

Please reply.

RE: The Saadc of issue of uninit

Olaf — Sun, 29 Apr 2018 05:29:10 GMT

I guess the problem is inside the SAADC_IRQHandler. When using the uninit inside the callback there is a NRF_SAADC_EVENT_STOPPED event created. As the handling of the end event in line 117 (nRF5_SDK_12.3.0_d7731ad) is not terminating the IRQ function, the stop event is handled in line 190, setting the state of the driver to NRF_SAADC_STATE_IDLE after the reinit has been performed in the callback. The next call to nrf_drv_saadc_sample is then creating the invalid state error.

Solution: In SAADC_IRQHandler use else if to handle each kind of event:

void SAADC_IRQHandler(void)
{
    if (nrf_saadc_event_check(NRF_SAADC_EVENT_END))
    {
        nrf_saadc_event_clear(NRF_SAADC_EVENT_END);
        NRF_LOG_DEBUG("Event: %s.\r\n", (uint32_t)EVT_TO_STR(NRF_SAADC_EVENT_END));

        if (!m_cb.low_power_mode || m_cb.conversions_end)
        {
            nrf_drv_saadc_evt_t evt;
            evt.type               = NRF_DRV_SAADC_EVT_DONE;
            evt.data.done.p_buffer = (nrf_saadc_value_t *)m_cb.p_buffer;
            evt.data.done.size     = m_cb.buffer_size;

            if (m_cb.p_secondary_buffer == NULL)
            {
                m_cb.adc_state = NRF_SAADC_STATE_IDLE;
            }
            else
            {
                m_cb.buffer_size_left   = m_cb.secondary_buffer_size;
                m_cb.p_buffer           = m_cb.p_secondary_buffer;
                m_cb.buffer_size        = m_cb.secondary_buffer_size;
                m_cb.p_secondary_buffer = NULL;
                if (!m_cb.low_power_mode)
                {
                    nrf_saadc_task_trigger(NRF_SAADC_TASK_START);
                }
            }
            m_cb.event_handler(&evt);
            m_cb.conversions_end = false;
        }
    }
    else if (m_cb.low_power_mode && nrf_saadc_event_check(NRF_SAADC_EVENT_STARTED))
    {
        nrf_saadc_event_clear(NRF_SAADC_EVENT_STARTED);
        NRF_LOG_DEBUG("Event: %s.\r\n", (uint32_t)EVT_TO_STR(NRF_SAADC_EVENT_STARTED));

        if (m_cb.buffer_size_left > m_cb.active_channels)
        {
            // More samples to convert than for single event.
            m_cb.buffer_size_left -= m_cb.active_channels;
            nrf_saadc_buffer_init((nrf_saadc_value_t *)&m_cb.p_buffer[m_cb.buffer_size -
                                                                      m_cb.buffer_size_left],
                                  m_cb.active_channels);
        }
        else if ((m_cb.buffer_size_left == m_cb.active_channels) &&

                 (m_cb.p_secondary_buffer != NULL))
        {
            // Samples to convert for one event, prepare next buffer.
            m_cb.conversions_end  = true;
            m_cb.buffer_size_left = 0;
            nrf_saadc_buffer_init((nrf_saadc_value_t *)m_cb.p_secondary_buffer,
                                  m_cb.active_channels);
        }
        else if (m_cb.buffer_size_left == m_cb.active_channels)
        {
            // Samples to convert for one event, but no second buffer.
            m_cb.conversions_end  = true;
            m_cb.buffer_size_left = 0;
        }
        nrf_saadc_event_clear(NRF_SAADC_EVENT_END);
        nrf_saadc_task_trigger(NRF_SAADC_TASK_SAMPLE);
    }
    else if (nrf_saadc_event_check(NRF_SAADC_EVENT_CALIBRATEDONE))
    {
        nrf_saadc_event_clear(NRF_SAADC_EVENT_CALIBRATEDONE);
        NRF_LOG_DEBUG("Event: %s.\r\n", (uint32_t)EVT_TO_STR(NRF_SAADC_EVENT_CALIBRATEDONE));
        m_cb.adc_state = NRF_SAADC_STATE_IDLE;

        nrf_drv_saadc_evt_t evt;
        evt.type = NRF_DRV_SAADC_EVT_CALIBRATEDONE;
        m_cb.event_handler(&evt);
    }
    else if (nrf_saadc_event_check(NRF_SAADC_EVENT_STOPPED))
    {
        nrf_saadc_event_clear(NRF_SAADC_EVENT_STOPPED);
        NRF_LOG_DEBUG("SAADC IRQ -- Event: %s.\r\n", (uint32_t)EVT_TO_STR(NRF_SAADC_EVENT_STOPPED));
        m_cb.adc_state = NRF_SAADC_STATE_IDLE;
    }
    else
    {
        uint32_t          limit_flags = m_cb.limits_enabled_flags;
        uint32_t          flag_idx;
        nrf_saadc_event_t event;

        while (limit_flags)
        {
            flag_idx     = __CLZ(limit_flags);
            limit_flags &= ~((1UL << 31) >> flag_idx);
            event        = FLAG_IDX_TO_EVENT(flag_idx);
            if (nrf_saadc_event_check(event))
            {
                nrf_saadc_event_clear(event);
                nrf_drv_saadc_evt_t evt;
                evt.type                  = NRF_DRV_SAADC_EVT_LIMIT;
                evt.data.limit.channel    = LIMIT_EVENT_TO_CHANNEL(event);
                evt.data.limit.limit_type = LIMIT_EVENT_TO_LIMIT_TYPE(event);
                NRF_LOG_DEBUG("Event limit, channel: %d, limit type: %s.\r\n", evt.data.limit.channel, (uint32_t)EVT_TO_STR(evt.data.limit.limit_type));
                m_cb.event_handler(&evt);
            }
        }
    }
}

RE: The Saadc of issue of uninit

Jørgen Holmefjord — Thu, 05 Apr 2018 14:43:37 GMT

What do you mean by this: "the code cant check the stop interrput ,as init some bugs in next init code"? Are you actually checking the error codes from your calls to nrf_drv_saadc_*, or are they only assigned? You say you get error 0x08 when calling nrf_drv_saadc_sample, this indicate that the driver is in IDLE state, normally because no buffer have been setup. You should have received an error code when you called one of the nrf_drv_saadc_* functions.

RE: The Saadc of issue of uninit

lenli — Mon, 02 Apr 2018 06:31:07 GMT

nrf_drv_saadc_uninit() function code has some bugs as below:

nrf_saadc_task_trigger(NRF_SAADC_TASK_STOP);

Wait for ADC being stopped.
uint32_t timeout = HW_TIMEOUT;
while (nrf_saadc_event_check(NRF_SAADC_EVENT_STOPPED) == 0 && timeout > 0)
{
--timeout;
}

while (nrf_saadc_event_check(NRF_SAADC_EVENT_STOPPED) == 0 && timeout > 0)
{
--timeout;
}

the code cant check the stop interrput ,as init some bugs in next init code.

RE: The Saadc of issue of uninit

lenli — Mon, 02 Apr 2018 04:23:17 GMT

i try it today, but there r no effect.

the error is same with that before.

how can u do ?

RE: The Saadc of issue of uninit

Chocol8 — Fri, 30 Mar 2018 11:30:59 GMT

Have you tried it?

RE: The Saadc of issue of uninit

Chocol8 — Fri, 30 Mar 2018 08:59:29 GMT

try uninit saadc like this:

nrf_drv_saadc_uninit();
NRF_SAADC->INTENCLR = (SAADC_INTENCLR_END_Clear << SAADC_INTENCLR_END_Pos);
NVIC_ClearPendingIRQ(SAADC_IRQn);

Do you see that power consumption actualy goes down when you unitiliaze? I guess it might be that you do not unitiliaze it properly. This would explain why code works good until initialized for the second time.

Does blocking function does not fit your plan?

RE: The Saadc of issue of uninit

lenli — Fri, 30 Mar 2018 08:42:28 GMT

i use the softdevice, sdk is nRF5_SDK_12.3.0_d7731ad.

my error is that i said in above.

when i use saadc,anything is ok. But i wanna uninit the saadc to power down the consumption.

But when i init saadc in twice more,saadc cant work well.

nrf_drv_saadc_sample error is 0x08, That means saadc is not busy.

i bubeg the code , and i find the code enter if (nrf_saadc_event_check(NRF_SAADC_EVENT_STOPPED)) in SAADC_IRQHandler.

why when i init saadc in twice more,the code enter nrf_saadc_event_check(NRF_SAADC_EVENT_STOPPED)???

RE: The Saadc of issue of uninit

Chocol8 — Fri, 30 Mar 2018 07:38:34 GMT

Hello, can you explain what are you trying to achieve? What is your setup MCU, sdk, softdevice? what does the error says? Recently I had problems while using SAADC. I would recommend you to take a look at proximity example. Moreover, do you do temperature calibration?