2 Timers as counter with external input capture pin

RE: 2 Timers as counter with external input capture pin

Amigo — Thu, 07 Jun 2018 09:51:18 GMT

Yes. I have found that relay works incorrect

RE: 2 Timers as counter with external input capture pin

Håkon Alseth — Thu, 07 Jun 2018 08:01:32 GMT

Just to confirm; the source of the issue has been found?

Best regards,

Håkon

RE: 2 Timers as counter with external input capture pin

Amigo — Thu, 07 Jun 2018 05:13:54 GMT

oh, i find, one of my relay time-to-time works incorrect.

RE: 2 Timers as counter with external input capture pin

Amigo — Thu, 07 Jun 2018 05:03:30 GMT

Ok.I took an experiment using nrf51 pca10001 board. i had the same problem on nrf51, but when i had used errata code , nrf51 code starts to work well! no double events.

void GPIOTE_IRQHandler(void)
{
		if(NRF_GPIOTE->EVENTS_IN[0] == 1)
		{	
			NRF_GPIOTE->EVENTS_IN[0] = 0;
			counter1++;

		}
		if(NRF_GPIOTE->EVENTS_IN[1] == 1)
		{			
			NRF_GPIOTE->EVENTS_IN[1] = 0;
			counter2++;
		}
}
...
...
...
nrf_gpio_cfg_input(0, GPIO_PIN_CNF_PULL_Pullup);
nrf_gpio_cfg_input(1, GPIO_PIN_CNF_PULL_Pullup);

*(volatile uint32_t *)(NRF_GPIOTE_BASE + 0x600 + (4 * 0)) = 1;
*(volatile uint32_t *)(NRF_GPIOTE_BASE + 0x600 + (4 * 1)) = 1;

NRF_GPIOTE->CONFIG[0] = GPIOTE_CONFIG_MODE_Event << GPIOTE_CONFIG_MODE_Pos |
												0 << GPIOTE_CONFIG_PSEL_Pos												 |	
												GPIOTE_CONFIG_POLARITY_HiToLo << GPIOTE_CONFIG_POLARITY_Pos;

NRF_GPIOTE->CONFIG[1] = GPIOTE_CONFIG_MODE_Event << GPIOTE_CONFIG_MODE_Pos |
												1 << GPIOTE_CONFIG_PSEL_Pos												 |	
												GPIOTE_CONFIG_POLARITY_HiToLo << GPIOTE_CONFIG_POLARITY_Pos;	

NRF_GPIOTE->EVENTS_IN[0] = 0;
NRF_GPIOTE->EVENTS_IN[1] = 0;

NRF_GPIOTE->INTENSET = GPIOTE_INTENSET_IN0_Enabled << GPIOTE_INTENSET_IN0_Pos | 
											 GPIOTE_INTENSET_IN1_Enabled << GPIOTE_INTENSET_IN1_Pos ; 

NRF_GPIOTE->POWER = 	GPIOTE_POWER_POWER_Enabled << GPIOTE_POWER_POWER_Pos;
NVIC_EnableIRQ(GPIOTE_IRQn);

Then i remake code for nrf 52

void GPIOTE_IRQHandler(void)
{
		if(NRF_GPIOTE->EVENTS_IN[0] == 1)
		{	
			NRF_GPIOTE->EVENTS_IN[0] = 0;
			counter1++;
		}
		if(NRF_GPIOTE->EVENTS_IN[1] == 1)
		{			
			NRF_GPIOTE->EVENTS_IN[1] = 0;
			counter2++;
		}
}
...
...
...
nrf_gpio_cfg_input(3, GPIO_PIN_CNF_PULL_Pullup);
nrf_gpio_cfg_input(4, GPIO_PIN_CNF_PULL_Pullup);

*(volatile uint32_t *)(NRF_GPIOTE_BASE + 0x600 + (4 * 0)) = 1;
*(volatile uint32_t *)(NRF_GPIOTE_BASE + 0x600 + (4 * 1)) = 1;

NRF_GPIOTE->CONFIG[0] = GPIOTE_CONFIG_MODE_Event << GPIOTE_CONFIG_MODE_Pos |
						3 << GPIOTE_CONFIG_PSEL_Pos												 |	
						GPIOTE_CONFIG_POLARITY_HiToLo << GPIOTE_CONFIG_POLARITY_Pos;

NRF_GPIOTE->CONFIG[1] = GPIOTE_CONFIG_MODE_Event << GPIOTE_CONFIG_MODE_Pos |
						4 << GPIOTE_CONFIG_PSEL_Pos												 |	
						GPIOTE_CONFIG_POLARITY_HiToLo << GPIOTE_CONFIG_POLARITY_Pos;	

NRF_GPIOTE->EVENTS_IN[0] = 0;
NRF_GPIOTE->EVENTS_IN[1] = 0;

NRF_GPIOTE->INTENSET = GPIOTE_INTENSET_IN0_Enabled << GPIOTE_INTENSET_IN0_Pos | 
					   GPIOTE_INTENSET_IN1_Enabled << GPIOTE_INTENSET_IN1_Pos ; 

NVIC_SetPriority(2, GPIOTE_IRQn);
NVIC_DisableIRQ(GPIOTE_IRQn);

But for nrf52 it doesnt works, it always has double event for EVENTS_IN[1]

RE: 2 Timers as counter with external input capture pin

Håkon Alseth — Wed, 06 Jun 2018 19:02:17 GMT

It is not the pin used, but the GPIOTE->IN[] instance used. If there are no other IN channels in use, then this is 0 and 1.

RE: 2 Timers as counter with external input capture pin

Amigo — Wed, 06 Jun 2018 15:57:04 GMT

Yes, i tried, i use construction from errata with in GPIOTE initialising. if GPIOTE_CH_USED is pin number like 4 or 5, i made it write. But it has no effect.

RE: 2 Timers as counter with external input capture pin

Håkon Alseth — Wed, 06 Jun 2018 12:35:42 GMT

Could you try to enable this errata workaround, just to see if the two signals are triggered, at some point, very close together?

http://infocenter.nordicsemi.com/topic/com.nordic.infocenter.nrf52832.Rev2.errata/dita/errata/nRF52832/Rev2/latest/anomaly_832_155.html?cp=2_1_1_0_1_41

Best regards,

Håkon

RE: 2 Timers as counter with external input capture pin

Amigo — Wed, 06 Jun 2018 11:59:20 GMT

All the same. RTT does not affect

RE: 2 Timers as counter with external input capture pin

Håkon Alseth — Wed, 06 Jun 2018 11:32:51 GMT

I assume your inputs should then alternate between CNT1 and CNT2, ie: the input signal phase is 0/180 degrees.

Could you try to omit RTT, and do something like this to see if this might be a RTT polling/buffering issue?

void in_pin_handler(nrf_drv_gpiote_pin_t pin, nrf_gpiote_polarity_t action)
{
        static nrf_drv_gpiote_pin_t last_pin;
		if( pin == 4 )
		{	
			counter1++;
			//SEGGER_RTT_WriteString(0,"CNT1\r\n");
		}
		else if( pin == 5 )
		{			
			counter2++;
			//SEGGER_RTT_WriteString(0,"CNT2\r\n");
		}
		if (pin == last_pin)
		{
		  // Same evt happen twice in a row.
		  static uint32_t double_count;
		  double_count++;
		}
		last_pin = pin;
}

Best regards,

Håkon

RE: 2 Timers as counter with external input capture pin

Amigo — Wed, 06 Jun 2018 10:53:30 GMT

With PPi or not, it has double event. There is no pulses (i use cap 0.1 uf on input pins). Variables are volatile but SEGGER_RTT_WriteString(0,"CNT2\r\n"); prints twice

RE: 2 Timers as counter with external input capture pin

Håkon Alseth — Wed, 06 Jun 2018 10:44:41 GMT

Your code does not use PPI. Do you still see double-events with this code? Have you scoped pin 5 to see if there are any glitches or pulses that might account for this double increment?

Is your counter values declared as volatile? This is important when variables are used in interrupt vectors.

Best regards,

Håkon

RE: 2 Timers as counter with external input capture pin

Amigo — Wed, 06 Jun 2018 10:23:30 GMT

Delay between signals 1 - 1.5 ms/

Code (next i remake without ppi)

void in_pin_handler(nrf_drv_gpiote_pin_t pin, nrf_gpiote_polarity_t action)

void in_pin_handler(nrf_drv_gpiote_pin_t pin, nrf_gpiote_polarity_t action)

		if( pin == 4 )
		{	
			counter1++;
			SEGGER_RTT_WriteString(0,"CNT1\r\n");
		}
		else if( pin == 5 )
		{			
			counter2++;
			SEGGER_RTT_WriteString(0,"CNT2\r\n");
		}
}

static void buttons_leds_init(bool * p_erase_bonds)
{
	nrf_gpio_cfg_output(17);
	nrf_gpio_cfg_output(18);
	nrf_gpio_cfg_output(19);
	nrf_gpio_cfg_output(20);
	nrf_gpio_pin_set(17);
	nrf_gpio_pin_set(18);
	nrf_gpio_pin_set(19);
	nrf_gpio_pin_set(20);

	err_code = nrf_drv_gpiote_init();
    APP_ERROR_CHECK(err_code);
	
    nrf_drv_gpiote_in_config_t in_config = GPIOTE_CONFIG_IN_SENSE_HITOLO(true);
    in_config.pull = NRF_GPIO_PIN_PULLUP;
    nrf_drv_gpiote_in_init(4, &in_config, in_pin_handler);
    nrf_drv_gpiote_in_event_enable(4, true);
    nrf_drv_gpiote_in_init(5, &in_config, in_pin_handler);
    nrf_drv_gpiote_in_event_enable(5, true);
    
    NVIC_SetPriority(2, GPIOTE_IRQn);
    NVIC_DisableIRQ(GPIOTE_IRQn);
}

cnt2 sets twice

RE: 2 Timers as counter with external input capture pin

Håkon Alseth — Wed, 30 May 2018 12:47:36 GMT

Hi,

Could you share a piece of the code where you tie everything together, so I can look at the logic?

Are the signals occurring within a very short period of time? If yes, then it might be that you are running into this errata: http://infocenter.nordicsemi.com/topic/com.nordic.infocenter.nrf52832.Rev1.errata/anomaly_832_155.html?cp=2_1_1_1_1_44

Best regards,

Håkon