Updating Advertising Service Data

RE: Updating Advertising Service Data

MartinBL — Fri, 13 Jul 2018 15:33:00 GMT

I'm not sure if I understand your question. My unelegant (and only) proposal is stop advertising and configure the advertising structure from scratch again each time you want to update the content.

RE: Updating Advertising Service Data

jloliveira — Thu, 12 Jul 2018 16:16:36 GMT

Hi Martin,

I could do the whole data update when considering a similar strategy by interleaving two different pointers that are passed to p_advertising->adv_data at each data update iteration. Yet, it is not working for the service_data update purpose, as implemented in the code I sent you.

Do you have any unelegant proposal to solve this issue? It seems like a limitation from the SDK that should be polished.

Thank you,

João

RE: Updating Advertising Service Data

MartinBL — Tue, 10 Jul 2018 15:40:25 GMT

Hi,

Unfortunately there is no elegant way of updating the data in the advertising packet while advertising. You need to stop advertising, reconfigure the packet, and restart advertising again.

RE: Updating Advertising Service Data

jloliveira — Mon, 09 Jul 2018 15:56:03 GMT

Hi Martin,

It seems that I had an issue with p_advertising->adv_data.adv_data.len indeed, which was getting unintentionally altered and reading the ServiceData "out of range".

It is now working but I'm struggling with the NRF_ERROR_INVALID_STATE with sd_ble_gap_adv_set_configure. According to the documentation, "It is invalid to provide the same data buffers while advertising. To update advertising data, provide new advertising buffers."

I try to contour the issue with the code in attachment but still retrieve the same error. Any ideas to solve it?

I'm using SDK15 and Softdevice6.0.0

Thank you,

João

ret_code_t sdata_set(ble_advertising_t * const p_advertising, uint16_t sdata)
{
    uint32_t ret;
    
    uint8_t * p_sdata = ble_advdata_parse(p_advertising->adv_data.adv_data.p_data,
				      p_advertising->adv_data.adv_data.len,
				      BLE_GAP_AD_TYPE_SERVICE_DATA);
    
    uint16_t offset = 0;
    if (p_sdata != NULL)
    {
			*p_sdata = sdata;

			ble_advdata_search(p_advertising->adv_data.adv_data.p_data, BLE_GAP_ADV_SET_DATA_SIZE_MAX, &offset, BLE_GAP_AD_TYPE_SERVICE_DATA);
			
        	offset+=2; //To get the data itself			
			p_advertising->adv_data.adv_data.p_data[offset++] = MSB_16(sdata);
        	p_advertising->adv_data.adv_data.p_data[offset++] = LSB_16(sdata);
    }
    else //Debug
    {
			NRF_LOG_ERROR("No SData!");
    }
    

    if(m_advdata_idx % 2 == 0)
    {
            memcpy(m_new_enc_advdata1, p_advertising->adv_data.adv_data.p_data, p_advertising->adv_data.adv_data.len);
            m_new_adv_data.adv_data.p_data      = m_new_enc_advdata1;
            m_new_adv_data.adv_data.len         = p_advertising->adv_data.adv_data.len;

            m_new_adv_data.scan_rsp_data.p_data = p_advertising->enc_scan_rsp_data;
            m_new_adv_data.scan_rsp_data.len    = p_advertising->adv_data.scan_rsp_data.len;
    }
    else
    {
            memcpy(m_new_enc_advdata2, p_advertising->adv_data.adv_data.p_data, p_advertising->adv_data.adv_data.len);
            m_new_adv_data.adv_data.p_data      = m_new_enc_advdata2;
            m_new_adv_data.adv_data.len         = p_advertising->adv_data.adv_data.len;

            m_new_adv_data.scan_rsp_data.p_data = p_advertising->enc_scan_rsp_data;
            m_new_adv_data.scan_rsp_data.len    = p_advertising->adv_data.scan_rsp_data.len;
    }

    m_advdata_idx++;

    memcpy(&p_advertising->adv_data, &m_new_adv_data, sizeof(p_advertising->adv_data));
    p_advertising->p_adv_data = &p_advertising->adv_data;

    ret = sd_ble_gap_adv_set_configure(&p_advertising->adv_handle, &p_advertising->adv_data, &p_advertising->adv_params);

    return ret;
}

RE: Updating Advertising Service Data

MartinBL — Fri, 06 Jul 2018 06:10:52 GMT

That is strange.

What SDK version are you using?
Can you share your entire project? We can make the case private if you prefer confidentiality.

RE: Updating Advertising Service Data

jloliveira — Thu, 05 Jul 2018 16:54:24 GMT

Hi Martin,

I tried to import your sdata_set function and it results the same => offset is always zero and thus p_sdata is never different than NULL.

I checked p_advertising->adv_data.adv_data.len and it is always 31.

Do you have any idea what might be the problem?

Thanks,

João

RE: Updating Advertising Service Data

MartinBL — Thu, 05 Jul 2018 15:09:11 GMT

Here is the code I used for testing btw:

/**
 * Copyright (c) 2014 - 2018, Nordic Semiconductor ASA
 * 
 * All rights reserved.
 * 
 * Redistribution and use in source and binary forms, with or without modification,
 * are permitted provided that the following conditions are met:
 * 
 * 1. Redistributions of source code must retain the above copyright notice, this
 *    list of conditions and the following disclaimer.
 * 
 * 2. Redistributions in binary form, except as embedded into a Nordic
 *    Semiconductor ASA integrated circuit in a product or a software update for
 *    such product, must reproduce the above copyright notice, this list of
 *    conditions and the following disclaimer in the documentation and/or other
 *    materials provided with the distribution.
 * 
 * 3. Neither the name of Nordic Semiconductor ASA nor the names of its
 *    contributors may be used to endorse or promote products derived from this
 *    software without specific prior written permission.
 * 
 * 4. This software, with or without modification, must only be used with a
 *    Nordic Semiconductor ASA integrated circuit.
 * 
 * 5. Any software provided in binary form under this license must not be reverse
 *    engineered, decompiled, modified and/or disassembled.
 * 
 * THIS SOFTWARE IS PROVIDED BY NORDIC SEMICONDUCTOR ASA "AS IS" AND ANY EXPRESS
 * OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
 * OF MERCHANTABILITY, NONINFRINGEMENT, AND FITNESS FOR A PARTICULAR PURPOSE ARE
 * DISCLAIMED. IN NO EVENT SHALL NORDIC SEMICONDUCTOR ASA OR CONTRIBUTORS BE
 * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
 * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE
 * GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
 * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
 * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 * 
 */
/** @file
 *
 * @defgroup ble_sdk_uart_over_ble_main main.c
 * @{
 * @ingroup  ble_sdk_app_nus_eval
 * @brief    UART over BLE application main file.
 *
 * This file contains the source code for a sample application that uses the Nordic UART service.
 * This application uses the @ref srvlib_conn_params module.
 */


#include <stdint.h>
#include <string.h>
#include "nordic_common.h"
#include "nrf.h"
#include "ble_hci.h"
#include "ble_advdata.h"
#include "ble_advertising.h"
#include "ble_conn_params.h"
#include "nrf_sdh.h"
#include "nrf_sdh_soc.h"
#include "nrf_sdh_ble.h"
#include "nrf_ble_gatt.h"
#include "nrf_ble_qwr.h"
#include "app_timer.h"
#include "ble_nus.h"
#include "app_uart.h"
#include "app_util_platform.h"
#include "bsp_btn_ble.h"
#include "nrf_pwr_mgmt.h"
#include "nrf_delay.h"

#if defined (UART_PRESENT)
#include "nrf_uart.h"
#endif
#if defined (UARTE_PRESENT)
#include "nrf_uarte.h"
#endif

#include "nrf_log.h"
#include "nrf_log_ctrl.h"
#include "nrf_log_default_backends.h"

#define APP_BLE_CONN_CFG_TAG            1                                           /**< A tag identifying the SoftDevice BLE configuration. */

#define DEVICE_NAME                     "ART"                               /**< Name of device. Will be included in the advertising data. */
#define NUS_SERVICE_UUID_TYPE           BLE_UUID_TYPE_VENDOR_BEGIN                  /**< UUID type for the Nordic UART Service (vendor specific). */

#define APP_BLE_OBSERVER_PRIO           3                                           /**< Application's BLE observer priority. You shouldn't need to modify this value. */

#define APP_ADV_INTERVAL                64                                          /**< The advertising interval (in units of 0.625 ms. This value corresponds to 40 ms). */

#define APP_ADV_DURATION                18000                                       /**< The advertising duration (180 seconds) in units of 10 milliseconds. */

#define MIN_CONN_INTERVAL               MSEC_TO_UNITS(20, UNIT_1_25_MS)             /**< Minimum acceptable connection interval (20 ms), Connection interval uses 1.25 ms units. */
#define MAX_CONN_INTERVAL               MSEC_TO_UNITS(75, UNIT_1_25_MS)             /**< Maximum acceptable connection interval (75 ms), Connection interval uses 1.25 ms units. */
#define SLAVE_LATENCY                   0                                           /**< Slave latency. */
#define CONN_SUP_TIMEOUT                MSEC_TO_UNITS(4000, UNIT_10_MS)             /**< Connection supervisory timeout (4 seconds), Supervision Timeout uses 10 ms units. */
#define FIRST_CONN_PARAMS_UPDATE_DELAY  APP_TIMER_TICKS(5000)                       /**< Time from initiating event (connect or start of notification) to first time sd_ble_gap_conn_param_update is called (5 seconds). */
#define NEXT_CONN_PARAMS_UPDATE_DELAY   APP_TIMER_TICKS(30000)                      /**< Time between each call to sd_ble_gap_conn_param_update after the first call (30 seconds). */
#define MAX_CONN_PARAMS_UPDATE_COUNT    3                                           /**< Number of attempts before giving up the connection parameter negotiation. */

#define DEAD_BEEF                       0xDEADBEEF                                  /**< Value used as error code on stack dump, can be used to identify stack location on stack unwind. */

#define UART_TX_BUF_SIZE                256                                         /**< UART TX buffer size. */
#define UART_RX_BUF_SIZE                256                                         /**< UART RX buffer size. */


BLE_NUS_DEF(m_nus, NRF_SDH_BLE_TOTAL_LINK_COUNT);                                   /**< BLE NUS service instance. */
NRF_BLE_GATT_DEF(m_gatt);                                                           /**< GATT module instance. */
NRF_BLE_QWR_DEF(m_qwr);                                                             /**< Context for the Queued Write module.*/
BLE_ADVERTISING_DEF(m_advertising);                                                 /**< Advertising module instance. */

static uint16_t   m_conn_handle          = BLE_CONN_HANDLE_INVALID;                 /**< Handle of the current connection. */
static uint16_t   m_ble_nus_max_data_len = BLE_GATT_ATT_MTU_DEFAULT - 3;            /**< Maximum length of data (in bytes) that can be transmitted to the peer by the Nordic UART service module. */
//static ble_uuid_t m_adv_uuids[]          =                                          /**< Universally unique service identifier. */
//{
//    {BLE_UUID_NUS_SERVICE, NUS_SERVICE_UUID_TYPE}
//};


/**@brief Function for assert macro callback.
 *
 * @details This function will be called in case of an assert in the SoftDevice.
 *
 * @warning This handler is an example only and does not fit a final product. You need to analyse
 *          how your product is supposed to react in case of Assert.
 * @warning On assert from the SoftDevice, the system can only recover on reset.
 *
 * @param[in] line_num    Line number of the failing ASSERT call.
 * @param[in] p_file_name File name of the failing ASSERT call.
 */
void assert_nrf_callback(uint16_t line_num, const uint8_t * p_file_name)
{
    app_error_handler(DEAD_BEEF, line_num, p_file_name);
}

/**@brief Function for initializing the timer module.
 */
static void timers_init(void)
{
    ret_code_t err_code = app_timer_init();
    APP_ERROR_CHECK(err_code);
}

/**@brief Function for the GAP initialization.
 *
 * @details This function will set up all the necessary GAP (Generic Access Profile) parameters of
 *          the device. It also sets the permissions and appearance.
 */
static void gap_params_init(void)
{
    uint32_t                err_code;
    ble_gap_conn_params_t   gap_conn_params;
    ble_gap_conn_sec_mode_t sec_mode;

    BLE_GAP_CONN_SEC_MODE_SET_OPEN(&sec_mode);

    err_code = sd_ble_gap_device_name_set(&sec_mode,
                                          (const uint8_t *) DEVICE_NAME,
                                          strlen(DEVICE_NAME));
    APP_ERROR_CHECK(err_code);

    memset(&gap_conn_params, 0, sizeof(gap_conn_params));

    gap_conn_params.min_conn_interval = MIN_CONN_INTERVAL;
    gap_conn_params.max_conn_interval = MAX_CONN_INTERVAL;
    gap_conn_params.slave_latency     = SLAVE_LATENCY;
    gap_conn_params.conn_sup_timeout  = CONN_SUP_TIMEOUT;

    err_code = sd_ble_gap_ppcp_set(&gap_conn_params);
    APP_ERROR_CHECK(err_code);
}


/**@brief Function for handling Queued Write Module errors.
 *
 * @details A pointer to this function will be passed to each service which may need to inform the
 *          application about an error.
 *
 * @param[in]   nrf_error   Error code containing information about what went wrong.
 */
static void nrf_qwr_error_handler(uint32_t nrf_error)
{
    APP_ERROR_HANDLER(nrf_error);
}


/**@brief Function for handling the data from the Nordic UART Service.
 *
 * @details This function will process the data received from the Nordic UART BLE Service and send
 *          it to the UART module.
 *
 * @param[in] p_evt       Nordic UART Service event.
 */
/**@snippet [Handling the data received over BLE] */
static void nus_data_handler(ble_nus_evt_t * p_evt)
{

    if (p_evt->type == BLE_NUS_EVT_RX_DATA)
    {
        uint32_t err_code;

        NRF_LOG_DEBUG("Received data from BLE NUS. Writing data on UART.");
        NRF_LOG_HEXDUMP_DEBUG(p_evt->params.rx_data.p_data, p_evt->params.rx_data.length);

        for (uint32_t i = 0; i < p_evt->params.rx_data.length; i++)
        {
            do
            {
                err_code = app_uart_put(p_evt->params.rx_data.p_data[i]);
                if ((err_code != NRF_SUCCESS) && (err_code != NRF_ERROR_BUSY))
                {
                    NRF_LOG_ERROR("Failed receiving NUS message. Error 0x%x. ", err_code);
                    APP_ERROR_CHECK(err_code);
                }
            } while (err_code == NRF_ERROR_BUSY);
        }
        if (p_evt->params.rx_data.p_data[p_evt->params.rx_data.length - 1] == '\r')
        {
            while (app_uart_put('\n') == NRF_ERROR_BUSY);
        }
    }

}
/**@snippet [Handling the data received over BLE] */


/**@brief Function for initializing services that will be used by the application.
 */
static void services_init(void)
{
    uint32_t           err_code;
    ble_nus_init_t     nus_init;
    nrf_ble_qwr_init_t qwr_init = {0};

    // Initialize Queued Write Module.
    qwr_init.error_handler = nrf_qwr_error_handler;

    err_code = nrf_ble_qwr_init(&m_qwr, &qwr_init);
    APP_ERROR_CHECK(err_code);

    // Initialize NUS.
    memset(&nus_init, 0, sizeof(nus_init));

    nus_init.data_handler = nus_data_handler;

    err_code = ble_nus_init(&m_nus, &nus_init);
    APP_ERROR_CHECK(err_code);
}


/**@brief Function for handling an event from the Connection Parameters Module.
 *
 * @details This function will be called for all events in the Connection Parameters Module
 *          which are passed to the application.
 *
 * @note All this function does is to disconnect. This could have been done by simply setting
 *       the disconnect_on_fail config parameter, but instead we use the event handler
 *       mechanism to demonstrate its use.
 *
 * @param[in] p_evt  Event received from the Connection Parameters Module.
 */
static void on_conn_params_evt(ble_conn_params_evt_t * p_evt)
{
    uint32_t err_code;

    if (p_evt->evt_type == BLE_CONN_PARAMS_EVT_FAILED)
    {
        err_code = sd_ble_gap_disconnect(m_conn_handle, BLE_HCI_CONN_INTERVAL_UNACCEPTABLE);
        APP_ERROR_CHECK(err_code);
    }
}


/**@brief Function for handling errors from the Connection Parameters module.
 *
 * @param[in] nrf_error  Error code containing information about what went wrong.
 */
static void conn_params_error_handler(uint32_t nrf_error)
{
    APP_ERROR_HANDLER(nrf_error);
}


/**@brief Function for initializing the Connection Parameters module.
 */
static void conn_params_init(void)
{
    uint32_t               err_code;
    ble_conn_params_init_t cp_init;

    memset(&cp_init, 0, sizeof(cp_init));

    cp_init.p_conn_params                  = NULL;
    cp_init.first_conn_params_update_delay = FIRST_CONN_PARAMS_UPDATE_DELAY;
    cp_init.next_conn_params_update_delay  = NEXT_CONN_PARAMS_UPDATE_DELAY;
    cp_init.max_conn_params_update_count   = MAX_CONN_PARAMS_UPDATE_COUNT;
    cp_init.start_on_notify_cccd_handle    = BLE_GATT_HANDLE_INVALID;
    cp_init.disconnect_on_fail             = false;
    cp_init.evt_handler                    = on_conn_params_evt;
    cp_init.error_handler                  = conn_params_error_handler;

    err_code = ble_conn_params_init(&cp_init);
    APP_ERROR_CHECK(err_code);
}


/**@brief Function for putting the chip into sleep mode.
 *
 * @note This function will not return.
 */
static void sleep_mode_enter(void)
{
    uint32_t err_code = bsp_indication_set(BSP_INDICATE_IDLE);
    APP_ERROR_CHECK(err_code);

    // Prepare wakeup buttons.
    err_code = bsp_btn_ble_sleep_mode_prepare();
    APP_ERROR_CHECK(err_code);

    // Go to system-off mode (this function will not return; wakeup will cause a reset).
    err_code = sd_power_system_off();
    APP_ERROR_CHECK(err_code);
}


/**@brief Function for handling advertising events.
 *
 * @details This function will be called for advertising events which are passed to the application.
 *
 * @param[in] ble_adv_evt  Advertising event.
 */
static void on_adv_evt(ble_adv_evt_t ble_adv_evt)
{
    uint32_t err_code;

    switch (ble_adv_evt)
    {
        case BLE_ADV_EVT_FAST:
            err_code = bsp_indication_set(BSP_INDICATE_ADVERTISING);
            APP_ERROR_CHECK(err_code);
            break;
        case BLE_ADV_EVT_IDLE:
            sleep_mode_enter();
            break;
        default:
            break;
    }
}


/**@brief Function for handling BLE events.
 *
 * @param[in]   p_ble_evt   Bluetooth stack event.
 * @param[in]   p_context   Unused.
 */
static void ble_evt_handler(ble_evt_t const * p_ble_evt, void * p_context)
{
    uint32_t err_code;

    switch (p_ble_evt->header.evt_id)
    {
        case BLE_GAP_EVT_CONNECTED:
            NRF_LOG_INFO("Connected");
            err_code = bsp_indication_set(BSP_INDICATE_CONNECTED);
            APP_ERROR_CHECK(err_code);
            m_conn_handle = p_ble_evt->evt.gap_evt.conn_handle;
            err_code = nrf_ble_qwr_conn_handle_assign(&m_qwr, m_conn_handle);
            APP_ERROR_CHECK(err_code);
            break;

        case BLE_GAP_EVT_DISCONNECTED:
            NRF_LOG_INFO("Disconnected");
            // LED indication will be changed when advertising starts.
            m_conn_handle = BLE_CONN_HANDLE_INVALID;
            break;

        case BLE_GAP_EVT_PHY_UPDATE_REQUEST:
        {
            NRF_LOG_DEBUG("PHY update request.");
            ble_gap_phys_t const phys =
            {
                .rx_phys = BLE_GAP_PHY_AUTO,
                .tx_phys = BLE_GAP_PHY_AUTO,
            };
            err_code = sd_ble_gap_phy_update(p_ble_evt->evt.gap_evt.conn_handle, &phys);
            APP_ERROR_CHECK(err_code);
        } break;

        case BLE_GAP_EVT_SEC_PARAMS_REQUEST:
            // Pairing not supported
            err_code = sd_ble_gap_sec_params_reply(m_conn_handle, BLE_GAP_SEC_STATUS_PAIRING_NOT_SUPP, NULL, NULL);
            APP_ERROR_CHECK(err_code);
            break;

        case BLE_GATTS_EVT_SYS_ATTR_MISSING:
            // No system attributes have been stored.
            err_code = sd_ble_gatts_sys_attr_set(m_conn_handle, NULL, 0, 0);
            APP_ERROR_CHECK(err_code);
            break;

        case BLE_GATTC_EVT_TIMEOUT:
            // Disconnect on GATT Client timeout event.
            err_code = sd_ble_gap_disconnect(p_ble_evt->evt.gattc_evt.conn_handle,
                                             BLE_HCI_REMOTE_USER_TERMINATED_CONNECTION);
            APP_ERROR_CHECK(err_code);
            break;

        case BLE_GATTS_EVT_TIMEOUT:
            // Disconnect on GATT Server timeout event.
            err_code = sd_ble_gap_disconnect(p_ble_evt->evt.gatts_evt.conn_handle,
                                             BLE_HCI_REMOTE_USER_TERMINATED_CONNECTION);
            APP_ERROR_CHECK(err_code);
            break;

        default:
            // No implementation needed.
            break;
    }
}


/**@brief Function for the SoftDevice initialization.
 *
 * @details This function initializes the SoftDevice and the BLE event interrupt.
 */
static void ble_stack_init(void)
{
    ret_code_t err_code;

    err_code = nrf_sdh_enable_request();
    APP_ERROR_CHECK(err_code);

    // Configure the BLE stack using the default settings.
    // Fetch the start address of the application RAM.
    uint32_t ram_start = 0;
    err_code = nrf_sdh_ble_default_cfg_set(APP_BLE_CONN_CFG_TAG, &ram_start);
    APP_ERROR_CHECK(err_code);

    // Enable BLE stack.
    err_code = nrf_sdh_ble_enable(&ram_start);
    APP_ERROR_CHECK(err_code);

    // Register a handler for BLE events.
    NRF_SDH_BLE_OBSERVER(m_ble_observer, APP_BLE_OBSERVER_PRIO, ble_evt_handler, NULL);
}


/**@brief Function for handling events from the GATT library. */
void gatt_evt_handler(nrf_ble_gatt_t * p_gatt, nrf_ble_gatt_evt_t const * p_evt)
{
    if ((m_conn_handle == p_evt->conn_handle) && (p_evt->evt_id == NRF_BLE_GATT_EVT_ATT_MTU_UPDATED))
    {
        m_ble_nus_max_data_len = p_evt->params.att_mtu_effective - OPCODE_LENGTH - HANDLE_LENGTH;
        NRF_LOG_INFO("Data len is set to 0x%X(%d)", m_ble_nus_max_data_len, m_ble_nus_max_data_len);
    }
    NRF_LOG_DEBUG("ATT MTU exchange completed. central 0x%x peripheral 0x%x",
                  p_gatt->att_mtu_desired_central,
                  p_gatt->att_mtu_desired_periph);
}


/**@brief Function for initializing the GATT library. */
void gatt_init(void)
{
    ret_code_t err_code;

    err_code = nrf_ble_gatt_init(&m_gatt, gatt_evt_handler);
    APP_ERROR_CHECK(err_code);

    err_code = nrf_ble_gatt_att_mtu_periph_set(&m_gatt, NRF_SDH_BLE_GATT_MAX_MTU_SIZE);
    APP_ERROR_CHECK(err_code);
}


/**@brief Function for handling events from the BSP module.
 *
 * @param[in]   event   Event generated by button press.
 */
void bsp_event_handler(bsp_event_t event)
{
    uint32_t err_code;
    switch (event)
    {
        case BSP_EVENT_SLEEP:
            sleep_mode_enter();
            break;

        case BSP_EVENT_DISCONNECT:
            err_code = sd_ble_gap_disconnect(m_conn_handle, BLE_HCI_REMOTE_USER_TERMINATED_CONNECTION);
            if (err_code != NRF_ERROR_INVALID_STATE)
            {
                APP_ERROR_CHECK(err_code);
            }
            break;

        case BSP_EVENT_WHITELIST_OFF:
            if (m_conn_handle == BLE_CONN_HANDLE_INVALID)
            {
                err_code = ble_advertising_restart_without_whitelist(&m_advertising);
                if (err_code != NRF_ERROR_INVALID_STATE)
                {
                    APP_ERROR_CHECK(err_code);
                }
            }
            break;

        default:
            break;
    }
}


/**@brief   Function for handling app_uart events.
 *
 * @details This function will receive a single character from the app_uart module and append it to
 *          a string. The string will be be sent over BLE when the last character received was a
 *          'new line' '\n' (hex 0x0A) or if the string has reached the maximum data length.
 */
/**@snippet [Handling the data received over UART] */
void uart_event_handle(app_uart_evt_t * p_event)
{
    static uint8_t data_array[BLE_NUS_MAX_DATA_LEN];
    static uint8_t index = 0;
    uint32_t       err_code;

    switch (p_event->evt_type)
    {
        case APP_UART_DATA_READY:
            UNUSED_VARIABLE(app_uart_get(&data_array[index]));
            index++;

            if ((data_array[index - 1] == '\n') || (index >= (m_ble_nus_max_data_len)))
            {
                NRF_LOG_DEBUG("Ready to send data over BLE NUS");
                NRF_LOG_HEXDUMP_DEBUG(data_array, index);

                do
                {
                    uint16_t length = (uint16_t)index;
                    err_code = ble_nus_data_send(&m_nus, data_array, &length, m_conn_handle);
                    if ( (err_code != NRF_ERROR_INVALID_STATE) && (err_code != NRF_ERROR_BUSY) &&
                         (err_code != NRF_ERROR_NOT_FOUND) )
                    {
                        APP_ERROR_CHECK(err_code);
                    }
                } while (err_code == NRF_ERROR_BUSY);

                index = 0;
            }
            break;

        case APP_UART_COMMUNICATION_ERROR:
            APP_ERROR_HANDLER(p_event->data.error_communication);
            break;

        case APP_UART_FIFO_ERROR:
            APP_ERROR_HANDLER(p_event->data.error_code);
            break;

        default:
            break;
    }
}
/**@snippet [Handling the data received over UART] */


/**@brief  Function for initializing the UART module.
 */
/**@snippet [UART Initialization] */
static void uart_init(void)
{
    uint32_t                     err_code;
    app_uart_comm_params_t const comm_params =
    {
        .rx_pin_no    = RX_PIN_NUMBER,
        .tx_pin_no    = TX_PIN_NUMBER,
        .rts_pin_no   = RTS_PIN_NUMBER,
        .cts_pin_no   = CTS_PIN_NUMBER,
        .flow_control = APP_UART_FLOW_CONTROL_DISABLED,
        .use_parity   = false,
#if defined (UART_PRESENT)
        .baud_rate    = NRF_UART_BAUDRATE_115200
#else
        .baud_rate    = NRF_UARTE_BAUDRATE_115200
#endif
    };

    APP_UART_FIFO_INIT(&comm_params,
                       UART_RX_BUF_SIZE,
                       UART_TX_BUF_SIZE,
                       uart_event_handle,
                       APP_IRQ_PRIORITY_LOWEST,
                       err_code);
    APP_ERROR_CHECK(err_code);
}
/**@snippet [UART Initialization] */



static ret_code_t service_data_set(ble_advertising_t * const p_advertising,
				    uint8_t * service_data)	
{
    uint8_t * p_service_data = ble_advdata_parse(p_advertising->adv_data.adv_data.p_data,
                                          p_advertising->adv_data.adv_data.len,
                                          BLE_GAP_AD_TYPE_SERVICE_DATA);

    if (p_service_data != NULL)
    {
        memcpy(p_service_data, service_data, p_advertising->adv_data.adv_data.len);
    }

    return sd_ble_gap_adv_set_configure(&p_advertising->adv_handle, &p_advertising->adv_data, &p_advertising->adv_params);
}



    
static ble_advertising_init_t 		   m_init_adv_data_and_params;
static ble_advdata_service_data_t      m_service_data;
uint16_t 							   m_sdata;
static ble_uuid_t 					   m_adv_uuids[] = {{0xBEEF, BLE_UUID_TYPE_BLE}};
static ble_gap_phys_t 				   m_phys;
/**@brief Function for initializing the Advertising functionality.
 */
void advertising_init(void)
{
    uint32_t err_code;

    //Build and Set Service Data
    m_service_data.service_uuid       = 0xBAAD;
    m_service_data.data.size          = 2;

//    m_sdata                           = get_new_advertising_data();
    m_service_data.data.p_data        = "Mart";//(uint8_t*)&m_sdata;


    memset(&m_init_adv_data_and_params, 0, sizeof(m_init_adv_data_and_params));

    //Build and Set Advertising Data.
    m_init_adv_data_and_params.advdata.flags                        = BLE_GAP_ADV_FLAGS_LE_ONLY_GENERAL_DISC_MODE;
    m_init_adv_data_and_params.advdata.name_type                    = BLE_ADVDATA_FULL_NAME;
    m_init_adv_data_and_params.advdata.include_appearance           = false;

    m_init_adv_data_and_params.advdata.uuids_complete.uuid_cnt       = sizeof(m_adv_uuids) / sizeof(m_adv_uuids[0]);
    m_init_adv_data_and_params.advdata.uuids_complete.p_uuids        = m_adv_uuids;
    m_init_adv_data_and_params.advdata.p_service_data_array          = &m_service_data;
    m_init_adv_data_and_params.advdata.service_data_count            = 1;

    //Build and Set Advertising Params.
    m_init_adv_data_and_params.config.ble_adv_whitelist_enabled      = true;
    m_init_adv_data_and_params.config.ble_adv_fast_enabled           = true;
    m_init_adv_data_and_params.config.ble_adv_fast_interval          = APP_ADV_INTERVAL;
    m_init_adv_data_and_params.config.ble_adv_fast_timeout           = APP_ADV_DURATION;
    m_init_adv_data_and_params.config.ble_adv_slow_enabled           = true;
    m_init_adv_data_and_params.config.ble_adv_slow_interval          = APP_ADV_INTERVAL;
    m_init_adv_data_and_params.config.ble_adv_slow_timeout           = APP_ADV_DURATION;
    m_init_adv_data_and_params.config.ble_adv_primary_phy            = BLE_GAP_PHY_1MBPS;
    m_init_adv_data_and_params.config.ble_adv_secondary_phy          = BLE_GAP_PHY_1MBPS;


    err_code = ble_advertising_init(&m_advertising, &m_init_adv_data_and_params);
    APP_ERROR_CHECK(err_code);

    ble_advertising_conn_cfg_tag_set(&m_advertising, APP_BLE_CONN_CFG_TAG);
}

/**@brief Function for initializing buttons and leds.
 *
 * @param[out] p_erase_bonds  Will be true if the clear bonding button was pressed to wake the application up.
 */
static void buttons_leds_init(bool * p_erase_bonds)
{
    bsp_event_t startup_event;

    uint32_t err_code = bsp_init(BSP_INIT_LEDS | BSP_INIT_BUTTONS, bsp_event_handler);
    APP_ERROR_CHECK(err_code);

    err_code = bsp_btn_ble_init(NULL, &startup_event);
    APP_ERROR_CHECK(err_code);

    *p_erase_bonds = (startup_event == BSP_EVENT_CLEAR_BONDING_DATA);
}


/**@brief Function for initializing the nrf log module.
 */
static void log_init(void)
{
    ret_code_t err_code = NRF_LOG_INIT(NULL);
    APP_ERROR_CHECK(err_code);

    NRF_LOG_DEFAULT_BACKENDS_INIT();
}


/**@brief Function for initializing power management.
 */
static void power_management_init(void)
{
    ret_code_t err_code;
    err_code = nrf_pwr_mgmt_init();
    APP_ERROR_CHECK(err_code);
}


/**@brief Function for handling the idle state (main loop).
 *
 * @details If there is no pending log operation, then sleep until next the next event occurs.
 */
static void idle_state_handle(void)
{
    UNUSED_RETURN_VALUE(NRF_LOG_PROCESS());
    nrf_pwr_mgmt_run();
}


/**@brief Function for starting advertising.
 */
static void advertising_start(void)
{
    uint32_t err_code = ble_advertising_start(&m_advertising, BLE_ADV_MODE_FAST);
    APP_ERROR_CHECK(err_code);
}

ret_code_t sdata_set(ble_advertising_t * const p_advertising, uint16_t sdata)
{
    uint8_t * p_sdata = ble_advdata_parse(p_advertising->adv_data.adv_data.p_data,
				      p_advertising->adv_data.adv_data.len,
				      BLE_GAP_AD_TYPE_SERVICE_DATA);

    if (p_sdata != NULL)
    {
	*p_sdata = sdata;
	NRF_LOG_ERROR("SData at address 0x%X", p_sdata);
	uint16_t offset = 0;
	ble_advdata_search(p_advertising->adv_data.adv_data.p_data, BLE_GAP_ADV_SET_DATA_SIZE_MAX, &offset, BLE_GAP_AD_TYPE_SERVICE_DATA);
	NRF_LOG_INFO("OFFSET: %d", offset);
    }
    else //Debug
    {
	NRF_LOG_ERROR("No SData!");
    }

    return sd_ble_gap_adv_set_configure(&p_advertising->adv_handle, &p_advertising->adv_data, &p_advertising->adv_params);
}

/**@brief Application main function.
 */
int main(void)
{
    bool erase_bonds;

    // Initialize.
    uart_init();
    log_init();
    timers_init();
    buttons_leds_init(&erase_bonds);
    power_management_init();
    ble_stack_init();
    gap_params_init();
    gatt_init();
    services_init();
    advertising_init();
    conn_params_init();

    // Start execution.
    printf("\r\nUART started.\r\n");
    NRF_LOG_INFO("Debug logging for UART over RTT started.");
    advertising_start();

    
				
    // Enter main loop.
    for (;;)
    {
//        idle_state_handle();
	nrf_delay_ms(1000);
	sdata_set(&m_advertising, 0xC0FE);
	NRF_LOG_FLUSH();
    }
}


/**
 * @}
 */

RE: Updating Advertising Service Data

MartinBL — Thu, 05 Jul 2018 15:08:16 GMT

Hi,

What SDK are you using? I tried to use your advertising_init() and sdata_set() functions together with the ble_app_uart example in SDK 15 and it seems to work fine. ble_advdata_parse() returns the address of Service Data in the advertising packet and the offset is correct. When you call ble_advdata_parse(), can you check the value of p_advertising->adv_data.adv_data.len and make sure that it makes sense? Maybe the length has been altered somewhere and that your Service Data is "out of range".

RE: Updating Advertising Service Data

jloliveira — Wed, 04 Jul 2018 16:11:06 GMT

Hi Martin,

I compiled the parts of code in respect to this matter for you to assess it.

Looking forward to hear any suggestion from you,

Thank you,

João

    //======= main.c =======
    
    static ble_advertising_init_t 		   m_init_adv_data_and_params;
 	static ble_advdata_service_data_t      m_service_data;
	uint16_t 							   m_sdata;
	static ble_uuid_t 					   m_adv_uuids[] = {{UUID_SERV_BEEP, BLE_UUID_TYPE_BLE}};
	static ble_gap_phys_t 				   m_phys;
	
    void advertising_init(void)
    {
    	uint32_t err_code;

    	//Build and Set Service Data
    	m_service_data.service_uuid       = UUID_SERV_BEEP;
    	m_service_data.data.size          = 2;
  
    	m_sdata                           = get_new_advertising_data();
    	m_service_data.data.p_data        = (uint8_t*)&m_sdata;


    	memset(&m_init_adv_data_and_params, 0, sizeof(m_init_adv_data_and_params));

    	//Build and Set Advertising Data.
    	m_init_adv_data_and_params.advdata.flags                        = BLE_GAP_ADV_FLAGS_LE_ONLY_GENERAL_DISC_MODE;
    	m_init_adv_data_and_params.advdata.name_type                    = BLE_ADVDATA_FULL_NAME;
    	m_init_adv_data_and_params.advdata.include_appearance           = false;
    
    	m_init_adv_data_and_params.advdata.uuids_complete.uuid_cnt       = sizeof(m_adv_uuids) / sizeof(m_adv_uuids[0]);
    	m_init_adv_data_and_params.advdata.uuids_complete.p_uuids        = m_adv_uuids;
    	m_init_adv_data_and_params.advdata.p_service_data_array          = &m_service_data;
    	m_init_adv_data_and_params.advdata.service_data_count            = 1;

    	//Build and Set Advertising Params.
    	m_init_adv_data_and_params.config.ble_adv_whitelist_enabled      = true;
    	m_init_adv_data_and_params.config.ble_adv_fast_enabled           = true;
    	m_init_adv_data_and_params.config.ble_adv_fast_interval          = APP_ADV_INTERVAL_FAST;
    	m_init_adv_data_and_params.config.ble_adv_fast_timeout           = APP_ADV_DURATION_10MS_FAST;
    	m_init_adv_data_and_params.config.ble_adv_slow_enabled           = true;
    	m_init_adv_data_and_params.config.ble_adv_slow_interval          = APP_ADV_INTERVAL_SLOW;
    	m_init_adv_data_and_params.config.ble_adv_slow_timeout           = APP_ADV_DURATION_10MS_SLOW;
    	m_init_adv_data_and_params.config.ble_adv_primary_phy            = BLE_GAP_PHY_1MBPS;
    	m_init_adv_data_and_params.config.ble_adv_secondary_phy          = BLE_GAP_PHY_1MBPS;


    	err_code = ble_advertising_init(&m_advertising, &m_init_adv_data_and_params);
    	APP_ERROR_CHECK(err_code);

    	ble_advertising_conn_cfg_tag_set(&m_advertising, APP_BLE_CONN_CFG_TAG);
    }
    
    //====== ble_advertising.c =======
    
    uint32_t ble_advertising_init(ble_advertising_t            * const p_advertising,
                              ble_advertising_init_t const * const p_init)
	{
	
    	uint32_t ret;
    	if ((p_init == NULL) || (p_advertising == NULL))
    	{
    	    return NRF_ERROR_NULL;
    	}
    	if (!config_is_valid(&p_init->config))
    	{
    	    return NRF_ERROR_INVALID_PARAM;
    	}

    	p_advertising->adv_mode_current               = BLE_ADV_MODE_IDLE;
    	p_advertising->adv_modes_config               = p_init->config;
    	p_advertising->conn_cfg_tag                   = BLE_CONN_CFG_TAG_DEFAULT;
    	p_advertising->evt_handler                    = p_init->evt_handler;
    	//p_advertising->error_handler                = p_init->error_handler;
    	p_advertising->current_slave_link_conn_handle = BLE_CONN_HANDLE_INVALID;
    	p_advertising->p_adv_data                     = &p_advertising->adv_data;

    	memset(&p_advertising->peer_address, 0, sizeof(p_advertising->peer_address));

    	if (!p_advertising->initialized)
    	{
        	p_advertising->adv_handle = BLE_GAP_ADV_SET_HANDLE_NOT_SET;
    	}

    	uint16_t max_len = BLE_GAP_ADV_SET_DATA_SIZE_MAX;

    	ret = ble_advdata_encode(&p_init->advdata, p_advertising->enc_advdata, &max_len);
    	VERIFY_SUCCESS(ret);


    	p_advertising->adv_params.primary_phy     = BLE_GAP_PHY_1MBPS;
    	p_advertising->adv_params.duration        = p_advertising->adv_modes_config.ble_adv_fast_timeout;
    
    	p_advertising->adv_params.properties.type = BLE_GAP_ADV_TYPE_CONNECTABLE_SCANNABLE_UNDIRECTED;

    	p_advertising->adv_params.p_peer_addr     = NULL;
    	p_advertising->adv_params.filter_policy   = BLE_GAP_ADV_FP_ANY;
    	p_advertising->adv_params.interval        = p_advertising->adv_modes_config.ble_adv_fast_interval;

    	p_advertising->adv_params.scan_req_notification=true;

    	ret = sd_ble_gap_adv_set_configure(&p_advertising->adv_handle, NULL, &p_advertising->adv_params);
    	VERIFY_SUCCESS(ret);

    	p_advertising->initialized = true;

    	return ret;
	}
	
	ret_code_t sdata_set(ble_advertising_t * const p_advertising, uint16_t sdata)
	{
    	uint8_t * p_sdata = ble_advdata_parse(p_advertising->adv_data.adv_data.p_data,
                                          p_advertising->adv_data.adv_data.len,
                                          BLE_GAP_AD_TYPE_SERVICE_DATA);

    	if (p_sdata != NULL)
    	{
        	*p_sdata = sdata;
    	}
    	else //Debug
    	{
			uint16_t offset = 0;
        	ble_advdata_search(p_advertising->adv_data.adv_data.p_data, BLE_GAP_ADV_SET_DATA_SIZE_MAX, &offset, BLE_GAP_AD_TYPE_SERVICE_DATA);
        	NRF_LOG_INFO("OFFSET: %d", offset);
        }
        
    	return sd_ble_gap_adv_set_configure(&p_advertising->adv_handle, &p_advertising->adv_data, &p_advertising->adv_params);
	}

RE: Updating Advertising Service Data

MartinBL — Wed, 04 Jul 2018 15:43:35 GMT

Not sure what it can be. Do you mind sharing your code? We can make the case private if you prefer confidentiality.

RE: Updating Advertising Service Data

jloliveira — Wed, 04 Jul 2018 15:15:28 GMT

Hi Martin,

Thank you for your reply.

I'm totally sure the advertising packet contains the ServiceData and it is working as expected. I'm updating the whole advertising data everytime I need to update the ServiceData and it works perfectly.

Any queues what might be wrong?

Thank you,

João

RE: Updating Advertising Service Data

MartinBL — Wed, 04 Jul 2018 12:57:52 GMT

Hi,

If ble_advdata_parse() always returns NULL it indicates that your advertising packets doesn't contain any Service Data. Have you confirmed that your packet actually contains a Service Data field before you call ble_advdata_parse()? You can easily see if the field is there with nRF Connect for mobile for example.

If it is there, can you upload your code?