button long-press & short press implement on nRF52

RE: button long-press & short press implement on nRF52

CY — Mon, 15 Jul 2019 10:10:20 GMT

Hi Einar,

I am also trying to do the same feature.

static void bsp_button_event_handler(uint8_t pin_no, uint8_t button_action)
{
    bsp_event_t        event  = BSP_EVENT_NOTHING;
    uint32_t           button = 0;
    uint32_t           err_code;
    static uint8_t     current_long_push_pin_no;              /**< Pin number of a currently pushed button, that could become a long push if held long enough. */
    static bsp_event_t release_event_at_push[BUTTONS_NUMBER]; /**< Array of what the release event of each button was last time it was pushed, so that no release event is sent if the event was bound after the push of the button. */

    button = bsp_board_pin_to_button_idx(pin_no);

    if (button < BUTTONS_NUMBER)
    {
        switch (button_action)
        {
        		case BSP_BUTTON_ACTION_PUSH:
                event = m_events_list[button].push_event;
                if (m_events_list[button].long_push_event != BSP_EVENT_NOTHING)
                {
                    //11/27 Wedy add the note: here can set the timer for long press button
                    err_code = app_timer_start(m_bsp_button_tmr, APP_TIMER_TICKS(BSP_LONG_PUSH_TIMEOUT_MS), (void*)&current_long_push_pin_no); //0716 Wedy add for marked to change the time condition "timer start"
                    if (err_code == NRF_SUCCESS)
                    {
                        current_long_push_pin_no = pin_no;
                    }
                }
                release_event_at_push[button] = m_events_list[button].release_event;
                break;
            case APP_BUTTON_RELEASE:
                (void)app_timer_stop(m_bsp_button_tmr); //0716 Wedy note for timer stop
                if (release_event_at_push[button] == m_events_list[button].release_event)
                {
                    event = m_events_list[button].release_event;
                }
                //11/27 Wedy add to set the long press release function
                /*if (release_event_at_push [button] == m_events_list[button].long_push_event)
                {
                    event=m_events_list[button].release_event;
                }*/
                break;
            case BSP_BUTTON_ACTION_LONG_PUSH:
                event = m_events_list[button].long_push_event;
                //11/27 Wedy add for the long press release Setting
                release_event_at_push[button]=m_events_list[button].long_push_event;
        }
    }

As you mentioned, is it can be achieved by modified the app_button_push to bsp_button_action_push?

I just modified my code, but it still trigger the short press when I was trying to trigger the long press event.

Besides, do you have any idea of double click based on this structure can be shared?

Thanks.

BR,

Wedy

RE: button long-press & short press implement on nRF52

Einar Thorsrud — Thu, 26 Jul 2018 13:40:52 GMT

Hi,

This is expected. The APP_BUTTON_PUSH from the app_button library is on a different "level" (app button library) then BSP_BUTTON_ACTION_LONG_PUSH (BSP library). app_button itself only support button press and release events, and has no concept of the duration of the pushes.

If you want t use BSP_BUTTON_ACTION_LONG_PUSH to get long pushes, then it makes sense to use the BSP_BUTTON_ACTION_PUSH event for the short/normal push, ignoring the app_button events.

RE: button long-press & short press implement on nRF52

jyothi — Wed, 25 Jul 2018 12:33:37 GMT

Hey , I used both push, and long push used in bsp.h,

The functions in the following code in bsp.h are those which I called in main.c

case APP_BUTTON_PUSH:
event = m_events_list[button].push_event;
//if (m_events_list[button].long_push_event != BSP_EVENT_NOTHING)
{
err_code = app_timer_start(m_button_timer_id, BSP_MS_TO_TICK(BSP_LONG_PUSH_TIMEOUT_MS), (void*)&current_long_push_pin_no);
if (err_code == NRF_SUCCESS)
{
current_long_push_pin_no = pin_no;
}
}
release_event_at_push[button] = m_events_list[button].release_event;
break;

case APP_BUTTON_RELEASE:
(void)app_timer_stop(m_button_timer_id);
if (release_event_at_push[button] == m_events_list[button].release_event)
{
event = m_events_list[button].release_event;
}
break;

case BSP_BUTTON_ACTION_LONG_PUSH:
event = m_events_list[button].long_push_event;
press = 2; // long

The thing is that short push is working fine, but for long push button, the output detected is related to both the short push and long push. Its just not giving the output of long push.

RE: button long-press & short press implement on nRF52

jyothi — Thu, 19 Jul 2018 11:40:54 GMT

okay, will try using this. But since I am begginer, I just want to sample codes if there are any!

And also, I need to use the timer right? for making funtionality? So just want to know where do we start timer and detect the press if we use bsp.c

RE: button long-press & short press implement on nRF52

noseed — Thu, 19 Jul 2018 08:57:04 GMT

If you look at the code(bsp.c), you can use it without the BLE function.

RE: button long-press & short press implement on nRF52

jyothi — Thu, 19 Jul 2018 08:47:12 GMT

yeah exactly, but i want to implement without connecting to softdevice and BLE.

I just want to detect long press and detect short press and there by perform small functionalities like prining basing upon the type of pressing.

RE: button long-press & short press implement on nRF52

noseed — Thu, 19 Jul 2018 08:18:24 GMT

그것은 이미 SDK에서 구현됩니다. ( 참조 BSP BLE 버튼 모듈 )