Can not save boot loader setting (bootloader_settings_t) when disable IS_SRVC_CHANGED_CHARACT_PRESENT 0 in bootloader

RE: Can not save boot loader setting (bootloader_settings_t) when disable IS_SRVC_CHANGED_CHARACT_PRESENT 0 in bootloader

Jason — Tue, 11 Sep 2018 03:00:17 GMT

Thanks,

Finally i found where my code go wrong.

/**@brief Function for the Application's S110 SoftDevice event handler.
 *
 * @param[in] p_ble_evt S110 SoftDevice event.
 */
static void on_ble_evt(ble_evt_t * p_ble_evt)
{
    uint32_t                              err_code;
    ble_gatts_rw_authorize_reply_params_t auth_reply;

    switch (p_ble_evt->header.evt_id)
    {
        case BLE_GAP_EVT_CONNECTED:

            m_conn_handle    = p_ble_evt->evt.gap_evt.conn_handle;
            m_is_advertising = false;
            break;

        case BLE_GAP_EVT_DISCONNECTED:
            {
                uint8_t  sys_attr[128];
                uint16_t sys_attr_len = 128;

                m_direct_adv_cnt = APP_DIRECTED_ADV_TIMEOUT;

                err_code = sd_ble_gatts_sys_attr_get(m_conn_handle,
                                                     sys_attr,
                                                     &sys_attr_len,
                                                     BLE_GATTS_SYS_ATTR_FLAG_SYS_SRVCS);
                APP_ERROR_CHECK(err_code);

            }
            if (!m_tear_down_in_progress)
            {
                // The Disconnected event is because of an external event. (Link loss or
                // disconnect triggered by the DFU Controller before the firmware update was
                // complete).
                // Restart advertising so that the DFU Controller can reconnect if possible.
                advertising_start();
            }

            m_conn_handle = BLE_CONN_HANDLE_INVALID;

            break;

In above function, when we get BLE_GAP_EVT_DISCONNECTED,

we also call

                err_code = sd_ble_gatts_sys_attr_get(m_conn_handle,
                                                     sys_attr,
                                                     &sys_attr_len,
                                                     BLE_GATTS_SYS_ATTR_FLAG_SYS_SRVCS);
                APP_ERROR_CHECK(err_code);

I don't know why we call that function, but it will return an NRF_ERROR_NOT_FOUND and make system reboot. I think that removing service change characteristic make my Generic Attribute Service empty and make that error. So my current solution is remove APP_ERROR_CHECK(err_code); line and use the original bootloader_settings_save method.

RE: Can not save boot loader setting (bootloader_settings_t) when disable IS_SRVC_CHANGED_CHARACT_PRESENT 0 in bootloader

bjorn-spockeli — Fri, 31 Aug 2018 08:34:38 GMT

The GATT Service is mandatory in Bluetooth Low Energy peripheral, you cannot remove it.

You should also note that most smartphones cache the GATT table of peers so that they do not have to perform service discovery unless a Service Change notification is sent. If you do not add the SC characteristic.

RE: Can not save boot loader setting (bootloader_settings_t) when disable IS_SRVC_CHANGED_CHARACT_PRESENT 0 in bootloader

Jason — Fri, 31 Aug 2018 02:45:55 GMT

Yes, that's it. With removing Service Changed characteristic, i can also remove Generic Attribute service. It will help improve the discovery time and improve our application performance.

RE: Can not save boot loader setting (bootloader_settings_t) when disable IS_SRVC_CHANGED_CHARACT_PRESENT 0 in bootloader

bjorn-spockeli — Thu, 30 Aug 2018 15:26:44 GMT

What kind of application performance are you referring to? Setting IS_SRVC_CHANGED_CHARACT_PRESENT to 1 will simply include a characteristic in the GATT service, that's it. If you set it to 0 then you remove this characteristic.

RE: Can not save boot loader setting (bootloader_settings_t) when disable IS_SRVC_CHANGED_CHARACT_PRESENT 0 in bootloader

Jason — Thu, 30 Aug 2018 02:28:01 GMT

bjorn-spockeli We think that disable IS_SRVC_CHANGED_CHARACT_PRESENT will improve our application performance. So we have to do the same in bootloader to support DFU process in IOS app. Everything is ok but this issue. Please reply if you have any idea about. Thanks.

RE: Can not save boot loader setting (bootloader_settings_t) when disable IS_SRVC_CHANGED_CHARACT_PRESENT 0 in bootloader

bjorn-spockeli — Wed, 29 Aug 2018 07:18:24 GMT

Jason: In the event log I saw that you replied, but i cant see the reply in the messages section, did you delete it?

RE: Can not save boot loader setting (bootloader_settings_t) when disable IS_SRVC_CHANGED_CHARACT_PRESENT 0 in bootloader

bjorn-spockeli — Fri, 03 Aug 2018 13:32:53 GMT

Could you elaborate on the reason for disabling IS_SRVC_CHANGED_CHARACT_PRESENT both in the application and the bootloader?

Removing the pstorage_clear() call is not a good idea since the following pstorage_store wil then not be able to write the data pointed to by p_settings correctly to flash as it is not cleared prior to the write operation.

RE: Can not save boot loader setting (bootloader_settings_t) when disable IS_SRVC_CHANGED_CHARACT_PRESENT 0 in bootloader

Jason — Fri, 03 Aug 2018 03:59:20 GMT

Thanks for your reply,

I have reason to disable IS_SRVC_CHANGED_CHARACT_PRESENT both in my application and boot loader.

Right now, i can do the dfu process with some changes in bootloader_settings_save method.

This is my old code. When dfu process completed, we call bootloader_settings_save method to clear and save the boot loader setting. And we will not received callbacks from pstorage module.

static void bootloader_settings_save(bootloader_settings_t * p_settings)
{
    uint32_t err_code = pstorage_clear(&m_bootsettings_handle, sizeof(bootloader_settings_t));
    APP_ERROR_CHECK(err_code);

    err_code = pstorage_store(&m_bootsettings_handle,
                              (uint8_t *)p_settings,
                              sizeof(bootloader_settings_t),
                              0);
    APP_ERROR_CHECK(err_code);
}

void bootloader_dfu_update_process(dfu_update_status_t update_status)
{
    static bootloader_settings_t  settings;
    const bootloader_settings_t * p_bootloader_settings;

    bootloader_util_settings_get(&p_bootloader_settings);

    if (update_status.status_code == DFU_UPDATE_APP_COMPLETE)
    {
        settings.bank_0_crc  = update_status.app_crc;
        settings.bank_0_size = update_status.app_size;
        settings.bank_0      = BANK_VALID_APP;
        settings.bank_1      = BANK_INVALID_APP;

        m_update_status      = BOOTLOADER_SETTINGS_SAVING;
        bootloader_settings_save_completed(&settings);
    }
    
    ....

In my new code. I remove the line call pstorage_clear and the dfu process was successful and boot loader can jump in to application.

static void bootloader_settings_save_completed(bootloader_settings_t * p_settings)
{
    uint32_t err_code = pstorage_store(&m_bootsettings_handle,
                              (uint8_t *)p_settings,
                              sizeof(bootloader_settings_t),
                              0);
    APP_ERROR_CHECK(err_code);
}


void bootloader_dfu_update_process(dfu_update_status_t update_status)
{
    static bootloader_settings_t  settings;
    const bootloader_settings_t * p_bootloader_settings;

    bootloader_util_settings_get(&p_bootloader_settings);

    if (update_status.status_code == DFU_UPDATE_APP_COMPLETE)
    {
        settings.bank_0_crc  = update_status.app_crc;
        settings.bank_0_size = update_status.app_size;
        settings.bank_0      = BANK_VALID_APP;
        settings.bank_1      = BANK_INVALID_APP;

        m_update_status      = BOOTLOADER_SETTINGS_SAVING;
        bootloader_settings_save_completed(&settings);
    }
    
    ...

So i think the reason for my problem is calling

pstorage_clear(&m_bootsettings_handle, sizeof(bootloader_settings_t));

But i can not understand why calling that method is making error?

RE: Can not save boot loader setting (bootloader_settings_t) when disable IS_SRVC_CHANGED_CHARACT_PRESENT 0 in bootloader

bjorn-spockeli — Tue, 31 Jul 2018 11:49:42 GMT

I am afraid that I dont understand what the issue. Why are you removing the Service Changed Characteristic in the bootloader project if that results in it not working? Unless there is a specific reason for removing the SC characteristic, then keep it in.