Handling data two times from one of the peripherals

RE: Handling data two times from one of the peripherals

arikyang — Sat, 12 Jan 2019 08:12:59 GMT

I just figure out that somewhere call back ble_nus_c_on_ble_evt() twice cause this problem.

One place I put in ble_evt_handler(), but I can't find another one.

RE: Handling data two times from one of the peripherals

Edvin — Thu, 09 Aug 2018 11:46:26 GMT

Glad it worked!

That is a good idea.

I tried to leave most of the functions, and just comment them out and write the new call below, but I might have forgotten this some places.

Most of the changes were conn_handle and service/characteristic_handle related.

If you want to get all the changes, you can use a diff-tool to compare the new vs old main.c and ble_nus_c.c.

I use this tool: http://meldmerge.org/

Best regards,

Edvin

RE: Handling data two times from one of the peripherals

Seyma Tutuncu — Thu, 09 Aug 2018 10:39:14 GMT

Hi Edvin!

I have just tried and it works. Every data comes as I send from peripherals.

I really appreciate you for your help, now I will look into your code and try to understand the parts that you added/changed.

Thank you very much.

RE: Handling data two times from one of the peripherals

Edvin — Wed, 08 Aug 2018 10:50:37 GMT

Hello,

I have seen a few cases regarding conn_handles and nus_c + multilink, so I looked into it. The issue is that the handles are not handled correctly. E.g. the notif_enable() function which is called in the DISCOVERY_COMPLETE event is different in lbs_c and nus_c.

I have been trying to get it to work for a while, and finally it worked, but I can't say exactly which change I did that made it work.

The only changes I did was in main.c and ble_nus_c.c, so I have attached these. I am sorry, because I have removed some logging and added some logging, but you can clean it up if you like.

Try your project with the attached files, and let me know whether it works or not.

devzone.nordicsemi.com/.../main.c devzone.nordicsemi.com/.../ble_5F00_nus_5F00_c.c

Best regards,

Edvin

RE: Handling data two times from one of the peripherals

Seyma Tutuncu — Tue, 07 Aug 2018 13:00:26 GMT

Hello Edvin,

Firstly, thank you for your attention. I am sorry that I didn't send all files that you need. I applied your suggestion about on_hvx part, and now I can see which daha come from which conn handle. But still from first conn handle (0x1) central can not receive data. From conn handle 0x2, central shows two times the data and conn handle 0x0 is ok.

Also I have controlled the code generation optimization settings and I saw that it is already disabled.

Now I have controlled, compiled and attached the all folder, you can directly use it.

In Multilink_Example>examples you can see both peripheral and central that I use.

File is here.

devzone.nordicsemi.com/.../Multilink_5F00_Example.rar

RE: Handling data two times from one of the peripherals

Edvin — Tue, 07 Aug 2018 08:12:09 GMT

Hello,

I am not able to compile your project. I get a lot of weird compiling errors, but I suspect that it is because you have modified the ble_nus_c.c and ble_nus_c.h files, which does not originally have BLE_NUS_C_ARRAY_DEF in SDK14.2.0.

Try to compile the project that you sent in a freshly unzipped SDK, and see what files that are missing. These are the files that I would need to compile.

Can you check one thing: Does the same behavior occur if you try to disable optimization? In SES you do this in project settings->code->code generation->optimization level.

It may be that the ble_nus_c.c does not pass the conn_handle correctly, since it is originally intended for only one connection (at least in SDK14.2.0).

Can you try to add the conn_handle in the on_hvx() function in ble_nus_c.c.

Change from:

static void on_hvx(ble_nus_c_t * p_ble_nus_c, ble_evt_t const * p_ble_evt)
{
    // HVX can only occur from client sending.
    if (   (p_ble_nus_c->handles.nus_tx_handle != BLE_GATT_HANDLE_INVALID)
        && (p_ble_evt->evt.gattc_evt.params.hvx.handle == p_ble_nus_c->handles.nus_tx_handle)
        && (p_ble_nus_c->evt_handler != NULL))
    {
        ble_nus_c_evt_t ble_nus_c_evt;

        ble_nus_c_evt.evt_type = BLE_NUS_C_EVT_NUS_TX_EVT;
        ble_nus_c_evt.p_data   = (uint8_t *)p_ble_evt->evt.gattc_evt.params.hvx.data;
        ble_nus_c_evt.data_len = p_ble_evt->evt.gattc_evt.params.hvx.len;

        p_ble_nus_c->evt_handler(p_ble_nus_c, &ble_nus_c_evt);
        NRF_LOG_DEBUG("Client sending data.");
    }
}

to:

static void on_hvx(ble_nus_c_t * p_ble_nus_c, ble_evt_t const * p_ble_evt)
{
    // HVX can only occur from client sending.
    if (   (p_ble_nus_c->handles.nus_tx_handle != BLE_GATT_HANDLE_INVALID)
        && (p_ble_evt->evt.gattc_evt.params.hvx.handle == p_ble_nus_c->handles.nus_tx_handle)
        && (p_ble_nus_c->evt_handler != NULL))
    {
        ble_nus_c_evt_t ble_nus_c_evt;

        ble_nus_c_evt.conn_handle = p_ble_nus_c->conn_handle;
        ble_nus_c_evt.evt_type = BLE_NUS_C_EVT_NUS_TX_EVT;
        ble_nus_c_evt.p_data   = (uint8_t *)p_ble_evt->evt.gattc_evt.params.hvx.data;
        ble_nus_c_evt.data_len = p_ble_evt->evt.gattc_evt.params.hvx.len;

        p_ble_nus_c->evt_handler(p_ble_nus_c, &ble_nus_c_evt);
        NRF_LOG_DEBUG("Client sending data.");
    }
}

RE: Handling data two times from one of the peripherals

Seyma Tutuncu — Mon, 06 Aug 2018 14:29:07 GMT

Hi,

Link for the central project file is here. Also I added the .rar file. I use only EYSHSNZWZ board, there isn't any other specific HW. I have only changed the pins for LEDs and there is not any other difference, I think you can use it.

Thank you.

devzone.nordicsemi.com/.../0474.ble_5F00_app_5F00_multilink_5F00_central.rar

RE: Handling data two times from one of the peripherals

Edvin — Mon, 06 Aug 2018 12:20:20 GMT

Hello,

Is it possible to send the central project? Do you use any special HW, such as sensors? Or can I replicate this on the regular DK?

Best regards,

Edvin

RE: Handling data two times from one of the peripherals

Seyma Tutuncu — Thu, 02 Aug 2018 13:10:36 GMT

Hi,

I get the data as 1234512345 while I am sending 12345.

Only from one connection handle I get this.

For example:

From conn handle 0; I send 00 00 00 15 0A, then central gets 00 00 00 15 0A. I see "Uartttan data alindi" part one time. This is OK.

From conn handle 2; I send 00 00 00 16 0A, then central gets 00 00 00 16 0A 00 00 00 16 0A. I see "Uartttan data alindi" part two times.

From conn handle 1; I send 00 00 00 17 0A, then central gets nothing. I don't see "Uartttan data alindi". After I reset conn handle 1, then it becomes conn handle 3, after that I send 00 00 00 17 0A then central get 00 00 00 17 0A. This time I see "Uartttan data alindi" part one time.

To conclude; handle 1 needs resetting to get data from central, and from conn handle 2, I get always 2 bytes consecutively.

I didn't use the ECHOBACK_BLE_UART_DATA, I removed it. Both central and peripherals.

I will consider what you say.

By the way, I have changed

NRF_LOG_INFO("Uartttan data alindi.) part to

NRF_LOG_INFO("Uartttan data alindi. conn_handle= %d", p_ble_nus_evt->conn_handle);

and I always see

0> <info> app: Uartttan data alindi.conn_handle= 0
0> <info> app: Uartttan data alindi.conn_handle= 0

0> <info> app: Uartttan data alindi.conn_handle= 0

from every connection handle. I get two times for handle 2, and one time for handle 0. But for every handle it says conn handle 0. I didn't understand. Because at first central assigns handles correctly at the time of connection.

RE: Handling data two times from one of the peripherals

Edvin — Thu, 02 Aug 2018 08:51:51 GMT

Hello,

Do you get two events, or do you get twice the length on the data?

e.g.:

data = 1234512345 or data = 1122334455?

What does the log look like when you send one message from the device with conn handle 2?

Do you get the line: "Receiving data" two times?

Can you also try to add, in your BLE_NUS_C_EVT_NUS_TX_EVT event:

NRF_LOG_INFO("Uartttan data alindi. conn_handle= %d", p_ble_nus_evt->conn_handle);

to see that you are not actually connected to the same device twice?

I assume that you have the same project/.hex-file on all the peripherals? Do you? do you have any #define ECHOBACK_BLE_UART_DATA in your peripheral project?

Best regards,

Edvin