NRF_LOG_INFO issues when formatting strings

RE: NRF_LOG_INFO issues when formatting strings

Gustavo Velasco-Hernández — Mon, 13 Aug 2018 11:43:05 GMT

I found a solution. The problem is present when char arrays are declared within the function, this is what I had when post the question (file nRF5_SDK_14.2.0/examples/peripheral/saadc/main.c):

void saadc_callback(nrf_drv_saadc_evt_t const * p_event)
{

char test[5] = "test";
char data[8] = "data";

...

NRF_LOG_INFO("%c*%X*%X*%s*%s", test[0], test[0], test, test, data);

...

}

But it was solved declaring the buffers outside the function, it is, at file level:

char test[5] = "test";
char data[8] = "data";

void saadc_callback(nrf_drv_saadc_evt_t const * p_event)
{
...

NRF_LOG_INFO("%c*%X*%X*%s*%s", test[0], test[0], test, test, data);
...

}

In this case, the output of the UART is:

<info> app: t*74*20000054*test*data

The difference I see is that the memory location for the variables is in another range (previous: 0x2003FF14, now: 0x20000054).

RE: NRF_LOG_INFO issues when formatting strings

Gustavo Velasco-Hernández — Mon, 13 Aug 2018 11:22:53 GMT

Thanks Erik for your response. Actually when you declare "test" it includes the null terminator '\0'. For this reason the array should be initiated for 5 elements. Also, sprintf includes the null terminator when storing a formatted string in an array. You must be sure that the array is long enough to store the formatted output. I learnt that the hard way: A critical bug found in production.

RE: NRF_LOG_INFO issues when formatting strings

eriknorth — Mon, 13 Aug 2018 09:45:46 GMT

Hi Gustavo,

Not sure if this will fix it but in general when using %s, strings (char arrays) should be null terminated with "\0".

/Erik