RE: Observation regarding GATT Bearer "Data OUT" Notifications Re-assembly logic and MTU negotiations

Roshan Rajaratnam — Fri, 24 Aug 2018 07:49:34 GMT

This is really good observation just like thst has mentioned. I would really appreciate if you could send a pull request across to our dev branch. Although, I might not agree on completely on the Part 1, because now I can see more clearly where I can improve when reassembling gatt level segmentations as both your and my solution does not seem to care if the incoming message is a part of a gatt level segmented message before appending them and I only check while trying to remove the segmentation bits and this would be wrong if two invalid messages were appended together. I guess the most correct approach would be to check the pdu type even before appending everything in to one packet, to ensure that they are part of the same message as there could be parallel messages.

Thanks again for this

Roshan

RE: Observation regarding GATT Bearer "Data OUT" Notifications Re-assembly logic and MTU negotiations

thst — Thu, 23 Aug 2018 14:36:37 GMT

Hi Srikkanth,

Thank you for digging into the Android-nRF-Mesh-Library, these certainly look like good observations.

The best way to get your changes into the code base and in front of the eyes of our mobile app developers would be to make a PR on the Github project. https://github.com/NordicSemiconductor/Android-nRF-Mesh-Library

Thanks again.

Tom

Mesh Team