Problem with fds: Flash read, write, delete calling that function using android phone.

RE: Problem with fds: Flash read, write, delete calling that function using android phone.

Edvin — Wed, 03 Jul 2019 10:31:59 GMT

Actually, you shouldn't call fds_gc() after each delete. You should do it as few times as possibly. only when you try to write or update a record, and it returns FDS_ERR_NO_SPACE_IN_FLASH, you should run fds_gc().

The reason you don't want to do this too often. The reason for this is that fds_gc() will shuffle around the valid record, and delete the entire old flash page. The flash on the nRF has ~10000 write cycles. This means that after you write to the same address in flash 10000 times, it is not guaranteed to work. (However, it will probably work for 40-50 000, but the "guarantee" is 10 000).

So the FDS handles flash wear leveling by spreading out the records, and marking them as "deleted" and write it in another address rather than deleting and writing to the same place. Therefore, you should only call fds_gc() when you need to. Calling fds_gc() every time you delete a record will "beat up" the flash, making the lifetime a lot shorter.

RE: Problem with fds: Flash read, write, delete calling that function using android phone.

vishal — Wed, 03 Jul 2019 10:13:16 GMT

Thanks for quick response..!

I have also set fds_delete_flag = false; after delete_all_reading_process().

Just one question Is it necessary to call fds_gc(); after each delete record event?

ret_code_t fds_delete_file(uint16_t file_ID) {
  ret_code_t ret = fds_file_delete(file_ID);
  if (ret != FDS_SUCCESS) {
    return ret;
  }
  wait_for_next_delete(); /* wait for this stored file successfully deleted*/
  /* Call garbage collector to clean dummpy data from flash*/
  ret = fds_gc(); 
  if (ret != FDS_SUCCESS) {
    return ret;
  }
  return NRF_SUCCESS;
}

What will happen if not call fds_gc(); after delete event.

Thanks...

RE: Problem with fds: Flash read, write, delete calling that function using android phone.

Edvin — Wed, 03 Jul 2019 09:34:29 GMT

Yes. That looks good.

[quote user="vishal.borle"]I have set fds_delete_flag = false; when last flash operation success.[/quote]

If I were to suggest one change, maybe set the fds_delete_flag = false directly after calling delete_all_reading_process(); so that it doesn't attempt to run delete_all_reading_process() several times. You can rather set it back to true if the delete event is called with result != success to try again.

RE: Problem with fds: Flash read, write, delete calling that function using android phone.

vishal — Wed, 03 Jul 2019 09:08:56 GMT

Hi Edvin,

As per you suggested above program snippet this is working and we are able to sent response after completion of flash process.

Here is my below is this correct shall we go ahead?

  for (;;) {
    if (fds_delete_flag == true) {
      delete_all_reading_process();
    }
    if (sleep_mode_enable == true) {
      sleep_mode_enter();
      sleep_mode_enable = false;
    }
    idle_state_handle();
  }

I have set fds_delete_flag = false; when last flash operation success.

Now every thing is working fine.

Thanks for the your suggestion.

RE: Problem with fds: Flash read, write, delete calling that function using android phone.

Edvin — Wed, 26 Jun 2019 13:00:10 GMT

Ok. You are calling it from the nus_data_handler. This is a softdevice interrupt, so it will not allow the FDS to start before you exit this interrupt.

You need to exit this function (let it run to the end) before you start your FDS operations. Very simplified, it will look something like this:

//near top of main.c:
static volatile bool fds_delete_flag = false;


nus_data_handler()
{

... 
    case '8':
    fds_delete_flag = true;
    break;
...
}


int main(void)
{
    ret_code_t err_code;
    init_everything();
    ...
    
    for (;;)
    {
        if (fds_delete_flag == true)
        {
            err_code = fds_delete_file();
            if (err_code == NRF_SUCCESS)
            {
                fds_delete_flag = false;
            }
        }
        power_manage();
    }
}

The point is to exit the nus_data_handler() before you call the FDS functions.

RE: Problem with fds: Flash read, write, delete calling that function using android phone.

vishal — Wed, 26 Jun 2019 12:06:25 GMT

I am calling fds_delete_file() from main here is below snippet:

static void nus_data_handler(ble_nus_evt_t *p_evt) {
  if (p_evt->type == BLE_NUS_EVT_RX_DATA) {
//    uint32_t err_code;
    NRF_LOG_DEBUG("Received data from BLE NUS. Writing data on UART.");
    NRF_LOG_HEXDUMP_DEBUG(p_evt->params.rx_data.p_data, p_evt->params.rx_data.length);
    switch (p_evt->params.rx_data.p_data[0]) {
    ...
    case '8': // To detach configured machine info.
      NRF_LOG_INFO("8 cmd received");
      delete_all_reading_process();
      ...

/* This function is used for delete all stored reading availble in flash even if any not available then clean flash for that file number*/
void delete_all_reading_process() {
  uint16_t file_no;
  ret_code_t ret;
  ret = fds_find_and_delete(FILE_ID_FRONT_REAR_VAL, REC_KEY_FRONT_REAR_VAL);
  if (ret == FDS_SUCCESS) {
    NRF_LOG_INFO("Deleted front & rear value");
  }
  for (file_no = 1; file_no <= READINGS_STORE; file_no++) {
    NRF_LOG_INFO("Deleting File no:%d", file_no);
    ret = fds_delete_file(file_no);
  }
  if (ret != FDS_SUCCESS) {
    ble_nus_data_send(&m_nus, DETACH_MACH_FAILED, &msg_code_len, m_conn_handle); // send message to connected phone
  }
  detached_machine_info();
}

If this wrong how I can set flag from the SD interrupt. I am not understand how i can check this is it inside a soft-device interrupt.

I am calling this function from nus_data_handler(..);

Thanks...

RE: Problem with fds: Flash read, write, delete calling that function using android phone.

Edvin — Wed, 26 Jun 2019 10:46:43 GMT

From where are you calling the fds_delete_file()? Is it inside a softdevice interrupt? If so, you may block the FDS. You should set a flag from the SD interrupt, and then call the FDS functions from the main context.

RE: Problem with fds: Flash read, write, delete calling that function using android phone.

vishal — Wed, 26 Jun 2019 09:20:31 GMT

I have tried min and max to 100ms, but still same problem.

[quote userid="26071" url="~/f/nordic-q-a/37743/problem-with-fds-flash-read-write-delete-calling-that-function-using-android-phone/194756"]Can you try to do the delete function without being in a connection and without advertising? Does it work then?[/quote]

Yes actually if i have called this function without any BLE activity it has worked and also got all fds event.

Why this happening only when BLE advertising OR with connected?

RE: Problem with fds: Flash read, write, delete calling that function using android phone.

Edvin — Wed, 26 Jun 2019 06:48:25 GMT

Can you try to increase the connection interval even more? E.g. try to set both min and max to 100.

Can you try to do the delete function without being in a connection and without advertising? Does it work then?

RE: Problem with fds: Flash read, write, delete calling that function using android phone.

vishal — Tue, 25 Jun 2019 14:21:32 GMT

Yes, the connection state is connected when i call to delete function,

#define APP_BLE_CONN_CFG_TAG 1                           /**< A tag identifying the SoftDevice BLE configuration. */
#define DEVICE_NAME "Device_test"                         /**< Name of device. Will be included in the advertising data. */
#define NUS_SERVICE_UUID_TYPE BLE_UUID_TYPE_VENDOR_BEGIN /**< UUID type for the Nordic UART Service (vendor specific). */

#define APP_BLE_OBSERVER_PRIO 3 /**< Application's BLE observer priority. You shouldn't need to modify this value. */
#define APP_ADV_INTERVAL 64     /**< The advertising interval (in units of 0.625 ms. This value corresponds to 40 ms). */

#define APP_ADV_DURATION 0   /* Set 0 for contineous advertisng time & handle their timeout by sperate app timer.*/ 

#define MIN_CONN_INTERVAL MSEC_TO_UNITS(7.5, UNIT_1_25_MS)   //20           /**< Minimum acceptable connection interval (20 ms), Connection interval uses 1.25 ms units. */
#define MAX_CONN_INTERVAL MSEC_TO_UNITS(7.5, UNIT_1_25_MS)   //75           /**< Maximum acceptable connection interval (75 ms), Connection interval uses 1.25 ms units. */
#define SLAVE_LATENCY 0                                      /**< Slave latency. */
#define CONN_SUP_TIMEOUT MSEC_TO_UNITS(4000, UNIT_10_MS)     /**< Connection supervisory timeout (4 seconds), Supervision Timeout uses 10 ms units. */
#define FIRST_CONN_PARAMS_UPDATE_DELAY APP_TIMER_TICKS(5000) /**< Time from initiating event (connect or start of notification) to first time sd_ble_gap_conn_param_update is called (5 seconds). */
#define NEXT_CONN_PARAMS_UPDATE_DELAY APP_TIMER_TICKS(90000) /**< Time between each call to sd_ble_gap_conn_param_update after the first call (30 seconds). */
#define MAX_CONN_PARAMS_UPDATE_COUNT 3                       /**< Number of attempts before giving up the connection parameter negotiation. */

Please note I have already tried with connection interval below:

#define MIN_CONN_INTERVAL MSEC_TO_UNITS(20, UNIT_1_25_MS)   //20           /**< Minimum acceptable connection interval (20 ms), Connection interval uses 1.25 ms units. */
#define MAX_CONN_INTERVAL MSEC_TO_UNITS(75, UNIT_1_25_MS)   //75

Thanks

RE: Problem with fds: Flash read, write, delete calling that function using android phone.

Edvin — Tue, 25 Jun 2019 13:31:31 GMT

The priority is lower for FDS than for BLE, yes, but it has to be that way. The BLE will not block you all the time. Only short interrupts.

What is your connection state when you try to delete? I assume it is connected? If so, what is your connection interval?

RE: Problem with fds: Flash read, write, delete calling that function using android phone.

vishal — Tue, 25 Jun 2019 13:16:12 GMT

[quote userid="26071" url="~/f/nordic-q-a/37743/problem-with-fds-flash-read-write-delete-calling-that-function-using-android-phone/194663"]Do you get the return value NRF_SUCCESS (= 0) from fds_file_delete()? And you are sure that the wait_for_next_delete() function is hit?[/quote]

Yes I got NRF_SUCESS from fds_file_delete(), and sure bout wait_for_next_delete() function hit.

I have check by set break point with FDS_EVT_DEL_RECORD and FDS_EVT_DEL_FILE but nothing get.

[quote userid="26071" url="~/f/nordic-q-a/37743/problem-with-fds-flash-read-write-delete-calling-that-function-using-android-phone/194663"]Also, can you try to remove the idle_state_handle(); from inside the while loop in the wait_for_next_delete() function?[/quote]

this already i have tried.

This happening only when if used wait_for_next_delete() If I comment this then got all event and also clean flash. Here is my below logs without wait for next delete:

<debug> app: Received data from BLE NUS. Writing data on UART.
<debug> app:  38                     |8       
<info> app: 8 cmd received
<info> app: Deleted record ID: 8 

<info> app: Deleted front & rear value
<info> app: Deleting File no:1
<info> app: Deleting File no:2
<info> app: Deleting File no:3
<info> app: Deleting File no:4
<info> app: Deleting File no:5
<info> app: Deleting File no:6
<info> app: Deleting File no:7
<info> app: Deleting File no:8
<info> app: Deleted record ID: 1 

<info> app: FDS mach-ID delete success
<info> app: Deleted record ID: 2 

<info> app: FDS Cron-Sch delete success
<info> app: Deleted record ID: 30 

<info> app: FDS Any Stored ERROR delete success
<info> app: Garbage Collection completed
<info> app: Flash data File deleted
<info> app: Disconnected
<debug> app: Started Advertisng timeout timer
<info> app: Garbage Collection completed
<info> app: Flash data File deleted
<info> app: Garbage Collection completed
<info> app: Flash data File deleted
<info> app: Garbage Collection completed
<info> app: Flash data File deleted
<info> app: Garbage Collection completed
<info> app: Flash data File deleted
<info> app: Garbage Collection completed
<info> app: Flash data File deleted
<info> app: Garbage Collection completed
<info> app: Flash data File deleted
<info> app: Garbage Collection completed
<info> app: Flash data File deleted
<info> app: Garbage Collection completed
<info> app: Flash data record deleted
<info> app: Garbage Collection completed
<info> app: Flash data record deleted
<info> app: Garbage Collection completed
<info> app: Flash data record deleted
<info> app: Garbage Collection completed
<info> app: Flash data record deleted
<info> app: Garbage Collection completed

I have read some ques and answer from Nordic forum link here someone suggest the intrrupt priority of FDS module is lower than BLE priority is this correct?

If yes how I can change the priority to get fds event with ble connected to device?

Thanks.......

RE: Problem with fds: Flash read, write, delete calling that function using android phone.

Edvin — Tue, 25 Jun 2019 12:59:38 GMT

Do you get the return value NRF_SUCCESS (= 0) from fds_file_delete()? And you are sure that the wait_for_next_delete() function is hit?

Maybe you get the FDS_EVT_DEL_FILE event with p_fds_evt->result != FDS_SUCCESS? Can you check this?

Also, can you try to remove the idle_state_handle(); from inside the while loop in the wait_for_next_delete() function?

RE: Problem with fds: Flash read, write, delete calling that function using android phone.

vishal — Tue, 25 Jun 2019 12:42:49 GMT

Thanks for quick response..!!!

I have made changes as you suggested and error code is 0 means NRF_SUCCESS

But still same issue.. it continuous in forever loop.

Any other suggestion please...

RE: Problem with fds: Flash read, write, delete calling that function using android phone.

Edvin — Tue, 25 Jun 2019 12:14:41 GMT

Ok. so two issues, then:

1: fds_file_delete() will trigger the FDS_EVT_DEL_RECORD event, which will set fds_delete_success = true. You are waiting for the fds_write_success to become true. It never will.

2: In your fds_delete_file(). If one of the function calls inside here returns ret != NRF_SUCCESS, your FDS operations aren't queued.

So let us say that inside fds_delete_files() returns e.g. FDS_ERR_NO_SPACE_IN_QUEUES, then fds_delete_file() returns FDS_ERR_NO_SPACE_IN_QUEUE, but your delete operation is not queued, and you will never get the FDS_EVT_DEL_RECORD (or the FDS_EVT_WRITE, for that matter. See issue 1.)

However, you wait for this event (the wrong one) before you check the return value of fds_file_delete();

You should check the return value before you wait for the event. Something like this:

ret_code_t fds_delete_file(uint16_t file_ID)
{
    ret_code_t ret = fds_file_delete(file_ID);
    if (ret != FDS_SUCCESS)
    {
        return ret;
    }
    wait_for_next_delete(); // PLEASE NOTE THIS CHANGE. not wait_for_next_write()
    ...
}

RE: Problem with fds: Flash read, write, delete calling that function using android phone.

vishal — Tue, 25 Jun 2019 11:37:32 GMT

I am waiting for the FDS_EVT_DEL_RECORD OR FDS_EVT_DEL_FILE but nothing get only when connected with BLE activity.

Is this any priority issue?

Here is my below updated functions:

void fds_evt_handler(fds_evt_t const *const p_fds_evt) {
  switch (p_fds_evt->id) {
  case FDS_EVT_INIT:
    if (p_fds_evt->result != FDS_SUCCESS) {
      // Initialization failed.
    }
    m_fds_init_success = true;
    break;
  case FDS_EVT_WRITE:
    if (p_fds_evt->result == FDS_SUCCESS) {
      NRF_LOG_INFO("Flash Write event generated");
      fds_write_success = true;
    }
    fds_allocation_for_write(0);
    break;
  case FDS_EVT_DEL_RECORD:
    if (p_fds_evt->result == FDS_SUCCESS) {
      NRF_LOG_INFO("Flash data record deleted");
      fds_delete_success = true;
    }
    break;
  case FDS_EVT_DEL_FILE:
    if (p_fds_evt->result == FDS_SUCCESS) {
      NRF_LOG_INFO("Flash data File deleted");
      fds_delete_success = true;
    }
    break;
  case FDS_EVT_UPDATE:
    if (p_fds_evt->result == FDS_SUCCESS) {
      NRF_LOG_INFO("Flash data updated");
      fds_write_success = true;
    }
    fds_allocation_for_write(0);
    break;
  case FDS_EVT_GC:
    if (p_fds_evt->result == FDS_SUCCESS) {
      NRF_LOG_INFO("Garbage Collection completed");
    }
    break;
  default:
    break;
  }
}

void wait_for_next_delete(void) {
  while (!fds_delete_success) {
    idle_state_handle();
  }
  fds_delete_success = false;
}

RE: Problem with fds: Flash read, write, delete calling that function using android phone.

Edvin — Tue, 25 Jun 2019 10:56:17 GMT

Are you waiting for the fds_write_success after you deleted a record? Wouldn't that give the FDS_EVT_DEL_RECORD event, which will set m_fds_delete_success = true? At least if you haven't changed anything since the snippets that you sent 7 months ago.

RE: Problem with fds: Flash read, write, delete calling that function using android phone.

vishal — Tue, 25 Jun 2019 10:30:21 GMT

Hi Edvin,

Sorry for very late reply, we have released our product.

Will you please help me with below issue:

Let's say in my device flash stored some data in 8 files. I want to delete this file once command received from mobile app with connected.

Here is my below function for deleting files while app connected:

ret_code_t fds_delete_file(uint16_t file_ID) {
  ret_code_t ret = fds_file_delete(file_ID);
  wait_for_next_write(); /* wait for this stored file successfully deleted*/
  if (ret != FDS_SUCCESS) {
    return ret;
  }
  /* Call garbage collector to clean dummpy data from flash*/
  ret = fds_gc(); 
  if (ret != FDS_SUCCESS) {
    return ret;
  }
  return NRF_SUCCESS;
}

void wait_for_next_write(void) {
  while (!fds_write_success) {
    idle_state_handle();
  }
  fds_write_success = false;
}

But now problem getting when i connect device and send command to call this function it will continuous waiting for fds_evt_handler();

But fds_evt_handler(); is not generated. If I comment to wait_for_next_write() function that time fds event getting but got success response before flash clean.

I want to get success response once flash data successfully deleted with ble connected with app.

Looking forward your response..!!!

Thanks.

RE: Problem with fds: Flash read, write, delete calling that function using android phone.

awneil — Thu, 03 Jan 2019 20:35:00 GMT

Regarding mentioning names with spaces, I've made a Backstage thread for that:

https://devzone.nordicsemi.com/backstage/f/welcome-to-the-devzone/42127/how-to-mention-names-with-spaces

RE: Problem with fds: Flash read, write, delete calling that function using android phone.

Edvin — Wed, 21 Nov 2018 07:56:59 GMT

This seems correct, but it is not the same as in your previous reply, so I am a bit confused.

To the left is your last snippet, and to the right is the snippet from your previous reply:

So did it work after you added the waiting?

RE: Problem with fds: Flash read, write, delete calling that function using android phone.

vishal — Tue, 20 Nov 2018 16:26:24 GMT

Thanks for quick response,

Here is bellow wait for update or write event:

static ret_code_t fds_write(uint16_t file_ID, uint16_t rec_key) {
  NRF_LOG_INFO("In flashing: %s", (uint32_t)fds_write_buff);
  ret_code_t err_code;
  fds_record_t record;
  fds_record_desc_t record_desc;
  fds_find_token_t ftoken;
  memset(&ftoken, 0x00, sizeof(fds_find_token_t));
  // Set up record.
  record.file_id = file_ID;
  record.key = rec_key;
  record.data.p_data = &fds_write_buff;
  record.data.length_words = (sizeof(fds_write_buff) + 3) / 4; //sizeof(m_deadbeef)/sizeof(uint8_t);

  if (fds_record_find(file_ID, rec_key, &record_desc, &ftoken) == FDS_SUCCESS) {
    err_code = fds_record_update(&record_desc, &record);
    APP_ERROR_CHECK(err_code);
	while(!m_fds_update_success)
    {
        // wait
    }
    m_fds_update_success = false;
  }
  else
  {
    err_code = fds_record_write(&record_desc, &record);
    APP_ERROR_CHECK(err_code);
	while(!m_fds_write_success)
    {
        // wait
    }
    m_fds_write_success = false;
  }
  return NRF_SUCCESS;
}

set this flag true in fds event :

  case FDS_EVT_WRITE:
    if (p_fds_evt->result == FDS_SUCCESS) {
      m_fds_write_success = true;
      NRF_LOG_INFO("Flash Write event generated");
    }
    break;
  case FDS_EVT_DEL_RECORD:
    if (p_fds_evt->result == FDS_SUCCESS) {
      NRF_LOG_INFO("Flash data record deleted");
      m_fds_delete_success = true;
    }
  case FDS_EVT_DEL_FILE:
    if (p_fds_evt->result == FDS_SUCCESS) {
      NRF_LOG_INFO("Flash data File deleted");
    }
  case FDS_EVT_UPDATE:
    if (p_fds_evt->result == FDS_SUCCESS) {
      NRF_LOG_INFO("Flash data updated");
      m_fds_update_success = true;
    }

[quote userid="26071" url="~/f/nordic-q-a/37743/problem-with-fds-flash-read-write-delete-calling-that-function-using-android-phone/158223"] How do you wait in your application?[/quote]

means this is same as above right if not can you please provide program snippet for wait in application.

Thanks you.....

RE: Problem with fds: Flash read, write, delete calling that function using android phone.

Edvin — Tue, 20 Nov 2018 14:55:23 GMT

I meant that you could test the project I attached to see how to do it, not port your current project.

Are you waiting for the udate or write event BEFORE you read the data from flash again?

[quote user="vishal.borle"]Another problem is if i set flag on each write & update record data event for wait that time BLE is hang not worked another functionality need to reset. So i removed wait flash in my fds_write function.[/quote]

How do you wait in your application?

RE: Problem with fds: Flash read, write, delete calling that function using android phone.

vishal — Tue, 20 Nov 2018 13:59:13 GMT

Hi Edvin,

I am not test my current project with new sdk due not having much time.

So i have modify my fds_write function as like bellow:

static ret_code_t fds_write(uint16_t file_ID, uint16_t rec_key) {
  NRF_LOG_INFO("In flashing: %s", (uint32_t)fds_write_buff);
  ret_code_t err_code;
  fds_record_t record;
  fds_record_desc_t record_desc;
  fds_find_token_t ftoken;
  memset(&ftoken, 0x00, sizeof(fds_find_token_t));
  // Set up record.
  record.file_id = file_ID;
  record.key = rec_key;
  record.data.p_data = &fds_write_buff;
  record.data.length_words = (sizeof(fds_write_buff) + 3) / 4; //sizeof(m_deadbeef)/sizeof(uint8_t);

  if (fds_record_find(file_ID, rec_key, &record_desc, &ftoken) == FDS_SUCCESS) {
    err_code = fds_record_update(&record_desc, &record);
    APP_ERROR_CHECK(err_code);
  }
  else
  {
    err_code = fds_record_write(&record_desc, &record);
    APP_ERROR_CHECK(err_code);
  }
  return NRF_SUCCESS;
}

In this function got another issue which is:

When i erase complete chip and flash my program then using android phone call command and store required config. in flash this is worked.

Now after when i connect phone read flash data is correct and that same time i call command to update flash data updated event got. but not get this data.

When i disconnect BLE connection and call update flash data then got correct data. Means i am trying to say before send command flash data update first disconnect and connect again then send this command That way got flash config. data.

Another problem is if i set flag on each write & update record data event for wait that time BLE is hang not worked another functionality need to reset. So i removed wait flash in my fds_write function.

Will you please tell me why this happen, If i disconnect BLE connection and connect then send flash update command to device that time flash data successfully updated and also got updated flash data.

Waiting for your response..

Thanks....!!

RE: Problem with fds: Flash read, write, delete calling that function using android phone.

Edvin — Wed, 31 Oct 2018 10:08:11 GMT

Try the attached project with SDK15.2.0 (download here).

I used the Keil IDE, so if you want to use something else, e.g. Segger Embedded Studio, please add the files:

fds.c

nrf_fstorage.c

nrf_fstorage_sd.c

devzone.nordicsemi.com/.../ble_5F00_app_5F00_uart_5F00_fds.zip

Best regards,

Edvin

RE: Problem with fds: Flash read, write, delete calling that function using android phone.

vishal — Tue, 30 Oct 2018 15:39:50 GMT

I have tried this above method but still getting same problem. One think is in there when i call fds_write(..);

got successfully flash also getting deleted ID of previous. Before turn off dev board when i send fds_read(...); getting correct buffer as flashed not getting empty. But when i switch off and ON board that time getting empty read from flash.

Still i am finding the solution not working. the flash read write method is very irritated sometime work sometime not. Please can you provide other way for fix this issue.

Thanks you..!!