RE: Bug in Discovery Module ble_db_discovery.c

Tielman — Fri, 05 Apr 2019 12:18:43 GMT

My code is based on SDK 15.0 so it might have already been fixed. Regardless, here is what I did:

In the ble_db_discovery.c is a function called "discovery_complete_evt_trigger". At the end of the function instead of incrementing the events counter and then sending the events as a bundle to the higher layer handlers, I simply send the event immediately. Here is the change I made:

m_pending_user_evts[m_pending_usr_evt_index].evt_handler = p_evt_handler;

// +++++ I added the following line to send every event as it is received and leave it to the upper layer driver to handle the individual events
m_pending_user_evts[0].evt_handler(&(m_pending_user_evts[0].evt));

/* +++++ The below part is what I removed
m_pending_usr_evt_index++;

if (m_pending_usr_evt_index == m_num_of_handlers_reg)
{
    // All registered modules have pending events. Send all pending events to the user
    // modules.
	NRF_LOG_ERROR("x%d%dx",conn_handle,m_pending_usr_evt_index);
    pending_user_evts_send();
}
else
{
    // Too many events pending. Do nothing. (Ideally this should not happen.)
	NRF_LOG_ERROR("x%d%dx",conn_handle,m_pending_usr_evt_index);
}*/

This is not a perfect fix but works great for me.

Hope it helps.

RE: Bug in Discovery Module ble_db_discovery.c

goldwake — Tue, 02 Apr 2019 02:23:55 GMT

hi Tielman, could you post your workaround?. Thanks

RE: Bug in Discovery Module ble_db_discovery.c

Tielman — Thu, 23 Aug 2018 12:35:45 GMT

That's fine, thanks. The workaround works great.

RE: Bug in Discovery Module ble_db_discovery.c

run_ar — Thu, 23 Aug 2018 11:22:58 GMT

Hi,

Thank you for notifying us about this bug. I have added this to our internal tracking system, and it is currently being added to SDK 15 known issues. Unfortunately, I am afraid we do not have time to fix this before the next sdk release.