SDK 15.1 nrfx_qspi.h wont compile under C++

RE: SDK 15.1 nrfx_qspi.h wont compile under C++

Peter Kenyon — Tue, 22 Oct 2019 11:57:54 GMT

fixed in sdk 16.0 and latest nrfx drivers

RE: SDK 15.1 nrfx_qspi.h wont compile under C++

tesc — Fri, 21 Sep 2018 12:34:56 GMT

Hi,

Thank you! We may choose to do some changes to the SDK in the future, for better compatibility with C++, based on your feedback.

Regards,
Terje

RE: SDK 15.1 nrfx_qspi.h wont compile under C++

Peter Kenyon — Wed, 19 Sep 2018 10:51:13 GMT

nrfx_qspi.h:

o rearrange the static initialisers in order of declaration

@@ -83,0 +84 @@ typedef struct
+    .irq_priority   = (uint8_t)NRFX_QSPI_CONFIG_IRQ_PRIORITY,           \
@@ -90,0 +92 @@ typedef struct
+        .sck_freq   = (nrf_qspi_frequency_t)NRFX_QSPI_CONFIG_FREQUENCY, \
@@ -92 +93,0 @@ typedef struct
-        .dpmen      = false,                                            \
@@ -94 +95 @@ typedef struct
-        .sck_freq   = (nrf_qspi_frequency_t)NRFX_QSPI_CONFIG_FREQUENCY, \
+        .dpmen      = false                                             \
@@ -96 +96,0 @@ typedef struct
-    .irq_priority   = (uint8_t)NRFX_QSPI_CONFIG_IRQ_PRIORITY,           \

nrf_pwr_mgmt.h:

o Add a C++ inclusion guard

@@ -55,5 +54,0 @@
-#ifdef __cplusplus
-extern "C" {
-#endif
-
@@ -154,4 +148,0 @@ void nrf_pwr_mgmt_shutdown(nrf_pwr_mgmt_shutdown_t
-#ifdef __cplusplus
-}
-#endif

app_util.h

o comment out the STATIC ASSERTs

@@ -206,2 +206,2 @@ enum
-#define STATIC_ASSERT_SIMPLE(EXPR)      //_Static_assert(EXPR, "unspecified message")
-#define STATIC_ASSERT_MSG(EXPR, MSG)    //_Static_assert(EXPR, MSG)
+#define STATIC_ASSERT_SIMPLE(EXPR)      _Static_assert(EXPR, "unspecified message")
+#define STATIC_ASSERT_MSG(EXPR, MSG)    _Static_assert(EXPR, MSG)

RE: SDK 15.1 nrfx_qspi.h wont compile under C++

tesc — Tue, 18 Sep 2018 09:23:34 GMT

Hi,

I see. What are the required changes, is there anything we should do in those files to facilitate C++?

Regards,
Terje

RE: SDK 15.1 nrfx_qspi.h wont compile under C++

Peter Kenyon — Tue, 18 Sep 2018 07:57:03 GMT

No problem I have to patch a few files to get C++ to work, ie

app_util.h,

nrf_pwr_mgmt.h

nrfx_qspi.h

RE: SDK 15.1 nrfx_qspi.h wont compile under C++

tesc — Mon, 17 Sep 2018 15:34:58 GMT

Hi,

Unfortunately yes, we were made aware of this issue too late for including any patch for it in the v15.2 release.

Regards,
Terje

RE: SDK 15.1 nrfx_qspi.h wont compile under C++

Peter Kenyon — Mon, 17 Sep 2018 12:37:45 GMT

Also for 15.2

RE: SDK 15.1 nrfx_qspi.h wont compile under C++

tesc — Fri, 07 Sep 2018 11:51:35 GMT

Hi,

Thank you for the clarification. I have registered the issue in our internal tracker. As you write this should be easy to fix, so hopefully it will not take too long.

In the mean time you will have to do the modification manually.

Regards,
Terje

RE: SDK 15.1 nrfx_qspi.h wont compile under C++

Peter Kenyon — Thu, 06 Sep 2018 15:05:51 GMT

Yes by rearranging the initialisers so that they appear in the order of declaration then the compiler can cope, The problem is in the order of the initialisers, so dead easy to fix

RE: SDK 15.1 nrfx_qspi.h wont compile under C++

tesc — Thu, 06 Sep 2018 12:23:29 GMT

Hi,

Thank you for the input.

Does it fail even when __cplusplus is defined, so that the full header file is inside an extern "C" block?

Regards,
Terje