RE: Design patterns and useability

AndersLundqvist — Thu, 27 Sep 2018 12:05:33 GMT

Hi Einar,

Making a complete SDK for several differnt processors is not an easy task... And making structural changes to the vast SDK is not something you do unless you really, really have no other option. I do not envy your developers in any way.

Perhaps I am just another "grumpy old man" who have spent his last 24 years programming various processors, languages and operative systems. Over the years I have come across code in all forms and structures, some of which I have come to appreciate and therefore reuse as often as I can. As you probably already have guessed, that will not be the case with nRF SDK5 (or any similar code). That do not in any way imply that the code is bad, on the contrary, the fact that your programmers have managed to get a working (well almost working) SDK from this code is an achievement. I am also sure that there are plenty of programmers out there who disagree with me and thinks that the SDK is the "jewel in the crown" and I have nothing but envy for them, wishing I was like them, but sadly I am not.

One final word of advice to your programmers: Admittedly there are advantages of having code in "defines", but when defines contains one or more defines that in turn contains defines and so on, things get a little "out of focus". It may of course be intentional so that no clumsy *** (like myself) even attempts to alter any of the code, but it is hard to understand and especially debug (if you, like I, have had to do) to understand why things do not work as expected.

Best regards

Anders

RE: Design patterns and useability

Einar Thorsrud — Thu, 27 Sep 2018 11:35:22 GMT

Hi Anders,

I agree with you on all points. The SDK team is aware of this and I believe many of these points will be addressed in the future. But as you write, the SDK is quite large, so it is difficult to change everything overnight.