Light Switch Client stop due to ++m_scheduler.event_count < 0?

RE: Light Switch Client stop due to ++m_scheduler.event_count < 0?

Mike — Thu, 29 Nov 2018 20:35:08 GMT

I just discovered this issue myself, and out of curiosity, I searched to see if anyone else has reported it.

I can add a clarification to the provided solution: since the count is incremented when an event is added to the queue, so too must the count be decremented when an event is removed from the queue. There are 2 places that events can be removed from the scheduler queue: in fire_timers and in remove_evt. I copied the decrement instruction from fire_timers and inserted it in remove_evt before line 108:

if (p_it->p_next == p_evt)
{
    NRF_MESH_ASSERT(m_scheduler.event_count-- > 0); //ATTENTION: unofficial modification
    p_it->p_next = p_evt->p_next;
    break;
}

RE: Light Switch Client stop due to ++m_scheduler.event_count < 0?

karinca — Thu, 22 Nov 2018 13:42:20 GMT

this is not working, it causing mesh assert. Could you please explain how to implement this? (Also checked if the event_count > 0 condition before --)

RE: Light Switch Client stop due to ++m_scheduler.event_count < 0?

Simon — Wed, 10 Oct 2018 16:02:55 GMT

The assert NRF_MESH_ASSERT(++m_scheduler.event_count > 0) failed, due to an overflow (since event_count is of type uint16_t and can't contain a negative value).

The only place event_count is decremented is inside the function fire_timers(..). However, if the functions timer_sch_reschedule(..) or timer_sch_abort is called, the function remove_evt(..) will be called, and inside remove_evt(..), event_count is not decremented. After 2 hours of running your application, these functions have been called enough times to make event_count overflow

Thus, the error you encountered is due to a bug in the code, and is reported.

The problem can be solved by adding

m_scheduler.event_count--;

inside the function remove_evt(..).

Best regards, Simon