RE: Memory Leak in Connection Parameters Negotiation module

ArmatureCurrent — Mon, 10 Dec 2018 13:21:52 GMT

Thanks for your answer

RE: Memory Leak in Connection Parameters Negotiation module

Einar Thorsrud — Mon, 10 Dec 2018 12:36:09 GMT

Hi,

The normal (non-FreeRTOS) app-timer implementation relies entirely on static memory. As you have commented, this is not the case for the FreeRTOS implementation since it use xTimerCreate(). However, I do not see this as a memory leak as the higher level app-timer API still treats this conceptually as a static allocation with the number of instances is fixed by the configuration define. And equally important: there is no app-timer API to tear down a timer once it has been created, so there is no reason to think that the memory should be freed at any point.

If you want to change this behavior properly, then you need to expand the app-timer API with a teardown function. Alternatively you could replace the call to xTimerCreate() with xTimerCreateStatic(). I do not see a significant benefit of it, though. I have created an internal ticket for this, but you should not probably expect this to be added in the next nRF5 SDK release (you are of course free to implement it yourself if you like).