UART example on coded PHY

RE: UART example on coded PHY

destiny98 — Fri, 17 Jul 2020 09:34:42 GMT

Hi, I tried to implement the main.c over to the UART Central example in debug mode and I got this error:

Am I suppose to change tis uint8_t scan_buffer_data[NRF_BLE_SCAN_BUFFER]; to

uint8_t scan_buffer_data[BLE_GAP_SCAN_BUFFER_EXTENDED_MIN];

RE: UART example on coded PHY

kunal1234 — Wed, 18 Mar 2020 16:40:13 GMT

@peterS the NRF_BLE_SCAN_BUFFER macro is in sdk_config.h

RE: UART example on coded PHY

peterS — Wed, 01 Jan 2020 12:35:43 GMT

I have the same problem, can you tell me where to change the NRF_BLE_SCAN_BUFFER to BLE_GAP_SCAN_BUFFER_EXTENDED_MIN. i can find it in main.c

Peter Stam

RE: UART example on coded PHY

AlexIsMe — Wed, 13 Nov 2019 10:03:38 GMT

Guys, thanks for this samples, its made my day! Was fighting incorrect parameters for whole day. Good luck with projects!

RE: UART example on coded PHY

Susheel Nuguru — Mon, 18 Mar 2019 11:55:04 GMT

Glad to hear. Good luck with your project.

RE: UART example on coded PHY

Luka Fercec — Mon, 11 Mar 2019 14:02:59 GMT

I have tried changing this NRF_BLE_SCAN_BUFFER to BLE_GAP_SCAN_BUFFER_EXTENDED_MIN as you suggested and I can confirm that everything is working now as expected.

Thank you very much AndreasF and Susheel Nuguru for your help, it was much appreciated. I would never have figured this out on my own.

Thank you

RE: UART example on coded PHY

Susheel Nuguru — Mon, 11 Mar 2019 11:18:09 GMT

Hi,

When using CODED_PHY you need to enabled the extended bit when scanning, which you did.

But then NRF_BLE_SCAN_BUFFER should be set to BLE_GAP_SCAN_BUFFER_EXTENDED_MIN which is 255.

Can you please try this and see if the scanner goes through?

RE: UART example on coded PHY

Luka Fercec — Wed, 06 Mar 2019 07:28:09 GMT

Hi Andreas

Yes, no problem, if you would take the example project ble_app_uart_c from SDK 15.2 and copy over this main.c from the attachment, you would basically have the same project.

Best regards,

Luka

devzone.nordicsemi.com/.../1325.ble_5F00_app_5F00_uart_5F00_c_5F00_modified_5F00_main.7z

RE: UART example on coded PHY

AndreasF — Tue, 05 Mar 2019 14:39:08 GMT

Hi Luka.

Could you share your project so I could take a look at it?

Best regards,

Andreas

RE: UART example on coded PHY

Luka Fercec — Tue, 05 Mar 2019 12:49:54 GMT

I tried changing the scan_init() with the one provided above, but I had no luck with this. When I tried to run it, it crashed again and what could be read on SEGGER RTT Viewer was this:

<info> app: BLE UART central example started.
<error> ble_scan: sd_ble_gap_scan_start returned 0x9
<error> app: Fatal error

According to nrf_error.h, code 0x9 means NRF_ERROR_INVALID_LENGTH.

If I commented out the lines that enable coded PHY and extended, everything worked. But if I enabled back the extended, the same error occured. But if I enabled only coded PHY without extended, I got slightly different error:

<info> app: BLE UART central example started.
<error> ble_scan: sd_ble_gap_scan_start returned 0x7
<error> app: Fatal error

The error code 0x7 according to nrf_error.h means NRF_ERROR_INVALID_PARAM, which makes sense, since coded PHY requiers extended. But why didn't it work with extended enabled and what is this code NRF_ERROR_INVALID_LENGTH?

Best regards,

Luka

RE: UART example on coded PHY

AndreasF — Fri, 01 Mar 2019 11:43:04 GMT

Hi.

Its ok with this question, since it is related to the issue.

I dont know if you might get in trouble with not using NRF_BLE_SCAN before interval, window and timeout, and maybe extended should be set as true.

Here is my scan_init() function:

static void scan_init(void)
{
    ret_code_t            err_code;
    nrf_ble_scan_init_t   init_scan;
    ble_gap_scan_params_t scan_params;

    memset(&scan_params, 0, sizeof(ble_gap_scan_params_t));

    scan_params.active        = 1;
    scan_params.interval      = NRF_BLE_SCAN_SCAN_INTERVAL;
    scan_params.window        = NRF_BLE_SCAN_SCAN_WINDOW;
    scan_params.timeout       = NRF_BLE_SCAN_SCAN_DURATION;
    scan_params.filter_policy = BLE_GAP_SCAN_FP_ACCEPT_ALL;
    scan_params.scan_phys     = BLE_GAP_PHY_CODED;
    scan_params.extended      = true;

    memset(&init_scan, 0, sizeof(init_scan));

    init_scan.connect_if_match = true;
    init_scan.conn_cfg_tag     = APP_BLE_CONN_CFG_TAG;
    init_scan.p_scan_param     = &scan_params;

    err_code = nrf_ble_scan_init(&m_scan, &init_scan, scan_evt_handler);
    APP_ERROR_CHECK(err_code);

    err_code = nrf_ble_scan_filter_set(&m_scan, SCAN_UUID_FILTER, &m_nus_uuid);
    APP_ERROR_CHECK(err_code);

    err_code = nrf_ble_scan_filters_enable(&m_scan, NRF_BLE_SCAN_UUID_FILTER, false);
    APP_ERROR_CHECK(err_code);
}

Best regards,

Andreas

RE: UART example on coded PHY

Luka Fercec — Fri, 01 Mar 2019 10:28:30 GMT

Yes, I can confirm now that this is working, so from what I have seen now, the scan response data should not be defined and extended mode has to be enabled in order for the coded PHY to work. If I do that in my code now, everything works.

Thank you very much for your help.

But, hovewer, can I ask for one more hint (or should I open another ticket) also for the central side? I modified scan parameters accordingly to what was set now in the peripheral example, so my scan parameters look like that:

/** @brief Parameters used when scanning. */
static ble_gap_scan_params_t const m_scan_params =
{
    .active           = 0,
    .interval         = SCAN_INTERVAL,
    .window           = SCAN_WINDOW,
    .timeout          = SCAN_DURATION,
    .scan_phys        = BLE_GAP_PHY_CODED,
    .filter_policy    = BLE_GAP_SCAN_FP_ACCEPT_ALL,
    .extended         = 1,
};

Now the same thing as before (NRF_ERROR_INVALID_PARAM) happens when the function sd_ble_gap_scan_start() is called. Again I am using the same example from SDK 15.2.

RE: UART example on coded PHY

AndreasF — Fri, 01 Mar 2019 08:31:25 GMT

Hi.

I've spotted the error.

Try using this code snippet as advertising_init():

static void advertising_init(void)
{
    uint32_t               err_code;
    ble_advertising_init_t init;

    memset(&init, 0, sizeof(init));

    init.advdata.name_type          = BLE_ADVDATA_FULL_NAME;
    init.advdata.include_appearance = false;
    init.advdata.flags              = BLE_GAP_ADV_FLAGS_LE_ONLY_LIMITED_DISC_MODE;

    init.advdata.uuids_complete.uuid_cnt = sizeof(m_adv_uuids) / sizeof(m_adv_uuids[0]);
    init.advdata.uuids_complete.p_uuids  = m_adv_uuids;

    init.config.ble_adv_fast_enabled      = true;
    init.config.ble_adv_fast_interval     = APP_ADV_INTERVAL;
    init.config.ble_adv_fast_timeout      = APP_ADV_DURATION;
    init.config.ble_adv_primary_phy       = BLE_GAP_PHY_CODED;
    init.config.ble_adv_secondary_phy     = BLE_GAP_PHY_CODED;
    init.config.ble_adv_extended_enabled  = true;
    init.evt_handler = on_adv_evt;

    err_code = ble_advertising_init(&m_advertising, &init);
    APP_ERROR_CHECK(err_code);

    ble_advertising_conn_cfg_tag_set(&m_advertising, APP_BLE_CONN_CFG_TAG);
}

This worked for me.

I think the problem was that the UUID was defined as scan response data.

Best regards,

Andreas

RE: UART example on coded PHY

AndreasF — Thu, 28 Feb 2019 14:03:23 GMT

Hi.

I just wanted to let you know that I'm still looking into the issue, sorry for the delay.

Best regards,

Andreas

RE: UART example on coded PHY

Bob Recny — Wed, 27 Feb 2019 23:41:57 GMT

As expected, the same happens with SDK v15.3.0

RE: UART example on coded PHY

Bob Recny — Wed, 27 Feb 2019 22:58:08 GMT

I have the same issue. When I try the changes to ble_advertising.c, though, both this edit and the original one for main.c give error_code = 0x7. SDK 15.2.0.

RE: UART example on coded PHY

Luka Fercec — Wed, 27 Feb 2019 13:31:29 GMT

Yes, I can confirm that if I do this, the system does not crash. But I cannot confirm that it is operating in Coded PHY mode, since I can see the device advertising with nRF Connect application on an iPhone. These phones don't support coded PHY, do they? So if it is really advertising in Coded PHY I shouldn't be able to see it, correct?

So is there any way to really put it into the Coded PHY mode?

Best regards,

Luka

RE: UART example on coded PHY

AndreasF — Wed, 27 Feb 2019 12:45:33 GMT

Hi Luka.

I noticed that the UART example uses the Advertising Module, not SoftDevice API calls directly. So the lines i proposed first would not work then.

Can you try this:

In main.c, use this as advertising_init:

static void advertising_init(void)
{
    uint32_t               err_code;
    ble_advertising_init_t init;

    memset(&init, 0, sizeof(init));

    init.advdata.name_type          = BLE_ADVDATA_FULL_NAME;
    init.advdata.include_appearance = false;
    init.advdata.flags              = BLE_GAP_ADV_FLAGS_LE_ONLY_LIMITED_DISC_MODE;

    init.srdata.uuids_complete.uuid_cnt = sizeof(m_adv_uuids) / sizeof(m_adv_uuids[0]);
    init.srdata.uuids_complete.p_uuids  = m_adv_uuids;

    init.config.ble_adv_fast_enabled  = true;
    init.config.ble_adv_fast_interval = APP_ADV_INTERVAL;
    init.config.ble_adv_fast_timeout  = APP_ADV_DURATION;
    init.evt_handler = on_adv_evt;

    err_code = ble_advertising_init(&m_advertising, &init);
    APP_ERROR_CHECK(err_code);

    ble_advertising_conn_cfg_tag_set(&m_advertising, APP_BLE_CONN_CFG_TAG);
}

And then you have to edit the implementation of ble_advertising_init(), which you can find in ble_advertising.c (located in \components\ble\ble_advertising\ble_advertising.c).

Edit the last part so that it looks like this:

    // Configure a initial advertising configuration. The advertising data and and advertising
    // parameters will be changed later when we call @ref ble_advertising_start, but must be set
    // to legal values here to define an advertising handle.

    p_advertising->adv_params.primary_phy = BLE_GAP_PHY_CODED;
    p_advertising->adv_params.secondary_phy = BLE_GAP_PHY_CODED;
    p_advertising->adv_params.duration        = p_advertising->adv_modes_config.ble_adv_fast_timeout;
    p_advertising->adv_params.properties.type = BLE_GAP_ADV_TYPE_EXTENDED_NONCONNECTABLE_SCANNABLE_UNDIRECTED;
    p_advertising->adv_params.p_peer_addr     = NULL;
    p_advertising->adv_params.filter_policy   = BLE_GAP_ADV_FP_ANY;
    p_advertising->adv_params.interval        = p_advertising->adv_modes_config.ble_adv_fast_interval;

    ret = sd_ble_gap_adv_set_configure(&p_advertising->adv_handle, NULL, &p_advertising->adv_params);
    VERIFY_SUCCESS(ret);

    p_advertising->initialized = true;
    return ret;
}

This worked for me.

Best regards,

Andreas

RE: UART example on coded PHY

Luka Fercec — Wed, 27 Feb 2019 05:41:59 GMT

No problem, just open unmodified version of ble_app_uart and in main.c in function advertising_init() after the line that says

    init.config.ble_adv_fast_timeout  = APP_ADV_DURATION;

insert these two lines of code:

    init.config.ble_adv_primary_phy = BLE_GAP_PHY_CODED;
    init.config.ble_adv_secondary_phy = BLE_GAP_PHY_CODED;

That's more or less everything that I did. But alternately you can also open unmodified project and replace main.c with what I have in the big code window in my original post.

Best regards,

Luka

RE: UART example on coded PHY

AndreasF — Tue, 26 Feb 2019 14:22:08 GMT

Hi.

I don't have the latest version. Could you explain to me what you have done compared to an unmodified version of ble_app_uart? So that I can try to recreate it in Segger Embedded Studio?

Best regards,

Andreas

RE: UART example on coded PHY

Luka Fercec — Tue, 26 Feb 2019 14:07:54 GMT

I have version 8.32.2 and it builds just fine for me, in fact I tried even now extracting the archive I provided and cleanning and building it and it works just fine.

Best regards,

Luka

RE: UART example on coded PHY

AndreasF — Tue, 26 Feb 2019 13:58:06 GMT

Hi.

Which version of IAR Workbench does it work on? I cannot compile it with my version.

Best regards,

Andreas

RE: UART example on coded PHY

Luka Fercec — Tue, 26 Feb 2019 09:12:56 GMT

It's no problem sharing the project right now, as it is only the SDK 15.2 project in that stage with changed power setting for adveretising.

This is Eclipse project with configured IAR toolchain (I use IAR compiler) and the original IAR project is still inside and it also works. So this works either with Eclipse and IAR plugin or the original IAR Workbench. The whole project files are in the attachment.

But also - what I have changed is basically the main.c from the project, which is in my original post anyway.

And by the way - UART pins are configured here a bit funny, because I am using the Fanstel development board, which has UART pins somewhere else.

devzone.nordicsemi.com/.../ble_5F00_app_5F00_uart_5F00_pca10056_5F00_s140.7z

RE: UART example on coded PHY

AndreasF — Tue, 26 Feb 2019 08:52:28 GMT

Hi.

Could you share your project so I can take a look at it?

I can make this ticket private if you do not want to share the project with anyone else but me and other Nordic employees :-)

Best regards,

Andreas

RE: UART example on coded PHY

Luka Fercec — Tue, 26 Feb 2019 06:38:24 GMT

Yes, I am using SDK 15.2.

ble_advertising_init() returns 0, which is NRF_SUCCESS.

ble_advertising_start() doesn't return NRF_ERROR_INVALID_STATE, which is 8, but I see it return number 7, which is NRF_ERROR_INVALID_PARAM.

If I change only primary PHY to coded, also the same thing happens, there is no difference.

Best regards,

Luka