Error adding USBD project

RE: Error adding USBD project

Sigurd — Mon, 04 Mar 2019 08:59:01 GMT

[quote userid="73639" url="~/f/nordic-q-a/44308/error-adding-usbd-project/173859"]But the original official example is normal here?[/quote]

Yes, that is because the CRITICAL_REGION macros is only using "{" and a "}" character when we have SOFTDEVICE_PRESENT defined.

So this is a bug in app_usbd_hid_generic.c, app_usbd_hid_generic_idle_report_set() function, I will report it internally.

RE: Error adding USBD project

shenwrt — Mon, 04 Mar 2019 01:30:26 GMT

OK, thank you. But the original official example is normal here?

RE: Error adding USBD project

Turbo J — Sat, 02 Mar 2019 12:39:21 GMT

Those CRITICAL_REGION macros contain a "{" and a "}" character each, thus "ret" is outside scope at the return statement.

Fix is really simple, just declare it early:

ret_code_t ret;

CRITICAL_REGION_ENTER();

ret = app_usbd_ep_transfer(ep_addr, &transfer);
if (ret == NRF_SUCCESS)
{
app_usbd_hid_state_flag_set(&p_generic_ctx->hid_ctx,
APP_USBD_HID_STATE_FLAG_TRANS_IN_PROGRESS);
}

CRITICAL_REGION_EXIT();

return ret;

RE: Error adding USBD project

awneil — Fri, 01 Mar 2019 21:00:11 GMT

how to properly post source code:

RE: Error adding USBD project

shenwrt — Fri, 01 Mar 2019 19:54:19 GMT

Normal after deleting critical Macro：

// CRITICAL_REGION_ENTER();
ret_code_t ret = app_usbd_ep_transfer(ep_addr, &transfer);
if (ret == NRF_SUCCESS)
{
app_usbd_hid_state_flag_set(&p_generic_ctx->hid_ctx,
APP_USBD_HID_STATE_FLAG_TRANS_IN_PROGRESS);
}
// CRITICAL_REGION_EXIT();

return ret;