RE: SDK 15.3.0: Restart Non-Connectable Advertising after Timeout

awneil — Mon, 24 Jun 2019 22:09:08 GMT

[quote userid="26263" url="~/f/nordic-q-a/47391/sdk-15-3-0-restart-non-connectable-advertising-after-timeout/194468"]Did you end up making any changes to ble_advertising.c? [/quote]

I don't think so.

RE: SDK 15.3.0: Restart Non-Connectable Advertising after Timeout

Eric — Mon, 24 Jun 2019 21:57:31 GMT

Hi Awneil,
I'm also getting NRF_ERROR_INVALID_PARAM after using your fix. Did you end up making any changes to ble_advertising.c? What advertising interval APP_ADV_INTERVAL did you use?

RE: SDK 15.3.0: Restart Non-Connectable Advertising after Timeout

awneil — Wed, 12 Jun 2019 08:56:26 GMT

[quote userid="6462" url="~/f/nordic-q-a/47391/sdk-15-3-0-restart-non-connectable-advertising-after-timeout"]It is an unhelpful Error code as it give no help in identifying which parameter was invalid, nor how it was invalid[/quote]

RE: SDK 15.3.0: Restart Non-Connectable Advertising after Timeout

Sigurd — Mon, 20 May 2019 14:51:50 GMT

Hi,

Thank you for the feedback.

[quote userid="6462" url="~/f/nordic-q-a/47391/sdk-15-3-0-restart-non-connectable-advertising-after-timeout/187697"]The trouble is, there are now no examples of how to do advertising "manually", and the Advertising module obfuscates it all so much that it's hard to pull the relevant details out.[/quote]

The ble_app_beacon and ble_app_blinky examples does not use the advertising module.

RE: SDK 15.3.0: Restart Non-Connectable Advertising after Timeout

awneil — Fri, 17 May 2019 16:18:13 GMT

[quote userid="6462" url="~/f/nordic-q-a/47391/sdk-15-3-0-restart-non-connectable-advertising-after-timeout/187695"]my final solution[/quote]

I guess the real solution is to just not use the Advertising module at all.

It's fine when it works but, when you want to do something a little different, it's an absolute pain in the behind!

😞

The trouble is, there are now no examples of how to do advertising "manually", and the Advertising module obfuscates it all so much that it's hard to pull the relevant details out.

😞

RE: SDK 15.3.0: Restart Non-Connectable Advertising after Timeout

awneil — Fri, 17 May 2019 16:01:22 GMT

[quote userid="6462" url="~/f/nordic-q-a/47391/sdk-15-3-0-restart-non-connectable-advertising-after-timeout"]None of the parameters should have changed[/quote]

Oh - if only it were that simple!

But no - the Advertising module has to mess with the settings!

Thanks to Niclas Heitz - who did a write-up on some of this:

https://devzone.nordicsemi.com/f/nordic-q-a/37233/ble_advertising_init-returning-nrf_error_invalid_param-for-parameters-set-by-the-function-itself/145212#145212

This pointed me to the fact that the Advertising Interval gets trashed:

<info> app: Connectable advertising
<info> app: Fast advertising.
<debug> app: ADV: GAP Conn
<info> app: GAP Conn
<info> app: Non-connectable, Non-scannable advertising; Handle 0; interval 300
<debug> app: ADV: Conn Parm Upd
<debug> app: ADV: Term
<info> app: Adv Tmo: Conn Hdl 0000; Adv Hdl 0; Mnf01
<info> app: Non-connectable, Non-scannable advertising; Handle 0; interval 0
<error> app: ERROR 7 [NRF_ERROR_INVALID_PARAM] at main.c:790
PC at: 0x000313A1
<error> app: End of error report

Fixing that, the Non-connectable advertising would re-start once - but then never time out.

Which suggested that the Advertising Duration was also getting trashed:

<info> app: Connectable advertising
<info> app: Fast advertising.
<debug> app: ADV: GAP Conn
<info> app: GAP Conn
<info> app: Non-connectable, Non-scannable advertising: Hdl 0; Int 300; Dur 3000
<debug> app: ADV: Conn Parm Upd
<debug> app: ADV: Term
<info> app: Adv Tmo: Conn Hdl 0000; Adv Hdl 0; Mnf01
<info> app: Non-connectable, Non-scannable advertising: Hdl 0; Int 0; Dur 0
<error> app: ERROR 7 [NRF_ERROR_INVALID_PARAM] at main.c:781
PC at: 0x00031397
<error> app: End of error report

But fixing that just led to a different error:

<info> app: Connectable advertising
<info> app: Fast advertising.
<debug> app: ADV: GAP Conn
<info> app: GAP Conn
<info> app: Non-connectable, Non-scannable advertising: Hdl 0; Int 300; Dur 3000
<debug> app: ADV: Conn Parm Upd
<debug> app: ADV: Term
<info> app: Adv Tmo: Conn Hdl 0000; Adv Hdl 0; Mnf01
<info> app: Non-connectable, Non-scannable advertising: Hdl 0; Int 0; Dur 0
<debug> app: ADV_SET_TERMINATED: start result 0
<info> app: ADV_SET_TERM.
<debug> app: ADV: Term
<debug> app: ADV_SET_TERMINATED: start result 18
<info> app: ADV_SET_TERM.

The "ADV_SET_TERMINATED: start result 18" comes from on_terminated() in ble_advertising.c:

static void on_terminated(ble_advertising_t * const p_advertising, ble_evt_t const * p_ble_evt)
{
    ret_code_t ret;

    if (p_ble_evt->header.evt_id != BLE_GAP_EVT_ADV_SET_TERMINATED)
    {
        // Nothing to do.
        NRF_LOG_DEBUG( "!ADV_SET_TERMINATED" );
        return;
    }

    if (  p_ble_evt->evt.gap_evt.params.adv_set_terminated.reason == BLE_GAP_EVT_ADV_SET_TERMINATED_REASON_TIMEOUT
        ||p_ble_evt->evt.gap_evt.params.adv_set_terminated.reason == BLE_GAP_EVT_ADV_SET_TERMINATED_REASON_LIMIT_REACHED)
    {
        // Start advertising in the next mode.
        ret = ble_advertising_start(p_advertising, adv_mode_next_get(p_advertising->adv_mode_current));

        NRF_LOG_DEBUG( "ADV_SET_TERMINATED: start result %d", ret );   // <<<< HERE !!

        if ((ret != NRF_SUCCESS) && (p_advertising->error_handler != NULL))
        {
            p_advertising->error_handler(ret);
        }
    }
}

The 18 is NRF_ERROR_CONN_COUNT: so the Advertising module has trashed the setting to do Non-connectable advertising - and, instead, is trying to start Connectable advertising!!

So my final solution is:

static void non_connectable_advertising_start(void)
{
    uint32_t    err_code;
    ble_gap_adv_params_t  adv_params;

    memcpy(&adv_params, &m_advertising.adv_params, sizeof(adv_params));

#if 0
    NRF_LOG_INFO( "Non-connectable, Scannable advertising" );
    adv_params.properties.type = BLE_GAP_ADV_TYPE_NONCONNECTABLE_SCANNABLE_UNDIRECTED;
#else
    NRF_LOG_INFO( "Non-connectable, Non-scannable advertising: Hdl %d; Int %d; Dur %d", m_advertising.adv_handle, m_advertising.adv_params.interval, m_advertising.adv_params.duration );
    adv_params.properties.type = BLE_GAP_ADV_TYPE_NONCONNECTABLE_NONSCANNABLE_UNDIRECTED;
#endif

    // Restore parameters which get trashed by the Advertising module
    adv_params.duration = APP_ADV_DURATION;
    adv_params.interval = APP_ADV_INTERVAL;

    // Don't let the Advertising module think it's got somewhere else in its advertising sequence
    m_advertising.adv_mode_current = BLE_ADV_MODE_FAST;

    err_code = sd_ble_gap_adv_set_configure(&m_advertising.adv_handle,
                                            &m_advertising.adv_data,
                                            &adv_params);
    APP_ERROR_CHECK(err_code);

    err_code = sd_ble_gap_adv_start(m_advertising.adv_handle, m_advertising.conn_cfg_tag);
    APP_ERROR_CHECK(err_code);
}